64438 2011-07-13 01:39:57 -0700 [CSSRegions]content:-webkit-from-flow not applied correctly 2011-07-13 11:49:34 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 57312 0 mihnea webkit-unassigned tony webkit.review.bot oldest_to_newest 436306 0 mihnea 2011-07-13 01:39:57 -0700 Correct the patch for bug 63133. Also, correct the associated layout test. 436310 1 100644 mihnea 2011-07-13 01:56:47 -0700 Created attachment 100644 Patch 436509 2 100644 webkit.review.bot 2011-07-13 10:30:18 -0700 Comment on attachment 100644 Patch Rejecting attachment 100644 from review queue. tony@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 436510 3 100644 webkit.review.bot 2011-07-13 10:30:57 -0700 Comment on attachment 100644 Patch Rejecting attachment 100644 from commit-queue. tony@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 436523 4 tony 2011-07-13 10:55:18 -0700 Let's try that again. 436573 5 100644 webkit.review.bot 2011-07-13 11:49:29 -0700 Comment on attachment 100644 Patch Clearing flags on attachment: 100644 Committed r90935: <http://trac.webkit.org/changeset/90935> 436574 6 webkit.review.bot 2011-07-13 11:49:34 -0700 All reviewed patches have been landed. Closing bug. 100644 2011-07-13 01:56:47 -0700 2011-07-13 11:49:29 -0700 Patch 64438.patch text/plain 6975 mihnea ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhMzYzNDU2Li5lNmIwZmUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDct MTMgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTU1Jl Z2lvbnNdY29udGVudDotd2Via2l0LWZyb20tZmxvdyBub3QgYXBwbGllZCBjb3JyZWN0bHkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0NDM4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29ycmVjdCB0aGUg bGF5b3V0IHRlc3QgZm9yIGNvbnRlbnQ6LXdlYmtpdC1mcm9tLWZsb3cgcGFyc2luZy4gVGVzdGlu ZyBnZXRDb21wdXRlZFN0eWxlIHZhbHVlcyBmb3IgY29udGVudCBwcm9wZXJ0eQorICAgICAgICB3 YXMgbm90IGRvbmUgcHJvcGVybHksIGFzICJmbG93LW5hbWUiIHdhcyBwYXNzZWQgaW5zdGVhZCBv ZiAiLXdlYmtpdC1mcm9tLWZsb3c6J2Zsb3ctbmFtZSciLgorCisgICAgICAgICogZmFzdC9yZWdp b25zL2NvbnRlbnQtd2Via2l0LWZyb20tZmxvdy1wYXJzaW5nLWV4cGVjdGVkLnR4dDoKKyAgICAg ICAgKiBmYXN0L3JlZ2lvbnMvc2NyaXB0LXRlc3RzL2NvbnRlbnQtd2Via2l0LWZyb20tZmxvdy1w YXJzaW5nLmpzOgorCiAyMDExLTA3LTEzICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBNb3JlIGVkZ2UgQUEgYW5kIG1pc2MgY2hyb21p dW0gZ3B1IGJhc2VsaW5lcyBhbmQgZXhwZWN0YXRpb25zIHVwZGF0ZXMuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvY29udGVudC13ZWJraXQtZnJvbS1mbG93LXBhcnNpbmct ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2NvbnRlbnQtd2Via2l0LWZy b20tZmxvdy1wYXJzaW5nLWV4cGVjdGVkLnR4dAppbmRleCAxOGZmMTNiLi41NDRhZjkzIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvY29udGVudC13ZWJraXQtZnJvbS1mbG93 LXBhcnNpbmctZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9jb250 ZW50LXdlYmtpdC1mcm9tLWZsb3ctcGFyc2luZy1leHBlY3RlZC50eHQKQEAgLTE4LDIwICsxOCwy MCBAQCBQQVNTIHRlc3RDU1NUZXh0KCJjb250ZW50OiAtd2Via2l0LWZyb20tZmxvdygtMSkiKSBp cyAiIgogUEFTUyB0ZXN0Q1NTVGV4dCgiY29udGVudDogLXdlYmtpdC1mcm9tLWZsb3coMTJweCki KSBpcyAiIgogUEFTUyB0ZXN0Q1NTVGV4dCgiY29udGVudDogLXdlYmtpdC1mcm9tLWZsb3coZmly c3QgZmxvdykiKSBpcyAiIgogUEFTUyB0ZXN0Q1NTVGV4dCgiY29udGVudDogLXdlYmtpdC1mcm9t LWZsb3coZmlyc3QtZmxvdykiKSBpcyAiIgotUEFTUyB0ZXN0Q29tcHV0ZWRTdHlsZSgiJ2ZpcnN0 LWZsb3cnIikgaXMgImZpcnN0LWZsb3ciCi1QQVNTIHRlc3RDb21wdXRlZFN0eWxlKCInZmlyc3Qg ZmxvdyciKSBpcyAiJ2ZpcnN0IGZsb3cnIgotUEFTUyB0ZXN0Q29tcHV0ZWRTdHlsZSgiJ2F1dG8n IikgaXMgImF1dG8iCi1QQVNTIHRlc3RDb21wdXRlZFN0eWxlKCJhdXRvIikgaXMgIiIKLVBBU1Mg dGVzdENvbXB1dGVkU3R5bGUoImluaXRpYWwiKSBpcyAiIgotUEFTUyB0ZXN0Q29tcHV0ZWRTdHls ZSgiaW5oZXJpdCIpIGlzICIiCi1QQVNTIHRlc3RDb21wdXRlZFN0eWxlKCIiKSBpcyAiIgotUEFT UyB0ZXN0Q29tcHV0ZWRTdHlsZSgiMSIpIGlzICIiCi1QQVNTIHRlc3RDb21wdXRlZFN0eWxlKCIx LjIiKSBpcyAiIgotUEFTUyB0ZXN0Q29tcHV0ZWRTdHlsZSgiLTEiKSBpcyAiIgotUEFTUyB0ZXN0 Q29tcHV0ZWRTdHlsZSgiMTJweCIpIGlzICIiCi1QQVNTIHRlc3RDb21wdXRlZFN0eWxlKCInJyIp IGlzICInJyIKLVBBU1MgdGVzdENvbXB1dGVkU3R5bGUoImZpcnN0IGZsb3ciKSBpcyAiIgotUEFT UyB0ZXN0Q29tcHV0ZWRTdHlsZSgiZmlyc3QtZmxvdyIpIGlzICIiCitQQVNTIHRlc3RDb21wdXRl ZFN0eWxlKCItd2Via2l0LWZyb20tZmxvdygnZmlyc3QtZmxvdycpIikgaXMgImZpcnN0LWZsb3ci CitQQVNTIHRlc3RDb21wdXRlZFN0eWxlKCItd2Via2l0LWZyb20tZmxvdygnZmlyc3QgZmxvdycp IikgaXMgIidmaXJzdCBmbG93JyIKK1BBU1MgdGVzdENvbXB1dGVkU3R5bGUoIi13ZWJraXQtZnJv bS1mbG93KCdhdXRvJykiKSBpcyAiYXV0byIKK1BBU1MgdGVzdENvbXB1dGVkU3R5bGUoIi13ZWJr aXQtZnJvbS1mbG93KGF1dG8pIikgaXMgIiIKK1BBU1MgdGVzdENvbXB1dGVkU3R5bGUoIi13ZWJr aXQtZnJvbS1mbG93KGluaXRpYWwpIikgaXMgIiIKK1BBU1MgdGVzdENvbXB1dGVkU3R5bGUoIi13 ZWJraXQtZnJvbS1mbG93KGluaGVyaXQpIikgaXMgIiIKK1BBU1MgdGVzdENvbXB1dGVkU3R5bGUo Ii13ZWJraXQtZnJvbS1mbG93KCkiKSBpcyAiIgorUEFTUyB0ZXN0Q29tcHV0ZWRTdHlsZSgiLXdl YmtpdC1mcm9tLWZsb3coMSkiKSBpcyAiIgorUEFTUyB0ZXN0Q29tcHV0ZWRTdHlsZSgiLXdlYmtp dC1mcm9tLWZsb3coMS4yKSIpIGlzICIiCitQQVNTIHRlc3RDb21wdXRlZFN0eWxlKCItd2Via2l0 LWZyb20tZmxvdygtMSkiKSBpcyAiIgorUEFTUyB0ZXN0Q29tcHV0ZWRTdHlsZSgiLXdlYmtpdC1m cm9tLWZsb3coMTJweCkiKSBpcyAiIgorUEFTUyB0ZXN0Q29tcHV0ZWRTdHlsZSgiLXdlYmtpdC1m cm9tLWZsb3coJycpIikgaXMgIicnIgorUEFTUyB0ZXN0Q29tcHV0ZWRTdHlsZSgiLXdlYmtpdC1m cm9tLWZsb3coZmlyc3QgZmxvdykiKSBpcyAiIgorUEFTUyB0ZXN0Q29tcHV0ZWRTdHlsZSgiLXdl YmtpdC1mcm9tLWZsb3coZmlyc3QtZmxvdykiKSBpcyAiIgogUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L3JlZ2lvbnMvc2NyaXB0LXRlc3RzL2NvbnRlbnQtd2Via2l0LWZyb20tZmxvdy1wYXJzaW5nLmpz IGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3NjcmlwdC10ZXN0cy9jb250ZW50LXdlYmtpdC1m cm9tLWZsb3ctcGFyc2luZy5qcwppbmRleCA4NGVlN2M2Li44NTkwMTcxIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvc2NyaXB0LXRlc3RzL2NvbnRlbnQtd2Via2l0LWZyb20t Zmxvdy1wYXJzaW5nLmpzCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9zY3JpcHQtdGVz dHMvY29udGVudC13ZWJraXQtZnJvbS1mbG93LXBhcnNpbmcuanMKQEAgLTMyLDE5ICszMiwxOSBA QCBzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ3Rlc3RDU1NUZXh0KCJjb250ZW50OiAtd2Via2l0LWZy b20tZmxvdygxMnB4KSIpJywgIiIpOwogc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCd0ZXN0Q1NTVGV4 dCgiY29udGVudDogLXdlYmtpdC1mcm9tLWZsb3coZmlyc3QgZmxvdykiKScsICIiKTsKIHNob3Vs ZEJlRXF1YWxUb1N0cmluZygndGVzdENTU1RleHQoImNvbnRlbnQ6IC13ZWJraXQtZnJvbS1mbG93 KGZpcnN0LWZsb3cpIiknLCAiIik7CiAKLXNob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdENvbXB1 dGVkU3R5bGUoIlwnZmlyc3QtZmxvd1wnIiknLCAiZmlyc3QtZmxvdyIpOwotc2hvdWxkQmVFcXVh bFRvU3RyaW5nKCd0ZXN0Q29tcHV0ZWRTdHlsZSgiXCdmaXJzdCBmbG93XCciKScsICInZmlyc3Qg ZmxvdyciKTsKLXNob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdENvbXB1dGVkU3R5bGUoIlwnYXV0 b1wnIiknLCAiYXV0byIpOwotc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCd0ZXN0Q29tcHV0ZWRTdHls ZSgiYXV0byIpJywgIiIpOwotc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCd0ZXN0Q29tcHV0ZWRTdHls ZSgiaW5pdGlhbCIpJywgIiIpOwotc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCd0ZXN0Q29tcHV0ZWRT dHlsZSgiaW5oZXJpdCIpJywgIiIpOwotc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCd0ZXN0Q29tcHV0 ZWRTdHlsZSgiIiknLCAiIik7Ci1zaG91bGRCZUVxdWFsVG9TdHJpbmcoJ3Rlc3RDb21wdXRlZFN0 eWxlKCIxIiknLCAiIik7Ci1zaG91bGRCZUVxdWFsVG9TdHJpbmcoJ3Rlc3RDb21wdXRlZFN0eWxl KCIxLjIiKScsICIiKTsKLXNob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdENvbXB1dGVkU3R5bGUo Ii0xIiknLCAiIik7Ci1zaG91bGRCZUVxdWFsVG9TdHJpbmcoJ3Rlc3RDb21wdXRlZFN0eWxlKCIx MnB4IiknLCAiIik7Ci1zaG91bGRCZUVxdWFsVG9TdHJpbmcoJ3Rlc3RDb21wdXRlZFN0eWxlKCJc J1wnIiknLCAiJyciKTsKLXNob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdENvbXB1dGVkU3R5bGUo ImZpcnN0IGZsb3ciKScsICIiKTsKLXNob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdENvbXB1dGVk U3R5bGUoImZpcnN0LWZsb3ciKScsICIiKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdENv bXB1dGVkU3R5bGUoIi13ZWJraXQtZnJvbS1mbG93KFwnZmlyc3QtZmxvd1wnKSIpJywgImZpcnN0 LWZsb3ciKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdENvbXB1dGVkU3R5bGUoIi13ZWJr aXQtZnJvbS1mbG93KFwnZmlyc3QgZmxvd1wnKSIpJywgIidmaXJzdCBmbG93JyIpOworc2hvdWxk QmVFcXVhbFRvU3RyaW5nKCd0ZXN0Q29tcHV0ZWRTdHlsZSgiLXdlYmtpdC1mcm9tLWZsb3coXCdh dXRvXCcpIiknLCAiYXV0byIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCd0ZXN0Q29tcHV0ZWRT dHlsZSgiLXdlYmtpdC1mcm9tLWZsb3coYXV0bykiKScsICIiKTsKK3Nob3VsZEJlRXF1YWxUb1N0 cmluZygndGVzdENvbXB1dGVkU3R5bGUoIi13ZWJraXQtZnJvbS1mbG93KGluaXRpYWwpIiknLCAi Iik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ3Rlc3RDb21wdXRlZFN0eWxlKCItd2Via2l0LWZy b20tZmxvdyhpbmhlcml0KSIpJywgIiIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCd0ZXN0Q29t cHV0ZWRTdHlsZSgiLXdlYmtpdC1mcm9tLWZsb3coKSIpJywgIiIpOworc2hvdWxkQmVFcXVhbFRv U3RyaW5nKCd0ZXN0Q29tcHV0ZWRTdHlsZSgiLXdlYmtpdC1mcm9tLWZsb3coMSkiKScsICIiKTsK K3Nob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdENvbXB1dGVkU3R5bGUoIi13ZWJraXQtZnJvbS1m bG93KDEuMikiKScsICIiKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdENvbXB1dGVkU3R5 bGUoIi13ZWJraXQtZnJvbS1mbG93KC0xKSIpJywgIiIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5n KCd0ZXN0Q29tcHV0ZWRTdHlsZSgiLXdlYmtpdC1mcm9tLWZsb3coMTJweCkiKScsICIiKTsKK3No b3VsZEJlRXF1YWxUb1N0cmluZygndGVzdENvbXB1dGVkU3R5bGUoIi13ZWJraXQtZnJvbS1mbG93 KFwnXCcpIiknLCAiJyciKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdENvbXB1dGVkU3R5 bGUoIi13ZWJraXQtZnJvbS1mbG93KGZpcnN0IGZsb3cpIiknLCAiIik7CitzaG91bGRCZUVxdWFs VG9TdHJpbmcoJ3Rlc3RDb21wdXRlZFN0eWxlKCItd2Via2l0LWZyb20tZmxvdyhmaXJzdC1mbG93 KSIpJywgIiIpOwogCiBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDQ1 NGZhNDAuLjU4NTgwNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wNy0xMyAg TWlobmVhIE92aWRlbmllICA8bWlobmVhQGFkb2JlLmNvbT4KKworICAgICAgICBbQ1NTUmVnaW9u c11jb250ZW50Oi13ZWJraXQtZnJvbS1mbG93IG5vdCBhcHBsaWVkIGNvcnJlY3RseQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ0MzgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3Jnb3QgdG8gbW9kaWZ5 IGdldFN0cmluZ1ZhbHVlKCksIGkgd2FzIG1vZGlmeWluZyBvbmx5IGdldFN0cmluZ1ZhbHVlKEV4 Y2VwdGlvbkNvZGUmKS4KKworICAgICAgICBUZXN0OiBmYXN0L3JlZ2lvbnMvY29udGVudC13ZWJr aXQtZnJvbS1mbG93LXBhcnNpbmcuaHRtbCAoZXhpc3RpbmcpLgorCisgICAgICAgICogY3NzL0NT U1ByaW1pdGl2ZVZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1ByaW1pdGl2ZVZhbHVl OjpnZXRTdHJpbmdWYWx1ZSk6CisKIDIwMTEtMDctMTIgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRh QGdvb2dsZS5jb20+CiAKICAgICAgICAgW1JlZmFjdG9yaW5nXVtTaGFkb3dDb250ZW50RWxlbWVu dF0gRm9yd2FyZGVkIG5vZGUgbGlzdCBzaG91bGQgYmUgYSBsaW5rZWQtbGlzdC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCmluZGV4IDVjOGU1NWEuLjFkYzY4YmUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcApAQCAtNTQ1LDYgKzU0NSw5 IEBAIFN0cmluZyBDU1NQcmltaXRpdmVWYWx1ZTo6Z2V0U3RyaW5nVmFsdWUoKSBjb25zdAogICAg ICAgICBjYXNlIENTU19TVFJJTkc6CiAgICAgICAgIGNhc2UgQ1NTX0FUVFI6CiAgICAgICAgIGNh c2UgQ1NTX1VSSToKKyNpZiBFTkFCTEUoQ1NTX1JFR0lPTlMpCisgICAgICAgIGNhc2UgQ1NTX0ZS T01fRkxPVzoKKyNlbmRpZgogICAgICAgICAgICAgIHJldHVybiBtX3ZhbHVlLnN0cmluZzsKICAg ICAgICAgY2FzZSBDU1NfSURFTlQ6CiAgICAgICAgICAgICByZXR1cm4gdmFsdWVPclByb3BlcnR5 TmFtZShtX3ZhbHVlLmlkZW50KTsK