64427 2011-07-12 20:05:23 -0700 Improve garden-o-matic UI when the bots fail to report revision numbers 2011-07-12 21:06:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64188 1 abarth abarth dglazkov ojan webkit.review.bot oldest_to_newest 436188 0 abarth 2011-07-12 20:05:23 -0700 Improve garden-o-matic UI when the bots fail to report revision numbers 436189 1 100612 abarth 2011-07-12 20:08:36 -0700 Created attachment 100612 Patch 436219 2 100612 webkit.review.bot 2011-07-12 21:06:05 -0700 Comment on attachment 100612 Patch Clearing flags on attachment: 100612 Committed r90884: <http://trac.webkit.org/changeset/90884> 436220 3 webkit.review.bot 2011-07-12 21:06:10 -0700 All reviewed patches have been landed. Closing bug. 100612 2011-07-12 20:08:36 -0700 2011-07-12 21:06:05 -0700 Patch bug-64427-20110712200835.patch text/plain 7635 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTA4ODEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNDAzNTNmNDIyZjRkYjY0Nzg2OWU3NDcxMjI2YzY1MTkz YWNjZDRiLi5kMjczYzcyNGY5YmVhYzY4MGQzYTE4NjU5NDQ5MTQ0YTVhYzBkODQxIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTEtMDctMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAg ICBJbXByb3ZlIGdhcmRlbi1vLW1hdGljIFVJIHdoZW4gdGhlIGJvdHMgZmFpbCB0byByZXBvcnQg cmV2aXNpb24gbnVtYmVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjQ0MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBdCBsZWFzdCBXaW4gKGRiZykoMikgc2VlbXMgdG8gZmFpbCB0byByZXBvcnQgdGhl IFNWTiByZXZpc2lvbiBudW1iZXIKKyAgICAgICAgaW4gZnVsbF9yZXN1bHRzLmpzb24uICBUaGlz IHBhdGNoIG1ha2VzIGdhcmRlbi1vLW1hdGljIG1vcmUgcm9idXN0IHRvCisgICAgICAgIG1pc3Np bmcgcmV2aXNpb24gbnVtYmVycy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9z ZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL21haW4uanM6CisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvcmVzdWx0cy5qczoKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZl ci9yZXN1bHRzX3VuaXR0ZXN0cy5qczoKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wv c2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci91aS5qczoKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci91aV91bml0dGVzdHMuanM6 CisKKzIwMTEtMDctMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwogICAgICAg ICBBZGp1c3QgZ2FyZGVuLW8tbWF0aWMgbGF5b3V0IHRvIHVzZSBmZXdlciBsaW5lcwogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ0MjIKIApkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdz ZXJ2ZXIvbWFpbi5qcyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEv Z2FyZGVuaW5nc2VydmVyL21haW4uanMKaW5kZXggMzM0ZmNiMDFjZWRmNmU0NGI5ZTkzNTFhZGEw YmRiOWVlNzFiM2Y4Yi4uOWI2MzliYTYwYzJmNzg2YjVjMDgyZjE4ODBhNWY4YzI4NDI3ZTA3NiAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJk ZW5pbmdzZXJ2ZXIvbWFpbi5qcworKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2Vy dmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9tYWluLmpzCkBAIC0zMCw2ICszMCw4IEBAIGZ1bmN0 aW9uIGZldGNoUmVzdWx0cyhvbnN1Y2Nlc3MpCiAgICAgICAgICAgICAgICAgdmFyIGJ1aWxkZXJO YW1lTGlzdCA9IGJhc2Uua2V5cyhyZXN1bHROb2Rlc0J5QnVpbGRlcik7CiAgICAgICAgICAgICAg ICAgcmVzdWx0cy51bmlmeVJlZ3Jlc3Npb25SYW5nZXMoYnVpbGRlck5hbWVMaXN0LCB0ZXN0TmFt ZSwgZnVuY3Rpb24ob2xkZXN0RmFpbGluZ1JldmlzaW9uLCBuZXdlc3RQYXNzaW5nUmV2aXNpb24p IHsKICAgICAgICAgICAgICAgICAgICAgJCgnLnJlZ3Jlc3Npb24tcmFuZ2UnLCB0ZXN0U3VtbWFy eSkuYXBwZW5kKHVpLnN1bW1hcml6ZVJlZ3Jlc3Npb25SYW5nZShvbGRlc3RGYWlsaW5nUmV2aXNp b24sIG5ld2VzdFBhc3NpbmdSZXZpc2lvbikpOworICAgICAgICAgICAgICAgICAgICBpZiAoIW5l d2VzdFBhc3NpbmdSZXZpc2lvbikKKyAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybjsKICAg ICAgICAgICAgICAgICAgICAgY2hlY2tvdXQuZXhpc3RzQXRSZXZpc2lvbihjaGVja291dC5zdWJ2 ZXJzaW9uVVJMRm9yVGVzdCh0ZXN0TmFtZSksIG5ld2VzdFBhc3NpbmdSZXZpc2lvbiwgZnVuY3Rp b24odGVzdEV4aXN0ZWRCZWZvcmVGYWlsdXJlKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAk KHRlc3RTdW1tYXJ5KS5hdHRyKCdkYXRhLW5ldy10ZXN0JywgIXRlc3RFeGlzdGVkQmVmb3JlRmFp bHVyZSk7CiAgICAgICAgICAgICAgICAgICAgIH0pOwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvcmVzdWx0cy5qcyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVy L3Jlc3VsdHMuanMKaW5kZXggOTNiNzRhODc1YjE2YzViOTgzYmYwZTIwNjg5ZDZiODgzYzBjY2Iw ZS4uZGMzNTE5M2ZiYzI2ODVhYWMzNmU1ZjQ4N2U2MGVlZGZiYTk2OTFjNCAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIv cmVzdWx0cy5qcworKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRh L2dhcmRlbmluZ3NlcnZlci9yZXN1bHRzLmpzCkBAIC0yMjcsNiArMjI3LDEwIEBAIHJlc3VsdHMu cmVncmVzc2lvblJhbmdlRm9yRmFpbHVyZSA9IGZ1bmN0aW9uKGJ1aWxkZXJOYW1lLCB0ZXN0TmFt ZSwgY2FsbGJhY2spCiAgICAgdmFyIG5ld2VzdFBhc3NpbmdSZXZpc2lvbiA9IDA7CiAKICAgICB3 YWxrSGlzdG9yeShidWlsZGVyTmFtZSwgdGVzdE5hbWUsIGZ1bmN0aW9uKHJldmlzaW9uLCByZXN1 bHROb2RlKSB7CisgICAgICAgIGlmICghcmV2aXNpb24pIHsKKyAgICAgICAgICAgIGNhbGxiYWNr KG9sZGVzdEZhaWxpbmdSZXZpc2lvbiwgbmV3ZXN0UGFzc2luZ1JldmlzaW9uKTsKKyAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgfQogICAgICAgICBpZiAoIXJlc3VsdE5vZGUpIHsK ICAgICAgICAgICAgIG5ld2VzdFBhc3NpbmdSZXZpc2lvbiA9IHJldmlzaW9uOwogICAgICAgICAg ICAgY2FsbGJhY2sob2xkZXN0RmFpbGluZ1JldmlzaW9uLCBuZXdlc3RQYXNzaW5nUmV2aXNpb24p OwpAQCAtMjUyLDYgKzI1Niw5IEBAIGZ1bmN0aW9uIG1lcmdlUmVncmVzc2lvblJhbmdlcyhyZWdy ZXNzaW9uUmFuZ2VzKQogICAgIG1lcmdlZFJhbmdlLm5ld2VzdFBhc3NpbmdSZXZpc2lvbiA9IDA7 CiAKICAgICAkLmVhY2gocmVncmVzc2lvblJhbmdlcywgZnVuY3Rpb24oYnVpbGRlck5hbWUsIHJh bmdlKSB7CisgICAgICAgIGlmICghcmFuZ2Uub2xkZXN0RmFpbGluZ1JldmlzaW9uIHx8ICFyYW5n ZS5uZXdlc3RQYXNzaW5nUmV2aXNpb24pCisgICAgICAgICAgICByZXR1cm4KKwogICAgICAgICBp ZiAoIW1lcmdlZFJhbmdlLm9sZGVzdEZhaWxpbmdSZXZpc2lvbikKICAgICAgICAgICAgIG1lcmdl ZFJhbmdlLm9sZGVzdEZhaWxpbmdSZXZpc2lvbiA9IHJhbmdlLm9sZGVzdEZhaWxpbmdSZXZpc2lv bjsKICAgICAgICAgaWYgKCFtZXJnZWRSYW5nZS5uZXdlc3RQYXNzaW5nUmV2aXNpb24pCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmlu Z3NlcnZlci9yZXN1bHRzX3VuaXR0ZXN0cy5qcyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL3Jlc3VsdHNfdW5pdHRlc3RzLmpzCmluZGV4 IGE3NTg1M2ZmNmZiY2M1YzY0NzRiNmI1Nzc1OWE3Y2UwYjBiMDk5ZWIuLmJkZGUwZjk5M2NkNTA3 YmUwYWNjMGU1YTEzNGFmNzMzODVhOGNlZTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL3Jlc3VsdHNfdW5pdHRlc3Rz LmpzCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVu aW5nc2VydmVyL3Jlc3VsdHNfdW5pdHRlc3RzLmpzCkBAIC0yNTQsNiArMjU0LDUwIEBAIHRlc3Qo IndhbGtIaXN0b3J5IiwgNiwgZnVuY3Rpb24oKSB7CiAgICAgfSk7CiB9KTsKIAordGVzdCgid2Fs a0hpc3RvcnkgKG5vIHJldmlzaW9uKSIsIDMsIGZ1bmN0aW9uKCkgeworICAgIHZhciBzaW11bGF0 b3IgPSBuZXcgTmV0d29ya1NpbXVsYXRvcigpOworCisgICAgdmFyIGtleU1hcCA9IHsKKyAgICAg ICAgInZzZmRzZmRzYWZzZGFmYXNkIjogeworICAgICAgICAgICAgInRlc3RzIjogeworICAgICAg ICAgICAgICAgICJ1c2Vyc2NyaXB0cyI6IHsKKyAgICAgICAgICAgICAgICAgICAgImFub3RoZXIt dGVzdC5odG1sIjogeworICAgICAgICAgICAgICAgICAgICAgICAgImV4cGVjdGVkIjogIlBBU1Mi LAorICAgICAgICAgICAgICAgICAgICAgICAgImFjdHVhbCI6ICJURVhUIgorICAgICAgICAgICAg ICAgICAgICB9CisgICAgICAgICAgICAgICAgfSwKKyAgICAgICAgICAgIH0sCisgICAgICAgICAg ICAicmV2aXNpb24iOiAiIgorICAgICAgICB9LAorICAgICAgICAiZ2F2c2F2c3JmZ3dhZXZ3ZWZh d3ZhZSI6eworICAgICAgICAgICAgInRlc3RzIjogeworICAgICAgICAgICAgfSwKKyAgICAgICAg ICAgICJyZXZpc2lvbiI6ICIiCisgICAgICAgIH0sCisgICAgfTsKKworICAgIHNpbXVsYXRvci5q c29ucEhvb2sgPSBmdW5jdGlvbih1cmwsIGNhbGxiYWNrKSB7CisgICAgICAgIHNpbXVsYXRvci5z Y2hlZHVsZUNhbGxiYWNrKGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgaWYgKC9kaXI9MS8udGVz dCh1cmwpKSB7CisgICAgICAgICAgICAgICAgY2FsbGJhY2soWworICAgICAgICAgICAgICAgICAg ICB7ICJrZXkiOiAidnNmZHNmZHNhZnNkYWZhc2QiIH0sCisgICAgICAgICAgICAgICAgICAgIHsg ImtleSI6ICJnYXZzYXZzcmZnd2FldndlZmF3dmFlIiB9LAorICAgICAgICAgICAgICAgIF0pOwor ICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICB2YXIga2V5ID0gdXJsLm1hdGNo KC9rZXk9KFteJl0rKS8pWzFdOworICAgICAgICAgICAgICAgIGNhbGxiYWNrKGtleU1hcFtrZXld KTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfSk7CisgICAgfTsKKworICAgIHNpbXVsYXRvci5y dW5UZXN0KGZ1bmN0aW9uKCkgeworICAgICAgICByZXN1bHRzLnJlZ3Jlc3Npb25SYW5nZUZvckZh aWx1cmUoIk1vY2sgQnVpbGRlciIsICJ1c2Vyc2NyaXB0cy9hbm90aGVyLXRlc3QuaHRtbCIsIGZ1 bmN0aW9uKG9sZGVzdEZhaWxpbmdSZXZpc2lvbiwgbmV3ZXN0UGFzc2luZ1JldmlzaW9uKSB7Cisg ICAgICAgICAgICBlcXVhbHMob2xkZXN0RmFpbGluZ1JldmlzaW9uLCAwKTsKKyAgICAgICAgICAg IGVxdWFscyhuZXdlc3RQYXNzaW5nUmV2aXNpb24sIDApOworICAgICAgICB9KTsKKyAgICB9KTsK K30pOworCiB0ZXN0KCJjb2xsZWN0VW5leHBlY3RlZFJlc3VsdHMiLCAxLCBmdW5jdGlvbigpIHsK ICAgICB2YXIgZGljdGlvbmFyeU9mUmVzdWx0Tm9kZXMgPSB7CiAgICAgICAgICJmb28iOiB7CmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRl bmluZ3NlcnZlci91aS5qcyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2Rh dGEvZ2FyZGVuaW5nc2VydmVyL3VpLmpzCmluZGV4IGY2MzRiZjFhMjgwZDZhODc5MTk1OTE2OGVi Mjk3YjUyNjk2ZTY1ZTAuLjQ2MzljNzcwNjlhYjg1YjI4ZTI0ZDZkYjE5NzdkNGRiODdmNWZhNTYg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2Fy ZGVuaW5nc2VydmVyL3VpLmpzCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2 ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL3VpLmpzCkBAIC01MCw3ICs1MCw3IEBAIHVpLnN1bW1h cml6ZVRlc3QgPSBmdW5jdGlvbih0ZXN0TmFtZSwgcmVzdWx0Tm9kZXNCeUJ1aWxkZXIpCiB1aS5z dW1tYXJpemVSZWdyZXNzaW9uUmFuZ2UgPSBmdW5jdGlvbihvbGRlc3RGYWlsaW5nUmV2aXNpb24s IG5ld2VzdFBhc3NpbmdSZXZpc2lvbikKIHsKICAgICBpZiAoIW9sZGVzdEZhaWxpbmdSZXZpc2lv biB8fCAhbmV3ZXN0UGFzc2luZ1JldmlzaW9uKQotICAgICAgICByZXR1cm4gJCgpOworICAgICAg ICByZXR1cm4gJCgnPGRpdiBjbGFzcz0icmVncmVzc2lvbi1yYW5nZSI+UmVncmVzc2lvbiBSYW5n ZTogVW5rbm93bjwvZGl2PicpOwogCiAgICAgdmFyIGltcGxpZWRGaXJzdEZhaWxpbmdSZXZpc2lv biA9IG5ld2VzdFBhc3NpbmdSZXZpc2lvbiArIDE7CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL3VpX3VuaXR0ZXN0 cy5qcyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5n c2VydmVyL3VpX3VuaXR0ZXN0cy5qcwppbmRleCA5Y2JkNzE5YjAxZjNlZDQ4NmY5MWM3MWJkMjQ1 M2I0YzY5ZTczOGUwLi5kYTk4MjIxYmYxMGNmZGZmYjdiMTgzOGVjYzVjNGRmNDFiODkzNWIwIDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRl bmluZ3NlcnZlci91aV91bml0dGVzdHMuanMKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvdWlfdW5pdHRlc3RzLmpzCkBAIC0zMCw3 ICszMCwxMSBAQCB0ZXN0KCJzdW1tYXJpemVUZXN0IiwgMywgZnVuY3Rpb24oKSB7CiAgICAgb2so c3VtbWFyeUhUTUwuaW5kZXhPZignTW9jayBCdWlsZGVyJykgIT0gLTEpOwogfSk7CiAKLXRlc3Qo InN1bW1hcml6ZVJlZ3Jlc3Npb25SYW5nZSIsIDIsIGZ1bmN0aW9uKCkgewordGVzdCgic3VtbWFy aXplUmVncmVzc2lvblJhbmdlIiwgMywgZnVuY3Rpb24oKSB7CisgICAgdmFyIHN1bW1hcnlXaXRo TXVsdGlwbGVSZXZpc2lvbnMgPSB1aS5zdW1tYXJpemVSZWdyZXNzaW9uUmFuZ2UoMCwgMCk7Cisg ICAgc3VtbWFyeVdpdGhNdWx0aXBsZVJldmlzaW9ucy53cmFwKCc8d3JhcHBlcj48L3dyYXBwZXI+ Jyk7CisgICAgZXF1YWwoc3VtbWFyeVdpdGhNdWx0aXBsZVJldmlzaW9ucy5wYXJlbnQoKS5odG1s KCksICc8ZGl2IGNsYXNzPSJyZWdyZXNzaW9uLXJhbmdlIj5SZWdyZXNzaW9uIFJhbmdlOiBVbmtu b3duPC9kaXY+Jyk7CisKICAgICB2YXIgc3VtbWFyeVdpdGhNdWx0aXBsZVJldmlzaW9ucyA9IHVp LnN1bW1hcml6ZVJlZ3Jlc3Npb25SYW5nZSg5MDQyNCwgOTA0MjYpOwogICAgIHN1bW1hcnlXaXRo TXVsdGlwbGVSZXZpc2lvbnMud3JhcCgnPHdyYXBwZXI+PC93cmFwcGVyPicpOwogICAgIGVxdWFs KHN1bW1hcnlXaXRoTXVsdGlwbGVSZXZpc2lvbnMucGFyZW50KCkuaHRtbCgpLCAnPGRpdiBjbGFz cz0icmVncmVzc2lvbi1yYW5nZSI+UmVncmVzc2lvbiBSYW5nZTogPGEgaHJlZj0iaHR0cDovL3Ry YWMud2Via2l0Lm9yZy9sb2cvdHJ1bmsvP3Jldj05MDQyNCZhbXA7c3RvcF9yZXY9OTA0MjcmYW1w O2xpbWl0PTEwMCZhbXA7dmVyYm9zZT1vbiI+cjkwNDI3LXI5MDQyNDwvYT48L2Rpdj4nKTsK