64422 2011-07-12 19:16:45 -0700 Adjust garden-o-matic layout to use fewer lines 2011-07-12 19:41:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64188 1 abarth abarth dglazkov eric ojan oldest_to_newest 436160 0 abarth 2011-07-12 19:16:45 -0700 Adjust garden-o-matic layout to use fewer lines 436161 1 100607 abarth 2011-07-12 19:18:23 -0700 Created attachment 100607 Patch 436163 2 abarth 2011-07-12 19:22:58 -0700 +ojan Thanks for reviewing these patches! 436165 3 100607 ojan 2011-07-12 19:24:56 -0700 Comment on attachment 100607 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100607&action=review > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:35 > + '<div class="when">' + Do you still need the "when" classname? It makes less sense now that it includes failure count. 436171 4 abarth 2011-07-12 19:31:34 -0700 (In reply to comment #3) > (From update of attachment 100607 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100607&action=review > > > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:35 > > + '<div class="when">' + > > Do you still need the "when" classname? It makes less sense now that it includes failure count. Yeah, I'm not sure we do. This stuff is mostly cargo-cult from dglazkov's mocks. 436176 5 abarth 2011-07-12 19:39:57 -0700 I'm going to leave it for now. It's not hurting anyone. 436178 6 100607 abarth 2011-07-12 19:41:24 -0700 Comment on attachment 100607 Patch Clearing flags on attachment: 100607 Committed r90881: <http://trac.webkit.org/changeset/90881> 436179 7 abarth 2011-07-12 19:41:28 -0700 All reviewed patches have been landed. Closing bug. 100607 2011-07-12 19:18:23 -0700 2011-07-12 19:41:23 -0700 Patch bug-64422-20110712191822.patch text/plain 4468 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTA4NzYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1ZTFjZDQ1M2ZhMWI1M2Y1ZjdjOGZmMzU5ZTg5OTM5OWI4 ZjlkMmQ2Li43MjZmZDEyNTI4NTY0YmZhMmQ2MDZkYTY4ODY2OGRlZDc3MzE4OGIxIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTEtMDctMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAg ICBBZGp1c3QgZ2FyZGVuLW8tbWF0aWMgbGF5b3V0IHRvIHVzZSBmZXdlciBsaW5lcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ0MjIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGVmZmVj dGl2ZWx5IG1lcmdlcyB0aGUgdGVzdCBuYW1lIGxpbmUgd2l0aCB0aGUgbGlzdCBvZgorICAgICAg ICBidWlsZGVycyBvbiB3aGljaCB0aGUgdGVzdCBmYWlscy4gIEVhY2ggdGVzdCBmYWlsdXJlIG5v dyBvY2N1cGllcyB0d28KKyAgICAgICAgbGluZXMgaW5zdGVhZCBvZiB0aHJlZS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL21h aW4uY3NzOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2Fy ZGVuaW5nc2VydmVyL21haW4uanM6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL3Nl cnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvdWkuanM6CisKKzIwMTEtMDctMTIgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwogICAgICAgICBnYXJkZW4tby1tYXRpYyBzaG91bGQg bGFiZWwgdGVzdHMgZmFpbHVyZXMgb2YgbmV3IHRlc3RzIGFzIHN1Y2gKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0NDIxCiAKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL21h aW4uY3NzIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5p bmdzZXJ2ZXIvbWFpbi5jc3MKaW5kZXggZjU4YjhhNDQ0NGY0NWNlNzMzNzdkZTVmYjhjNmUzNjUw NjZmOGQ4Yi4uYjUwYzYwYjI0OGRjNTM5NmNlMjcyZGYyNDhhYTQyMDBhNDg0ZGFiMCAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdz ZXJ2ZXIvbWFpbi5jc3MKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMv ZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvbWFpbi5jc3MKQEAgLTU3LDYgKzU3LDcgQEAgdHI6bGFzdC1v Zi10eXBlIHRkIHsKIC5yZWdyZXNzaW9uIHVsIHsKICAgICBtYXJnaW46IDA7CiAgICAgbGlzdC1z dHlsZTogbm9uZTsKKyAgICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7CiAgICAgcGFkZGluZzogMCAw IDAgMTBweDsKIH0KIApAQCAtMTM1LDExICsxMzYsMTEgQEAgdHI6bGFzdC1vZi10eXBlIHRkIHsK ICAgICBjb2xvcjogIzU1NTsKIH0KIAotLnJlZ3Jlc3Npb24gLndoZW4sIC5yZWdyZXNzaW9uIC5o b3ctbWFueSB7CisucmVncmVzc2lvbiAucmVncmVzc2lvbi1yYW5nZSwgLnJlZ3Jlc3Npb24gLmZh aWx1cmUtY291bnQgewogICAgIHBhZGRpbmc6IDBweCAycHg7CiAgICAgZGlzcGxheTogaW5saW5l LWJsb2NrOwogfQogCi0ucmVncmVzc2lvbiAuaG93LW1hbnkgeworLnJlZ3Jlc3Npb24gLmZhaWx1 cmUtY291bnQgewogICAgIGNvbG9yOiAjNTU1OwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvbWFpbi5qcyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL21h aW4uanMKaW5kZXggZDllMzEwNGZjYzliNGNiNzVmYWNhZjA3ZjZhNzQ2M2Q3MmI1ZGI2MS4uMzM0 ZmNiMDFjZWRmNmU0NGI5ZTkzNTFhZGEwYmRiOWVlNzFiM2Y4YiAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvbWFpbi5q cworKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmlu Z3NlcnZlci9tYWluLmpzCkBAIC0yOSwxNCArMjksMTQgQEAgZnVuY3Rpb24gZmV0Y2hSZXN1bHRz KG9uc3VjY2VzcykKIAogICAgICAgICAgICAgICAgIHZhciBidWlsZGVyTmFtZUxpc3QgPSBiYXNl LmtleXMocmVzdWx0Tm9kZXNCeUJ1aWxkZXIpOwogICAgICAgICAgICAgICAgIHJlc3VsdHMudW5p ZnlSZWdyZXNzaW9uUmFuZ2VzKGJ1aWxkZXJOYW1lTGlzdCwgdGVzdE5hbWUsIGZ1bmN0aW9uKG9s ZGVzdEZhaWxpbmdSZXZpc2lvbiwgbmV3ZXN0UGFzc2luZ1JldmlzaW9uKSB7Ci0gICAgICAgICAg ICAgICAgICAgICQoJy53aGVuJywgdGVzdFN1bW1hcnkpLmFwcGVuZCh1aS5zdW1tYXJpemVSZWdy ZXNzaW9uUmFuZ2Uob2xkZXN0RmFpbGluZ1JldmlzaW9uLCBuZXdlc3RQYXNzaW5nUmV2aXNpb24p KTsKKyAgICAgICAgICAgICAgICAgICAgJCgnLnJlZ3Jlc3Npb24tcmFuZ2UnLCB0ZXN0U3VtbWFy eSkuYXBwZW5kKHVpLnN1bW1hcml6ZVJlZ3Jlc3Npb25SYW5nZShvbGRlc3RGYWlsaW5nUmV2aXNp b24sIG5ld2VzdFBhc3NpbmdSZXZpc2lvbikpOwogICAgICAgICAgICAgICAgICAgICBjaGVja291 dC5leGlzdHNBdFJldmlzaW9uKGNoZWNrb3V0LnN1YnZlcnNpb25VUkxGb3JUZXN0KHRlc3ROYW1l KSwgbmV3ZXN0UGFzc2luZ1JldmlzaW9uLCBmdW5jdGlvbih0ZXN0RXhpc3RlZEJlZm9yZUZhaWx1 cmUpIHsKICAgICAgICAgICAgICAgICAgICAgICAgICQodGVzdFN1bW1hcnkpLmF0dHIoJ2RhdGEt bmV3LXRlc3QnLCAhdGVzdEV4aXN0ZWRCZWZvcmVGYWlsdXJlKTsKICAgICAgICAgICAgICAgICAg ICAgfSk7CiAgICAgICAgICAgICAgICAgfSk7CiAgICAgICAgICAgICAgICAgcmVzdWx0cy5jb3Vu dEZhaWx1cmVPY2N1cmFuY2VzKGJ1aWxkZXJOYW1lTGlzdCwgdGVzdE5hbWUsIGZ1bmN0aW9uKGZh aWx1cmVDb3VudCkgewogICAgICAgICAgICAgICAgICAgICAkKHRlc3RTdW1tYXJ5KS5hdHRyKCdk YXRhLWZhaWx1cmUtY291bnQnLCBmYWlsdXJlQ291bnQpOwotICAgICAgICAgICAgICAgICAgICAk KCcuaG93LW1hbnknLCB0ZXN0U3VtbWFyeSkudGV4dCh1aS5mYWlsdXJlQ291bnQoZmFpbHVyZUNv dW50KSk7CisgICAgICAgICAgICAgICAgICAgICQoJy5mYWlsdXJlLWNvdW50JywgdGVzdFN1bW1h cnkpLnRleHQodWkuZmFpbHVyZUNvdW50KGZhaWx1cmVDb3VudCkpOwogICAgICAgICAgICAgICAg IH0pOwogICAgICAgICAgICAgfSk7CiAgICAgICAgICAgICAkKCcucmVzdWx0cycpLmFwcGVuZChy ZWdyZXNzaW9ucyk7CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2Vy dmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci91aS5qcyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL3VpLmpzCmluZGV4IDY0ODZkMDc5MDg4 MTE4OWRlMjE2ZTczMzBkZTM0NmM4NTAyOGM2MmUuLmY2MzRiZjFhMjgwZDZhODc5MTk1OTE2OGVi Mjk3YjUyNjk2ZTY1ZTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9z ZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL3VpLmpzCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL3VpLmpzCkBAIC0zMiw4ICsz MiwxMCBAQCB1aS5zdW1tYXJpemVUZXN0ID0gZnVuY3Rpb24odGVzdE5hbWUsIHJlc3VsdE5vZGVz QnlCdWlsZGVyKQogICAgICAgICAgICc8c3BhbiBjbGFzcz0id2hhdCI+PGEgZHJhZ2dhYmxlPjwv YT48L3NwYW4+JyArCiAgICAgICAgICAgJzxzcGFuPmZhaWxzIG9uPC9zcGFuPicgKwogICAgICAg ICAgICc8dWwgY2xhc3M9IndoZXJlIj48L3VsPicgKwotICAgICAgICAgICc8ZGl2IGNsYXNzPSJ3 aGVuIj48L2Rpdj4nICsKLSAgICAgICAgICAnPGRpdiBjbGFzcz0iaG93LW1hbnkiPjwvZGl2Picg KworICAgICAgICAgICc8ZGl2IGNsYXNzPSJ3aGVuIj4nICsKKyAgICAgICAgICAgICc8ZGl2IGNs YXNzPSJyZWdyZXNzaW9uLXJhbmdlIj48L2Rpdj4nICsKKyAgICAgICAgICAgICc8ZGl2IGNsYXNz PSJmYWlsdXJlLWNvdW50Ij48L2Rpdj4nICsKKyAgICAgICAgICAnPC9kaXY+JyArCiAgICAgICAg ICc8L2Rpdj4nKTsKICAgICAkKCcud2hhdCBhJywgYmxvY2spLnRleHQodGVzdE5hbWUpLmF0dHIo J2hyZWYnLCB1aS51cmxGb3JUZXN0KHRlc3ROYW1lKSkuYXR0cignY2xhc3MnLCB1bmV4cGVjdGVk UmVzdWx0cy5qb2luKCcgJykpOwogCg==