64419 2011-07-12 18:39:53 -0700 Remove hack that forcefully prevents scripts from running in shadow SVG 2012-02-25 02:45:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 78902 P2 Normal --- 64776 64778 64779 64781 1 simonjam simonjam ddkilzer schenney tonyg webkit.review.bot zimmermann oldest_to_newest 436143 0 simonjam 2011-07-12 18:39:53 -0700 Remove hack that forcefully prevents scripts from running in shadow SVG 436146 1 100604 simonjam 2011-07-12 18:47:32 -0700 Created attachment 100604 Patch 436148 2 simonjam 2011-07-12 18:48:50 -0700 This should undo r88549 (except for the tests). 436327 3 100604 tonyg 2011-07-13 03:04:25 -0700 Comment on attachment 100604 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100604&action=review > Source/WebCore/ChangeLog:12 > + No new tests. Passed existing tests. No new functionality. I don't understand. Shouldn't there be an expectations update if we are now passing an existing test? 436769 4 simonjam 2011-07-13 16:47:56 -0700 (In reply to comment #3) > (From update of attachment 100604 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100604&action=review > > > Source/WebCore/ChangeLog:12 > > + No new tests. Passed existing tests. No new functionality. > > I don't understand. Shouldn't there be an expectations update if we are now passing an existing test? I mean that I ran all of the tests and they still pass as they did before the change. Because r88549 went in, the code I'm removing should never trigger. I'll try to reword that when I commit. 436771 5 100731 simonjam 2011-07-13 16:57:11 -0700 Created attachment 100731 Patch for landing 436850 6 100731 webkit.review.bot 2011-07-13 19:05:17 -0700 Comment on attachment 100731 Patch for landing Clearing flags on attachment: 100731 Committed r90970: <http://trac.webkit.org/changeset/90970> 436851 7 webkit.review.bot 2011-07-13 19:05:24 -0700 All reviewed patches have been landed. Closing bug. 438940 8 simonjam 2011-07-18 20:11:55 -0700 This hack was restored because it protects from two other bugs. 564924 9 zimmermann 2012-02-25 02:45:43 -0800 Bug 78902 also contains this change. Bug is fixed, now that SVG <use> impl uses ShadowRoot. *** This bug has been marked as a duplicate of bug 78902 *** 100604 2011-07-12 18:47:32 -0700 2011-07-13 16:57:09 -0700 Patch bug-64419-20110712184731.patch text/plain 1894 simonjam U3VidmVyc2lvbiBSZXZpc2lvbjogOTA4MzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMWNiYWY1NDBjMzY2OWFl NmMxZmM2NmEyMDdkZTM1Njg1ODlhNzhjLi43NWFiNTQxODZkNDgzYTE4OWRjMjMyYjgzMGYyOTU2 M2NhODY2ZmU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDctMTIgIEphbWVz IFNpbW9uc2VuICA8c2ltb25qYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBoYWNr IHRoYXQgZm9yY2VmdWxseSBwcmV2ZW50cyBzY3JpcHRzIGZyb20gcnVubmluZyBpbiBzaGFkb3cg U1ZHCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDQx OQorCisgICAgICAgIFRoaXMgaGFjayB3YXMgcHV0IGluIHRvIHByZXZlbnQgc2NyaXB0cyBmcm9t IHJ1bm5pbmcgaW4gc2hhZG93IFNWRy4gVGhpcyBzaG91bGQgbmV2ZXIgaGF2ZQorICAgICAgICBo YXBwZW5lZCwgYnV0IGRpZCBiZWNhdXNlIHdlIGRpZG4ndCBwYXJzZSA8c2NyaXB0PiB0YWdzIGlu IFNWRyBwcm9wZXJseS4gVGhpcyB3YXMgZml4ZWQgaW4KKyAgICAgICAgcjg4NTg0LCBzbyB0aGUg aGFjayBpcyBubyBsb25nZXIgbmVlZGVkLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gUGFzc2VkIGV4aXN0aW5nIHRlc3RzLiBO byBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIGRvbS9TY3JpcHRFbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEVsZW1lbnQ6OnByZXBhcmVTY3JpcHQpOgorCiAyMDEx LTA3LTEyICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBpbnRyb2R1Y2UgVXNlck1ldHJpY3MgZm9yIGNvbGxlY3Rpbmcgc3RhdHMg aW4gQ2hyb21pdW0gcG9ydC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRF bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmNwcAppbmRleCAz NmQ3NmI5ZjY4OWMwYzkyNzhhYzBkYzk3MjUxZTZhY2E5OTI1YWQzLi5jOGNjMzUxYzkzYjhiYzlj YzU2NmZjZWNkOTc2MGY3Nzg1YTM5ODc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v U2NyaXB0RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQu Y3BwCkBAIC0yMDMsMTQgKzIwMyw2IEBAIGJvb2wgU2NyaXB0RWxlbWVudDo6cHJlcGFyZVNjcmlw dChjb25zdCBUZXh0UG9zaXRpb24xJiBzY3JpcHRTdGFydFBvc2l0aW9uLCBMZWdhCiAgICAgaWYg KCFtX2VsZW1lbnQtPmRvY3VtZW50KCktPmZyYW1lKCktPnNjcmlwdCgpLT5jYW5FeGVjdXRlU2Ny aXB0cyhBYm91dFRvRXhlY3V0ZVNjcmlwdCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAg IC8vIEZJWE1FOiBUaGlzIGlzIG5vbi1zdGFuZGFyZC4gUmVtb3ZlIHRoaXMgYWZ0ZXIgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNDEyLgotICAgIE5vZGUqIGFuY2Vz dG9yID0gbV9lbGVtZW50LT5wYXJlbnROb2RlKCk7Ci0gICAgd2hpbGUgKGFuY2VzdG9yKSB7Ci0g ICAgICAgIGlmIChhbmNlc3Rvci0+aXNTVkdTaGFkb3dSb290KCkpCi0gICAgICAgICAgICByZXR1 cm4gZmFsc2U7Ci0gICAgICAgIGFuY2VzdG9yID0gYW5jZXN0b3ItPnBhcmVudE5vZGUoKTsKLSAg ICB9Ci0KICAgICBpZiAoIWlzU2NyaXB0Rm9yRXZlbnRTdXBwb3J0ZWQoKSkKICAgICAgICAgcmV0 dXJuIGZhbHNlOwogCg== 100731 2011-07-13 16:57:11 -0700 2011-07-13 19:05:17 -0700 Patch for landing bug-64419-20110713165710.patch text/plain 1898 simonjam U3VidmVyc2lvbiBSZXZpc2lvbjogOTA5MTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwMjAyYzE1ZTAzNThhNmU5 YzVhZjkzNzBmYTgxMTMyNzQ4OWI2M2ZlLi44YjdiY2U1MTRjMWNlYmY1YjBjMGQ1ZTVkN2Y3OWUw NjZmYzNmZjkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDctMTMgIEphbWVz IFNpbW9uc2VuICA8c2ltb25qYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBoYWNr IHRoYXQgZm9yY2VmdWxseSBwcmV2ZW50cyBzY3JpcHRzIGZyb20gcnVubmluZyBpbiBzaGFkb3cg U1ZHCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDQx OQorCisgICAgICAgIFRoaXMgaGFjayB3YXMgcHV0IGluIHRvIHByZXZlbnQgc2NyaXB0cyBmcm9t IHJ1bm5pbmcgaW4gc2hhZG93IFNWRy4gVGhpcyBzaG91bGQgbmV2ZXIgaGF2ZQorICAgICAgICBo YXBwZW5lZCwgYnV0IGRpZCBiZWNhdXNlIHdlIGRpZG4ndCBwYXJzZSA8c2NyaXB0PiB0YWdzIGlu IFNWRyBwcm9wZXJseS4gVGhpcyB3YXMgZml4ZWQgaW4KKyAgICAgICAgcjg4NTg0LCBzbyB0aGUg aGFjayBpcyBubyBsb25nZXIgbmVlZGVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0 aGVyZSBpcyBubyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICBSZXZpZXdlZCBi eSBUb255IEdlbnRpbGNvcmUuCisKKyAgICAgICAgKiBkb20vU2NyaXB0RWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTY3JpcHRFbGVtZW50OjpwcmVwYXJlU2NyaXB0KToKKwogMjAxMS0w Ny0xMyAgSm9obiBLbm90dGVuYmVsdCAgPGprbm90dGVuQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZWZlcmVuY2UgR2VvbG9jYXRpb24gb2JqZWN0IGZyb20gR2VvTm90aWZpZXIgYW5kIEdlb2xv Y2F0aW9uOjpzZXRJc0FsbG93ZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2Ny aXB0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RWxlbWVudC5jcHAKaW5k ZXggMzZkNzZiOWY2ODljMGM5Mjc4YWMwZGM5NzI1MWU2YWNhOTkyNWFkMy4uYzhjYzM1MWM5M2I4 YmM5Y2M1NjZmY2VjZDk3NjBmNzc4NWEzOTg3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZG9tL1NjcmlwdEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVt ZW50LmNwcApAQCAtMjAzLDE0ICsyMDMsNiBAQCBib29sIFNjcmlwdEVsZW1lbnQ6OnByZXBhcmVT Y3JpcHQoY29uc3QgVGV4dFBvc2l0aW9uMSYgc2NyaXB0U3RhcnRQb3NpdGlvbiwgTGVnYQogICAg IGlmICghbV9lbGVtZW50LT5kb2N1bWVudCgpLT5mcmFtZSgpLT5zY3JpcHQoKS0+Y2FuRXhlY3V0 ZVNjcmlwdHMoQWJvdXRUb0V4ZWN1dGVTY3JpcHQpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK LSAgICAvLyBGSVhNRTogVGhpcyBpcyBub24tc3RhbmRhcmQuIFJlbW92ZSB0aGlzIGFmdGVyIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjQxMi4KLSAgICBOb2RlKiBh bmNlc3RvciA9IG1fZWxlbWVudC0+cGFyZW50Tm9kZSgpOwotICAgIHdoaWxlIChhbmNlc3Rvcikg ewotICAgICAgICBpZiAoYW5jZXN0b3ItPmlzU1ZHU2hhZG93Um9vdCgpKQotICAgICAgICAgICAg cmV0dXJuIGZhbHNlOwotICAgICAgICBhbmNlc3RvciA9IGFuY2VzdG9yLT5wYXJlbnROb2RlKCk7 Ci0gICAgfQotCiAgICAgaWYgKCFpc1NjcmlwdEZvckV2ZW50U3VwcG9ydGVkKCkpCiAgICAgICAg IHJldHVybiBmYWxzZTsKIAo=