64418 2011-07-12 18:20:29 -0700 sheriffbot isn't reopening patches after it lands rollouts 2012-05-06 21:08:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 webkit.review.bot tomz abarth dpranke eric ojan tomz oldest_to_newest 436137 0 webkit.review.bot 2011-07-12 18:20:29 -0700 sheriffbot isn't reopening patches after it lands rollouts Requested by abarth on #webkit. 483602 1 abarth 2011-10-13 16:11:37 -0700 This is worth fixing if it's still the case. 486893 2 tomz 2011-10-19 11:21:21 -0700 Do you mean re-open the bug? Is this something that webkit-patch create-rollout should do? I'm having trouble understanding the different use-cases for prepare-rollout, create-rollout, and rollout in webkit-patch. 487022 3 abarth 2011-10-19 14:44:05 -0700 > prepare-rollout This is meant to be a local command that only affects the local working copy. We could rename this to prepare-rollout-locally if that would be clearer. > create-rollout This is meant to post a rollout patch to a new bug. We could rename this to "post-rollout" if that would be clearer. > rollout This is meant to actually do a full rollout, including preparing the local change and then landing it. 487023 4 abarth 2011-10-19 14:44:47 -0700 > Is this something that webkit-patch create-rollout should do? Sure. The only risk there is that we'll create a rollout patch but never land it. I guess that means the person will just have to close their bug again. 487027 5 tomz 2011-10-19 14:50:49 -0700 I think that's reasonable. Especially since the alternative is that there could be a bug out there with a patch waiting to undo an author's change that they might not be aware of. 487030 6 abarth 2011-10-19 14:53:02 -0700 There's already logic to mark the rollout bug as blocking the original bug. It's probably easy to make it re-open the bug at that stage. 488499 7 111989 tomz 2011-10-21 11:02:31 -0700 Created attachment 111989 Patch 488572 8 abarth 2011-10-21 12:50:09 -0700 As I mentioned to tomz in IRC, we can test this either using a step unittest or a command unittest. In either case, the MockTool will be substituted for the tool and the reopen_bug function on the mock object should generate logging output that we can capture and check. 617081 9 140418 tomz 2012-05-05 23:17:46 -0700 Created attachment 140418 Patch 617115 10 140418 abarth 2012-05-06 09:41:38 -0700 Comment on attachment 140418 Patch Ah, nice approach. 617194 11 140418 webkit.review.bot 2012-05-06 15:32:35 -0700 Comment on attachment 140418 Patch Clearing flags on attachment: 140418 Committed r116245: <http://trac.webkit.org/changeset/116245> 617195 12 webkit.review.bot 2012-05-06 15:32:42 -0700 All reviewed patches have been landed. Closing bug. 617202 13 eric 2012-05-06 15:47:43 -0700 I'm not sure I follow exactly. This makes it so that when sherriff-bot creates a rollout he re-opens the original bug? 617351 14 tomz 2012-05-06 21:08:50 -0700 (In reply to comment #13) > I'm not sure I follow exactly. This makes it so that when sherriff-bot creates a rollout he re-opens the original bug? Yes. 111989 2011-10-21 11:02:31 -0700 2012-05-05 23:17:42 -0700 Patch bug-64418-20111021110219.patch text/plain 1306 tomz U3VidmVyc2lvbiBSZXZpc2lvbjogOTc4NjYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlMTViZDc3ZjViOWZlMTM2MThjNWVhY2UzMzA2ZDRmMGI3 MzI1OGMzLi5iYjc2NThkYzA3YWRjODIzZmIxNWRjMDhhODA2ZGE1NTlkOWMwYTRkIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMTAtMjEgIFRvbSBaYWtyYWpzZWsgIDx0b216QGNvZGVhdXJvcmEub3JnPgorCisg ICAgICAgIHNoZXJpZmZib3QgaXNuJ3QgcmVvcGVuaW5nIHBhdGNoZXMgYWZ0ZXIgaXQgbGFuZHMg cm9sbG91dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY0NDE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY3JlYXRlYnVnLnB5OgorCiAyMDExLTEwLTE5 ICBDaGFuZyBTaHUgIDxjc2h1QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBTdXBwb3J0IFdL MS1vbmx5IFNraXBwZWQgbGlzdApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL3N0ZXBzL2NyZWF0ZWJ1Zy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVw cy9jcmVhdGVidWcucHkKaW5kZXggMGFiNmY2OGEyM2RlM2MzMGFhMzc4NzcyODllNGU1Y2YxNTc4 NjkzYy4uMjYzOGQxOTczNDNmY2M0MjUzNDMzMDA4NGI1MGZmMmQ4OTg2MzI2NCAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2NyZWF0ZWJ1Zy5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY3JlYXRlYnVnLnB5CkBAIC01MCwzICs1 MCw1IEBAIGNsYXNzIENyZWF0ZUJ1ZyhBYnN0cmFjdFN0ZXApOgogICAgICAgICBpZiBub3QgYmxv Y2tzOgogICAgICAgICAgICAgYmxvY2tzID0gc3RhdGUuZ2V0KCJidWdfYmxvY2tlZCIpCiAgICAg ICAgIHN0YXRlWyJidWdfaWQiXSA9IHNlbGYuX3Rvb2wuYnVncy5jcmVhdGVfYnVnKHN0YXRlWyJi dWdfdGl0bGUiXSwgc3RhdGVbImJ1Z19kZXNjcmlwdGlvbiJdLCBibG9ja2VkPWJsb2NrcywgY29t cG9uZW50PXNlbGYuX29wdGlvbnMuY29tcG9uZW50LCBjYz1jYykKKyAgICAgICAgaWYgYmxvY2tz OgorICAgICAgICAgICAgc2VsZi5fdG9vbC5idWdzLnJlb3Blbl9idWcoYmxvY2tzLCAiUmUtb3Bl bmVkIHNpbmNlIHRoaXMgaXMgYmxvY2tlZCBieSAlcyIgJSBzdGF0ZVsiYnVnX2lkIl0pCg== 140418 2012-05-05 23:17:46 -0700 2012-05-06 15:32:35 -0700 Patch bug-64418-20120505231744.patch text/plain 2374 tomz U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MjMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjkxNjMxNTRlZmY0NzIyZjkzMTBlMzkyNWE5MGY0NmU1 NmE2NWZjMS4uZGZkODg3YmMyYTdiZjllNDBjODYwYmJiYzc0NThiOTM3ZDljYTU4NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTA1LTA1ICBUb20gWmFrcmFqc2VrICA8dG9tekBjb2RlYXVyb3JhLm9yZz4KKwor ICAgICAgICBzaGVyaWZmYm90IGlzbid0IHJlb3BlbmluZyBwYXRjaGVzIGFmdGVyIGl0IGxhbmRz IHJvbGxvdXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02NDQxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25sb2FkX3VuaXR0ZXN0LnB5Ogor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jcmVhdGVidWcucHk6CisgICAg ICAgIChDcmVhdGVCdWcucnVuKToKKwogMjAxMi0wNS0wNCAgUmFwaGFlbCBLdWJvIGRhIENvc3Rh ICA8cmFrdWNvQHdlYmtpdC5vcmc+CiAKICAgICAgICAgd2Via2l0cHk6IFVzZSBvcy5wYXRoc2Vw IGluc3RlYWQgb2YgbWFudWFsbHkgZmluZGluZyBvdXQgdGhlIHBhdGggc2VwYXJhdG9yIGluIE5S V1QuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZG93 bmxvYWRfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMv ZG93bmxvYWRfdW5pdHRlc3QucHkKaW5kZXggOWExMTU4MzlmYTcyNmZmZDYwNjM2ZjEwOTUzMzhm MTkxZDk3MGU3NC4uZjkzNmE5NjczMjMzZTY2ZDE0YjM2MDZjMTBjMjJhZjlmM2IxZTJmMiAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25sb2FkX3Vu aXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3du bG9hZF91bml0dGVzdC5weQpAQCAtMjYxLDYgKzI2MSw3IEBAIFJlYXNvbgogY29tcG9uZW50OiBN T0NLIGNvbXBvbmVudAogY2M6IE1PQ0sgY2MKIGJsb2NrZWQ6IDUwMDAwCitNT0NLIHJlb3Blbl9i dWcgNTAwMDAgd2l0aCBjb21tZW50ICdSZS1vcGVuZWQgc2luY2UgdGhpcyBpcyBibG9ja2VkIGJ5 IDUwMDA0JwogTU9DSyBhZGRfcGF0Y2hfdG9fYnVnOiBidWdfaWQ9NTAwMDQsIGRlc2NyaXB0aW9u PVJPTExPVVQgb2Ygcjg1MiwgbWFya19mb3JfcmV2aWV3PUZhbHNlLCBtYXJrX2Zvcl9jb21taXRf cXVldWU9VHJ1ZSwgbWFya19mb3JfbGFuZGluZz1GYWxzZQogLS0gQmVnaW4gY29tbWVudCAtLQog QW55IGNvbW1pdHRlciBjYW4gbGFuZCB0aGlzIHBhdGNoIGF1dG9tYXRpY2FsbHkgYnkgbWFya2lu ZyBpdCBjb21taXQtcXVldWUrLiAgVGhlIGNvbW1pdC1xdWV1ZSB3aWxsIGJ1aWxkIGFuZCB0ZXN0 IHRoZSBwYXRjaCBiZWZvcmUgbGFuZGluZyB0byBlbnN1cmUgdGhhdCB0aGUgcm9sbG91dCB3aWxs IGJlIHN1Y2Nlc3NmdWwuICBUaGlzIHByb2Nlc3MgdGFrZXMgYXBwcm94aW1hdGVseSAxNSBtaW51 dGVzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2NyZWF0 ZWJ1Zy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jcmVhdGVidWcucHkK aW5kZXggMGFiNmY2OGEyM2RlM2MzMGFhMzc4NzcyODllNGU1Y2YxNTc4NjkzYy4uMjYzOGQxOTcz NDNmY2M0MjUzNDMzMDA4NGI1MGZmMmQ4OTg2MzI2NCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL3N0ZXBzL2NyZWF0ZWJ1Zy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvc3RlcHMvY3JlYXRlYnVnLnB5CkBAIC01MCwzICs1MCw1IEBAIGNsYXNzIENy ZWF0ZUJ1ZyhBYnN0cmFjdFN0ZXApOgogICAgICAgICBpZiBub3QgYmxvY2tzOgogICAgICAgICAg ICAgYmxvY2tzID0gc3RhdGUuZ2V0KCJidWdfYmxvY2tlZCIpCiAgICAgICAgIHN0YXRlWyJidWdf aWQiXSA9IHNlbGYuX3Rvb2wuYnVncy5jcmVhdGVfYnVnKHN0YXRlWyJidWdfdGl0bGUiXSwgc3Rh dGVbImJ1Z19kZXNjcmlwdGlvbiJdLCBibG9ja2VkPWJsb2NrcywgY29tcG9uZW50PXNlbGYuX29w dGlvbnMuY29tcG9uZW50LCBjYz1jYykKKyAgICAgICAgaWYgYmxvY2tzOgorICAgICAgICAgICAg c2VsZi5fdG9vbC5idWdzLnJlb3Blbl9idWcoYmxvY2tzLCAiUmUtb3BlbmVkIHNpbmNlIHRoaXMg aXMgYmxvY2tlZCBieSAlcyIgJSBzdGF0ZVsiYnVnX2lkIl0pCg==