64397 2011-07-12 14:45:20 -0700 Added the ability to dynamically change the parent context of a WebGraphicsContext3D. 2011-07-12 19:28:34 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apatrick apatrick kbr webkit.review.bot oldest_to_newest 435978 0 apatrick 2011-07-12 14:45:20 -0700 Added the ability to dynamically change the parent context of a WebGraphicsContext3D. GraphicsContext3DInternal::platformTexture uses this to set the parent as appropriate. This is to fix the bug where a WebGL canvas cannot be moved to a newly opened window in Chrome. 435980 1 100566 apatrick 2011-07-12 14:46:57 -0700 Created attachment 100566 Patch 435982 2 webkit.review.bot 2011-07-12 14:49:06 -0700 Attachment 100566 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/chromium/public/WebGraphicsContext3D.h:135: parent_context is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 436041 3 100566 kbr 2011-07-12 16:08:17 -0700 Comment on attachment 100566 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100566&action=review Please clean up the style issues and re-upload the patch. > Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:146 > + m_impl->setParentContext(m_webViewImpl->graphicsContext3D()); Does this still work if accelerated compositing is turned off (i.e., with the command line argument --disable-accelerated-compositing)? 436066 4 100585 apatrick 2011-07-12 16:31:34 -0700 Created attachment 100585 Patch 2 436068 5 100566 apatrick 2011-07-12 16:32:50 -0700 Comment on attachment 100566 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100566&action=review >> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:146 >> + m_impl->setParentContext(m_webViewImpl->graphicsContext3D()); > > Does this still work if accelerated compositing is turned off (i.e., with the command line argument --disable-accelerated-compositing)? Yeah. platformTexture doesn't get called when the accelerated compositor is turned off. 436140 6 100585 kbr 2011-07-12 18:35:48 -0700 Comment on attachment 100585 Patch 2 OK, seems fine as long as it's been tested. 436167 7 100585 webkit.review.bot 2011-07-12 19:28:29 -0700 Comment on attachment 100585 Patch 2 Clearing flags on attachment: 100585 Committed r90878: <http://trac.webkit.org/changeset/90878> 436168 8 webkit.review.bot 2011-07-12 19:28:34 -0700 All reviewed patches have been landed. Closing bug. 100566 2011-07-12 14:46:57 -0700 2011-07-12 16:32:50 -0700 Patch setparent.patch text/plain 2112 apatrick SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5MDg0NCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDctMTIgIEFsIFBhdHJpY2sgIDxhcGF0cmlja0BjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgQWRkZWQgdGhlIGFiaWxpdHkgdG8gZHluYW1pY2FsbHkgY2hhbmdlIHRoZSBwYXJlbnQg Y29udGV4dCBvZiBhIFdlYkdyYXBoaWNzQ29udGV4dDNELgorICAgICAgICBHcmFwaGljc0NvbnRl eHQzREludGVybmFsOjpwbGF0Zm9ybVRleHR1cmUgdXNlcyB0aGlzIHRvIHNldCB0aGUgcGFyZW50 IGFzIGFwcHJvcHJpYXRlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmg6CisgICAgICAgIChXZWJL aXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEOjpzZXRQYXJlbnRDb250ZXh0KToKKyAgICAgICAgKiBz cmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFw aGljc0NvbnRleHQzREludGVybmFsOjpwbGF0Zm9ybVRleHR1cmUpOgorCiAyMDExLTA3LTEyICBT aGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkLiAgUm9sbGVkIERFUFMuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmgJKHJldmlzaW9uIDkwNTg2KQorKysg U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR3JhcGhpY3NDb250ZXh0M0QuaAkod29y a2luZyBjb3B5KQpAQCAtMTMyLDYgKzEzMiw4IEBAIHB1YmxpYzoKICAgICAvLyBRdWVyeSB3aGV0 aGVyIGl0IGlzIGJ1aWx0IG9uIHRvcCBvZiBjb21wbGlhbnQgR0xFUzIgaW1wbGVtZW50YXRpb24u CiAgICAgdmlydHVhbCBib29sIGlzR0xFUzJDb21wbGlhbnQoKSA9IDA7CiAKKyAgICB2aXJ0dWFs IGJvb2wgc2V0UGFyZW50Q29udGV4dChXZWJHcmFwaGljc0NvbnRleHQzRCogcGFyZW50X2NvbnRl eHQpIHsgcmV0dXJuIGZhbHNlOyB9CisKICAgICAvLyBIZWxwZXIgZm9yIHNvZnR3YXJlIGNvbXBv c2l0aW5nIHBhdGguIFJlYWRzIGJhY2sgdGhlIGZyYW1lIGJ1ZmZlciBpbnRvCiAgICAgLy8gdGhl IG1lbW9yeSByZWdpb24gcG9pbnRlZCB0byBieSAicGl4ZWxzIiB3aXRoIHNpemUgImJ1ZmZlclNp emUiLiBJdCBpcwogICAgIC8vIGV4cGVjdGVkIHRoYXQgdGhlIHN0b3JhZ2UgZm9yICJwaXhlbHMi IGNvdmVycyAoNCAqIHdpZHRoICogaGVpZ2h0KSBieXRlcy4KSW5kZXg6IFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL0dyYXBoaWNzQ29udGV4dDNEQ2hyb21pdW0uY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29udGV4dDNEQ2hyb21pdW0uY3Bw CShyZXZpc2lvbiA5MDU4NikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNz Q29udGV4dDNEQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDMsNiArMTQzLDcgQEAg UGxhdGZvcm1HcmFwaGljc0NvbnRleHQzRCBHcmFwaGljc0NvbnRleAogCiBQbGF0Zm9ybTNET2Jq ZWN0IEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw6OnBsYXRmb3JtVGV4dHVyZSgpIGNvbnN0CiB7 CisgICAgbV9pbXBsLT5zZXRQYXJlbnRDb250ZXh0KG1fd2ViVmlld0ltcGwtPmdyYXBoaWNzQ29u dGV4dDNEKCkpOwogICAgIHJldHVybiBtX2ltcGwtPmdldFBsYXRmb3JtVGV4dHVyZUlkKCk7CiB9 CiAK 100585 2011-07-12 16:31:34 -0700 2011-07-12 19:28:29 -0700 Patch 2 setparent.patch text/plain 2166 apatrick SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5MDg0NCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDctMTIgIEFsIFBhdHJpY2sgIDxhcGF0cmlja0BjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgQWRkZWQgdGhlIGFiaWxpdHkgdG8gZHluYW1pY2FsbHkgY2hhbmdlIHRoZSBwYXJlbnQg Y29udGV4dCBvZiBhIFdlYkdyYXBoaWNzQ29udGV4dDNELgorICAgICAgICBHcmFwaGljc0NvbnRl eHQzREludGVybmFsOjpwbGF0Zm9ybVRleHR1cmUgdXNlcyB0aGlzIHRvIHNldCB0aGUgcGFyZW50 IGFzIGFwcHJvcHJpYXRlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjQzOTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHB1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oOgorICAgICAgICAoV2ViS2l0 OjpXZWJHcmFwaGljc0NvbnRleHQzRDo6c2V0UGFyZW50Q29udGV4dCk6CisgICAgICAgICogc3Jj L0dyYXBoaWNzQ29udGV4dDNEQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhp Y3NDb250ZXh0M0RJbnRlcm5hbDo6cGxhdGZvcm1UZXh0dXJlKToKKwogMjAxMS0wNy0xMiAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZC4gIFJvbGxlZCBERVBTLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViR3JhcGhpY3NDb250ZXh0M0QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCShyZXZpc2lvbiA5MDU4NikKKysrIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmgJKHdvcmtp bmcgY29weSkKQEAgLTEzMiw2ICsxMzIsOCBAQCBwdWJsaWM6CiAgICAgLy8gUXVlcnkgd2hldGhl ciBpdCBpcyBidWlsdCBvbiB0b3Agb2YgY29tcGxpYW50IEdMRVMyIGltcGxlbWVudGF0aW9uLgog ICAgIHZpcnR1YWwgYm9vbCBpc0dMRVMyQ29tcGxpYW50KCkgPSAwOwogCisgICAgdmlydHVhbCBi b29sIHNldFBhcmVudENvbnRleHQoV2ViR3JhcGhpY3NDb250ZXh0M0QqIHBhcmVudENvbnRleHQp IHsgcmV0dXJuIGZhbHNlOyB9CisKICAgICAvLyBIZWxwZXIgZm9yIHNvZnR3YXJlIGNvbXBvc2l0 aW5nIHBhdGguIFJlYWRzIGJhY2sgdGhlIGZyYW1lIGJ1ZmZlciBpbnRvCiAgICAgLy8gdGhlIG1l bW9yeSByZWdpb24gcG9pbnRlZCB0byBieSAicGl4ZWxzIiB3aXRoIHNpemUgImJ1ZmZlclNpemUi LiBJdCBpcwogICAgIC8vIGV4cGVjdGVkIHRoYXQgdGhlIHN0b3JhZ2UgZm9yICJwaXhlbHMiIGNv dmVycyAoNCAqIHdpZHRoICogaGVpZ2h0KSBieXRlcy4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL0dyYXBoaWNzQ29udGV4dDNEQ2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29udGV4dDNEQ2hyb21pdW0uY3BwCShy ZXZpc2lvbiA5MDU4NikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29u dGV4dDNEQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDMsNiArMTQzLDcgQEAgUGxh dGZvcm1HcmFwaGljc0NvbnRleHQzRCBHcmFwaGljc0NvbnRleAogCiBQbGF0Zm9ybTNET2JqZWN0 IEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw6OnBsYXRmb3JtVGV4dHVyZSgpIGNvbnN0CiB7Cisg ICAgbV9pbXBsLT5zZXRQYXJlbnRDb250ZXh0KG1fd2ViVmlld0ltcGwtPmdyYXBoaWNzQ29udGV4 dDNEKCkpOwogICAgIHJldHVybiBtX2ltcGwtPmdldFBsYXRmb3JtVGV4dHVyZUlkKCk7CiB9CiAK