64394 2011-07-12 14:34:07 -0700 cr-linux-ews should run pixel tests 2011-07-12 15:35:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric jamesr ojan tony webkit.review.bot oldest_to_newest 435958 0 abarth 2011-07-12 14:34:07 -0700 cr-linux-ews should run pixel tests 435962 1 100564 abarth 2011-07-12 14:36:18 -0700 Created attachment 100564 Patch 435969 2 100564 ojan 2011-07-12 14:39:35 -0700 Comment on attachment 100564 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100564&action=review > Tools/ChangeLog:9 > + test on the bots, it looks like we have five pixel failures, related to I'm confused, won't these 5 tests start failing on every run now? > Tools/ChangeLog:11 > + avoid uploading huge zip files to bugs.webkit.org (with all the exected typo:exected 435971 3 abarth 2011-07-12 14:41:07 -0700 (In reply to comment #2) > (From update of attachment 100564 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100564&action=review > > > Tools/ChangeLog:9 > > + test on the bots, it looks like we have five pixel failures, related to > > I'm confused, won't these 5 tests start failing on every run now? Yes, but we have code to recognize persistent failures and ignore them. 435975 4 100564 ojan 2011-07-12 14:42:13 -0700 Comment on attachment 100564 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100564&action=review >>> Tools/ChangeLog:9 >>> + test on the bots, it looks like we have five pixel failures, related to >> >> I'm confused, won't these 5 tests start failing on every run now? > > Yes, but we have code to recognize persistent failures and ignore them. That sounds scary. 435988 5 abarth 2011-07-12 14:52:59 -0700 (In reply to comment #4) > (From update of attachment 100564 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100564&action=review > > >>> Tools/ChangeLog:9 > >>> + test on the bots, it looks like we have five pixel failures, related to > >> > >> I'm confused, won't these 5 tests start failing on every run now? > > > > Yes, but we have code to recognize persistent failures and ignore them. > > That sounds scary. There's an upper bound on how many failures to ignore. It's been working for us so far. If it causes problems, we can re-evaluate later. 436023 6 100564 webkit.review.bot 2011-07-12 15:35:41 -0700 Comment on attachment 100564 Patch Clearing flags on attachment: 100564 Committed r90864: <http://trac.webkit.org/changeset/90864> 436024 7 webkit.review.bot 2011-07-12 15:35:46 -0700 All reviewed patches have been landed. Closing bug. 100564 2011-07-12 14:36:18 -0700 2011-07-12 15:35:41 -0700 Patch bug-64394-20110712143617.patch text/plain 3492 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkwODUwKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTEtMDctMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBjci1saW51eC1ld3Mgc2hvdWxkIHJ1biBwaXhlbCB0ZXN0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQzOTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGVuYWJsZWQgcGl4 ZWwgdGVzdCBvbiB0aGUgY3ItbGludXgtZXdzLiAgUnVubmluZyBhIHF1aWNrCisgICAgICAgIHRl c3Qgb24gdGhlIGJvdHMsIGl0IGxvb2tzIGxpa2Ugd2UgaGF2ZSBmaXZlIHBpeGVsIGZhaWx1cmVz LCByZWxhdGVkIHRvCisgICAgICAgIHNvbWUgbWlzc2luZyBmb250cy4gIEkndmUgYWxzbyBtYWRl IHRoZSBib3RzIHNraXAgZmFpbGluZyB0ZXN0cyB0bworICAgICAgICBhdm9pZCB1cGxvYWRpbmcg aHVnZSB6aXAgZmlsZXMgdG8gYnVncy53ZWJraXQub3JnICh3aXRoIGFsbCB0aGUgZXhlY3RlZAor ICAgICAgICBJTUFHRSBmYWlsdXJlcykuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9jb25maWcvcG9ydHMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y29uZmlnL3BvcnRzX3VuaXR0ZXN0LnB5OgorCiAyMDExLTA3LTEyICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIGEgaGFwcHkgYW5pbWF0aW9uIHRvIGdhcmRl bi1vLW1hdGljIHdoZW4gdGhlcmUgYXJlIG5vIGZhaWx1cmVzCkluZGV4OiBUb29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3BvcnRzLnB5CShyZXZpc2lvbiA5MDg0NikKKysr IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5weQkod29ya2luZyBj b3B5KQpAQCAtMjQ1LDcgKzI0NSw3IEBAIGNsYXNzIENocm9taXVtUG9ydChXZWJLaXRQb3J0KToK ICAgICBkZWYgcnVuX3dlYmtpdF90ZXN0c19jb21tYW5kKGNscyk6CiAgICAgICAgIGNvbW1hbmQg PSBjbHMuc2NyaXB0X3NoZWxsX2NvbW1hbmQoIm5ldy1ydW4td2Via2l0LXRlc3RzIikKICAgICAg ICAgY29tbWFuZC5hcHBlbmQoIi0tY2hyb21pdW0iKQotICAgICAgICBjb21tYW5kLmFwcGVuZCgi LS1uby1waXhlbC10ZXN0cyIpCisgICAgICAgIGNvbW1hbmQuYXBwZW5kKCItLXNraXAtZmFpbGlu Zy10ZXN0cyIpCiAgICAgICAgIHJldHVybiBjb21tYW5kCiAKICAgICBAY2xhc3NtZXRob2QKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0c191bml0dGVzdC5w eQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9y dHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDkwODQ2KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vY29uZmlnL3BvcnRzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC02NCwx MyArNjQsMTMgQEAgY2xhc3MgV2ViS2l0UG9ydFRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAg IGRlZiB0ZXN0X2Nocm9taXVtX3BvcnQoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxz KENocm9taXVtUG9ydC5uYW1lKCksICJDaHJvbWl1bSIpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWxzKENocm9taXVtUG9ydC5mbGFnKCksICItLXBvcnQ9Y2hyb21pdW0iKQotICAgICAgICBzZWxm LmFzc2VydEVxdWFscyhDaHJvbWl1bVBvcnQucnVuX3dlYmtpdF90ZXN0c19jb21tYW5kKCksIFtX ZWJLaXRQb3J0LnNjcmlwdF9wYXRoKCJuZXctcnVuLXdlYmtpdC10ZXN0cyIpLCAiLS1jaHJvbWl1 bSIsICItLW5vLXBpeGVsLXRlc3RzIl0pCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKENocm9t aXVtUG9ydC5ydW5fd2Via2l0X3Rlc3RzX2NvbW1hbmQoKSwgW1dlYktpdFBvcnQuc2NyaXB0X3Bh dGgoIm5ldy1ydW4td2Via2l0LXRlc3RzIiksICItLWNocm9taXVtIiwgIi0tc2tpcC1mYWlsaW5n LXRlc3RzIl0pCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKENocm9taXVtUG9ydC5idWlsZF93 ZWJraXRfY29tbWFuZCgpLCBbV2ViS2l0UG9ydC5zY3JpcHRfcGF0aCgiYnVpbGQtd2Via2l0Iiks ICItLWNocm9taXVtIiwgIi0tdXBkYXRlLWNocm9taXVtIl0pCiAgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWxzKENocm9taXVtUG9ydC5idWlsZF93ZWJraXRfY29tbWFuZChidWlsZF9zdHlsZT0iZGVi dWciKSwgW1dlYktpdFBvcnQuc2NyaXB0X3BhdGgoImJ1aWxkLXdlYmtpdCIpLCAiLS1kZWJ1ZyIs ICItLWNocm9taXVtIiwgIi0tdXBkYXRlLWNocm9taXVtIl0pCiAgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWxzKENocm9taXVtUG9ydC51cGRhdGVfd2Via2l0X2NvbW1hbmQoKSwgW1dlYktpdFBvcnQu c2NyaXB0X3BhdGgoInVwZGF0ZS13ZWJraXQiKSwgIi0tY2hyb21pdW0iXSkKIAogICAgIGRlZiB0 ZXN0X2Nocm9taXVtX3h2ZmJfcG9ydChzZWxmKToKLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMo Q2hyb21pdW1YVkZCUG9ydC5ydW5fd2Via2l0X3Rlc3RzX2NvbW1hbmQoKSwgWyd4dmZiLXJ1bics ICdUb29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0LXRlc3RzJywgJy0tY2hyb21pdW0nLCAnLS1u by1waXhlbC10ZXN0cycsICctLXJlc3VsdHMtZGlyZWN0b3J5PS90bXAvbGF5b3V0LXRlc3QtcmVz dWx0cycsICctLXNraXAtZmFpbGluZy10ZXN0cycsICctLXByaW50PWFjdHVhbCxjb25maWcsZXhw ZWN0ZWQsbWlzYyxzbG93ZXN0LHVuZXhwZWN0ZWQsdW5leHBlY3RlZC1yZXN1bHRzJ10pCisgICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWxzKENocm9taXVtWFZGQlBvcnQucnVuX3dlYmtpdF90ZXN0c19j b21tYW5kKCksIFsneHZmYi1ydW4nLCAnVG9vbHMvU2NyaXB0cy9uZXctcnVuLXdlYmtpdC10ZXN0 cycsICctLWNocm9taXVtJywgJy0tc2tpcC1mYWlsaW5nLXRlc3RzJywgJy0tcmVzdWx0cy1kaXJl Y3Rvcnk9L3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzJywgJy0tc2tpcC1mYWlsaW5nLXRlc3RzJywg Jy0tcHJpbnQ9YWN0dWFsLGNvbmZpZyxleHBlY3RlZCxtaXNjLHNsb3dlc3QsdW5leHBlY3RlZCx1 bmV4cGVjdGVkLXJlc3VsdHMnXSkKIAogaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAgICB1 bml0dGVzdC5tYWluKCkK