64392 2011-07-12 14:30:30 -0700 Caret should move immediately before a word when modifying selection by word granularity on Windows 2012-05-02 11:15:50 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 dtseng webkit-unassigned aroben darin enrica justin.garcia mitz mrobinson rniwa xji oldest_to_newest 435952 0 dtseng 2011-07-12 14:30:30 -0700 1. place focus on a textfield or textarea (i.e. google.com, search field). 2. type a sentence (i.e. "this is a test"). 3. press ctrl-right several times and then ctrl-left several times. What is the expected result? each press of ctrl-right places cursor before next word. Example: this |is a test. this is |a test. this is a |test. Currently, webkit places the cursor *after* the current word. this| is a test. this is| a test. this is a| test. This though consistent with Mac cursor movement, isn't in Windows. 435968 1 rniwa 2011-07-12 14:39:33 -0700 http://crbug.com/88711 439483 2 101393 dtseng 2011-07-19 14:57:20 -0700 Created attachment 101393 Proposed patch. 439489 3 101393 rniwa 2011-07-19 15:08:30 -0700 Comment on attachment 101393 Proposed patch. We definitely need a test for this. 439497 4 101393 rniwa 2011-07-19 15:16:17 -0700 Comment on attachment 101393 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=101393&action=review > Source/WebCore/platform/text/TextBoundaries.cpp:74 > - if (position < len && isAlphanumeric(chars[position - 1])) > + if (position < len && isAlphanumeric(chars[position])) This code seems to be used by GTK as well. Are we sure we want this behavior on GTK? 439500 5 101393 darin 2011-07-19 15:18:55 -0700 Comment on attachment 101393 Proposed patch. I don’t think this is the right level to make this policy change. Further, this should probably be a behavior change that is conditional based on text editing behavior. It’s a coincidence right now that this code isn’t used on Mac, for example. 439508 6 rniwa 2011-07-19 15:26:35 -0700 (In reply to comment #5) > (From update of attachment 101393 [details]) > I don’t think this is the right level to make this policy change. > > Further, this should probably be a behavior change that is conditional based on text editing behavior. It’s a coincidence right now that this code isn’t used on Mac, for example. I agree. Changing behavior based on EditingBehavior is much cleaner. 448184 7 101393 rniwa 2011-08-08 12:39:37 -0700 Comment on attachment 101393 Proposed patch. Clearing cq? since this patch has been r-ed. 614026 8 rniwa 2012-05-01 23:39:45 -0700 Xiaomei, is this bug fixed per your visual word movement patch? 614459 9 xji 2012-05-02 11:15:50 -0700 (In reply to comment #8) > Xiaomei, is this bug fixed per your visual word movement patch? Yes. and I am closing it. 101393 2011-07-19 14:57:20 -0700 2011-08-08 12:39:36 -0700 Proposed patch. text.txt text/plain 1557 dtseng SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxMzA0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMTkgIERhdmlkIFRz ZW5nICA8ZHRzZW5nQGdvb2dsZS5jb20+CisKKyAgICAgICAgQ2FyZXQgc2hvdWxkIG1vdmUgaW1t ZWRpYXRlbHkgYmVmb3JlIGEgd29yZCB3aGVuIG1vZGlmeWluZyBzZWxlY3Rpb24gYnkgd29yZCBn cmFudWxhcml0eSBvbiBXaW5kb3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NDM5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCitBd2FpdGluZyByZXZpZXcgZm9yIHRlc3QgYWRkaXRpb25zLgorCisgICAgICAgICogcGxh dGZvcm0vdGV4dC9UZXh0Qm91bmRhcmllcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpmaW5kTmV4 dFdvcmRGcm9tSW5kZXgpOgorCiAyMDExLTA3LTE1ICBMdWtlIFphcmtvICA8bHVrZXphcmtvQGdt YWlsLmNvbT4KIAogICAgICAgIEJyaW5nIFY4J3MgU2VyaWFsaXplZFNjcmlwdFZhbHVlIGltcGxl bWVudGF0aW9uIHVwIHRvIGRhdGUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0 L1RleHRCb3VuZGFyaWVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS90ZXh0L1RleHRCb3VuZGFyaWVzLmNwcAkocmV2aXNpb24gOTEyODYpCisrKyBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS90ZXh0L1RleHRCb3VuZGFyaWVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NjksOSArNjksOSBAQCBpbnQgZmluZE5leHRXb3JkRnJvbUluZGV4KGNvbnN0IFVDaGFyKiBjCiAg ICAgaWYgKGZvcndhcmQpIHsKICAgICAgICAgcG9zaXRpb24gPSB0ZXh0QnJlYWtGb2xsb3dpbmco aXQsIHBvc2l0aW9uKTsKICAgICAgICAgd2hpbGUgKHBvc2l0aW9uICE9IFRleHRCcmVha0RvbmUp IHsKLSAgICAgICAgICAgIC8vIFdlIHN0b3Agc2VhcmNoaW5nIHdoZW4gdGhlIGNoYXJhY3RlciBw cmVjZWVkaW5nIHRoZSBicmVhaworICAgICAgICAgICAgLy8gV2Ugc3RvcCBzZWFyY2hpbmcgd2hl biB0aGUgY2hhcmFjdGVyIGZvbGxvd2luZyB0aGUgYnJlYWsKICAgICAgICAgICAgIC8vIGlzIGFs cGhhbnVtZXJpYy4KLSAgICAgICAgICAgIGlmIChwb3NpdGlvbiA8IGxlbiAmJiBpc0FscGhhbnVt ZXJpYyhjaGFyc1twb3NpdGlvbiAtIDFdKSkKKyAgICAgICAgICAgIGlmIChwb3NpdGlvbiA8IGxl biAmJiBpc0FscGhhbnVtZXJpYyhjaGFyc1twb3NpdGlvbl0pKQogICAgICAgICAgICAgICAgIHJl dHVybiBwb3NpdGlvbjsKIAogICAgICAgICAgICAgcG9zaXRpb24gPSB0ZXh0QnJlYWtGb2xsb3dp bmcoaXQsIHBvc2l0aW9uKTsK