64383 2011-07-12 12:51:12 -0700 [Qt][WK2] Navigation actions in incorrect state when loadStarted() is emitted. 2011-07-12 13:25:35 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling benjamin oldest_to_newest 435874 0 kling 2011-07-12 12:51:12 -0700 The navigation actions currently don't have their isEnabled() value updated until after loadStarted() is emitted. 435878 1 100544 kling 2011-07-12 12:56:04 -0700 Created attachment 100544 Proposed patch 435892 2 100544 kenneth 2011-07-12 13:01:10 -0700 Comment on attachment 100544 Proposed patch Good test 435910 3 100544 kling 2011-07-12 13:25:28 -0700 Comment on attachment 100544 Proposed patch Clearing flags on attachment: 100544 Committed r90844: <http://trac.webkit.org/changeset/90844> 435911 4 kling 2011-07-12 13:25:35 -0700 All reviewed patches have been landed. Closing bug. 100544 2011-07-12 12:56:04 -0700 2011-07-12 13:25:27 -0700 Proposed patch bug-64383.diff text/plain 3797 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmMjQ2ZTM3Li5mOGQxZDQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg QEAKIDIwMTEtMDctMTIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIFtRdF1bV0syXSBOYXZpZ2F0aW9uIGFjdGlvbnMgaW4gaW5jb3JyZWN0IHN0YXRlIHdoZW4g bG9hZFN0YXJ0ZWQoKSBpcyBlbWl0dGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjQzODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBVcGRhdGUgdGhlIG5hdmlnYXRpb24gYWN0aW9ucyBiZWZvcmUgZW1p dHRpbmcgbG9hZFN0YXJ0ZWQoKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVzdHMv cWRlc2t0b3B3ZWJ2aWV3L3RzdF9xZGVza3RvcHdlYnZpZXcuY3BwOgorICAgICAgICAoTG9hZFN0 YXJ0ZWRDYXRjaGVyOjpMb2FkU3RhcnRlZENhdGNoZXIpOgorICAgICAgICAoTG9hZFN0YXJ0ZWRD YXRjaGVyOjpvbkxvYWRTdGFydGVkKToKKyAgICAgICAgKHRzdF9RRGVza3RvcFdlYlZpZXc6OnN0 b3BBY3Rpb25FbmFibGVkQWZ0ZXJMb2FkU3RhcnRlZCk6CisgICAgICAgICogVUlQcm9jZXNzL3F0 L0NsaWVudEltcGwuY3BwOgorICAgICAgICAocXRfd2tfZGlkU3RhcnRQcm92aXNpb25hbExvYWRG b3JGcmFtZSk6CisKKzIwMTEtMDctMTIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3Jn PgorCiAgICAgICAgIFtRdF1bV0syXSBOYXZpZ2F0aW9uIGFjdGlvbnMgc2hvdWxkIHJlYWN0IHRv IHdlYiBwcm9jZXNzIGF2YWlsYWJpbGl0eS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTY0Mzc1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvdGVzdHMvcWRlc2t0b3B3ZWJ2aWV3L3RzdF9xZGVza3RvcHdlYnZpZXcu Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xZGVza3RvcHdlYnZp ZXcvdHN0X3FkZXNrdG9wd2Vidmlldy5jcHAKaW5kZXggNTUzMTBiNC4uNWI4M2NkNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xZGVza3RvcHdlYnZp ZXcvdHN0X3FkZXNrdG9wd2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC90ZXN0cy9xZGVza3RvcHdlYnZpZXcvdHN0X3FkZXNrdG9wd2Vidmlldy5jcHAKQEAg LTIyLDYgKzIyLDcgQEAKICNpbmNsdWRlIDxRdFRlc3QvUXRUZXN0PgogI2luY2x1ZGUgPHFkZXNr dG9wd2Vidmlldy5oPgogI2luY2x1ZGUgIi4uL3Rlc3R3aW5kb3cuaCIKKyNpbmNsdWRlICIuLi91 dGlsLmgiCiAKIGNsYXNzIHRzdF9RRGVza3RvcFdlYlZpZXcgOiBwdWJsaWMgUU9iamVjdCB7CiAg ICAgUV9PQkpFQ1QKQEAgLTMxLDYgKzMyLDcgQEAgcHJpdmF0ZSBzbG90czoKICAgICB2b2lkIGNs ZWFudXAoKTsKIAogICAgIHZvaWQgbmF2aWdhdGlvbkFjdGlvbnNTdGF0dXNBdFN0YXJ0dXAoKTsK KyAgICB2b2lkIHN0b3BBY3Rpb25FbmFibGVkQWZ0ZXJMb2FkU3RhcnRlZCgpOwogCiBwcml2YXRl OgogICAgIGlubGluZSBRRGVza3RvcFdlYlZpZXcqIHdlYlZpZXcoKSBjb25zdDsKQEAgLTcxLDYg KzczLDQ3IEBAIHZvaWQgdHN0X1FEZXNrdG9wV2ViVmlldzo6bmF2aWdhdGlvbkFjdGlvbnNTdGF0 dXNBdFN0YXJ0dXAoKQogICAgIFFDT01QQVJFKHJlbG9hZEFjdGlvbi0+aXNFbmFibGVkKCksIGZh bHNlKTsKIH0KIAorY2xhc3MgTG9hZFN0YXJ0ZWRDYXRjaGVyIDogcHVibGljIFFPYmplY3Qgewor ICAgIFFfT0JKRUNUCitwdWJsaWM6CisgICAgTG9hZFN0YXJ0ZWRDYXRjaGVyKFFEZXNrdG9wV2Vi Vmlldyogd2ViVmlldykKKyAgICAgICAgOiBtX3dlYlZpZXcod2ViVmlldykKKyAgICB7CisgICAg ICAgIGNvbm5lY3QobV93ZWJWaWV3LCBTSUdOQUwobG9hZFN0YXJ0ZWQoKSksIHRoaXMsIFNMT1Qo b25Mb2FkU3RhcnRlZCgpKSk7CisgICAgfQorCitwdWJsaWMgc2xvdHM6CisgICAgdm9pZCBvbkxv YWRTdGFydGVkKCkKKyAgICB7CisgICAgICAgIFFNZXRhT2JqZWN0OjppbnZva2VNZXRob2QodGhp cywgImZpbmlzaGVkIiwgUXQ6OlF1ZXVlZENvbm5lY3Rpb24pOworCisgICAgICAgIFFBY3Rpb24q IHN0b3BBY3Rpb24gPSBtX3dlYlZpZXctPm5hdmlnYXRpb25BY3Rpb24oUXRXZWJLaXQ6OlN0b3Ap OworICAgICAgICBRVkVSSUZZKHN0b3BBY3Rpb24pOworICAgICAgICBRQ09NUEFSRShzdG9wQWN0 aW9uLT5pc0VuYWJsZWQoKSwgdHJ1ZSk7CisgICAgfQorCitzaWduYWxzOgorICAgIHZvaWQgZmlu aXNoZWQoKTsKKworcHJpdmF0ZToKKyAgICBRRGVza3RvcFdlYlZpZXcqIG1fd2ViVmlldzsKK307 CisKK3ZvaWQgdHN0X1FEZXNrdG9wV2ViVmlldzo6c3RvcEFjdGlvbkVuYWJsZWRBZnRlckxvYWRT dGFydGVkKCkKK3sKKyAgICBRQWN0aW9uKiBzdG9wQWN0aW9uID0gd2ViVmlldygpLT5uYXZpZ2F0 aW9uQWN0aW9uKFF0V2ViS2l0OjpTdG9wKTsKKyAgICBRVkVSSUZZKHN0b3BBY3Rpb24pOworICAg IFFDT01QQVJFKHN0b3BBY3Rpb24tPmlzRW5hYmxlZCgpLCBmYWxzZSk7CisKKyAgICBMb2FkU3Rh cnRlZENhdGNoZXIgY2F0Y2hlcih3ZWJWaWV3KCkpOworICAgIHdlYlZpZXcoKS0+bG9hZChRVXJs Ojpmcm9tTG9jYWxGaWxlKFFMYXRpbjFTdHJpbmcoVEVTVFNfU09VUkNFX0RJUiAiL2h0bWwvYmFz aWNfcGFnZS5odG1sIikpKTsKKyAgICB3YWl0Rm9yU2lnbmFsKCZjYXRjaGVyLCBTSUdOQUwoZmlu aXNoZWQoKSkpOworCisgICAgUUNPTVBBUkUoc3RvcEFjdGlvbi0+aXNFbmFibGVkKCksIHRydWUp OworCisgICAgd2FpdEZvclNpZ25hbCh3ZWJWaWV3KCksIFNJR05BTChsb2FkU3VjY2VlZGVkKCkp KTsKK30KKwogUVRFU1RfTUFJTih0c3RfUURlc2t0b3BXZWJWaWV3KQogCiAjaW5jbHVkZSAidHN0 X3FkZXNrdG9wd2Vidmlldy5tb2MiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvcXQvQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvQ2xpZW50 SW1wbC5jcHAKaW5kZXggZTQ0ODdhZi4uMzZhNGE0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL3F0L0NsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9xdC9DbGllbnRJbXBsLmNwcApAQCAtNjksOCArNjksOSBAQCB2b2lkIHF0X3drX2RpZFN0 YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUoV0tQYWdlUmVmIHBhZ2UsIFdLRnJhbWVSZWYgZnJh bWUsIFdLVAogewogICAgIGlmICghV0tGcmFtZUlzTWFpbkZyYW1lKGZyYW1lKSkKICAgICAgICAg cmV0dXJuOwotICAgIHRvUXRXZWJQYWdlUHJveHkoY2xpZW50SW5mbyktPmxvYWREaWRCZWdpbigp OworCiAgICAgdG9RdFdlYlBhZ2VQcm94eShjbGllbnRJbmZvKS0+dXBkYXRlTmF2aWdhdGlvbkFj dGlvbnMoKTsKKyAgICB0b1F0V2ViUGFnZVByb3h5KGNsaWVudEluZm8pLT5sb2FkRGlkQmVnaW4o KTsKIH0KIAogdm9pZCBxdF93a19kaWRSZWNlaXZlU2VydmVyUmVkaXJlY3RGb3JQcm92aXNpb25h bExvYWRGb3JGcmFtZShXS1BhZ2VSZWYgcGFnZSwgV0tGcmFtZVJlZiBmcmFtZSwgV0tUeXBlUmVm IHVzZXJEYXRhLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQo=