64375 2011-07-12 11:30:00 -0700 [Qt][WK2] Navigation actions should react to web process availability. 2011-07-12 11:56:12 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling benjamin oldest_to_newest 435807 0 kling 2011-07-12 11:30:00 -0700 When the web process is crashed, stop should be disabled and reload only enabled if there's something to reload. 435808 1 100529 kling 2011-07-12 11:30:36 -0700 Created attachment 100529 Proposed patch 435831 2 100529 benjamin 2011-07-12 11:48:32 -0700 Comment on attachment 100529 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=100529&action=review > Source/WebKit2/UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:33 > + void navigationActionEnabledStatusAtStartup(); navigationActionsStatusAtStartup? 435838 3 kling 2011-07-12 11:56:12 -0700 Committed r90837: <http://trac.webkit.org/changeset/90837> 100529 2011-07-12 11:30:36 -0700 2011-07-12 11:48:32 -0700 Proposed patch bug-64375.diff text/plain 6694 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwZDZjMGMzLi41NGQwZTBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUg QEAKIDIwMTEtMDctMTIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIFtRdF1bV0syXSBOYXZpZ2F0aW9uIGFjdGlvbnMgc2hvdWxkIHJlYWN0IHRvIHdlYiBwcm9j ZXNzIGF2YWlsYWJpbGl0eS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY0Mzc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiB0aGUgd2ViIHByb2Nlc3MgaXMgdW5hdmFpbGFibGUsIHRoZSByZWxvYWQg YW5kIHN0b3AgYWN0aW9ucyBzaG91bGQKKyAgICAgICAgYmVoYXZlIHNsaWdodGx5IGRpZmZlcmVu dGx5LiBTdG9wIHNob3VsZCBhbHdheXMgYmUgZGlzYWJsZWQsIGFuZCByZWxvYWQKKyAgICAgICAg c2hvdWxkIGJlIGVuYWJsZWQgaWYgdGhlcmUncyBhIHJlbG9hZGFibGUgaXRlbSBpbiB0aGUgYmFj ay9mb3J3YXJkIGxpc3QuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FkZXNr dG9wd2Vidmlldy90c3RfcWRlc2t0b3B3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHRzdF9RRGVza3Rv cFdlYlZpZXc6Om5hdmlnYXRpb25BY3Rpb25FbmFibGVkU3RhdHVzQXRTdGFydHVwKToKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3F0b3VjaHdlYnZpZXcvdHN0X3F0b3VjaHdlYnZp ZXcuY3BwOgorICAgICAgICAodHN0X1FUb3VjaFdlYlZpZXc6Om5hdmlnYXRpb25BY3Rpb25FbmFi bGVkU3RhdHVzQXRTdGFydHVwKToKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJv eHkuY3BwOgorICAgICAgICAoUXRXZWJQYWdlUHJveHk6OnVwZGF0ZUFjdGlvbik6CisgICAgICAg IChRdFdlYlBhZ2VQcm94eTo6ZGlkUmVsYXVuY2hQcm9jZXNzKToKKyAgICAgICAgKFF0V2ViUGFn ZVByb3h5Ojpwcm9jZXNzRGlkQ3Jhc2gpOgorCisyMDExLTA3LTEyICBBbmRyZWFzIEtsaW5nICA8 a2xpbmdAd2Via2l0Lm9yZz4KKwogICAgICAgICBbUXRdW1dLMl0gQWRkIGluZm9ybWF0aXZlIGxv YWRGYWlsZWQoKSBzaWduYWwgdG8gd2ViIHZpZXdzLgogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQzNjIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xZGVza3RvcHdlYnZpZXcvdHN0X3FkZXNrdG9wd2Vi dmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FkZXNrdG9w d2Vidmlldy90c3RfcWRlc2t0b3B3ZWJ2aWV3LmNwcAppbmRleCAxZjdkMGY1Li5iNDg5Y2QxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FkZXNrdG9w d2Vidmlldy90c3RfcWRlc2t0b3B3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3Rlc3RzL3FkZXNrdG9wd2Vidmlldy90c3RfcWRlc2t0b3B3ZWJ2aWV3LmNw cApAQCAtMTcsNiArMTcsNyBAQAogICAgIEJvc3RvbiwgTUEgMDIxMTAtMTMwMSwgVVNBLgogKi8K IAorI2luY2x1ZGUgPFFBY3Rpb24+CiAjaW5jbHVkZSA8UVNjb3BlZFBvaW50ZXI+CiAjaW5jbHVk ZSA8UXRUZXN0L1F0VGVzdD4KICNpbmNsdWRlIDxxZGVza3RvcHdlYnZpZXcuaD4KQEAgLTI5LDYg KzMwLDggQEAgcHJpdmF0ZSBzbG90czoKICAgICB2b2lkIGluaXQoKTsKICAgICB2b2lkIGNsZWFu dXAoKTsKIAorICAgIHZvaWQgbmF2aWdhdGlvbkFjdGlvbkVuYWJsZWRTdGF0dXNBdFN0YXJ0dXAo KTsKKwogcHJpdmF0ZToKICAgICBpbmxpbmUgUURlc2t0b3BXZWJWaWV3KiB3ZWJWaWV3KCkgY29u c3Q7CiAgICAgUVNjb3BlZFBvaW50ZXI8VGVzdFdpbmRvdz4gbV93aW5kb3c7CkBAIC00OSw2ICs1 MiwyNSBAQCBpbmxpbmUgUURlc2t0b3BXZWJWaWV3KiB0c3RfUURlc2t0b3BXZWJWaWV3Ojp3ZWJW aWV3KCkgY29uc3QKICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8UURlc2t0b3BXZWJWaWV3Kj4obV93 aW5kb3ctPndlYlZpZXcuZGF0YSgpKTsKIH0KIAordm9pZCB0c3RfUURlc2t0b3BXZWJWaWV3Ojpu YXZpZ2F0aW9uQWN0aW9uRW5hYmxlZFN0YXR1c0F0U3RhcnR1cCgpCit7CisgICAgUUFjdGlvbiog YmFja0FjdGlvbiA9IHdlYlZpZXcoKS0+bmF2aWdhdGlvbkFjdGlvbihRdFdlYktpdDo6QmFjayk7 CisgICAgUVZFUklGWShiYWNrQWN0aW9uKTsKKyAgICBRQ09NUEFSRShiYWNrQWN0aW9uLT5pc0Vu YWJsZWQoKSwgZmFsc2UpOworCisgICAgUUFjdGlvbiogZm9yd2FyZEFjdGlvbiA9IHdlYlZpZXco KS0+bmF2aWdhdGlvbkFjdGlvbihRdFdlYktpdDo6Rm9yd2FyZCk7CisgICAgUVZFUklGWShmb3J3 YXJkQWN0aW9uKTsKKyAgICBRQ09NUEFSRShmb3J3YXJkQWN0aW9uLT5pc0VuYWJsZWQoKSwgZmFs c2UpOworCisgICAgUUFjdGlvbiogc3RvcEFjdGlvbiA9IHdlYlZpZXcoKS0+bmF2aWdhdGlvbkFj dGlvbihRdFdlYktpdDo6U3RvcCk7CisgICAgUVZFUklGWShzdG9wQWN0aW9uKTsKKyAgICBRQ09N UEFSRShzdG9wQWN0aW9uLT5pc0VuYWJsZWQoKSwgZmFsc2UpOworCisgICAgUUFjdGlvbiogcmVs b2FkQWN0aW9uID0gd2ViVmlldygpLT5uYXZpZ2F0aW9uQWN0aW9uKFF0V2ViS2l0OjpSZWxvYWQp OworICAgIFFWRVJJRlkocmVsb2FkQWN0aW9uKTsKKyAgICBRQ09NUEFSRShyZWxvYWRBY3Rpb24t PmlzRW5hYmxlZCgpLCBmYWxzZSk7Cit9CisKIFFURVNUX01BSU4odHN0X1FEZXNrdG9wV2ViVmll dykKIAogI2luY2x1ZGUgInRzdF9xZGVza3RvcHdlYnZpZXcubW9jIgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xdG91Y2h3ZWJ2aWV3L3RzdF9xdG91 Y2h3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXRv dWNod2Vidmlldy90c3RfcXRvdWNod2Vidmlldy5jcHAKaW5kZXggNDUzMmVjYy4uMDc0OTUyZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xdG91Y2h3 ZWJ2aWV3L3RzdF9xdG91Y2h3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3Rlc3RzL3F0b3VjaHdlYnZpZXcvdHN0X3F0b3VjaHdlYnZpZXcuY3BwCkBAIC0x Nyw2ICsxNyw3IEBACiAgICAgQm9zdG9uLCBNQSAwMjExMC0xMzAxLCBVU0EuCiAqLwogCisjaW5j bHVkZSA8UUFjdGlvbj4KICNpbmNsdWRlIDxRdFRlc3QvUXRUZXN0PgogI2luY2x1ZGUgPHF0b3Vj aHdlYnBhZ2UuaD4KICNpbmNsdWRlIDxxdG91Y2h3ZWJ2aWV3Lmg+CkBAIC0zMyw2ICszNCw3IEBA IHByaXZhdGUgc2xvdHM6CiAgICAgdm9pZCBjbGVhbnVwKCk7CiAKICAgICB2b2lkIGFjY2Vzc1Bh Z2UoKTsKKyAgICB2b2lkIG5hdmlnYXRpb25BY3Rpb25FbmFibGVkU3RhdHVzQXRTdGFydHVwKCk7 CiAKIHByaXZhdGU6CiAgICAgaW5saW5lIFFUb3VjaFdlYlZpZXcqIHdlYlZpZXcoKSBjb25zdDsK QEAgLTY4LDYgKzcwLDI2IEBAIHZvaWQgdHN0X1FUb3VjaFdlYlZpZXc6OmFjY2Vzc1BhZ2UoKQog ICAgIFFDT01QQVJFKHBhZ2VQcm9wZXJ0eUFjY2VzcywgcGFnZURpcmVjdEFjY2Vzcyk7CiB9CiAK K3ZvaWQgdHN0X1FUb3VjaFdlYlZpZXc6Om5hdmlnYXRpb25BY3Rpb25FbmFibGVkU3RhdHVzQXRT dGFydHVwKCkKK3sKKyAgICBRQWN0aW9uKiBiYWNrQWN0aW9uID0gd2ViVmlldygpLT5wYWdlKCkt Pm5hdmlnYXRpb25BY3Rpb24oUXRXZWJLaXQ6OkJhY2spOworICAgIFFWRVJJRlkoYmFja0FjdGlv bik7CisgICAgUUNPTVBBUkUoYmFja0FjdGlvbi0+aXNFbmFibGVkKCksIGZhbHNlKTsKKworICAg IFFBY3Rpb24qIGZvcndhcmRBY3Rpb24gPSB3ZWJWaWV3KCktPnBhZ2UoKS0+bmF2aWdhdGlvbkFj dGlvbihRdFdlYktpdDo6Rm9yd2FyZCk7CisgICAgUVZFUklGWShmb3J3YXJkQWN0aW9uKTsKKyAg ICBRQ09NUEFSRShmb3J3YXJkQWN0aW9uLT5pc0VuYWJsZWQoKSwgZmFsc2UpOworCisgICAgUUFj dGlvbiogc3RvcEFjdGlvbiA9IHdlYlZpZXcoKS0+cGFnZSgpLT5uYXZpZ2F0aW9uQWN0aW9uKFF0 V2ViS2l0OjpTdG9wKTsKKyAgICBRVkVSSUZZKHN0b3BBY3Rpb24pOworICAgIFFDT01QQVJFKHN0 b3BBY3Rpb24tPmlzRW5hYmxlZCgpLCBmYWxzZSk7CisKKyAgICBRQWN0aW9uKiByZWxvYWRBY3Rp b24gPSB3ZWJWaWV3KCktPnBhZ2UoKS0+bmF2aWdhdGlvbkFjdGlvbihRdFdlYktpdDo6UmVsb2Fk KTsKKyAgICBRVkVSSUZZKHJlbG9hZEFjdGlvbik7CisgICAgUUNPTVBBUkUocmVsb2FkQWN0aW9u LT5pc0VuYWJsZWQoKSwgZmFsc2UpOworfQorCisKIFFURVNUX01BSU4odHN0X1FUb3VjaFdlYlZp ZXcpCiAKICNpbmNsdWRlICJ0c3RfcXRvdWNod2Vidmlldy5tb2MiCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmNwcAppbmRleCA3ZjI2N2EwLi41YzkxMWU5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHku Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5jcHAK QEAgLTMzLDYgKzMzLDcgQEAKICNpbmNsdWRlICJMb2NhbGl6ZWRTdHJpbmdzLmgiCiAjaW5jbHVk ZSAiTmF0aXZlV2ViS2V5Ym9hcmRFdmVudC5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgi CisjaW5jbHVkZSAiV2ViQmFja0ZvcndhcmRMaXN0LmgiCiAjaW5jbHVkZSAiV2ViQ29udGV4dC5o IgogI2luY2x1ZGUgIldlYkNvbnRleHRNZW51UHJveHlRdC5oIgogI2luY2x1ZGUgIldlYkVkaXRD b21tYW5kUHJveHkuaCIKQEAgLTQ4MSwxMSArNDgyLDggQEAgdm9pZCBRdFdlYlBhZ2VQcm94eTo6 dXBkYXRlQWN0aW9uKFF0V2ViUGFnZVByb3h5OjpXZWJBY3Rpb24gYWN0aW9uKQogICAgICAgICBy ZXR1cm47CiAKICAgICBSZWZQdHI8V2ViS2l0OjpXZWJGcmFtZVByb3h5PiBtYWluRnJhbWUgPSBt X3dlYlBhZ2VQcm94eS0+bWFpbkZyYW1lKCk7Ci0gICAgaWYgKCFtYWluRnJhbWUpCi0gICAgICAg IHJldHVybjsKIAogICAgIGJvb2wgZW5hYmxlZCA9IGEtPmlzRW5hYmxlZCgpOwotICAgIGJvb2wg Y2hlY2tlZCA9IGEtPmlzQ2hlY2tlZCgpOwogCiAgICAgc3dpdGNoIChhY3Rpb24pIHsKICAgICBj YXNlIFF0V2ViUGFnZVByb3h5OjpCYWNrOgpAQCAtNDk1LDE5ICs0OTMsMTkgQEAgdm9pZCBRdFdl YlBhZ2VQcm94eTo6dXBkYXRlQWN0aW9uKFF0V2ViUGFnZVByb3h5OjpXZWJBY3Rpb24gYWN0aW9u KQogICAgICAgICBlbmFibGVkID0gbV93ZWJQYWdlUHJveHktPmNhbkdvRm9yd2FyZCgpOwogICAg ICAgICBicmVhazsKICAgICBjYXNlIFF0V2ViUGFnZVByb3h5OjpTdG9wOgotICAgICAgICBlbmFi bGVkID0gIShXZWJGcmFtZVByb3h5OjpMb2FkU3RhdGVGaW5pc2hlZCA9PSBtYWluRnJhbWUtPmxv YWRTdGF0ZSgpKTsKKyAgICAgICAgZW5hYmxlZCA9IG1haW5GcmFtZSAmJiAhKFdlYkZyYW1lUHJv eHk6OkxvYWRTdGF0ZUZpbmlzaGVkID09IG1haW5GcmFtZS0+bG9hZFN0YXRlKCkpOwogICAgICAg ICBicmVhazsKICAgICBjYXNlIFF0V2ViUGFnZVByb3h5OjpSZWxvYWQ6Ci0gICAgICAgIGVuYWJs ZWQgPSAoV2ViRnJhbWVQcm94eTo6TG9hZFN0YXRlRmluaXNoZWQgPT0gbWFpbkZyYW1lLT5sb2Fk U3RhdGUoKSk7CisgICAgICAgIGlmIChtYWluRnJhbWUpCisgICAgICAgICAgICBlbmFibGVkID0g KFdlYkZyYW1lUHJveHk6OkxvYWRTdGF0ZUZpbmlzaGVkID09IG1haW5GcmFtZS0+bG9hZFN0YXRl KCkpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBlbmFibGVkID0gbV93ZWJQYWdlUHJveHkt PmJhY2tGb3J3YXJkTGlzdCgpLT5jdXJyZW50SXRlbSgpOwogICAgICAgICBicmVhazsKICAgICBk ZWZhdWx0OgotICAgICAgICBicmVhazsKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAg ICAgfQogCiAgICAgYS0+c2V0RW5hYmxlZChlbmFibGVkKTsKLQotICAgIGlmIChhLT5pc0NoZWNr YWJsZSgpKQotICAgICAgICBhLT5zZXRDaGVja2VkKGNoZWNrZWQpOwogfQogCiB2b2lkIFF0V2Vi UGFnZVByb3h5Ojp1cGRhdGVOYXZpZ2F0aW9uQWN0aW9ucygpCkBAIC01MjksMTIgKzUyNywxNCBA QCB2b2lkIFF0V2ViUGFnZVByb3h5Ojp3ZWJBY3Rpb25UcmlnZ2VyZWQoYm9vbCBjaGVja2VkKQog CiB2b2lkIFF0V2ViUGFnZVByb3h5OjpkaWRSZWxhdW5jaFByb2Nlc3MoKQogeworICAgIHVwZGF0 ZU5hdmlnYXRpb25BY3Rpb25zKCk7CiAgICAgbV92aWV3SW50ZXJmYWNlLT5kaWRSZWxhdW5jaFBy b2Nlc3MoKTsKICAgICBzZXREcmF3aW5nQXJlYVNpemUobV92aWV3SW50ZXJmYWNlLT5kcmF3aW5n QXJlYVNpemUoKSk7CiB9CiAKIHZvaWQgUXRXZWJQYWdlUHJveHk6OnByb2Nlc3NEaWRDcmFzaCgp CiB7CisgICAgdXBkYXRlTmF2aWdhdGlvbkFjdGlvbnMoKTsKICAgICBtX3ZpZXdJbnRlcmZhY2Ut PnByb2Nlc3NEaWRDcmFzaCgpOwogfQogCg==