64371 2011-07-12 11:03:24 -0700 [Qt][WK2] QDesktopWebView crashes if resized without web process. 2011-07-12 11:13:56 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling benjamin oldest_to_newest 435778 0 kling 2011-07-12 11:03:24 -0700 There are some incorrect assumptions about drawingArea() never being null in QtWebPageProxy. It may be null when the web process has crashed, so we need to handle this gracefully. 435780 1 100523 kling 2011-07-12 11:04:05 -0700 Created attachment 100523 Proposed patch 435783 2 100523 benjamin 2011-07-12 11:07:11 -0700 Comment on attachment 100523 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=100523&action=review > Source/WebKit2/ChangeLog:11 > + (Q drawing area is null.tWebPageProxy::setDrawingAreaSize): Fail silently if there is no "Q drawing area is null.tWebPageProxy" ???? 435784 3 kling 2011-07-12 11:08:10 -0700 (In reply to comment #2) > (From update of attachment 100523 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100523&action=review > > > Source/WebKit2/ChangeLog:11 > > + (Q drawing area is null.tWebPageProxy::setDrawingAreaSize): Fail silently if there is no > > "Q drawing area is null.tWebPageProxy" ???? vim is hard :( 435790 4 kling 2011-07-12 11:13:56 -0700 Committed r90829: <http://trac.webkit.org/changeset/90829> 100523 2011-07-12 11:04:05 -0700 2011-07-12 11:07:11 -0700 Proposed patch bug-64371.diff text/plain 1655 kling SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwODI2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMTIgIEFuZHJlYXMg S2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF1bV0syXSBRRGVza3RvcFdl YlZpZXcgY3Jhc2hlcyBpZiByZXNpemVkIHdpdGhvdXQgd2ViIHByb2Nlc3MuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDM3MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0V2Vi UGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFF0V2ViUGFnZVByb3h5OjpwYWludCk6IFJlbW92ZSBh biBpbnZhbGlkIGFzc2VydGlvbi4gVGhlIGRyYXdpbmcgYXJlYQorICAgICAgICBtYXkgYmUgbnVs bCBpZiB0aGUgd2ViIHByb2Nlc3MgaGFzIGNyYXNoZWQuCisgICAgICAgIChRIGRyYXdpbmcgYXJl YSBpcyBudWxsLnRXZWJQYWdlUHJveHk6OnNldERyYXdpbmdBcmVhU2l6ZSk6IEZhaWwgc2lsZW50 bHkgaWYgdGhlcmUgaXMgbm8KKyAgICAgICAgZHJhd2luZyBhcmVhLgorCiAyMDExLTA3LTEyICBB bmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdW1dLMl0gQWRk IGluZm9ybWF0aXZlIGxvYWRGYWlsZWQoKSBzaWduYWwgdG8gd2ViIHZpZXdzLgpJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuY3BwCShyZXZpc2lv biA5MDgyNikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2Nyw3ICs0NjcsNiBAQCB2b2lkIFF0V2ViUGFnZVByb3h5 OjpkaWRDaGFuZ2VMb2FkUHJvZ3JlCiAKIHZvaWQgUXRXZWJQYWdlUHJveHk6OnBhaW50KFFQYWlu dGVyKiBwYWludGVyLCBRUmVjdCBhcmVhKQogewotICAgIEFTU0VSVChtX3dlYlBhZ2VQcm94eS0+ ZHJhd2luZ0FyZWEoKSk7CiAgICAgaWYgKG1fd2ViUGFnZVByb3h5LT5pc1ZhbGlkKCkpCiAgICAg ICAgIHBhaW50Q29udGVudChwYWludGVyLCBhcmVhKTsKICAgICBlbHNlCkBAIC01ODUsNyArNTg0 LDggQEAgUVN0cmluZyBRdFdlYlBhZ2VQcm94eTo6dGl0bGUoKSBjb25zdAogCiB2b2lkIFF0V2Vi UGFnZVByb3h5OjpzZXREcmF3aW5nQXJlYVNpemUoY29uc3QgUVNpemUmIHNpemUpCiB7Ci0gICAg QVNTRVJUKG1fd2ViUGFnZVByb3h5LT5kcmF3aW5nQXJlYSgpKTsKKyAgICBpZiAoIW1fd2ViUGFn ZVByb3h5LT5kcmF3aW5nQXJlYSgpKQorICAgICAgICByZXR1cm47CiAgICAgbV93ZWJQYWdlUHJv eHktPmRyYXdpbmdBcmVhKCktPnNldFNpemUoSW50U2l6ZShzaXplKSwgSW50U2l6ZSgpKTsKIH0K IAo=