64367 2011-07-12 10:36:47 -0700 cr-linux-ews complains about tests that aren't actually failing 2011-07-12 19:32:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60381 1 abarth abarth eric ojan oldest_to_newest 435732 0 abarth 2011-07-12 10:36:47 -0700 cr-linux-ews complains about tests that aren't actually failing 435733 1 100509 abarth 2011-07-12 10:44:35 -0700 Created attachment 100509 Patch 435736 2 abarth 2011-07-12 10:45:44 -0700 I'm going to land this to-be-reviewed to stop the bots from spamming. Please feel free to review after the fact and I will happily make any changes. 435742 3 abarth 2011-07-12 10:49:33 -0700 Committed r90823: <http://trac.webkit.org/changeset/90823> 435792 4 100509 ojan 2011-07-12 11:14:11 -0700 Comment on attachment 100509 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100509&action=review > Tools/Scripts/webkitpy/common/net/resultsjsonparser.py:76 > + # FIXME: We should only remove_pixel_failures this JSONResult can from a run without pixel tests! I can't even begin to parse this. 100509 2011-07-12 10:44:35 -0700 2011-07-12 19:32:07 -0700 Patch bug-64367-20110712104434.patch text/plain 3886 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkwODIxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMjQgQEAKKzIwMTEtMDctMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBjci1saW51eC1ld3MgY29tcGxhaW5zIGFib3V0IHRlc3RzIHRoYXQgYXJlbid0IGFj dHVhbGx5IGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY0MzY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhlIHVuZGVybHlpbmcgcHJvYmxlbSBoZXJlIGlzIHRoYXQgZnVsbF9yZXN1bHRzLmpz b24gZG9lc24ndCBoYXZlCisgICAgICAgIGVub3VnaCBpbmZvcm1hdGlvbiB0byBkZXRlcm1pbmUg d2hldGhlciBhIGdpdmVuIHRlc3QgcmVzdWx0IHdhcworICAgICAgICBleHBlY3RlZCBiZWNhdXNl IHdoZXRoZXIgYW4gYWN0dWFsIHJlc3VsdCBpcyBleHBlY3RlZCBkZXBlbmRzIG9uCisgICAgICAg IHdoZXRoZXIgZnVsbF9yZXN1bHRzLmpzb24gd2FzIGdlbmVyYXRlZCBkdWluZyBhIHRlc3QgcnVu IHRoYXQgaW5jbHVkZWQKKyAgICAgICAgcGl4ZWwgdGVzdHMuCisKKyAgICAgICAgVGhlIHJpZ2h0 IGxvbmctdGVybSBzb2x1dGlvbiBpcyB0byBtYWtlIGZ1bGxfcmVzdWx0cy5qc29uIGEgY29tcGxl dGUKKyAgICAgICAgZGVzY3JpcHRpb24gb2Ygd2hhdCBoYXBwZW5lZCBkdXJuaW5nIGEgdGVzdCBy dW4uICBJbiB0aGlzIHBhdGNoCisgICAgICAgIGhvd2V2ZXIsIHRvIHN0b3AgdGhlIHNwYW0sIHRo aXMgcGF0Y2ggbWFrZXMgdGhlIGpzb25yZXN1bHRzcGFyc2VyCisgICAgICAgIGlnbm9yZSBwaXhl bCBmYWlsdXJlcy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9yZXN1 bHRzanNvbnBhcnNlci5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQv cmVzdWx0c2pzb25wYXJzZXJfdW5pdHRlc3QucHk6CisKIDIwMTEtMDctMTEgIEFkYW0gUm9iZW4g IDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEV4dHJhY3QgVGVzdEZhaWx1cmVzJ3MgYnVn LWZpbGluZyBjb2RlIGludG8gdHdvIG5ldyBjbGFzc2VzCkluZGV4OiBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9uZXQvcmVzdWx0c2pzb25wYXJzZXIucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L3Jlc3VsdHNqc29ucGFyc2VyLnB5CShyZXZp c2lvbiA5MDgyMSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9yZXN1bHRz anNvbnBhcnNlci5weQkod29ya2luZyBjb3B5KQpAQCAtNzMsNiArNzMsOSBAQCBjbGFzcyBKU09O VGVzdFJlc3VsdChvYmplY3QpOgogICAgIGRlZiBkaWRfcnVuX2FzX2V4cGVjdGVkKHNlbGYpOgog ICAgICAgICBhY3R1YWxfcmVzdWx0cyA9IHNlbGYuX2FjdHVhbF9hc190b2tlbnMoKQogICAgICAg ICBleHBlY3RlZF9yZXN1bHRzID0gc2VsZi5fZXhwZWN0ZWRfYXNfdG9rZW5zKCkKKyAgICAgICAg IyBGSVhNRTogV2Ugc2hvdWxkIG9ubHkgcmVtb3ZlX3BpeGVsX2ZhaWx1cmVzIHRoaXMgSlNPTlJl c3VsdCBjYW4gZnJvbSBhIHJ1biB3aXRob3V0IHBpeGVsIHRlc3RzIQorICAgICAgICBpZiBub3Qg dGVzdF9leHBlY3RhdGlvbnMuaGFzX3BpeGVsX2ZhaWx1cmVzKGFjdHVhbF9yZXN1bHRzKToKKyAg ICAgICAgICAgIGV4cGVjdGVkX3Jlc3VsdHMgPSB0ZXN0X2V4cGVjdGF0aW9ucy5yZW1vdmVfcGl4 ZWxfZmFpbHVyZXMoZXhwZWN0ZWRfcmVzdWx0cykKICAgICAgICAgZm9yIGFjdHVhbF9yZXN1bHQg aW4gYWN0dWFsX3Jlc3VsdHM6CiAgICAgICAgICAgICBpZiBub3QgdGVzdF9leHBlY3RhdGlvbnMu cmVzdWx0X3dhc19leHBlY3RlZChhY3R1YWxfcmVzdWx0LCBleHBlY3RlZF9yZXN1bHRzLCBGYWxz ZSwgRmFsc2UpOgogICAgICAgICAgICAgICAgIHJldHVybiBGYWxzZQpAQCAtODIsNyArODUsNyBA QCBjbGFzcyBKU09OVGVzdFJlc3VsdChvYmplY3QpOgogICAgICAgICB0b2tlbnMgPSBtYXAodGVz dF9leHBlY3RhdGlvbnMuVGVzdEV4cGVjdGF0aW9ucy5leHBlY3RhdGlvbl9mcm9tX3N0cmluZywg cmVzdWx0c19zdHJpbmcuc3BsaXQoJyAnKSkKICAgICAgICAgaWYgTm9uZSBpbiB0b2tlbnM6CiAg ICAgICAgICAgICBsb2coIlVucmVjb2duaXplZCByZXN1bHQgaW4gJXMiICUgcmVzdWx0c19zdHJp bmcpCi0gICAgICAgIHJldHVybiB0b2tlbnMKKyAgICAgICAgcmV0dXJuIHNldCh0b2tlbnMpCiAK ICAgICBAbWVtb2l6ZWQKICAgICBkZWYgX2FjdHVhbF9hc190b2tlbnMoc2VsZik6CkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvcmVzdWx0c2pzb25wYXJzZXJfdW5pdHRl c3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L3Jl c3VsdHNqc29ucGFyc2VyX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA5MDgyMSkKKysrIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9yZXN1bHRzanNvbnBhcnNlcl91bml0dGVzdC5weQko d29ya2luZyBjb3B5KQpAQCAtNTgsNiArNTgsMTAgQEAgY2xhc3MgUmVzdWx0c0pTT05QYXJzZXJU ZXN0KHVuaXR0ZXN0LlRlcwogICAgICAgICAgICAgICAgICJwcm90b3R5cGUtc3RyYXdiZXJyeS5o dG1sIjogewogICAgICAgICAgICAgICAgICAgICAiZXhwZWN0ZWQiOiAiUEFTUyIsCiAgICAgICAg ICAgICAgICAgICAgICJhY3R1YWwiOiAiVEVYVCBQQVNTIgorICAgICAgICAgICAgICAgIH0sCisg ICAgICAgICAgICAgICAgInByb3RvdHlwZS1wZWFjaC5odG1sIjogeworICAgICAgICAgICAgICAg ICAgICAiZXhwZWN0ZWQiOiAiSU1BR0UrVEVYVCIsCisgICAgICAgICAgICAgICAgICAgICJhY3R1 YWwiOiAiVEVYVCIKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgIH0s CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9l eHBlY3RhdGlvbnMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CShyZXZpc2lvbiA5MDgyMSkKKysr IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0 aW9ucy5weQkod29ya2luZyBjb3B5KQpAQCAtODQsNiArODQsMTAgQEAgZGVmIHJlbW92ZV9waXhl bF9mYWlsdXJlcyhleHBlY3RlZF9yZXN1bAogICAgIHJldHVybiBleHBlY3RlZF9yZXN1bHRzCiAK IAorZGVmIGhhc19waXhlbF9mYWlsdXJlcyhhY3R1YWxfcmVzdWx0cyk6CisgICAgcmV0dXJuIElN QUdFIGluIGFjdHVhbF9yZXN1bHRzIG9yIElNQUdFX1BMVVNfVEVYVCBpbiBhY3R1YWxfcmVzdWx0 cworCisKIGRlZiBzdHJpcF9jb21tZW50cyhsaW5lKToKICAgICAiIiJTdHJpcHMgY29tbWVudHMg ZnJvbSBhIGxpbmUgYW5kIHJldHVybiBOb25lIGlmIHRoZSBsaW5lIGlzIGVtcHR5CiAgICAgb3Ig ZWxzZSB0aGUgY29udGVudHMgb2YgbGluZSB3aXRoIGxlYWRpbmcgYW5kIHRyYWlsaW5nIHNwYWNl cyByZW1vdmVkCg==