64354 2011-07-12 05:34:14 -0700 [EFL] Implement EFL-specific current time and monotonicallyIncreasingTime. 2011-07-25 00:19:10 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 435593 0 ryuan.choi 2011-07-12 05:34:14 -0700 Patch will be added. 436216 1 100618 ryuan.choi 2011-07-12 20:56:48 -0700 Created attachment 100618 Patch 436266 2 100618 gyuyoung.kim 2011-07-12 23:04:42 -0700 Comment on attachment 100618 Patch Did you test this functions ? 436289 3 ryuan.choi 2011-07-13 00:13:50 -0700 (In reply to comment #2) > (From update of attachment 100618 [details]) > Did you test this functions ? I tested gettimeofday version and ecore_time_unix_get. They return almost same value. (little bit different because time elapsed after calling one and other). In case of ecore_time_get, you can reference below document. http://docs.enlightenment.org/auto/ecore/group__Ecore__Time__Group.html#ga43846b079394bb4d098abf5c16dfc544 Because ecore_time_get use monotonic clock, it cover functionality of monotonicallyIncreasingTime. 436326 4 gyuyoung.kim 2011-07-13 03:03:02 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 100618 [details] [details]) > > Did you test this functions ? > > I tested gettimeofday version and ecore_time_unix_get. > They return almost same value. > (little bit different because time elapsed after calling one and other). > > In case of ecore_time_get, you can reference below document. > http://docs.enlightenment.org/auto/ecore/group__Ecore__Time__Group.html#ga43846b079394bb4d098abf5c16dfc544 > > Because ecore_time_get use monotonic clock, it cover functionality of monotonicallyIncreasingTime. Implementation of ecore_time_unix_get() uses gettimeofday as well. So, it looks there is no problem. 436408 5 rakuco 2011-07-13 06:55:21 -0700 LGTM. 441573 6 100618 webkit.review.bot 2011-07-25 00:19:04 -0700 Comment on attachment 100618 Patch Clearing flags on attachment: 100618 Committed r91660: <http://trac.webkit.org/changeset/91660> 441574 7 webkit.review.bot 2011-07-25 00:19:10 -0700 All reviewed patches have been landed. Closing bug. 100618 2011-07-12 20:56:48 -0700 2011-07-25 00:19:04 -0700 Patch bug-64354-20110713125700.patch text/plain 1978 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogOTA4ODMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDk2 NDdiMWNmNjgwMjFjODk1NTc5N2FkMTJhOGFiM2RmMDE0ZDAxZGIuLmU0ODk2M2Q5N2EwNGM5Zjk5 Nzg4MWYzYTZmMWQ1YzIyOGZhNmFkZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE3IEBACisyMDExLTA3LTEyICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNv bT4KKworICAgICAgICBbRUZMXSBJbXBsZW1lbnQgRUZMLXNwZWNpZmljIGN1cnJlbnQgdGltZSBh bmQgbW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQzNTQKKworICAgICAgICBVc2UgZWNvcmVfdGltZV91 bml4X2dldCB3aGljaCByZXR1cm5zIHVuaXggdGltZSBhcyBkb3VibGUgdHlwZSBmb3IgY3VycmVu dFRpbWUKKyAgICAgICAgYW5kIGVjb3JlX3RpbWVfZ2V0IHdoaWNoIHVzZXMgbW9ub3RvbmljIGNs b2NrIGZvciBtb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUuCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvQ3VycmVudFRpbWUuY3BwOgorICAg ICAgICAoV1RGOjpjdXJyZW50VGltZSk6CisgICAgICAgIChXVEY6Om1vbm90b25pY2FsbHlJbmNy ZWFzaW5nVGltZSk6CisKIDIwMTEtMDctMTIgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNv bT4KIAogICAgICAgICBERkcgSklUIGRvZXMgbm90IGltcGxlbWVudCBvcF9jb25zdHJ1Y3QuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0N1cnJlbnRUaW1lLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQ3VycmVudFRpbWUuY3BwCmluZGV4IGU0MmRhYmIyNWQx Nzk0YmIxNmZlNjAwNjY0NWJhYTM2ZjgxZWM0YmEuLjkxOTBkYmM1NWI3MGI2YTU1M2ZiOGU2MmE5 OTNkN2RmMGUwYjA3YTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQ3Vy cmVudFRpbWUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQ3VycmVudFRpbWUu Y3BwCkBAIC02Miw2ICs2Miw4IEBAIGV4dGVybiAiQyIgdGltZV90IG1rdGltZShzdHJ1Y3QgdG0g KnQpOwogI2luY2x1ZGUgPHd4L2RhdGV0aW1lLmg+CiAjZWxpZiBQTEFURk9STShCUkVXTVApCiAj aW5jbHVkZSA8QUVFU3RkTGliLmg+CisjZWxpZiBQTEFURk9STShFRkwpCisjaW5jbHVkZSA8RWNv cmUuaD4KICNlbHNlCiAjaW5jbHVkZSA8c3lzL3RpbWUuaD4KICNlbmRpZgpAQCAtMjg2LDYgKzI4 OCwxMyBAQCBkb3VibGUgY3VycmVudFRpbWUoKQogICAgIHJldHVybiBzdGF0aWNfY2FzdDxkb3Vi bGU+KGRpZmZTZWNvbmRzICsgR0VUVVRDU0VDT05EUygpICsgKChHRVRUSU1FTVMoKSAlIDEwMDAp IC8gbXNQZXJTZWNvbmQpKTsKIH0KIAorI2VsaWYgUExBVEZPUk0oRUZMKQorCitkb3VibGUgY3Vy cmVudFRpbWUoKQoreworICAgIHJldHVybiBlY29yZV90aW1lX3VuaXhfZ2V0KCk7Cit9CisKICNl bHNlCiAKIGRvdWJsZSBjdXJyZW50VGltZSgpCkBAIC0zMTAsNiArMzE5LDEzIEBAIGRvdWJsZSBt b25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKQogICAgIHJldHVybiAobWFjaF9hYnNvbHV0ZV90 aW1lKCkgKiB0aW1lYmFzZUluZm8ubnVtZXIpIC8gKDEuMGU5ICogdGltZWJhc2VJbmZvLmRlbm9t KTsKIH0KIAorI2VsaWYgUExBVEZPUk0oRUZMKQorCitkb3VibGUgbW9ub3RvbmljYWxseUluY3Jl YXNpbmdUaW1lKCkKK3sKKyAgICByZXR1cm4gZWNvcmVfdGltZV9nZXQoKTsKK30KKwogI2Vsc2UK IAogZG91YmxlIG1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpCg==