64348 2011-07-12 01:36:35 -0700 Unquoted string "attributes" may clash with future reserved word at ../../Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm line 1058. 2011-10-17 16:14:14 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 a.renevier webkit-unassigned darin dbates eric webkit.review.bot oldest_to_newest 435521 0 a.renevier 2011-07-12 01:36:35 -0700 Hi, when building webkit-gtk with annotations, warning is issued multiple times from CodeGeneratorGObject.pm 435523 1 100450 a.renevier 2011-07-12 01:48:42 -0700 Created attachment 100450 patch 465970 2 100450 eric 2011-09-12 17:02:50 -0700 Comment on attachment 100450 patch Huh? I'm confused by this perl. 485216 3 100450 darin 2011-10-17 09:33:11 -0700 Comment on attachment 100450 patch View in context: https://bugs.webkit.org/attachment.cgi?id=100450&action=review > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1058 > - $param->extendedAttributes(attributes); > + $param->extendedAttributes("attributes"); After reviewing, I realized that I don’t really understand this line. It looks like it fetches a value that is never used. 485599 4 100450 webkit.review.bot 2011-10-17 16:14:08 -0700 Comment on attachment 100450 patch Clearing flags on attachment: 100450 Committed r97664: <http://trac.webkit.org/changeset/97664> 485600 5 webkit.review.bot 2011-10-17 16:14:14 -0700 All reviewed patches have been landed. Closing bug. 100450 2011-07-12 01:48:42 -0700 2011-10-17 16:14:08 -0700 patch 0001-64348.patch text/plain 1670 a.renevier RnJvbSBhNDMwYzJmZjIyZTNmNDFjZmM5MzdhZGQyMmFkNzFiMDExMWYyNTE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBcm5vIFJlbmV2aWVyIDxhcm5vQHJlbmV2aWVyLm5ldD4KRGF0 ZTogVHVlLCAxMiBKdWwgMjAxMSAxMDo0NTo1OSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIDY0MzQ4 CgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAg IHwgICAxMSArKysrKysrKysrKwogLi4uL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdP YmplY3QucG0gICAgICAgfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDJmOGNjOGYuLjA3NWUyNTAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxMS0wNy0xMiAgQXJubyBSZW5ldmllciAgPGFybm9A cmVuZXZpZXIubmV0PgogCisgICAgICAgIHF1b3RlICJhdHRyaWJ1dGVzIiBrZXl3b3JkIGluIENv ZGVHZW5lcmF0b3JHT2JqZWN0LnBtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NDM0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vIGNoYW5nZSBvZiBmdW5jdGlvbmFsaXR5LiBObyBuZXcgdGVzdHMuCisK KyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtOgorCisy MDExLTA3LTEyICBBcm5vIFJlbmV2aWVyICA8YXJub0ByZW5ldmllci5uZXQ+CisKICAgICAgICAg bW9kaWZ5IENvZGVHZW5lcmF0b3JHT2JqZWN0LnBtIHRvIGdlbmVyYXRlIGFubm90YXRpb25zCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTM5NQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JH T2JqZWN0LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y R09iamVjdC5wbQppbmRleCBjZDJlMjAyLi4zYTVjMDYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KQEAgLTEw NTUsNyArMTA1NSw3IEBAIHN1YiBHZW5lcmF0ZUZ1bmN0aW9ucyB7CiAgICAgICAgICRwYXJhbS0+ bmFtZSgidmFsdWUiKTsKICAgICAgICAgJHBhcmFtLT50eXBlKCRhdHRyaWJ1dGUtPnNpZ25hdHVy ZS0+dHlwZSk7CiAgICAgICAgIG15ICVhdHRyaWJ1dGVzID0gKCk7Ci0gICAgICAgICRwYXJhbS0+ ZXh0ZW5kZWRBdHRyaWJ1dGVzKGF0dHJpYnV0ZXMpOworICAgICAgICAkcGFyYW0tPmV4dGVuZGVk QXR0cmlidXRlcygiYXR0cmlidXRlcyIpOwogICAgICAgICBteSAkYXJyYXlSZWYgPSAkZnVuY3Rp b24tPnBhcmFtZXRlcnM7CiAgICAgICAgIHB1c2goQCRhcnJheVJlZiwgJHBhcmFtKTsKICAgICAg ICAgCi0tIAoxLjcuNS40Cgo=