64342 2011-07-11 22:30:58 -0700 Simplify logic in ResourceResponse::nsURLResponse 2011-07-11 22:30:58 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 psolanki webkit-unassigned ddkilzer jberlin oldest_to_newest 435483 0 psolanki 2011-07-11 22:30:58 -0700 In the review for the fix for bug 63286, David Kilzer notes <https://bugs.webkit.org/show_bug.cgi?id=63286#c5> > Is there ever a case where you have an m_nsResponse but not a m_cfResponse (in which case you could > make the m_cfResponse from the m_nsResponse)? Or is this ASSERT-ed elsewhere during construction > so it's not possible to get into this state? > > Could some of this logic be simplified by doing an early return if m_isNull is true: > > if (m_isNull) > return nil; IIRC the code is a bit convoluted due to some layout test failures I had run into. But we should revisit it. I think it can be simplified.