64336 2011-07-11 18:46:44 -0700 RenderListBox scroller doesn't scroll 2012-04-19 16:36:07 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 joepeck webkit-unassigned adele eric joepeck sam simon.fraser oldest_to_newest 435402 0 joepeck 2011-07-11 18:46:44 -0700 Existing test: LayoutTests/platform/mac/fast/forms/listbox-scrollbar-hit-test.html The test seems to succeed in DRT but the scrollbars don't work properly in Safari. Scrollwheel events seem to work, but clicking on the scrollbar, using up/down etc all don't work. 435403 1 joepeck 2011-07-11 18:47:23 -0700 Hmm, I see the "native animator" getting called, but ends up doing nothing: ScrollAnimatorMac::scroll... [m_scrollAnimationHelper.get() scrollToPoint:newPoint]; gdb> po m_scrollAnimationHelper.get() <NSScrollAnimationHelper: 0x118616b50> Because ScrollAnimatorMac::adjustScrollPositionIfNecessary resets the y scroll to 0: float newY = max<float>(min<float>(position.y(), m_scrollableArea->contentsSize().height() - m_scrollableArea->visibleHeight()), 0); => max(min(1, 125-129), 0) => max(min(1, -4), 0) => max(-1, 0) => 0 Is the "- m_scrollableArea->visibleHeight()" part of the equation necessary? It sounds like we just want to clamp in the content size, in this case from 0 to 125 and the visible height is not needed? However, I think custom scrollers work. So I'll compare this to custom scrollers. 435406 2 joepeck 2011-07-11 18:54:00 -0700 This breaks whenever the visibleHeight is greater than the contentHeight. So this is broken for custom scrollbars as well. 435450 3 100430 joepeck 2011-07-11 19:59:14 -0700 Created attachment 100430 [PATCH] Proposed Fix 435452 4 100431 joepeck 2011-07-11 20:04:58 -0700 Created attachment 100431 [PATCH] Proposed Fix Now with git add ChangeLog! 436206 5 sam 2011-07-12 20:38:47 -0700 Joe, do you know why this seems to work in DRT? 436212 6 joepeck 2011-07-12 20:46:38 -0700 Nope, I didn't look into that =/. 558505 7 eric 2012-02-16 13:59:16 -0800 The difference between content and visible should be padding/margin, no? We need some way to test this... 606124 8 adele 2012-04-19 16:28:31 -0700 Would a test that used up/down work? 606141 9 100431 eric 2012-04-19 16:36:07 -0700 Comment on attachment 100431 [PATCH] Proposed Fix r- for lack of test or lack of why testing is impossible/impratical. 100430 2011-07-11 19:59:14 -0700 2011-07-11 20:04:58 -0700 [PATCH] Proposed Fix list-box.patch text/plain 1516 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkN2ZmOWI4Li5lMjlmZTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDctMTEgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZW5kZXJMaXN0Qm94IHNjcm9sbGVyIGRvZXNuJ3Qgc2Nyb2xsCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDMzNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMh KQorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxpc3RCb3guY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyTGlzdEJveDo6Y29udmVydEZyb21TY3JvbGxiYXJUb0NvbnRhaW5pbmdWaWV3 KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxpc3RCb3g6OmNvbnZlcnRGcm9tQ29udGFpbmlu Z1ZpZXdUb1Njcm9sbGJhcik6CisKIDIwMTEtMDctMDcgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBl Y2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0Qm94LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0Qm94LmNwcAppbmRleCAwYTRiNmNjLi5k MzU0MGI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEJv eC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RCb3guY3BwCkBA IC03NzksMTIgKzc3OSwxNiBAQCBJbnRTaXplIFJlbmRlckxpc3RCb3g6OmNvbnRlbnRzU2l6ZSgp IGNvbnN0CiAKIExheW91dFVuaXQgUmVuZGVyTGlzdEJveDo6dmlzaWJsZUhlaWdodCgpIGNvbnN0 CiB7Ci0gICAgcmV0dXJuIGhlaWdodCgpOworICAgIC8vIE5PVEU6IHZpc2libGVIZWlnaHQgaXMg bm90IHdoYXQgaXMgdmlzaWJsZSBvZiB0aGUgTGlzdEJveCwKKyAgICAvLyBpdCBpcyB3aGF0IGlz IHZpc2libGUgb2YgdGhlIHNjcm9sbGFibGUgYXJlYSBpbiB0aGUgTGlzdEJveC4KKyAgICByZXR1 cm4gY29udGVudEhlaWdodCgpOwogfQogCiBMYXlvdXRVbml0IFJlbmRlckxpc3RCb3g6OnZpc2li bGVXaWR0aCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIHdpZHRoKCk7CisgICAgLy8gTk9URTogdmlz aWJsZVdpZHRoIGlzIG5vdCB3aGF0IGlzIHZpc2libGUgb2YgdGhlIExpc3RCb3gsCisgICAgLy8g aXQgaXMgd2hhdCBpcyB2aXNpYmxlIG9mIHRoZSBzY3JvbGxhYmxlIGFyZWEgaW4gdGhlIExpc3RC b3guCisgICAgcmV0dXJuIGNvbnRlbnRXaWR0aCgpOwogfQogCiBJbnRQb2ludCBSZW5kZXJMaXN0 Qm94OjpjdXJyZW50TW91c2VQb3NpdGlvbigpIGNvbnN0Cg== 100431 2011-07-11 20:04:58 -0700 2012-04-19 16:36:07 -0700 [PATCH] Proposed Fix list-box.patch text/plain 1619 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkN2ZmOWI4Li4zZjZiMDNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDctMTEgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5kZXJMaXN0 Qm94IHNjcm9sbGVyIGRvZXNuJ3Qgc2Nyb2xsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NDMzNgorCisgICAgICAgIFRoZSBzY3JvbGxhYmxlIGNvbnRl bnQgaW5zaWRlIG9mIGEgTGlzdEJveCBpcyBkaWZmZXJlbnQKKyAgICAgICAgZnJvbSB0aGUgTGlz dEJveCdzIHRvdGFsIGhlaWdodCBhbmQgd2lkdGguCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyTGlzdEJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMaXN0Qm94Ojp2aXNpYmxl SGVpZ2h0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxpc3RCb3g6OnZpc2libGVXaWR0aCk6 CisgICAgICAgIFJldHVybiB0aGUgc2Nyb2xsYWJsZSBhcmVhJ3MgdmlzaWJsZSB3aWR0aCBhbmQg aGVpZ2h0LAorCiAyMDExLTA3LTA3ICBKb3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNrQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEJveC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEJveC5jcHAKaW5kZXggMGE0YjZjYy4uZDM1NDBiOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RCb3guY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0Qm94LmNwcApAQCAtNzc5LDEyICs3 NzksMTYgQEAgSW50U2l6ZSBSZW5kZXJMaXN0Qm94Ojpjb250ZW50c1NpemUoKSBjb25zdAogCiBM YXlvdXRVbml0IFJlbmRlckxpc3RCb3g6OnZpc2libGVIZWlnaHQoKSBjb25zdAogewotICAgIHJl dHVybiBoZWlnaHQoKTsKKyAgICAvLyBOT1RFOiB2aXNpYmxlSGVpZ2h0IGlzIG5vdCB3aGF0IGlz IHZpc2libGUgb2YgdGhlIExpc3RCb3gsCisgICAgLy8gaXQgaXMgd2hhdCBpcyB2aXNpYmxlIG9m IHRoZSBzY3JvbGxhYmxlIGFyZWEgaW4gdGhlIExpc3RCb3guCisgICAgcmV0dXJuIGNvbnRlbnRI ZWlnaHQoKTsKIH0KIAogTGF5b3V0VW5pdCBSZW5kZXJMaXN0Qm94Ojp2aXNpYmxlV2lkdGgoKSBj b25zdAogewotICAgIHJldHVybiB3aWR0aCgpOworICAgIC8vIE5PVEU6IHZpc2libGVXaWR0aCBp cyBub3Qgd2hhdCBpcyB2aXNpYmxlIG9mIHRoZSBMaXN0Qm94LAorICAgIC8vIGl0IGlzIHdoYXQg aXMgdmlzaWJsZSBvZiB0aGUgc2Nyb2xsYWJsZSBhcmVhIGluIHRoZSBMaXN0Qm94LgorICAgIHJl dHVybiBjb250ZW50V2lkdGgoKTsKIH0KIAogSW50UG9pbnQgUmVuZGVyTGlzdEJveDo6Y3VycmVu dE1vdXNlUG9zaXRpb24oKSBjb25zdAo=