64324 2011-07-11 16:30:46 -0700 webkit-patch roll-chromium-deps no longer works 2011-07-11 16:35:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa abarth aroben oldest_to_newest 435283 0 rniwa 2011-07-11 16:30:46 -0700 webkit-patch roll-chromium-deps blows up with the following trace: File "Tools/Scripts/webkit-patch", line 66, in <module> main() File "Tools/Scripts/webkit-patch", line 61, in main WebKitPatch(__file__).main() File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/steps/commit.py", line 48, in run raise Exception("Attempted to commit with a commit message shorter than 50 characters. Either your patch is missing a ChangeLog or webkit-patch may have a bug.") 435286 1 100379 rniwa 2011-07-11 16:32:32 -0700 Created attachment 100379 Patch 435287 2 100379 abarth 2011-07-11 16:33:06 -0700 Comment on attachment 100379 Patch Did you run test-webkitpy? 435290 3 100379 jamesr 2011-07-11 16:33:31 -0700 Comment on attachment 100379 Patch R=me but please file a bug to make this check actually do what it claims it's trying to do (checking for a ChangeLog on the patch). 435294 4 rniwa 2011-07-11 16:35:17 -0700 Committed r90793: <http://trac.webkit.org/changeset/90793> 100379 2011-07-11 16:32:32 -0700 2011-07-11 16:33:31 -0700 Patch bug-64324-20110711163231.patch text/plain 1530 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkwNzkwKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMDctMTEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgd2Via2l0LXBhdGNoIHJvbGwtY2hyb21pdW0tZGVwcyBubyBsb25nZXIgd29ya3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MzI0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTG93ZXIgdGhl IG1pbmltdW0gY29tbWl0IG1lc3NhZ2UgbGVuZ3RoIHRvIDEwLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS90b29sL3N0ZXBzL2NvbW1pdC5weToKKwogMjAxMS0wNy0xMSAgQWxpY2UgQm94 aGFsbCAgPGFib3hoYWxsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDb252ZXJ0IGpzb25fcmVz dWx0c19nZW5lcmF0b3IucHkgdG8gb3V0cHV0IHZlcnNpb24gNCBKU09OLgpJbmRleDogVG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2NvbW1pdC5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY29tbWl0LnB5CShyZXZpc2lvbiA5MDc5MCkK KysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jb21taXQucHkJKHdvcmtpbmcg Y29weSkKQEAgLTQ0LDggKzQ0LDggQEAgY2xhc3MgQ29tbWl0KEFic3RyYWN0U3RlcCk6CiAKICAg ICBkZWYgcnVuKHNlbGYsIHN0YXRlKToKICAgICAgICAgc2VsZi5fY29tbWl0X21lc3NhZ2UgPSBz ZWxmLl90b29sLmNoZWNrb3V0KCkuY29tbWl0X21lc3NhZ2VfZm9yX3RoaXNfY29tbWl0KHNlbGYu X29wdGlvbnMuZ2l0X2NvbW1pdCkubWVzc2FnZSgpCi0gICAgICAgIGlmIGxlbihzZWxmLl9jb21t aXRfbWVzc2FnZSkgPCA1MDoKLSAgICAgICAgICAgIHJhaXNlIEV4Y2VwdGlvbigiQXR0ZW1wdGVk IHRvIGNvbW1pdCB3aXRoIGEgY29tbWl0IG1lc3NhZ2Ugc2hvcnRlciB0aGFuIDUwIGNoYXJhY3Rl cnMuICBFaXRoZXIgeW91ciBwYXRjaCBpcyBtaXNzaW5nIGEgQ2hhbmdlTG9nIG9yIHdlYmtpdC1w YXRjaCBtYXkgaGF2ZSBhIGJ1Zy4iKQorICAgICAgICBpZiBsZW4oc2VsZi5fY29tbWl0X21lc3Nh Z2UpIDwgMTA6CisgICAgICAgICAgICByYWlzZSBFeGNlcHRpb24oIkF0dGVtcHRlZCB0byBjb21t aXQgd2l0aCBhIGNvbW1pdCBtZXNzYWdlIHNob3J0ZXIgdGhhbiAxMCBjaGFyYWN0ZXJzLiAgRWl0 aGVyIHlvdXIgcGF0Y2ggaXMgbWlzc2luZyBhIENoYW5nZUxvZyBvciB3ZWJraXQtcGF0Y2ggbWF5 IGhhdmUgYSBidWcuIikKIAogICAgICAgICBzZWxmLl9zdGF0ZSA9IHN0YXRlCiAK