64302 2011-07-11 11:54:54 -0700 [skia] optimize getImageData to avoid a copy when not needed. lockPixels() now does the right thing. 2013-04-09 13:03:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 64389 1 reed reed bsalomon dglazkov jamesr kbr schenney senorblanco webkit.review.bot oldest_to_newest 435077 0 reed 2011-07-11 11:54:54 -0700 [skia] optimize getImageData to avoid a copy when not needed. lockPixels() now does the right thing. 435080 1 100341 reed 2011-07-11 11:56:41 -0700 Created attachment 100341 Patch 435093 2 100341 webkit.review.bot 2011-07-11 12:06:32 -0700 Comment on attachment 100341 Patch Attachment 100341 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9014296 435098 3 100341 kbr 2011-07-11 12:11:21 -0700 Comment on attachment 100341 Patch Does this need a roll of the Chromium revision in WebKit/Source/WebKit/chromium/DEPS, and is that why the patch doesn't build on the cr-linux EWS? 435102 4 100344 reed 2011-07-11 12:12:16 -0700 Created attachment 100344 Patch 435103 5 reed 2011-07-11 12:12:51 -0700 may need webkit to update to a newer chrome/skia DEPS for this to build. 435116 6 100344 webkit.review.bot 2011-07-11 12:24:08 -0700 Comment on attachment 100344 Patch Attachment 100344 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9010567 435120 7 100344 kbr 2011-07-11 12:26:22 -0700 Comment on attachment 100344 Patch Per above comment, please update chromium_rev in Source/WebKit/chromium/DEPS. 435582 8 100470 reed 2011-07-12 05:24:14 -0700 Created attachment 100470 Patch 435594 9 reed 2011-07-12 05:35:06 -0700 no code change for this patch, just rebaselined the ChangeLog file 435795 10 100470 kbr 2011-07-12 11:20:15 -0700 Comment on attachment 100470 Patch Looks good to me. 435800 11 100470 senorblanco 2011-07-12 11:22:42 -0700 Comment on attachment 100470 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100470&action=review > Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:228 > + return result.release(); Just for my own edification: is this early-out for failure of the accessBitmap(), the extractSubset() or both? 435801 12 reed 2011-07-12 11:23:20 -0700 accessBitmap() never fails. The boolean check is on extractSubset(). 435802 13 100470 senorblanco 2011-07-12 11:23:28 -0700 Comment on attachment 100470 Patch Looks good to me too (restoring r+). 435809 14 100470 webkit.review.bot 2011-07-12 11:32:06 -0700 Comment on attachment 100470 Patch Clearing flags on attachment: 100470 Committed r90831: <http://trac.webkit.org/changeset/90831> 435810 15 webkit.review.bot 2011-07-12 11:32:11 -0700 All reviewed patches have been landed. Closing bug. 436136 16 jamesr 2011-07-12 18:20:25 -0700 Reverted http://trac.webkit.org/changeset/90847 100341 2011-07-11 11:56:41 -0700 2011-07-11 12:12:07 -0700 Patch bug-64302-20110711145640.patch text/plain 2147 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwNzcxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMTEgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBbc2tpYV0gb3B0aW1pemUgZ2V0SW1hZ2VE YXRhIHRvIGF2b2lkIGEgY29weSB3aGVuIG5vdCBuZWVkZWQuIGxvY2tQaXhlbHMoKSBub3cgZG9l cyB0aGUgcmlnaHQgdGhpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NDMwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cy4gSnVzdCBhbiBvcHRpbWl6YXRpb24gZm9yIGdldEltYWdl RGF0YSgpLCBleGlzdGluZyA8Y2FudmFzPiB0ZXN0cyBhcHBseQorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Z2V0SW1hZ2VEYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OnB1dEltYWdlRGF0YSk6CisKIDIwMTEt MDctMTEgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hy b21pdW1dIEVuc3VyZSB3ZSBkb24ndCBjcmFzaCB3aGVuIGFuCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEu Y3BwCShyZXZpc2lvbiA5MDc2MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjIzLDcgKzIyMywx MCBAQCBQYXNzUmVmUHRyPEJ5dGVBcnJheT4gZ2V0SW1hZ2VEYXRhKGNvbnN0CiAgICAgdW5zaWdu ZWQgZGVzdEJ5dGVzUGVyUm93ID0gNCAqIHJlY3Qud2lkdGgoKTsKIAogICAgIFNrQml0bWFwIHNy Y0JpdG1hcDsKLSAgICBzcmNEZXZpY2UucmVhZFBpeGVscyhTa0lSZWN0OjpNYWtlWFlXSChvcmln aW5YLCBvcmlnaW5ZLCBudW1Db2x1bW5zLCBudW1Sb3dzKSwgJnNyY0JpdG1hcCk7CisgICAgU2tJ UmVjdCBzcmNSZWN0ID0gU2tJUmVjdDo6TWFrZVhZV0gob3JpZ2luWCwgb3JpZ2luWSwgbnVtQ29s dW1ucywgbnVtUm93cyk7CisgICAgaWYgKCFzcmNEZXZpY2UuYWNjZXNzQml0bWFwKGZhbHNlKS5l eHRyYWN0U3Vic2V0KCZzcmNCaXRtYXAsIHNyY1JlY3QpKQorICAgICAgICByZXR1cm4gcmVzdWx0 LnJlbGVhc2UoKTsKKyAgICBTa0F1dG9Mb2NrUGl4ZWxzIGFscChzcmNCaXRtYXApOwogCiAgICAg dW5zaWduZWQgY2hhciogZGVzdFJvdyA9IGRhdGEgKyBkZXN0WSAqIGRlc3RCeXRlc1BlclJvdyAr IGRlc3RYICogNDsKIApAQCAtMjk4LDEwICszMDEsOCBAQCB2b2lkIHB1dEltYWdlRGF0YShCeXRl QXJyYXkqJiBzb3VyY2UsIGNvCiAKICAgICB1bnNpZ25lZCBzcmNCeXRlc1BlclJvdyA9IDQgKiBz b3VyY2VTaXplLndpZHRoKCk7CiAKLSAgICBTa0JpdG1hcCBkZXZpY2VCaXRtYXAgPSBkc3REZXZp Y2UtPmFjY2Vzc0JpdG1hcCh0cnVlKTsKLQotICAgIC8vIElmIHRoZSBkZXZpY2UncyBiaXRtYXAg ZG9lc24ndCBoYXZlIHBpeGVscyB3ZSB3aWxsIG1ha2UgYSB0ZW1wIGFuZCBjYWxsIHdyaXRlUGl4 ZWxzIG9uIHRoZSBkZXZpY2UuCi0gICAgYm9vbCB0ZW1wb3JhcnlCaXRtYXAgPSAhIWRldmljZUJp dG1hcC5nZXRUZXh0dXJlKCk7CisgICAgY29uc3QgU2tCaXRtYXAmIGRldmljZUJpdG1hcCA9IGRz dERldmljZS0+YWNjZXNzQml0bWFwKHRydWUpOworICAgIGJvb2wgdGVtcG9yYXJ5Qml0bWFwID0g IWRldmljZUJpdG1hcC5sb2NrUGl4ZWxzQXJlV3JpdGFibGUoKTsKICAgICBTa0JpdG1hcCBkZXN0 Qml0bWFwOwogCiAgICAgaWYgKHRlbXBvcmFyeUJpdG1hcCkgewo= 100344 2011-07-11 12:12:16 -0700 2011-07-12 05:24:08 -0700 Patch bug-64302-20110711151215.patch text/plain 2147 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwNzcxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMTEgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBbc2tpYV0gb3B0aW1pemUgZ2V0SW1hZ2VE YXRhIHRvIGF2b2lkIGEgY29weSB3aGVuIG5vdCBuZWVkZWQuIGxvY2tQaXhlbHMoKSBub3cgZG9l cyB0aGUgcmlnaHQgdGhpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NDMwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cy4gSnVzdCBhbiBvcHRpbWl6YXRpb24gZm9yIGdldEltYWdl RGF0YSgpLCBleGlzdGluZyA8Y2FudmFzPiB0ZXN0cyBhcHBseQorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Z2V0SW1hZ2VEYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OnB1dEltYWdlRGF0YSk6CisKIDIwMTEt MDctMTEgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hy b21pdW1dIEVuc3VyZSB3ZSBkb24ndCBjcmFzaCB3aGVuIGFuCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEu Y3BwCShyZXZpc2lvbiA5MDc2MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjIzLDcgKzIyMywx MCBAQCBQYXNzUmVmUHRyPEJ5dGVBcnJheT4gZ2V0SW1hZ2VEYXRhKGNvbnN0CiAgICAgdW5zaWdu ZWQgZGVzdEJ5dGVzUGVyUm93ID0gNCAqIHJlY3Qud2lkdGgoKTsKIAogICAgIFNrQml0bWFwIHNy Y0JpdG1hcDsKLSAgICBzcmNEZXZpY2UucmVhZFBpeGVscyhTa0lSZWN0OjpNYWtlWFlXSChvcmln aW5YLCBvcmlnaW5ZLCBudW1Db2x1bW5zLCBudW1Sb3dzKSwgJnNyY0JpdG1hcCk7CisgICAgU2tJ UmVjdCBzcmNSZWN0ID0gU2tJUmVjdDo6TWFrZVhZV0gob3JpZ2luWCwgb3JpZ2luWSwgbnVtQ29s dW1ucywgbnVtUm93cyk7CisgICAgaWYgKCFzcmNEZXZpY2UuYWNjZXNzQml0bWFwKGZhbHNlKS5l eHRyYWN0U3Vic2V0KCZzcmNCaXRtYXAsIHNyY1JlY3QpKQorICAgICAgICByZXR1cm4gcmVzdWx0 LnJlbGVhc2UoKTsKKyAgICBTa0F1dG9Mb2NrUGl4ZWxzIGFscChzcmNCaXRtYXApOwogCiAgICAg dW5zaWduZWQgY2hhciogZGVzdFJvdyA9IGRhdGEgKyBkZXN0WSAqIGRlc3RCeXRlc1BlclJvdyAr IGRlc3RYICogNDsKIApAQCAtMjk4LDEwICszMDEsOCBAQCB2b2lkIHB1dEltYWdlRGF0YShCeXRl QXJyYXkqJiBzb3VyY2UsIGNvCiAKICAgICB1bnNpZ25lZCBzcmNCeXRlc1BlclJvdyA9IDQgKiBz b3VyY2VTaXplLndpZHRoKCk7CiAKLSAgICBTa0JpdG1hcCBkZXZpY2VCaXRtYXAgPSBkc3REZXZp Y2UtPmFjY2Vzc0JpdG1hcCh0cnVlKTsKLQotICAgIC8vIElmIHRoZSBkZXZpY2UncyBiaXRtYXAg ZG9lc24ndCBoYXZlIHBpeGVscyB3ZSB3aWxsIG1ha2UgYSB0ZW1wIGFuZCBjYWxsIHdyaXRlUGl4 ZWxzIG9uIHRoZSBkZXZpY2UuCi0gICAgYm9vbCB0ZW1wb3JhcnlCaXRtYXAgPSAhIWRldmljZUJp dG1hcC5nZXRUZXh0dXJlKCk7CisgICAgY29uc3QgU2tCaXRtYXAmIGRldmljZUJpdG1hcCA9IGRz dERldmljZS0+YWNjZXNzQml0bWFwKHRydWUpOworICAgIGJvb2wgdGVtcG9yYXJ5Qml0bWFwID0g IWRldmljZUJpdG1hcC5sb2NrUGl4ZWxzQXJlV3JpdGFibGUoKTsKICAgICBTa0JpdG1hcCBkZXN0 Qml0bWFwOwogCiAgICAgaWYgKHRlbXBvcmFyeUJpdG1hcCkgewo= 100470 2011-07-12 05:24:14 -0700 2011-07-12 11:32:06 -0700 Patch bug-64302-20110712082412.patch text/plain 2149 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwODExKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMTIgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBbc2tpYV0gb3B0aW1pemUgZ2V0SW1hZ2VE YXRhIHRvIGF2b2lkIGEgY29weSB3aGVuIG5vdCBuZWVkZWQuIGxvY2tQaXhlbHMoKSBub3cgZG9l cyB0aGUgcmlnaHQgdGhpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NDMwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cy4gSnVzdCBhbiBvcHRpbWl6YXRpb24gZm9yIGdldEltYWdl RGF0YSgpLCBleGlzdGluZyA8Y2FudmFzPiB0ZXN0cyBhcHBseQorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Z2V0SW1hZ2VEYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OnB1dEltYWdlRGF0YSk6CisKIDIwMTEt MDctMTIgIE9saXZlciBWYXJnYSAgPFZhcmdhLk9saXZlckBzdHVkLnUtc3plZ2VkLmh1PgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE5pa29sYXMgWmltbWVybWFubi4KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tp YS5jcHAJKHJldmlzaW9uIDkwODExKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjMsNyArMjIz LDEwIEBAIFBhc3NSZWZQdHI8Qnl0ZUFycmF5PiBnZXRJbWFnZURhdGEoY29uc3QKICAgICB1bnNp Z25lZCBkZXN0Qnl0ZXNQZXJSb3cgPSA0ICogcmVjdC53aWR0aCgpOwogCiAgICAgU2tCaXRtYXAg c3JjQml0bWFwOwotICAgIHNyY0RldmljZS5yZWFkUGl4ZWxzKFNrSVJlY3Q6Ok1ha2VYWVdIKG9y aWdpblgsIG9yaWdpblksIG51bUNvbHVtbnMsIG51bVJvd3MpLCAmc3JjQml0bWFwKTsKKyAgICBT a0lSZWN0IHNyY1JlY3QgPSBTa0lSZWN0OjpNYWtlWFlXSChvcmlnaW5YLCBvcmlnaW5ZLCBudW1D b2x1bW5zLCBudW1Sb3dzKTsKKyAgICBpZiAoIXNyY0RldmljZS5hY2Nlc3NCaXRtYXAoZmFsc2Up LmV4dHJhY3RTdWJzZXQoJnNyY0JpdG1hcCwgc3JjUmVjdCkpCisgICAgICAgIHJldHVybiByZXN1 bHQucmVsZWFzZSgpOworICAgIFNrQXV0b0xvY2tQaXhlbHMgYWxwKHNyY0JpdG1hcCk7CiAKICAg ICB1bnNpZ25lZCBjaGFyKiBkZXN0Um93ID0gZGF0YSArIGRlc3RZICogZGVzdEJ5dGVzUGVyUm93 ICsgZGVzdFggKiA0OwogCkBAIC0yOTgsMTAgKzMwMSw4IEBAIHZvaWQgcHV0SW1hZ2VEYXRhKEJ5 dGVBcnJheSomIHNvdXJjZSwgY28KIAogICAgIHVuc2lnbmVkIHNyY0J5dGVzUGVyUm93ID0gNCAq IHNvdXJjZVNpemUud2lkdGgoKTsKIAotICAgIFNrQml0bWFwIGRldmljZUJpdG1hcCA9IGRzdERl dmljZS0+YWNjZXNzQml0bWFwKHRydWUpOwotCi0gICAgLy8gSWYgdGhlIGRldmljZSdzIGJpdG1h cCBkb2Vzbid0IGhhdmUgcGl4ZWxzIHdlIHdpbGwgbWFrZSBhIHRlbXAgYW5kIGNhbGwgd3JpdGVQ aXhlbHMgb24gdGhlIGRldmljZS4KLSAgICBib29sIHRlbXBvcmFyeUJpdG1hcCA9ICEhZGV2aWNl Qml0bWFwLmdldFRleHR1cmUoKTsKKyAgICBjb25zdCBTa0JpdG1hcCYgZGV2aWNlQml0bWFwID0g ZHN0RGV2aWNlLT5hY2Nlc3NCaXRtYXAodHJ1ZSk7CisgICAgYm9vbCB0ZW1wb3JhcnlCaXRtYXAg PSAhZGV2aWNlQml0bWFwLmxvY2tQaXhlbHNBcmVXcml0YWJsZSgpOwogICAgIFNrQml0bWFwIGRl c3RCaXRtYXA7CiAKICAgICBpZiAodGVtcG9yYXJ5Qml0bWFwKSB7Cg==