64289 2011-07-11 09:20:45 -0700 [Qt][WK2] Get rid of focusNextPrevChild() 2011-07-11 11:22:38 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 benjamin benjamin kling webkit.review.bot oldest_to_newest 434922 0 benjamin 2011-07-11 09:20:45 -0700 Qt 5 does not support focusNextPrevChild(). We should get rid of that for now. 434930 1 100312 benjamin 2011-07-11 09:32:20 -0700 Created attachment 100312 Patch 434933 2 100312 kling 2011-07-11 09:38:50 -0700 Comment on attachment 100312 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100312&action=review r=me. > Source/WebKit2/UIProcess/qt/ClientImpl.cpp:172 > void qt_wk_takeFocus(WKPageRef page, WKFocusDirection direction, const void *clientInfo) You could get rid of this ClientImpl method. 434957 3 100312 kling 2011-07-11 10:10:55 -0700 Comment on attachment 100312 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100312&action=review You asked for it.. > Source/WebKit2/ChangeLog:3 > + [Qt][WK2] Get rid of the focusNextPrevChild() s/the// 435035 4 benjamin 2011-07-11 11:22:38 -0700 Committed r90766: <http://trac.webkit.org/changeset/90766> 100312 2011-07-11 09:32:20 -0700 2011-07-11 10:10:55 -0700 Patch bug-64289-20110711184444.patch text/plain 4442 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogOTA3MzkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBkN2M3NGRkYWMyMjgyZDA4 NWY4ODRhNDQ3ZTNhMjlkZjJiMjVhMWQ1Li5lYTlmMTM4YWQ2NThkNzc1OGIxOGRmZTcxYzYyNmM5 YjZkOWNjOTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDctMTEgIEJlbmph bWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF1bV0syXSBH ZXQgcmlkIG9mIHRoZSBmb2N1c05leHRQcmV2Q2hpbGQoKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQyODkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBRdCA1IGRvZXMgbm90IHVzZSBmb2N1c05leHRQcmV2 Q2hpbGQoKSBidXQgdXNlcyBzZXRGb2N1c05hdmlnYXRpb24oKSwgYW5kCisgICAgICAgIHRoZSBm b2N1cyBpcyBub3QgYmFzZWQgb24gUVdpZGdldC4KKworICAgICAgICBXZSBjYW4gZ2V0IHJpZCBv ZiB0aGUgbWV0aG9kIHNpbmNlIHRoZSBuZXcgaW1wbGVtZW50YXRpb24gd2lsbCBiZSB0b3RhbGx5 CisgICAgICAgIGRpZmZlcmVudC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXRvdWNo d2VicGFnZS5jcHA6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJwYWdlLmg6 CisgICAgICAgICogVUlQcm9jZXNzL3F0L0NsaWVudEltcGwuY3BwOgorICAgICAgICAocXRfd2tf dGFrZUZvY3VzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuaDoKKwog MjAxMS0wNy0xMSAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAg W1F0XVtXSzJdIE1vdmUgem9vbWFibGUtYXJlYS1mb3ItcG9pbnQgZnVuY3Rpb25hbGl0eSB0byBR VG91Y2hXZWJQYWdlUHJveHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvcXRvdWNod2VicGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3F0b3VjaHdlYnBhZ2UuY3BwCmluZGV4IDU1MTA5MmY2ZmFlZTdmYTNjNDlkYTk0MDMyNDgzY2Fm MTA1YTRlMmIuLjI3Yzk0ZDY1OTM1Njk4NWY0MDIzMGRhYzcwNzBmYzlmY2Q0MmIzYTMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXRvdWNod2VicGFnZS5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJwYWdlLmNwcApA QCAtNjcsNDYgKzY3LDYgQEAgUVN0cmluZyBRVG91Y2hXZWJQYWdlOjp0aXRsZSgpIGNvbnN0CiAg ICAgcmV0dXJuIGQtPnBhZ2UtPnRpdGxlKCk7CiB9CiAKLWNsYXNzIEZyaWVuZGx5V2lkZ2V0IDog cHVibGljIFFXaWRnZXQgewotcHVibGljOgotICAgIGJvb2wgZm9jdXNOZXh0UHJldkNoaWxkKGJv b2wgbmV4dCk7Ci19OwotCi12b2lkIFFUb3VjaFdlYlBhZ2U6OmZvY3VzTmV4dFByZXZDaGlsZENh bGxiYWNrKGJvb2wgbmV4dCkKLXsKLSAgICBpZiAoIWhhc0ZvY3VzKCkpCi0gICAgICAgIHJldHVy bjsKLQotICAgIC8vIEZpbmQgdGhlIHZpZXcgd2hpY2ggaGFzIHRoZSBmb2N1cy4KLSAgICBRTGlz dDxRR3JhcGhpY3NWaWV3Kj4gdmlld3MgPSBzY2VuZSgpLT52aWV3cygpOwotICAgIGNvbnN0IGlu dCB2aWV3Q291bnQgPSB2aWV3cy5jb3VudCgpOwotICAgIFFHcmFwaGljc1ZpZXcqIGZvY3VzZWRW aWV3ID0gMDsKLSAgICBmb3IgKGludCBpID0gMDsgaSA8IHZpZXdDb3VudDsgKytpKSB7Ci0gICAg ICAgIGlmICh2aWV3c1tpXS0+aGFzRm9jdXMoKSkgewotICAgICAgICAgICAgZm9jdXNlZFZpZXcg PSB2aWV3c1tpXTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9Ci0gICAgfQotCi0gICAg aWYgKGZvY3VzZWRWaWV3KSB7Ci0gICAgICAgIFFXaWRnZXQqIHdpbmRvdyA9IGZvY3VzZWRWaWV3 LT53aW5kb3coKTsKLSAgICAgICAgRnJpZW5kbHlXaWRnZXQqIGZyaWVuZGx5V2luZG93ID0gc3Rh dGljX2Nhc3Q8RnJpZW5kbHlXaWRnZXQqPih3aW5kb3cpOwotICAgICAgICBmcmllbmRseVdpbmRv dy0+Zm9jdXNOZXh0UHJldkNoaWxkKG5leHQpOwotICAgIH0KLX0KLQotLyohIFxyZWltcAotKi8K LWJvb2wgUVRvdWNoV2ViUGFnZTo6Zm9jdXNOZXh0UHJldkNoaWxkKGJvb2wgbmV4dCkKLXsKLSNp ZiAwCi0gICAgLy8gRklYTUU6IEtleSBldmVudCBpcyBoYW5kbGVkIGJ5IHRoZSBRdFdlYlBhZ2VQ cm94eSBzdWJjbGFzcy4KLSAgICBRS2V5RXZlbnQgZXYoUUV2ZW50OjpLZXlQcmVzcywgUXQ6Oktl eV9UYWIsIFF0OjpLZXlib2FyZE1vZGlmaWVycyhuZXh0ID8gUXQ6Ok5vTW9kaWZpZXIgOiBRdDo6 U2hpZnRNb2RpZmllcikpOwotICAgIGQtPnBhZ2Uua2V5UHJlc3NFdmVudCgmZXYpOwotI2VuZGlm Ci0gICAgcmV0dXJuIHRydWU7Ci19Ci0KIC8qISBccmVpbXAKICovCiBib29sIFFUb3VjaFdlYlBh Z2U6OmV2ZW50KFFFdmVudCogZXYpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3F0b3VjaHdlYnBhZ2UuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXRvdWNod2VicGFnZS5oCmluZGV4IGE4OGVjYzEwN2UwYTk3ZDFiZGJjYzM2MzY3MWMzNGM0 NjkyYzA0ODkuLjdlZDJjYTNhODJiMWMzODE4ZDc4ZWE3M2I1ODNlNThiMDAwMDJlYzkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXRvdWNod2VicGFnZS5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXRvdWNod2VicGFnZS5oCkBAIC02 OCwxMCArNjgsNiBAQCBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCB2b2lkIHRpbWVyRXZlbnQoUVRp bWVyRXZlbnQqKTsKICAgICB2aXJ0dWFsIHZvaWQgcmVzaXplRXZlbnQoUUdyYXBoaWNzU2NlbmVS ZXNpemVFdmVudCopOwogCi0gICAgUV9TTE9UIHZvaWQgZm9jdXNOZXh0UHJldkNoaWxkQ2FsbGJh Y2soYm9vbCBuZXh0KTsKLQotICAgIHZpcnR1YWwgYm9vbCBmb2N1c05leHRQcmV2Q2hpbGQoYm9v bCBuZXh0KTsKLQogcHJpdmF0ZToKICAgICBRX1BSSVZBVEVfU0xPVChkLCB2b2lkIG9uU2NhbGVD aGFuZ2VkKCkpCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9DbGll bnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9DbGllbnRJbXBsLmNwcApp bmRleCA3ZmRmZTZmYTBkOTYzZGEwYjM4YWU1MTk5Yjk2NzBhZGUyZmFhYjIyLi43YjM0Y2E0MWYy NGQ2YWJkZjIxZDY4MWM5NDcxZDNiMDI2Y2RlMDQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvcXQvQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL3F0L0NsaWVudEltcGwuY3BwCkBAIC0xNzEsNyArMTcxLDYgQEAgdm9pZCBxdF93a19jbG9z ZShXS1BhZ2VSZWYgcGFnZSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykKIAogdm9pZCBxdF93a190 YWtlRm9jdXMoV0tQYWdlUmVmIHBhZ2UsIFdLRm9jdXNEaXJlY3Rpb24gZGlyZWN0aW9uLCBjb25z dCB2b2lkICpjbGllbnRJbmZvKQogewotICAgIGVtaXQgdG9RdFdlYlBhZ2VQcm94eShjbGllbnRJ bmZvKS0+Zm9jdXNOZXh0UHJldkNoaWxkKGRpcmVjdGlvbiA9PSBrV0tGb2N1c0RpcmVjdGlvbkZv cndhcmQpOwogfQogCiB2b2lkIHF0X3drX3J1bkphdmFTY3JpcHRBbGVydChXS1BhZ2VSZWYgcGFn ZSwgV0tTdHJpbmdSZWYgYWxlcnRUZXh0LCBXS0ZyYW1lUmVmIGZyYW1lLCBjb25zdCB2b2lkKiBj bGllbnRJbmZvKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2Vi UGFnZVByb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHku aAppbmRleCA1NzVmZDJjMTM4MDI0MGI5MWQwOWFkMzM0YTdiM2ZiZjI2Y2RmM2MzLi5kODEwM2U0 OTBhMjc4MjgyODMzMjA3MjFkYjZmZWUyZTQ4Mzg3ZThlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuaApAQCAtMTk3LDcgKzE5Nyw2IEBAIHB1YmxpYzoK ICAgICBRX1NJR05BTCB2b2lkIHNjcm9sbFJlcXVlc3RlZChpbnQgZHgsIGludCBkeSk7CiAgICAg UV9TSUdOQUwgdm9pZCB3aW5kb3dDbG9zZVJlcXVlc3RlZCgpOwogICAgIFFfU0lHTkFMIHZvaWQg em9vbWFibGVBcmVhRm91bmQoY29uc3QgUVJlY3QmKTsKLSAgICBRX1NJR05BTCB2b2lkIGZvY3Vz TmV4dFByZXZDaGlsZChib29sKTsKIAogcHJvdGVjdGVkOgogICAgIHZvaWQgaW5pdCgpOwo=