64273 2011-07-11 06:15:06 -0700 [Qt][WK2] Move zoomable-area-for-point functionality to QTouchWebPageProxy 2011-07-11 06:25:37 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling benjamin kenneth oldest_to_newest 434813 0 kling 2011-07-11 06:15:06 -0700 This API is not interesting for QDesktopWebView, and should be moved to QTouchWeb*. 434814 1 kenneth 2011-07-11 06:16:16 -0700 When doing this, can't you upstream my latest version? 434815 2 100286 kling 2011-07-11 06:16:35 -0700 Created attachment 100286 Proposed patch 434817 3 kling 2011-07-11 06:19:55 -0700 (In reply to comment #1) > When doing this, can't you upstream my latest version? No, please do that yourself. :) 434825 4 100286 kling 2011-07-11 06:25:29 -0700 Comment on attachment 100286 Proposed patch Clearing flags on attachment: 100286 Committed r90739: <http://trac.webkit.org/changeset/90739> 434826 5 kling 2011-07-11 06:25:37 -0700 All reviewed patches have been landed. Closing bug. 100286 2011-07-11 06:16:35 -0700 2011-07-11 06:25:29 -0700 Proposed patch bug-64273.diff text/plain 5160 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4NjU2NTJiLi5lNzJlZTlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMDctMTEgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFtRdF1bV0syXSBNb3ZlIHpvb21hYmxlLWFyZWEtZm9yLXBvaW50IGZ1bmN0aW9uYWxpdHkg dG8gUVRvdWNoV2ViUGFnZVByb3h5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NDI3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAg KiBVSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQv cWRlc2t0b3B3ZWJwYWdlcHJveHkuY3BwOgorICAgICAgICAoUURlc2t0b3BXZWJQYWdlUHJveHk6 OmRpZEZpbmRab29tYWJsZUFyZWEpOgorICAgICAgICAqIFVJUHJvY2Vzcy9xdC9xZGVza3RvcHdl YnBhZ2Vwcm94eS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9xdC9xdG91Y2h3ZWJwYWdlcHJveHku Y3BwOgorICAgICAgICAoUVRvdWNoV2ViUGFnZVByb3h5OjpmaW5kWm9vbWFibGVBcmVhRm9yUG9p bnQpOgorICAgICAgICAoUVRvdWNoV2ViUGFnZVByb3h5OjpkaWRGaW5kWm9vbWFibGVBcmVhKToK KyAgICAgICAgKiBVSVByb2Nlc3MvcXQvcXRvdWNod2VicGFnZXByb3h5Lmg6CisKIDIwMTEtMDct MTAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJL aXQyIGlzIGxlYWtpbmcgTlNDdXJzb3JzIGNyZWF0ZWQgYnkgbGVha05hbWVkQ3Vyc29yCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmNwcAppbmRleCAwOTI2 MzU2Li5mNTA3YjAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRX ZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBh Z2VQcm94eS5jcHAKQEAgLTc0NSwxNiArNzQ1LDYgQEAgUUFjdGlvbiogUXRXZWJQYWdlUHJveHk6 OmFjdGlvbihXZWJBY3Rpb24gYWN0aW9uKSBjb25zdAogICAgIHJldHVybiBhOwogfQogCi12b2lk IFF0V2ViUGFnZVByb3h5OjpmaW5kWm9vbWFibGVBcmVhRm9yUG9pbnQoY29uc3QgUVBvaW50JiBw b2ludCkKLXsKLSAgICBtX3dlYlBhZ2VQcm94eS0+ZmluZFpvb21hYmxlQXJlYUZvclBvaW50KHBv aW50KTsKLX0KLQotdm9pZCBRdFdlYlBhZ2VQcm94eTo6ZGlkRmluZFpvb21hYmxlQXJlYShjb25z dCBJbnRSZWN0JiBhcmVhKQotewotICAgIGVtaXQgem9vbWFibGVBcmVhRm91bmQoUVJlY3QoYXJl YSkpOwotfQotCiB2b2lkIFF0V2ViUGFnZVByb3h5OjpzdGFydERyYWcoY29uc3QgV2ViQ29yZTo6 RHJhZ0RhdGEmIGRyYWdEYXRhLCBQYXNzUmVmUHRyPFNoYXJlYWJsZUJpdG1hcD4gZHJhZ0ltYWdl KQogewogICAgIFFJbWFnZSBkcmFnUUltYWdlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv cXQvUXRXZWJQYWdlUHJveHkuaAppbmRleCA0OWExMWQ5Li41NzVmZDJjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuaApAQCAtMTA4LDcgKzEwOCw3IEBA IHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgcGFnZUNsb3NlZCgpIHsgfQogICAgIHZpcnR1YWwg dm9pZCBkaWRSZWxhdW5jaFByb2Nlc3MoKTsKICAgICB2aXJ0dWFsIHZvaWQgZGlkQ2hhbmdlQ29u dGVudHNTaXplKGNvbnN0IFdlYkNvcmU6OkludFNpemUmKTsKLSAgICB2aXJ0dWFsIHZvaWQgZGlk RmluZFpvb21hYmxlQXJlYShjb25zdCBXZWJDb3JlOjpJbnRSZWN0Jik7CisKICAgICB2aXJ0dWFs IHZvaWQgc3RhcnREcmFnKGNvbnN0IFdlYkNvcmU6OkRyYWdEYXRhJiwgUGFzc1JlZlB0cjxTaGFy ZWFibGVCaXRtYXA+IGRyYWdJbWFnZSk7CiAgICAgdmlydHVhbCBXZWJDb3JlOjpJbnRSZWN0IHZp ZXdwb3J0VmlzaWJsZVJlY3QoKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0Q3Vyc29yKGNv bnN0IFdlYkNvcmU6OkN1cnNvciYpOwpAQCAtMTg4LDggKzE4OCw2IEBAIHB1YmxpYzoKIAogICAg IFFXS0hpc3RvcnkqIGhpc3RvcnkoKSBjb25zdDsKIAotICAgIHZvaWQgZmluZFpvb21hYmxlQXJl YUZvclBvaW50KGNvbnN0IFFQb2ludCYpOwotCiAgICAgdm9pZCBzZXRQYWdlSXNWaXNpYmxlKGJv b2wpOwogCiBwdWJsaWMgUV9TTE9UUzoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9xdC9xZGVza3RvcHdlYnBhZ2Vwcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvcXQvcWRlc2t0b3B3ZWJwYWdlcHJveHkuY3BwCmluZGV4IGRiM2VjNGQuLjQ3MTYxYmIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9xZGVza3RvcHdlYnBhZ2Vwcm94 eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L3FkZXNrdG9wd2VicGFnZXBy b3h5LmNwcApAQCAtMjI1LDMgKzIyNSw4IEBAIHZvaWQgUURlc2t0b3BXZWJQYWdlUHJveHk6OnRp bWVyRXZlbnQoUVRpbWVyRXZlbnQqIGV2KQogICAgIGVsc2UKICAgICAgICAgUU9iamVjdDo6dGlt ZXJFdmVudChldik7CiB9CisKK3ZvaWQgUURlc2t0b3BXZWJQYWdlUHJveHk6OmRpZEZpbmRab29t YWJsZUFyZWEoY29uc3QgSW50UmVjdCYpCit7CisgICAgLy8gVGhpcyBmZWF0dXJlIGlzIG9ubHkg dXNlZCBieSBRVG91Y2hXZWJWaWV3LgorfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL3F0L3FkZXNrdG9wd2VicGFnZXByb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvcXQvcWRlc2t0b3B3ZWJwYWdlcHJveHkuaAppbmRleCA0ODM1YjU3Li5mZGE0YzA0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvcWRlc2t0b3B3ZWJwYWdlcHJveHku aAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvcWRlc2t0b3B3ZWJwYWdlcHJveHku aApAQCAtNDYsNiArNDYsNyBAQCBwcml2YXRlOgogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCiAg ICAgdmlydHVhbCB2b2lkIGRvbmVXaXRoVG91Y2hFdmVudChjb25zdCBOYXRpdmVXZWJUb3VjaEV2 ZW50JiwgYm9vbCB3YXNFdmVudEhhbmRsZWQpOwogI2VuZGlmCisgICAgdmlydHVhbCB2b2lkIGRp ZEZpbmRab29tYWJsZUFyZWEoY29uc3QgV2ViQ29yZTo6SW50UmVjdCYpOwogCiAgICAgdmlydHVh bCB2b2lkIHRpbWVyRXZlbnQoUVRpbWVyRXZlbnQqKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL3F0L3F0b3VjaHdlYnBhZ2Vwcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvcXQvcXRvdWNod2VicGFnZXByb3h5LmNwcAppbmRleCAzZDdhNDhjLi45YWJj YmRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvcXRvdWNod2VicGFn ZXByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvcXRvdWNod2VicGFn ZXByb3h5LmNwcApAQCAtOTYsMyArOTYsMTMgQEAgdm9pZCBRVG91Y2hXZWJQYWdlUHJveHk6OnRv dWNoRXZlbnQoUVRvdWNoRXZlbnQqIGV2ZW50KQogICAgIGV2LT5pZ25vcmUoKTsKICNlbmRpZgog fQorCit2b2lkIFFUb3VjaFdlYlBhZ2VQcm94eTo6ZmluZFpvb21hYmxlQXJlYUZvclBvaW50KGNv bnN0IFFQb2ludCYgcG9pbnQpCit7CisgICAgbV93ZWJQYWdlUHJveHktPmZpbmRab29tYWJsZUFy ZWFGb3JQb2ludChwb2ludCk7Cit9CisKK3ZvaWQgUVRvdWNoV2ViUGFnZVByb3h5OjpkaWRGaW5k Wm9vbWFibGVBcmVhKGNvbnN0IEludFJlY3QmIGFyZWEpCit7CisgICAgZW1pdCB6b29tYWJsZUFy ZWFGb3VuZChRUmVjdChhcmVhKSk7Cit9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvcXQvcXRvdWNod2VicGFnZXByb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv cXQvcXRvdWNod2VicGFnZXByb3h5LmgKaW5kZXggYTQwMjVlNS4uNDU2OGYyNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L3F0b3VjaHdlYnBhZ2Vwcm94eS5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9xdG91Y2h3ZWJwYWdlcHJveHkuaApAQCAtMzks NiArMzksNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGhhbmRsZUV2ZW50KFFFdmVudCop OwogCiAgICAgdm9pZCBzZXRSZXNpemVzVG9Db250ZW50c1VzaW5nTGF5b3V0U2l6ZShjb25zdCBR U2l6ZSYgdGFyZ2V0TGF5b3V0U2l6ZSk7CisgICAgdm9pZCBmaW5kWm9vbWFibGVBcmVhRm9yUG9p bnQoY29uc3QgUVBvaW50Jik7CiAKIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIHZvaWQgcGFpbnRD b250ZW50KFFQYWludGVyKiBwYWludGVyLCBjb25zdCBRUmVjdCYgYXJlYSk7CkBAIC01MCw2ICs1 MSw3IEBAIHByaXZhdGU6CiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKICAgICB2aXJ0dWFsIHZv aWQgZG9uZVdpdGhUb3VjaEV2ZW50KGNvbnN0IE5hdGl2ZVdlYlRvdWNoRXZlbnQmLCBib29sIHdh c0V2ZW50SGFuZGxlZCk7CiAjZW5kaWYKKyAgICB2aXJ0dWFsIHZvaWQgZGlkRmluZFpvb21hYmxl QXJlYShjb25zdCBXZWJDb3JlOjpJbnRSZWN0Jik7CiAKICAgICBUb3VjaFZpZXdJbnRlcmZhY2Uq IHRvdWNoVmlld0ludGVyZmFjZSgpIGNvbnN0IHsgcmV0dXJuIHN0YXRpY19jYXN0PFRvdWNoVmll d0ludGVyZmFjZSo+KG1fdmlld0ludGVyZmFjZSk7IH0KICAgICBRVG91Y2hXZWJQYWdlKiBwYWdl VmlldygpIGNvbnN0IHsgcmV0dXJuIHN0YXRpY19jYXN0PFFUb3VjaFdlYlBhZ2UqPih0b3VjaFZp ZXdJbnRlcmZhY2UoKS0+cGFnZVZpZXcoKSk7IH0K