64261 2011-07-11 04:36:14 -0700 Fix the condition of the optimized code in doubleTransfer 2011-07-11 10:23:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 loki webkit-unassigned webkit.review.bot zherczeg oldest_to_newest 434754 0 loki 2011-07-11 04:36:14 -0700 The condition of the optimized code in doubleTransfer is wrong on ARM. The data transfer should be executed with four bytes aligned address. VFP cannot perform unaligned memory access. 434756 1 100265 loki 2011-07-11 04:38:06 -0700 Created attachment 100265 Fix the condition of the optimized code in doubleTransfer 434761 2 100265 zherczeg 2011-07-11 04:50:32 -0700 Comment on attachment 100265 Fix the condition of the optimized code in doubleTransfer Nice catch. 434801 3 100265 webkit.review.bot 2011-07-11 05:32:31 -0700 Comment on attachment 100265 Fix the condition of the optimized code in doubleTransfer Clearing flags on attachment: 100265 Committed r90738: <http://trac.webkit.org/changeset/90738> 434802 4 webkit.review.bot 2011-07-11 05:32:35 -0700 All reviewed patches have been landed. Closing bug. 434967 5 ap 2011-07-11 10:18:54 -0700 Regression test? 434972 6 zherczeg 2011-07-11 10:23:06 -0700 (In reply to comment #5) > Regression test? Basically all math tests are regression tests. This was a typo, which prevented to use the fast path on ARM, and generated multiple instructions even when one is enough. 100265 2011-07-11 04:38:06 -0700 2011-07-11 05:32:31 -0700 Fix the condition of the optimized code in doubleTransfer 0001-Fix-the-condition-of-the-optimized-code-in-doubleTra.patch text/plain 2439 loki RnJvbSBmMTE3MmI5MjM4MTE2OGI0NmYxMGI4NGI3ZWViZTlhOGNlNjg1NDYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogTW9uLCAxMSBKdWwgMjAxMSAxMzoyODowMCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTEt MDctMTEgIEdhYm9yIExva2kgIDxsb2tpQHdlYmtpdC5vcmc+CgogICAgICAgIEZpeCB0aGUgY29u ZGl0aW9uIG9mIHRoZSBvcHRpbWl6ZWQgY29kZSBpbiBkb3VibGVUcmFuc2ZlcgogICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDI2MQoKICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgVGhlIGNvbmRpdGlvbiBvZiB0aGUgb3B0 aW1pemVkIGNvZGUgaW4gZG91YmxlVHJhbnNmZXIgaXMgd3JvbmcuIFRoZQogICAgICAgIGRhdGEg dHJhbnNmZXIgc2hvdWxkIGJlIGV4ZWN1dGVkIHdpdGggZm91ciBieXRlcyBhbGlnbmVkIGFkZHJl c3MuCiAgICAgICAgVkZQIGNhbm5vdCBwZXJmb3JtIHVuYWxpZ25lZCBtZW1vcnkgYWNjZXNzLgoK ICAgICAgICBSZXBvcnRlZCBieSBKYWNvYiBCcmFtbGV5LgoKICAgICAgICAqIGFzc2VtYmxlci9B Uk1Bc3NlbWJsZXIuY3BwOgogICAgICAgIChKU0M6OkFSTUFzc2VtYmxlcjo6ZG91YmxlVHJhbnNm ZXIpOgoKLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgfCAgIDE0ICsrKysrKysrKysrKysrCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L0FSTUFzc2VtYmxlci5jcHAgfCAgICAzICsrLQogMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGE4MDhh NDguLjdjOGUwZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisy MDExLTA3LTExICBHYWJvciBMb2tpICA8bG9raUB3ZWJraXQub3JnPgorCisgICAgICAgIEZpeCB0 aGUgY29uZGl0aW9uIG9mIHRoZSBvcHRpbWl6ZWQgY29kZSBpbiBkb3VibGVUcmFuc2ZlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQyNjEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY29uZGl0aW9u IG9mIHRoZSBvcHRpbWl6ZWQgY29kZSBpbiBkb3VibGVUcmFuc2ZlciBpcyB3cm9uZy4gVGhlCisg ICAgICAgIGRhdGEgdHJhbnNmZXIgc2hvdWxkIGJlIGV4ZWN1dGVkIHdpdGggZm91ciBieXRlcyBh bGlnbmVkIGFkZHJlc3MuCisgICAgICAgIFZGUCBjYW5ub3QgcGVyZm9ybSB1bmFsaWduZWQgbWVt b3J5IGFjY2Vzcy4KKworICAgICAgICBSZXBvcnRlZCBieSBKYWNvYiBCcmFtbGV5LgorCisgICAg ICAgICogYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5jcHA6CisgICAgICAgIChKU0M6OkFSTUFzc2Vt Ymxlcjo6ZG91YmxlVHJhbnNmZXIpOgorCiAyMDExLTA3LTExICBHYWJvciBMb2tpICA8bG9raUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFNpZ25lZCBhcml0aG1ldGljIGJ1ZyBpbiBkYXRhVHJhbnNm ZXIzMi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNz ZW1ibGVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVy LmNwcAppbmRleCA3NTQzNTg2Li5lNjI2Y2Q3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuY3BwCkBAIC0zMTMsNyArMzEzLDggQEAgdm9pZCBB Uk1Bc3NlbWJsZXI6OmJhc2VJbmRleFRyYW5zZmVyMzIoYm9vbCBpc0xvYWQsIFJlZ2lzdGVySUQg c3JjRHN0LCBSZWdpc3RlckkKIAogdm9pZCBBUk1Bc3NlbWJsZXI6OmRvdWJsZVRyYW5zZmVyKGJv b2wgaXNMb2FkLCBGUFJlZ2lzdGVySUQgc3JjRHN0LCBSZWdpc3RlcklEIGJhc2UsIGludDMyX3Qg b2Zmc2V0KQogewotICAgIGlmIChvZmZzZXQgJiAweDMpIHsKKyAgICAvLyBWRlAgY2Fubm90IGRp cmVjdGx5IGFjY2VzcyBtZW1vcnkgdGhhdCBpcyBub3QgZm91ci1ieXRlLWFsaWduZWQKKyAgICBp ZiAoIShvZmZzZXQgJiAweDMpKSB7CiAgICAgICAgIGlmIChvZmZzZXQgPD0gMHgzZmYgJiYgb2Zm c2V0ID49IDApIHsKICAgICAgICAgICAgIGZkdHJfdShpc0xvYWQsIHNyY0RzdCwgYmFzZSwgb2Zm c2V0ID4+IDIpOwogICAgICAgICAgICAgcmV0dXJuOwotLSAKMS43LjQuMQoK