64245 2011-07-10 14:02:26 -0700 Cleanup TilingData::textureOffset 2011-07-12 22:13:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reveman reveman enne jamesr ojan webkit.review.bot oldest_to_newest 434616 0 reveman 2011-07-10 14:02:26 -0700 Cleanup TilingData::textureOffset 434617 1 100237 reveman 2011-07-10 14:03:32 -0700 Created attachment 100237 Patch 434618 2 webkit.review.bot 2011-07-10 14:06:17 -0700 Attachment 100237 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 434619 3 100238 reveman 2011-07-10 14:07:24 -0700 Created attachment 100238 Patch 434638 4 100238 bfulgham 2011-07-10 18:46:57 -0700 Comment on attachment 100238 Patch What were the two indices used for previously? Was the original design such that the tiling data would hold multiple textures? At any rate, this looks fine to me. 434641 5 reveman 2011-07-10 18:59:32 -0700 (In reply to comment #4) > (From update of attachment 100238 [details]) > What were the two indices used for previously? Was the original design such that the tiling data would hold multiple textures? The texture offset previously depended on the tile index. This is not the case since r90646. Landed r90653 Friday as a minimal change to just fix the build. This is just a proper cleanup of that change. 436249 6 100238 webkit.review.bot 2011-07-12 22:13:10 -0700 Comment on attachment 100238 Patch Clearing flags on attachment: 100238 Committed r90886: <http://trac.webkit.org/changeset/90886> 436250 7 webkit.review.bot 2011-07-12 22:13:14 -0700 All reviewed patches have been landed. Closing bug. 100237 2011-07-10 14:03:32 -0700 2011-07-10 14:07:18 -0700 Patch bug-64245-20110710170330.patch text/plain 2918 reveman SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwNjk5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDctMTAgIERhdmlkIFJl dmVtYW4gIDxyZXZlbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmVkIHVubmVjZXNz YXJ5IGZ1bmN0aW9uIHBhcmFtZXRlcnMgZnJvbSBUaWxpbmdEYXRhOjp0ZXh0dXJlT2Zmc2V0Lgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cywgbm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2VzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkxheWVyVGlsZXJDaHJvbWl1bTo6ZHJhd1RpbGVzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9ncHUvVGlsaW5nRGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUaWxpbmdEYXRhOjp0 ZXh0dXJlT2Zmc2V0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvVGlsaW5nRGF0 YS5oOgorCiAyMDExLTA3LTEwICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBTd2l0Y2ggdXBkYXRlSGl0VGVzdFJlc3VsdCB0byB0byBuZXcgbGF5b3V0IHR5cGVz CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclRp bGVyQ2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL0xheWVyVGlsZXJDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDkwNjk5KQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxlckNo cm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTM3LDcgKzUzNyw3IEBAIHZvaWQgTGF5ZXJU aWxlckNocm9taXVtOjpkcmF3VGlsZXMoY29uc3QKICAgICAgICAgICAgIEludFJlY3QgdGlsZVJl Y3QgPSBtX3RpbGluZ0RhdGEudGlsZUJvdW5kcyhtX3RpbGluZ0RhdGEudGlsZUluZGV4KHRpbGUt PmkoKSwgdGlsZS0+aigpKSk7CiAgICAgICAgICAgICB0aWxlUmVjdC5tb3ZlKG1fbGF5ZXJQb3Np dGlvbi54KCksIG1fbGF5ZXJQb3NpdGlvbi55KCkpOwogCi0gICAgICAgICAgICBJbnRQb2ludCB0 ZXhPZmZzZXQgPSBtX3RpbGluZ0RhdGEudGV4dHVyZU9mZnNldCh0aWxlLT5pKCksIHRpbGUtPmoo KSk7CisgICAgICAgICAgICBJbnRQb2ludCB0ZXhPZmZzZXQgPSBtX3RpbGluZ0RhdGEudGV4dHVy ZU9mZnNldCgpOwogICAgICAgICAgICAgSW50UmVjdCB0ZXhSZWN0ID0gdGlsZVRleFJlY3QodGls ZSk7CiAgICAgICAgICAgICBmbG9hdCB0aWxlV2lkdGggPSBzdGF0aWNfY2FzdDxmbG9hdD4odGV4 UmVjdC53aWR0aCgpKTsKICAgICAgICAgICAgIGZsb2F0IHRpbGVIZWlnaHQgPSBzdGF0aWNfY2Fz dDxmbG9hdD4odGV4UmVjdC5oZWlnaHQoKSk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9ncHUvVGlsaW5nRGF0YS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1RpbGluZ0RhdGEuY3BwCShyZXZpc2lvbiA5MDY5OSkK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjQ4LDcgKzI0OCw3IEBAIHZvaWQgVGlsaW5nRGF0YTo6aW50ZXJz ZWN0RHJhd1F1YWQoY29uc3QKICAgICAgICAgc3JjUmVjdEludGVyc2VjdGVkTm9ybUggKiBkc3RS ZWN0LmhlaWdodCgpKTsKIH0KIAotSW50UG9pbnQgVGlsaW5nRGF0YTo6dGV4dHVyZU9mZnNldChp bnQsIGludCkgY29uc3QKK0ludFBvaW50IFRpbGluZ0RhdGE6OnRleHR1cmVPZmZzZXQoKSBjb25z dAogewogICAgIHJldHVybiBJbnRQb2ludChtX2JvcmRlclRleGVscywgbV9ib3JkZXJUZXhlbHMp OwogfQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1RpbGluZ0Rh dGEuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUv VGlsaW5nRGF0YS5oCShyZXZpc2lvbiA5MDY5OSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmgJKHdvcmtpbmcgY29weSkKQEAgLTc1LDcgKzc1LDcg QEAgcHVibGljOgogICAgIHZvaWQgaW50ZXJzZWN0RHJhd1F1YWQoY29uc3QgRmxvYXRSZWN0JiBz cmNSZWN0LCBjb25zdCBGbG9hdFJlY3QmIGRzdFJlY3QsIGludCB0aWxlLCBGbG9hdFJlY3QqIG5l d1NyYywgRmxvYXRSZWN0KiBuZXdEc3QpIGNvbnN0OwogCiAgICAgLy8gRGlmZmVyZW5jZSBiZXR3 ZWVuIHRpbGVCb3VuZCdzIGFuZCB0aWxlQm91bmRXaXRoQm9yZGVyJ3MgbG9jYXRpb24oKS4KLSAg ICBJbnRQb2ludCB0ZXh0dXJlT2Zmc2V0KGludCB4SW5kZXgsIGludCB5SW5kZXgpIGNvbnN0Owor ICAgIEludFBvaW50IHRleHR1cmVPZmZzZXQoKSBjb25zdDsKIAogcHJpdmF0ZToKICAgICBUaWxp bmdEYXRhKCkgOiBtX21heFRleHR1cmVTaXplKDApLCBtX3RvdGFsU2l6ZVgoMCksIG1fdG90YWxT aXplWSgwKSB7fQo= 100238 2011-07-10 14:07:24 -0700 2011-07-12 22:13:10 -0700 Patch bug-64245-20110710170723.patch text/plain 2973 reveman SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwNjk5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDctMTAgIERhdmlkIFJl dmVtYW4gIDxyZXZlbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmVkIHVubmVjZXNz YXJ5IGZ1bmN0aW9uIHBhcmFtZXRlcnMgZnJvbSBUaWxpbmdEYXRhOjp0ZXh0dXJlT2Zmc2V0Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQyNDUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMsIG5vIGZ1bmN0aW9uYWxpdHkgY2hhbmdlcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0xheWVyVGlsZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpM YXllclRpbGVyQ2hyb21pdW06OmRyYXdUaWxlcyk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvZ3B1L1RpbGluZ0RhdGEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGlsaW5nRGF0YTo6dGV4 dHVyZU9mZnNldCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1RpbGluZ0RhdGEu aDoKKwogMjAxMS0wNy0xMCAgRW1pbCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgU3dpdGNoIHVwZGF0ZUhpdFRlc3RSZXN1bHQgdG8gdG8gbmV3IGxheW91dCB0eXBlcwpJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxl ckNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uY3BwCShyZXZpc2lvbiA5MDY5OSkKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyVGlsZXJDaHJv bWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzNyw3ICs1MzcsNyBAQCB2b2lkIExheWVyVGls ZXJDaHJvbWl1bTo6ZHJhd1RpbGVzKGNvbnN0CiAgICAgICAgICAgICBJbnRSZWN0IHRpbGVSZWN0 ID0gbV90aWxpbmdEYXRhLnRpbGVCb3VuZHMobV90aWxpbmdEYXRhLnRpbGVJbmRleCh0aWxlLT5p KCksIHRpbGUtPmooKSkpOwogICAgICAgICAgICAgdGlsZVJlY3QubW92ZShtX2xheWVyUG9zaXRp b24ueCgpLCBtX2xheWVyUG9zaXRpb24ueSgpKTsKIAotICAgICAgICAgICAgSW50UG9pbnQgdGV4 T2Zmc2V0ID0gbV90aWxpbmdEYXRhLnRleHR1cmVPZmZzZXQodGlsZS0+aSgpLCB0aWxlLT5qKCkp OworICAgICAgICAgICAgSW50UG9pbnQgdGV4T2Zmc2V0ID0gbV90aWxpbmdEYXRhLnRleHR1cmVP ZmZzZXQoKTsKICAgICAgICAgICAgIEludFJlY3QgdGV4UmVjdCA9IHRpbGVUZXhSZWN0KHRpbGUp OwogICAgICAgICAgICAgZmxvYXQgdGlsZVdpZHRoID0gc3RhdGljX2Nhc3Q8ZmxvYXQ+KHRleFJl Y3Qud2lkdGgoKSk7CiAgICAgICAgICAgICBmbG9hdCB0aWxlSGVpZ2h0ID0gc3RhdGljX2Nhc3Q8 ZmxvYXQ+KHRleFJlY3QuaGVpZ2h0KCkpOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3B1L1RpbGluZ0RhdGEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcAkocmV2aXNpb24gOTA2OTkpCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvVGlsaW5nRGF0YS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTI0OCw3ICsyNDgsNyBAQCB2b2lkIFRpbGluZ0RhdGE6OmludGVyc2Vj dERyYXdRdWFkKGNvbnN0CiAgICAgICAgIHNyY1JlY3RJbnRlcnNlY3RlZE5vcm1IICogZHN0UmVj dC5oZWlnaHQoKSk7CiB9CiAKLUludFBvaW50IFRpbGluZ0RhdGE6OnRleHR1cmVPZmZzZXQoaW50 LCBpbnQpIGNvbnN0CitJbnRQb2ludCBUaWxpbmdEYXRhOjp0ZXh0dXJlT2Zmc2V0KCkgY29uc3QK IHsKICAgICByZXR1cm4gSW50UG9pbnQobV9ib3JkZXJUZXhlbHMsIG1fYm9yZGVyVGV4ZWxzKTsK IH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRh LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1Rp bGluZ0RhdGEuaAkocmV2aXNpb24gOTA2OTkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9ncHUvVGlsaW5nRGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC03NSw3ICs3NSw3IEBA IHB1YmxpYzoKICAgICB2b2lkIGludGVyc2VjdERyYXdRdWFkKGNvbnN0IEZsb2F0UmVjdCYgc3Jj UmVjdCwgY29uc3QgRmxvYXRSZWN0JiBkc3RSZWN0LCBpbnQgdGlsZSwgRmxvYXRSZWN0KiBuZXdT cmMsIEZsb2F0UmVjdCogbmV3RHN0KSBjb25zdDsKIAogICAgIC8vIERpZmZlcmVuY2UgYmV0d2Vl biB0aWxlQm91bmQncyBhbmQgdGlsZUJvdW5kV2l0aEJvcmRlcidzIGxvY2F0aW9uKCkuCi0gICAg SW50UG9pbnQgdGV4dHVyZU9mZnNldChpbnQgeEluZGV4LCBpbnQgeUluZGV4KSBjb25zdDsKKyAg ICBJbnRQb2ludCB0ZXh0dXJlT2Zmc2V0KCkgY29uc3Q7CiAKIHByaXZhdGU6CiAgICAgVGlsaW5n RGF0YSgpIDogbV9tYXhUZXh0dXJlU2l6ZSgwKSwgbV90b3RhbFNpemVYKDApLCBtX3RvdGFsU2l6 ZVkoMCkge30K