64180 2011-07-08 11:05:09 -0700 REGRESSION (r90564): test-webkitpy failing on multiple bots due to commit-log-editor errors 2011-07-08 11:51:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aroben aroben abarth eric webkit.review.bot oldest_to_newest 434156 0 aroben 2011-07-08 11:05:09 -0700 REGRESSION (r90564): test-webkitpy failing on multiple bots due to commit-log-editor errors 434157 1 100135 aroben 2011-07-08 11:07:15 -0700 Created attachment 100135 Patch 434159 2 100135 abarth 2011-07-08 11:09:11 -0700 Comment on attachment 100135 Patch Ok. Do I need to make sure this env variable is set on the commit bots? 434179 3 aroben 2011-07-08 11:20:51 -0700 (In reply to comment #2) > (From update of attachment 100135 [details]) > Ok. Do I need to make sure this env variable is set on the commit bots? No. You already ensured the git variable user.name is set, which is used as a fallback. 434192 4 100135 eric 2011-07-08 11:34:59 -0700 Comment on attachment 100135 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100135&action=review > Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py:129 > + kwargs['env'] = env You can just pass it as env=env and it will automagically end up on the other side as part of kwargs. **kwargs is expanding the "kwargs" dictionary (not a special name) to be named args. 434200 5 eric 2011-07-08 11:46:31 -0700 ** can be used to either stuff all the named args into a dictionary (of any name of your choosing, although conventionally kwargs) or to expand a dictionary into named args when calling a function. so defining a function as: def foo(*blah, **moreblah) will take all the non-named args, and put them into a tuple() blah, and all the named args and put them into a dict() moreblah Calling *listname will expand an arglist into a list of args, but only during a function call it seems. I thought * was a generic "expand tuple" operator, but I've since learned this morning it's just part of the language grammar. :) http://docs.python.org/reference/expressions.html#calls 434201 6 100135 webkit.review.bot 2011-07-08 11:48:03 -0700 Comment on attachment 100135 Patch Clearing flags on attachment: 100135 Committed r90648: <http://trac.webkit.org/changeset/90648> 434202 7 webkit.review.bot 2011-07-08 11:48:09 -0700 All reviewed patches have been landed. Closing bug. 434203 8 100135 aroben 2011-07-08 11:51:39 -0700 Comment on attachment 100135 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100135&action=review >> Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py:129 >> + kwargs['env'] = env > > You can just pass it as env=env and it will automagically end up on the other side as part of kwargs. **kwargs is expanding the "kwargs" dictionary (not a special name) to be named args. If kwargs happens to already contain a value for 'env' then passing env=env will cause a runtime error. 100135 2011-07-08 11:07:15 -0700 2011-07-08 11:51:38 -0700 Patch bug-64180-20110708140712.patch text/plain 2174 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogOTA2NDAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2YTc3NTdlNWVmMjM4ODcxMzEzZDUxYjM1ZjQ1M2RkZjVj OTZiYjhiLi5mZTNjZTJhZjgyMTFiZTFjNzQ2YmQzZDA4NGMyMTk5YjY2ODVkZGQ2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg QEAKIDIwMTEtMDctMDggIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCisgICAgICAg IEVuc3VyZSAkQ0hBTkdFX0xPR19FTUFJTF9BRERSRVNTIGlzIHNldCB3aGVuIHRlc3Rpbmcgd2Vi a2l0cHkncyBjb21taXQtbG9nLWVkaXRvciBpbnRlZ3JhdGlvbgorCisgICAgICAgIEZpeGVzIDxo dHRwOi8vd2Via2l0Lm9yZy9iLzY0MTgwPiBSRUdSRVNTSU9OIChyOTA1NjQpOiB0ZXN0LXdlYmtp dHB5IGZhaWxpbmcgb24gbXVsdGlwbGUKKyAgICAgICAgYm90cyBkdWUgdG8gY29tbWl0LWxvZy1l ZGl0b3IgZXJyb3JzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGVja291dF91bml0dGVz dC5weToKKyAgICAgICAgKENvbW1pdE1lc3NhZ2VGb3JUaGlzQ29tbWl0VGVzdC50ZXN0X2NvbW1p dF9tZXNzYWdlX2Zvcl90aGlzX2NvbW1pdCk6IFNldAorICAgICAgICAkQ0hBTkdFX0xPR19FTUFJ TF9BRERSRVNTIHRvIHRoZSBwYXRjaCBhdXRob3IncyBlbWFpbCBhZGRyZXNzLiBUaGlzIGVuc3Vy ZXMgdGhhdAorICAgICAgICBjb21taXQtbG9nLWVkaXRvciBjYW4gZmluZCBhIHZhbHVlIGZvciB0 aGUgY29tbWl0dGVyJ3MgZW1haWwsIGFuZCB0aGF0IHRoZSBjb21taXR0ZXIgYW5kCisgICAgICAg IGF1dGhvciBlbWFpbCBhZGRyZXNzZXMgbWF0Y2gsIHdoaWNoIHdpbGwgcHJldmVudCBjb21taXQt bG9nLWVkaXRvciBmcm9tIGluc2VydGluZyBhICJQYXRjaAorICAgICAgICBieSIgbGluZSBpbiB0 aGUgY29tbWl0IG1lc3NhZ2UuCisKKzIwMTEtMDctMDggIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBw bGUuY29tPgorCiAgICAgICAgIFRlYWNoIFRlc3RGYWlsdXJlcyBob3cgdG8gZmluZCB0ZXN0IG5h bWVzIGluIGNvbW1pdC1sb2ctZWRpdG9yLXN0eWxlIGNvbW1pdCBtZXNzYWdlcwogCiAgICAgICAg IFRlc3RGYWlsdXJlcyB3YXMgcmVseWluZyBvbiBUcmFjIHR1cm5pbmcgdGhlIGxpc3Qgb2YgbW9k aWZpZWQgZmlsZXMgaW4gb3VyIGNvbW1pdCBtZXNzYWdlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hlY2tvdXRfdW5pdHRlc3QucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGVja291dF91bml0dGVzdC5weQpp bmRleCA0ZjIyNmZmZWIyZDRkNzFhMDJiOWYyMWExYTM4OWVlYzQ4NDg3ZTNkLi40NjMyOWFhNmI5 OTMwNzZjYzQ4ZDBhZWY4ZDVjNDE2OWI5ZTRhM2FmIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGVja291dF91bml0dGVzdC5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGVja291dF91bml0dGVzdC5weQpA QCAtMTI0LDYgKzEyNCw5IEBAIFNlY29uZCBwYXJ0IG9mIHRoaXMgY29tcGxpY2F0ZWQgY2hhbmdl IGJ5IG1lLCBUb3IgQXJuZSBWZXN0Ylx1MDBmOCEKICAgICAgICAgZGVmIG1vY2tfcnVuKCphcmdz LCAqKmt3YXJncyk6CiAgICAgICAgICAgICAjIE5vdGUgdGhhdCB3ZSB1c2UgYSByZWFsIEV4ZWN1 dGl2ZSBoZXJlLCBub3QgYSBNb2NrRXhlY3V0aXZlLCBzbyB3ZSBjYW4gdGVzdCB0aGF0IHdlJ3Jl CiAgICAgICAgICAgICAjIGludm9raW5nIGNvbW1pdC1sb2ctZWRpdG9yIGNvcnJlY3RseS4KKyAg ICAgICAgICAgIGVudiA9IG9zLmVudmlyb24uY29weSgpCisgICAgICAgICAgICBlbnZbJ0NIQU5H RV9MT0dfRU1BSUxfQUREUkVTUyddID0gJ3Zlc3Rib0B3ZWJraXQub3JnJworICAgICAgICAgICAg a3dhcmdzWydlbnYnXSA9IGVudgogICAgICAgICAgICAgcmV0dXJuIEV4ZWN1dGl2ZSgpLnJ1bl9j b21tYW5kKCphcmdzLCAqKmt3YXJncykKIAogICAgICAgICBkZWYgbW9ja19zY3JpcHRfcGF0aChz Y3JpcHQpOgo=