64167 2011-07-08 07:47:25 -0700 Web Inspector: NetworkPanel search failed if the matched sting is in the query part of url 2011-07-08 08:54:10 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 434047 0 loislo 2011-07-08 07:47:25 -0700 %subj% 434054 1 100119 loislo 2011-07-08 08:16:31 -0700 Created attachment 100119 [patch] initial version 434075 2 100119 yurys 2011-07-08 08:49:32 -0700 Comment on attachment 100119 [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=100119&action=review > Source/WebCore/ChangeLog:3 > + Web Inspector: NetworkPanel search failed if the matched sting is in the query part of url sting -> string 434076 3 yurys 2011-07-08 08:50:52 -0700 Would be better if we could search in the full url string. I understand though, that there is no simple way to highlight an arbitrary part of the url in current UI. 434080 4 loislo 2011-07-08 08:54:10 -0700 Committed r90635: <http://trac.webkit.org/changeset/90635> 100119 2011-07-08 08:16:31 -0700 2011-07-08 08:49:32 -0700 [patch] initial version patch text/plain 3582 loislo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2OWEwYjljLi41NWQxNzFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDctMDggIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE5ldHdvcmtQYW5lbCBzZWFyY2ggZmFpbGVkIGlmIHRo ZSBtYXRjaGVkIHN0aW5nIGlzIGluIHRoZSBxdWVyeSBwYXJ0IG9mIHVybAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQxNjcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv TmV0d29ya1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtQYW5lbC5wcm90 b3R5cGUuX21hdGNoUmVzb3VyY2UpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtQYW5l bC5wcm90b3R5cGUuX2hpZ2hsaWdodE50aE1hdGNoZWRSZXNvdXJjZSk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuTmV0d29ya0RhdGFHcmlkTm9kZS5wcm90b3R5cGUuX3JlZnJlc2hOYW1lQ2VsbCk6 CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZS5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5SZXNvdXJjZS5wcm90b3R5cGUuZ2V0IGZvbGRlcik6CisKIDIwMTEtMDctMDcg IEVtaWwgQSBFa2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFN3aXRjaCBIaXRU ZXN0UmVzdWx0IHRvIHRvIG5ldyBsYXlvdXQgdHlwZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMKaW5kZXggOTBmODU4My4uYjRhNWI2 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3Jr UGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3Jr UGFuZWwuanMKQEAgLTExMTcsNyArMTExNyw3IEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrUGFuZWwu cHJvdG90eXBlID0gewogICAgICAgICBpZiAoIXRoaXMuX3NlYXJjaFJlZ0V4cCkKICAgICAgICAg ICAgIHJldHVybiAtMTsKIAotICAgICAgICBpZiAoKCFyZXNvdXJjZS5kaXNwbGF5TmFtZSB8fCAh cmVzb3VyY2UuZGlzcGxheU5hbWUubWF0Y2godGhpcy5fc2VhcmNoUmVnRXhwKSkgJiYgKCFyZXNv dXJjZS5wYXRoIHx8ICFyZXNvdXJjZS5wYXRoLm1hdGNoKHRoaXMuX3NlYXJjaFJlZ0V4cCkpKQor ICAgICAgICBpZiAoKCFyZXNvdXJjZS5kaXNwbGF5TmFtZSB8fCAhcmVzb3VyY2UuZGlzcGxheU5h bWUubWF0Y2godGhpcy5fc2VhcmNoUmVnRXhwKSkgJiYgIXJlc291cmNlLmZvbGRlci5tYXRjaCh0 aGlzLl9zZWFyY2hSZWdFeHApKQogICAgICAgICAgICAgcmV0dXJuIC0xOwogCiAgICAgICAgIGlm IChyZXNvdXJjZS5pZGVudGlmaWVyIGluIHRoaXMuX21hdGNoZWRSZXNvdXJjZXNNYXApCkBAIC0x MTY4LDcgKzExNjgsNyBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya1BhbmVsLnByb3RvdHlwZSA9IHsK ICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICB2YXIgbmFtZU1hdGNoZWQgPSByZXNvdXJj ZS5kaXNwbGF5TmFtZSAmJiByZXNvdXJjZS5kaXNwbGF5TmFtZS5tYXRjaCh0aGlzLl9zZWFyY2hS ZWdFeHApOwotICAgICAgICB2YXIgcGF0aE1hdGNoZWQgPSByZXNvdXJjZS5wYXRoICYmIHJlc291 cmNlLnBhdGgubWF0Y2godGhpcy5fc2VhcmNoUmVnRXhwKTsKKyAgICAgICAgdmFyIHBhdGhNYXRj aGVkID0gcmVzb3VyY2UucGF0aCAmJiByZXNvdXJjZS5mb2xkZXIubWF0Y2godGhpcy5fc2VhcmNo UmVnRXhwKTsKICAgICAgICAgaWYgKCFuYW1lTWF0Y2hlZCAmJiBwYXRoTWF0Y2hlZCAmJiAhdGhp cy5fbGFyZ2VyUmVzb3VyY2VzQnV0dG9uLnRvZ2dsZWQpCiAgICAgICAgICAgICB0aGlzLl90b2dn bGVMYXJnZXJSZXNvdXJjZXMoKTsKIApAQCAtMTY1OCwxMSArMTY1OCw4IEBAIFdlYkluc3BlY3Rv ci5OZXR3b3JrRGF0YUdyaWROb2RlLnByb3RvdHlwZSA9IHsKIAogICAgICAgICB2YXIgc3VidGl0 bGUgPSB0aGlzLl9yZXNvdXJjZS5kaXNwbGF5RG9tYWluOwogCi0gICAgICAgIGlmICh0aGlzLl9y ZXNvdXJjZS5wYXRoICYmIHRoaXMuX3Jlc291cmNlLmxhc3RQYXRoQ29tcG9uZW50KSB7Ci0gICAg ICAgICAgICB2YXIgbGFzdFBhdGhDb21wb25lbnRJbmRleCA9IHRoaXMuX3Jlc291cmNlLnBhdGgu bGFzdEluZGV4T2YoIi8iICsgdGhpcy5fcmVzb3VyY2UubGFzdFBhdGhDb21wb25lbnQpOwotICAg ICAgICAgICAgaWYgKGxhc3RQYXRoQ29tcG9uZW50SW5kZXggIT0gLTEpCi0gICAgICAgICAgICAg ICAgc3VidGl0bGUgKz0gdGhpcy5fcmVzb3VyY2UucGF0aC5zdWJzdHJpbmcoMCwgbGFzdFBhdGhD b21wb25lbnRJbmRleCk7Ci0gICAgICAgIH0KKyAgICAgICAgaWYgKHRoaXMuX3Jlc291cmNlLnBh dGgpCisgICAgICAgICAgICBzdWJ0aXRsZSArPSB0aGlzLl9yZXNvdXJjZS5mb2xkZXI7CiAKICAg ICAgICAgdGhpcy5fYXBwZW5kU3VidGl0bGUodGhpcy5fbmFtZUNlbGwsIHN1YnRpdGxlKTsKICAg ICAgICAgdGhpcy5fbmFtZUNlbGwudGl0bGUgPSB0aGlzLl9yZXNvdXJjZS51cmw7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlLmpzIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZS5qcwppbmRleCBhMTA0MDM1 Li45MmE1M2VlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1Jlc291cmNlLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVz b3VyY2UuanMKQEAgLTI0Nyw2ICsyNDcsMTYgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlLnByb3Rv dHlwZSA9IHsKICAgICAgICAgcmV0dXJuIHRoaXMuX2Rpc3BsYXlOYW1lOwogICAgIH0sCiAKKyAg ICBnZXQgZm9sZGVyKCkKKyAgICB7CisgICAgICAgIHZhciBwYXRoID0gdGhpcy5wYXRoOworICAg ICAgICB2YXIgaW5kZXhPZlF1ZXJ5ID0gcGF0aC5pbmRleE9mKCI/Iik7CisgICAgICAgIGlmIChp bmRleE9mUXVlcnkgIT09IC0xKQorICAgICAgICAgICAgcGF0aCA9IHBhdGguc3Vic3RyaW5nKDAs IGluZGV4T2ZRdWVyeSk7CisgICAgICAgIHZhciBsYXN0U2xhc2hJbmRleCA9IHBhdGgubGFzdElu ZGV4T2YoIi8iKTsKKyAgICAgICAgcmV0dXJuIGxhc3RTbGFzaEluZGV4ICE9PSAtMSA/IHBhdGgu c3Vic3RyaW5nKDAsIGxhc3RTbGFzaEluZGV4KSA6ICIiOworICAgIH0sCisKICAgICBnZXQgZGlz cGxheURvbWFpbigpCiAgICAgewogICAgICAgICAvLyBXZWJJbnNwZWN0b3IuRGF0YWJhc2UgY2Fs bHMgdGhpcywgc28gZG9uJ3QgYWNjZXNzIG1vcmUgdGhhbiB0aGlzLmRvbWFpbi4K