64159 2011-07-08 05:11:00 -0700 [GTK] testwebview API test fails after http://trac.webkit.org/changeset/90471 2011-07-08 06:43:07 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 gustavo gustavo oldest_to_newest 434007 0 gustavo 2011-07-08 05:11:00 -0700 We relied on the page being considered loaded for checking the icon signals. The page is now considered loaded before the favicon change happens, so the test broke. 434011 1 100107 gustavo 2011-07-08 05:19:55 -0700 Created attachment 100107 Patch 434027 2 100107 xan.lopez 2011-07-08 06:37:05 -0700 Comment on attachment 100107 Patch If you add a reference to the changeset where this changed I'll like you even more! 434030 3 100107 gustavo 2011-07-08 06:43:00 -0700 Comment on attachment 100107 Patch Clearing flags on attachment: 100107 Committed r90627: <http://trac.webkit.org/changeset/90627> 434031 4 gustavo 2011-07-08 06:43:07 -0700 All reviewed patches have been landed. Closing bug. 100107 2011-07-08 05:19:55 -0700 2011-07-08 06:43:00 -0700 Patch bug-64159-20110708091953.patch text/plain 3486 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogOTA0NzEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCAzNTU5YTMzNTRh YWM2YTE5ODgzYzhhZWQ0Y2Y5YWQxZTEyY2NlNTk4Li41MjY0NmJlZTFkNzVkNGNiYWI5M2YxNWY0 OThiYWRmZjM1MmVlMTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEt MDctMDggIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEu Y29tPgorCisgICAgICAgIFtHVEtdIHRlc3R3ZWJ2aWV3IEFQSSB0ZXN0IGZhaWxzIGFmdGVyIGh0 dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzkwNDcxCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDE1OQorCisgICAgICAgIFJld29yayB0aGUg aWNvbi11cmkgY2hhbmdlIHRlc3Qgc28gdGhhdCB0aGUgY29uZGl0aW9uIGZvciBxdWl0dGluZwor ICAgICAgICB0aGUgbWFpbmxvb3AgaXMgdGhlIGljb24tdXJpIGNoYW5nZSBpdHNlbGYsIGFsb25n IHdpdGggYSB0aW1lb3V0CisgICAgICAgIHRvIGF2b2lkIHRha2luZyB0b28gbG9uZyBpbiBjYXNl IG9mIGZhaWx1cmUuIFNpbmNlIHRoZSBjb25kaXRpb25zCisgICAgICAgIGZvciBjb25zaWRlcmlu ZyBhIHBhZ2UgbG9hZGVkIHdlcmUgY2hhbmdlZCB3ZSBjYW4ndCByZWx5IG9uIHRoYXQKKyAgICAg ICAgZm9yIHRoaXMgdGVzdCBhbnltb3JlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogdGVzdHMvdGVzdHdlYnZpZXcuYzoKKyAgICAgICAgKHRpbWVv dXRfY2IpOiBlcnJvciBvdXQgaWYgaXQgdGFrZXMgdG9vIGxvbmcgZm9yIHRoZSBpY29uLXVyaQor ICAgICAgICBjaGFuZ2UgdG8gaGFwcGVuLgorICAgICAgICAoaWNvbl91cmlfY2hhbmdlZF9jYik6 IHF1aXQgdGhlIGxvb3AgaGVyZSBpbnN0ZWFkIG9mIHdhaXRpbmcgb24KKyAgICAgICAgdGhlIHBh Z2UgYmVpbmcgbG9hZGVkLgorICAgICAgICAodGVzdF93ZWJraXRfd2ViX3ZpZXdfaWNvbl91cmkp OgorCiAyMDExLTA3LTAxICBKb29uZSBIdXIgIDxqb29uZS5odXJAY29sbGFib3JhLmNvLnVrPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3R3ZWJ2aWV3LmMgYi9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0 cy90ZXN0d2Vidmlldy5jCmluZGV4IGViNjk2YWVkNGRmN2E0ZTEzOTVmMTk3YzY3YTU5MTViNmJj ZTJlZWYuLjhlYmRkOTJhMjA0NGRhZThjZTk3ZTE0N2ZmNWRjY2RiNzUzNGI1OGEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3R3ZWJ2aWV3LmMKKysrIGIvU291cmNlL1dl YktpdC9ndGsvdGVzdHMvdGVzdHdlYnZpZXcuYwpAQCAtNzgsOSArNzgsMTQgQEAgc3RhdGljIHZv aWQgaWRsZV9xdWl0X2xvb3BfY2IoV2ViS2l0V2ViVmlldyogd2ViX3ZpZXcsIEdQYXJhbVNwZWMq IHBzcGVjLCBncG9pbnQKICAgICAgICAgZ19tYWluX2xvb3BfcXVpdChsb29wKTsKIH0KIAorc3Rh dGljIGdib29sZWFuIHRpbWVvdXRfY2IoZ3BvaW50ZXIgZGF0YSkKK3sKKyAgICBnX2Vycm9yKCJE aWRuJ3QgZ2V0IGljb24tdXJpIGJlZm9yZSB0aW1pbmcgb3V0LiIpOworICAgIHJldHVybiBGQUxT RTsKK30KKwogc3RhdGljIHZvaWQgaWNvbl91cmlfY2hhbmdlZF9jYihXZWJLaXRXZWJWaWV3KiB3 ZWJfdmlldywgR1BhcmFtU3BlYyogcHNwZWMsIGdwb2ludGVyIGRhdGEpCiB7Ci0gICAgZ2Jvb2xl YW4qIGJlZW5faGVyZSA9IChnYm9vbGVhbiopZGF0YTsKICAgICBjaGFyKiBleHBlY3RlZF91cmk7 CiAKICAgICBnX2Fzc2VydF9jbXBzdHIoZ19wYXJhbV9zcGVjX2dldF9uYW1lKHBzcGVjKSwgPT0s ICJpY29uLXVyaSIpOwpAQCAtODksNyArOTQsNyBAQCBzdGF0aWMgdm9pZCBpY29uX3VyaV9jaGFu Z2VkX2NiKFdlYktpdFdlYlZpZXcqIHdlYl92aWV3LCBHUGFyYW1TcGVjKiBwc3BlYywgZ3BvaQog ICAgIGdfYXNzZXJ0X2NtcHN0cih3ZWJraXRfd2ViX3ZpZXdfZ2V0X2ljb25fdXJpKHdlYl92aWV3 KSwgPT0sIGV4cGVjdGVkX3VyaSk7CiAgICAgZ19mcmVlKGV4cGVjdGVkX3VyaSk7CiAKLSAgICAq YmVlbl9oZXJlID0gVFJVRTsKKyAgICBnX21haW5fbG9vcF9xdWl0KGxvb3ApOwogfQogCiBzdGF0 aWMgdm9pZCBpY29uX2xvYWRlZF9jYihXZWJLaXRXZWJWaWV3KiB3ZWJfdmlldywgY2hhciogaWNv bl91cmksIGdwb2ludGVyIGRhdGEpCkBAIC0xMDYsNyArMTExLDYgQEAgc3RhdGljIHZvaWQgaWNv bl9sb2FkZWRfY2IoV2ViS2l0V2ViVmlldyogd2ViX3ZpZXcsIGNoYXIqIGljb25fdXJpLCBncG9p bnRlciBkYXQKIAogc3RhdGljIHZvaWQgdGVzdF93ZWJraXRfd2ViX3ZpZXdfaWNvbl91cmkoKQog ewotICAgIGdib29sZWFuIGJlZW5fdG9fdXJpX2NoYW5nZWQgPSBGQUxTRTsKICAgICBnYm9vbGVh biBiZWVuX3RvX2ljb25fbG9hZGVkID0gRkFMU0U7CiAgICAgV2ViS2l0V2ViVmlldyogdmlldyA9 IFdFQktJVF9XRUJfVklFVyh3ZWJraXRfd2ViX3ZpZXdfbmV3KCkpOwogICAgIGdfb2JqZWN0X3Jl Zl9zaW5rKEdfT0JKRUNUKHZpZXcpKTsKQEAgLTExNCwxNiArMTE4LDE4IEBAIHN0YXRpYyB2b2lk IHRlc3Rfd2Via2l0X3dlYl92aWV3X2ljb25fdXJpKCkKICAgICBsb29wID0gZ19tYWluX2xvb3Bf bmV3KE5VTEwsIFRSVUUpOwogCiAgICAgZ19vYmplY3RfY29ubmVjdChHX09CSkVDVCh2aWV3KSwK LSAgICAgICAgICAgICAgICAgICAgICJzaWduYWw6Om5vdGlmeTo6cHJvZ3Jlc3MiLCBpZGxlX3F1 aXRfbG9vcF9jYiwgTlVMTCwKLSAgICAgICAgICAgICAgICAgICAgICJzaWduYWw6Om5vdGlmeTo6 aWNvbi11cmkiLCBpY29uX3VyaV9jaGFuZ2VkX2NiLCAmYmVlbl90b191cmlfY2hhbmdlZCwKKyAg ICAgICAgICAgICAgICAgICAgICJzaWduYWw6Om5vdGlmeTo6aWNvbi11cmkiLCBpY29uX3VyaV9j aGFuZ2VkX2NiLCBOVUxMLAogICAgICAgICAgICAgICAgICAgICAgInNpZ25hbDo6aWNvbi1sb2Fk ZWQiLCBpY29uX2xvYWRlZF9jYiwgJmJlZW5fdG9faWNvbl9sb2FkZWQsCiAgICAgICAgICAgICAg ICAgICAgICBOVUxMKTsKIAogICAgIHdlYmtpdF93ZWJfdmlld19sb2FkX3VyaSh2aWV3LCBiYXNl X3VyaSk7CiAKKyAgICBndWludCB0aW1lb3V0X2lkID0gZ190aW1lb3V0X2FkZCg1MDAsIHRpbWVv dXRfY2IsIDApOworCiAgICAgZ19tYWluX2xvb3BfcnVuKGxvb3ApOwogCi0gICAgZ19hc3NlcnQo YmVlbl90b191cmlfY2hhbmdlZCk7CisgICAgZ19zb3VyY2VfcmVtb3ZlKHRpbWVvdXRfaWQpOwor CiAgICAgZ19hc3NlcnQoYmVlbl90b19pY29uX2xvYWRlZCk7CiAKICAgICBnX29iamVjdF91bnJl Zih2aWV3KTsK