64155 2011-07-08 02:23:59 -0700 Web Inspector: typing undefined = 1 in console crashes browser 2011-07-08 03:16:01 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 433964 0 yurys 2011-07-08 02:23:59 -0700 What steps will reproduce the problem? 1. Open the JavaScript console (Ctrl-Shift-J) 2. Type "undefined = this" without the quotes 3. Type "undefined = 1" without the quotes Original Chromium bug: crbug.com/88414 433966 1 yurys 2011-07-08 02:41:36 -0700 It is not necessarily undefined=this; right hand side value may be any object with cyclic reference, so the steps could be changed to: 1. Open the JavaScript console (Ctrl-Shift-J) 2. Type "var x = {a:1}; x.self = x; undefined = x;" without the quotes 3. Type "unknownVar" without the quotes 433968 2 100098 yurys 2011-07-08 02:54:32 -0700 Created attachment 100098 Patch 433974 3 100098 pfeldman 2011-07-08 03:10:05 -0700 Comment on attachment 100098 Patch How do we make sure undefined is not used? Declare "var trueUndefined" in the top of the file? 433975 4 100098 apavlov 2011-07-08 03:12:52 -0700 Comment on attachment 100098 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100098&action=review > Source/WebCore/inspector/InjectedScriptSource.js:456 > + // Avoid explicit assignment to undefined as its value can be overriden (see crbug.com/88414). ..overridden.. 433976 5 yurys 2011-07-08 03:13:30 -0700 Committed r90614: <http://trac.webkit.org/changeset/90614> 433977 6 yurys 2011-07-08 03:14:42 -0700 (In reply to comment #3) > (From update of attachment 100098 [details]) > How do we make sure undefined is not used? Declare "var trueUndefined" in the top of the file? I don't see a good way to achieve this without affecting the application that decided to modify undefined value. 433979 7 yurys 2011-07-08 03:16:01 -0700 (In reply to comment #6) > (In reply to comment #3) > > (From update of attachment 100098 [details] [details]) > > How do we make sure undefined is not used? Declare "var trueUndefined" in the top of the file? > > I don't see a good way to achieve this without affecting the application that decided to modify undefined value. We could emulate worst-case conditions in all tests(override JSON object, undefined value and whatever we need). 100098 2011-07-08 02:54:32 -0700 2011-07-08 03:12:51 -0700 Patch bug-64155-20110708135430.patch text/plain 5918 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogOTA2MTMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5ZDNkZDZkMjEyMTk3N2ZiMzU4NmE4 ZTAxYzczNjkxZjIxZmZhNDQzLi5jMjgyYzY5NzFiMGU1ZWQ2M2MwZTQ5ZTY1Y2I1Y2VmOWIzN2Uy NTI5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDctMDggIFl1cnkgU2VtaWtoYXRza3kg IDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogdHlwaW5nIHVu ZGVmaW5lZCA9IDEgaW4gY29uc29sZSBjcmFzaGVzIGJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MTU1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvY29uc29sZS9jb25zb2xl LWV2YWwtdW5kZWZpbmVkLW92ZXJyaWRlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog aW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1ldmFsLXVuZGVmaW5lZC1vdmVycmlkZS5odG1sOiBB ZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9pbnNwZWN0b3IvY29uc29sZS9jb25z b2xlLWV2YWwtdW5kZWZpbmVkLW92ZXJyaWRlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMTEt MDctMDggIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLiBNb3ZpbmcgdGVzdCBleHBlY3RhdGlvbiBmcm9tIHBsYXRmb3JtLXNwZWNpZmlj IHRvIGdlbmVyaWMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9j b25zb2xlLWV2YWwtdW5kZWZpbmVkLW92ZXJyaWRlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtZXZhbC11bmRlZmluZWQtb3ZlcnJpZGUtZXhwZWN0 ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjQ0M2QzMjU4ZWZkOGU5YjRlNmE0NzEyMjc4OWVkNTMwMWRlNTFm YjMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25z b2xlLWV2YWwtdW5kZWZpbmVkLW92ZXJyaWRlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDcgQEAK K1Rlc3RzIHRoYXQgZXZhbHVhdGluZyBzb21ldGhpbmcgaW4gY29uc29sZSB3b24ndCBjcmFzaCB0 aGUgYnJvd3NlciBpZiB1bmRlZmluZWQgdmFsdWUgaXMgb3ZlcnJpZGVuLiBUaGUgdGVzdCBwYXNz ZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4gQnVnIDY0MTU1LgorCit2YXIgeCA9IHthOjF9OyB4LnNl bGYgPSB4OyB1bmRlZmluZWQgPSB4OworT2JqZWN0Cit1bmtub3duVmFyCitFcnJvcgorCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLWV2YWwtdW5kZWZp bmVkLW92ZXJyaWRlLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xl LWV2YWwtdW5kZWZpbmVkLW92ZXJyaWRlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDZlZGZhZTQ3Y2I5ZmE2 NzljODg4N2ZlNTI3MGNlZmYwN2JmNmIzNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtZXZhbC11bmRlZmluZWQtb3ZlcnJpZGUuaHRtbApA QCAtMCwwICsxLDMwIEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2h0dHAv dGVzdHMvaW5zcGVjdG9yL2luc3BlY3Rvci10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3Jj PSIuLi8uLi9odHRwL3Rlc3RzL2luc3BlY3Rvci9jb25zb2xlLXRlc3QuanMiPjwvc2NyaXB0Pgor PHNjcmlwdD4KK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIEluc3BlY3RvclRlc3QuZXZhbHVhdGVJ bkNvbnNvbGUoInZhciB4ID0ge2E6MX07IHguc2VsZiA9IHg7IHVuZGVmaW5lZCA9IHg7Iiwgc3Rl cDEpOworCisgICAgZnVuY3Rpb24gc3RlcDEoKQorICAgIHsKKyAgICAgICAgSW5zcGVjdG9yVGVz dC5ldmFsdWF0ZUluQ29uc29sZSgidW5rbm93blZhciIsIHN0ZXAyKTsKKyAgICB9CisgICAgZnVu Y3Rpb24gc3RlcDIoKQorICAgIHsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5kdW1wQ29uc29sZU1l c3NhZ2VzKCk7CisgICAgICAgIEluc3BlY3RvclRlc3QuY29tcGxldGVUZXN0KCk7CisgICAgfQor fQorCis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKzxwPgor VGVzdHMgdGhhdCBldmFsdWF0aW5nIHNvbWV0aGluZyBpbiBjb25zb2xlIHdvbid0IGNyYXNoIHRo ZSBicm93c2VyIGlmIHVuZGVmaW5lZCB2YWx1ZQoraXMgb3ZlcnJpZGVuLiBUaGUgdGVzdCBwYXNz ZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4KKzxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02NDE1NSI+QnVnIDY0MTU1LjwvYT4KKzwvcD4KKzwvYm9keT4KKzwv aHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2luc3BlY3Rv ci9jb25zb2xlL2NvbnNvbGUtZXZhbC11bmRlZmluZWQtb3ZlcnJpZGUtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1l dmFsLXVuZGVmaW5lZC1vdmVycmlkZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDI2MDc1OTM2 ZjUxMWMyMGUxNDFiZGVkYzgxODNiM2I3MmQ2YzU5MAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtZXZhbC11 bmRlZmluZWQtb3ZlcnJpZGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNyBAQAorVGVzdHMgdGhh dCBldmFsdWF0aW5nIHNvbWV0aGluZyBpbiBjb25zb2xlIHdvbid0IGNyYXNoIHRoZSBicm93c2Vy IGlmIHVuZGVmaW5lZCB2YWx1ZSBpcyBvdmVycmlkZW4uIFRoZSB0ZXN0IHBhc3NlcyBpZiBpdCBk b2Vzbid0IGNyYXNoLiBCdWcgNjQxNTUuCisKK3ZhciB4ID0ge2E6MX07IHguc2VsZiA9IHg7IHVu ZGVmaW5lZCA9IHg7CitPYmplY3QKK3Vua25vd25WYXIKK1JlZmVyZW5jZUVycm9yCisKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCA2OWEwYjljYTVlYmUxYWNmYmE3MDhlY2YxMTlkZWYzZDJlNjgxNjk3Li4zOTg3Zjdi M2Q4NDEyYjc4YWI4NTM0ZTM2MDczNjllNzkzMDA3NjBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTkgQEAKKzIwMTEtMDctMDggIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogdHlwaW5nIHVuZGVmaW5lZCA9IDEgaW4gY29uc29s ZSBjcmFzaGVzIGJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY0MTU1CisKKyAgICAgICAgRG8gbm90IGFjY2VzcyB1bmRlZmluZWQgdmFsdWUg ZGlyZWN0bHkgd2hlbiBwcm9kdWNpbmcgSlNPTiBvYmplY3RzIGFzIHVuZGVmaW5lZAorICAgICAg ICBtYXkgYmUgb3ZlcnJpZGVuIGJ5IHRoZSBpbnNwZWN0ZWQgcGFnZS4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBpbnNwZWN0b3IvY29uc29s ZS9jb25zb2xlLWV2YWwtdW5kZWZpbmVkLW92ZXJyaWRlLmh0bWwKKworICAgICAgICAqIGluc3Bl Y3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qczoKKyAgICAgICAgKC4pOgorICAgICAgICAoKToK KwogMjAxMS0wNy0wNyAgRW1pbCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgU3dpdGNoIEhpdFRlc3RSZXN1bHQgdG8gdG8gbmV3IGxheW91dCB0eXBlcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzCmluZGV4IDkwMWU1 NzE0ODNhMGFjYTI1YTM1MzNmNTQ1NWUyYTY2NDVhZWM2YTQuLmY3NzQwYTZlM2I4Y2IyZWVlY2U2 MWU4ZTgwMTY2YzM4NTVhNDRiMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMKQEAgLTE4OSw3ICsxODksMTEgQEAgSW5qZWN0ZWRTY3Jp cHQucHJvdG90eXBlID0gewogICAgICAgICB2YXIgZXhwcmVzc2lvbkxlbmd0aCA9IGV4cHJlc3Np b24ubGVuZ3RoOwogICAgICAgICBpZiAoIWV4cHJlc3Npb25MZW5ndGgpIHsKICAgICAgICAgICAg IGRlbGV0ZSBvYmplY3RbcHJvcGVydHlOYW1lXTsKLSAgICAgICAgICAgIHJldHVybiBwcm9wZXJ0 eU5hbWUgaW4gb2JqZWN0ID8gIkNvdW5kIG5vdCBkZWxldGUgcHJvcGVydHkuIiA6IHVuZGVmaW5l ZDsKKyAgICAgICAgICAgIC8vIEF2b2lkIGV4cGxpY2l0IGFzc2lnbm1lbnQgdG8gdW5kZWZpbmVk IGFzIGl0cyB2YWx1ZSBjYW4gYmUgb3ZlcnJpZGVuIChzZWUgY3JidWcuY29tLzg4NDE0KS4KKyAg ICAgICAgICAgIHZhciByZXN1bHQ7CisgICAgICAgICAgICBpZiAocHJvcGVydHlOYW1lIGluIG9i amVjdCkKKyAgICAgICAgICAgICAgICByZXN1bHQgPSAiQ291bmQgbm90IGRlbGV0ZSBwcm9wZXJ0 eS4iOworICAgICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICAgICAgfQogCiAgICAgICAgIHRy eSB7CkBAIC00NDgsNyArNDUyLDEwIEBAIEluamVjdGVkU2NyaXB0LlJlbW90ZU9iamVjdC5mcm9t T2JqZWN0ID0gZnVuY3Rpb24ob2JqZWN0LCBvYmplY3RJZCkKICAgICB2YXIgdHlwZSA9IGluamVj dGVkU2NyaXB0Ll90eXBlKG9iamVjdCk7CiAgICAgdmFyIHJhd1R5cGUgPSB0eXBlb2Ygb2JqZWN0 OwogICAgIHZhciBoYXNDaGlsZHJlbiA9IChyYXdUeXBlID09PSAib2JqZWN0IiAmJiBvYmplY3Qg IT09IG51bGwgJiYgKCEhT2JqZWN0LmdldE93blByb3BlcnR5TmFtZXMob2JqZWN0KS5sZW5ndGgg fHwgISFvYmplY3QuX19wcm90b19fKSkgfHwgcmF3VHlwZSA9PT0gImZ1bmN0aW9uIjsKLSAgICB2 YXIgY2xhc3NOYW1lID0gdHlwZW9mIG9iamVjdCA9PT0gIm9iamVjdCIgfHwgdHlwZW9mIG9iamVj dCA9PT0gImZ1bmN0aW9uIiA/IEluamVjdGVkU2NyaXB0SG9zdC5pbnRlcm5hbENvbnN0cnVjdG9y TmFtZShvYmplY3QpIDogdW5kZWZpbmVkOworICAgIHZhciBjbGFzc05hbWU7CisgICAgLy8gQXZv aWQgZXhwbGljaXQgYXNzaWdubWVudCB0byB1bmRlZmluZWQgYXMgaXRzIHZhbHVlIGNhbiBiZSBv dmVycmlkZW4gKHNlZSBjcmJ1Zy5jb20vODg0MTQpLgorICAgIGlmICh0eXBlb2Ygb2JqZWN0ID09 PSAib2JqZWN0IiB8fCB0eXBlb2Ygb2JqZWN0ID09PSAiZnVuY3Rpb24iKQorICAgICAgICBjbGFz c05hbWUgPSBJbmplY3RlZFNjcmlwdEhvc3QuaW50ZXJuYWxDb25zdHJ1Y3Rvck5hbWUob2JqZWN0 KTsKICAgICB2YXIgZGVzY3JpcHRpb24gPSBpbmplY3RlZFNjcmlwdC5fZGVzY3JpYmUob2JqZWN0 KTsKICAgICByZXR1cm4gbmV3IEluamVjdGVkU2NyaXB0LlJlbW90ZU9iamVjdChvYmplY3RJZCwg dHlwZSwgY2xhc3NOYW1lLCBkZXNjcmlwdGlvbiwgaGFzQ2hpbGRyZW4pOwogfQo=