64153 2011-07-08 00:28:22 -0700 sheriffbot is too spammy in IRC 2011-07-08 08:58:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth aroben eric lforschler webkit.review.bot oldest_to_newest 433936 0 abarth 2011-07-08 00:28:22 -0700 sheriffbot is too spammy in IRC 433939 1 100088 abarth 2011-07-08 00:32:00 -0700 Created attachment 100088 Patch 433959 2 100088 eric 2011-07-08 02:06:44 -0700 Comment on attachment 100088 Patch I like the builder idea. But I agree, this feature isnt' helping these days. 434028 3 100088 aroben 2011-07-08 06:38:46 -0700 Comment on attachment 100088 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100088&action=review > Tools/ChangeLog:11 > + Reporting failures in IRC worked well when the tree was greener than it > + is today. Nowadays, this feature mostly just results in spam about > + false positives. If we reach a greener state, we can bring this code > + back. One particularly painful source of redness that causes sheriffbot issues is flaky tests. 434086 4 100088 webkit.review.bot 2011-07-08 08:58:43 -0700 Comment on attachment 100088 Patch Clearing flags on attachment: 100088 Committed r90636: <http://trac.webkit.org/changeset/90636> 434087 5 webkit.review.bot 2011-07-08 08:58:47 -0700 All reviewed patches have been landed. Closing bug. 100088 2011-07-08 00:32:00 -0700 2011-07-08 08:58:43 -0700 Patch bug-64153-20110708003159.patch text/plain 5419 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTA2MTIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiZGMyNTA0NjAxODRlZTdhMTlkNzhiMDNiMjUwMjhhZWJi NmNlYTVlLi40Y2Q4ZjI2NWYwNzg5YjFmYTVkYzUzY2JlMjQwNzA5NDFlNjMwZjRmIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMDctMDggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAg ICBzaGVyaWZmYm90IGlzIHRvbyBzcGFtbXkgaW4gSVJDCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDE1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcG9ydGluZyBmYWlsdXJlcyBpbiBJUkMgd29ya2Vk IHdlbGwgd2hlbiB0aGUgdHJlZSB3YXMgZ3JlZW5lciB0aGFuIGl0CisgICAgICAgIGlzIHRvZGF5 LiAgTm93YWRheXMsIHRoaXMgZmVhdHVyZSBtb3N0bHkganVzdCByZXN1bHRzIGluIHNwYW0gYWJv dXQKKyAgICAgICAgZmFsc2UgcG9zaXRpdmVzLiAgSWYgd2UgcmVhY2ggYSBncmVlbmVyIHN0YXRl LCB3ZSBjYW4gYnJpbmcgdGhpcyBjb2RlCisgICAgICAgIGJhY2suCisKKyAgICAgICAgKEFub3Ro ZXIgcG9zc2liaWxpdHkgaXMgdG8gcmVzdHJpY3QgdGhpcyBmZWF0dXJlIHRvIGJ1aWxkZXIgYm90 cywKKyAgICAgICAgcmF0aGVyIHRoYW4gaW5jbHVkaW5nIHRlc3RlcnMsIGFzIHdlIGRpZCBiZWZv cmUgdGhpcyBwYXRjaC4pCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvc2hlcmlmZmJvdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvc2hlcmlmZmJvdF91bml0dGVzdC5weToKKwogMjAxMS0wNy0wNyAgS2V2aW4gT2xsaXZpZXIg IDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICBbd3hdIFVucmV2aWV3ZWQgYnVp bGQgZml4LCByZW1vdmUgb2xkIGZpbGVzIGZyb20gdGhlIHRyZWUgYW5kIHVwZGF0ZSBwYXRocyB0 byBuZXcgb25lcy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21t YW5kcy9zaGVyaWZmYm90LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRz L3NoZXJpZmZib3QucHkKaW5kZXggODMyZGJiZDQ5MWYyYThkOTE3NGEzN2FiMmEzMjZlYTk5OGNi MDk3MC4uNTQ3MzA5ZTg4YTA3ZThkNTkyZmVkNWJjNTIzMTYyZTg1MWNmNmI0OSAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3NoZXJpZmZib3QucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3NoZXJpZmZib3QucHkKQEAg LTQzLDkgKzQzLDYgQEAgY2xhc3MgU2hlcmlmZkJvdChBYnN0cmFjdFF1ZXVlLCBTdGVwU2VxdWVu Y2VFcnJvckhhbmRsZXIpOgogICAgICAgICAiZXJpY0B3ZWJraXQub3JnIiwKICAgICBdCiAKLSAg ICBkZWYgX3VwZGF0ZShzZWxmKToKLSAgICAgICAgc2VsZi5ydW5fd2Via2l0X3BhdGNoKFsidXBk YXRlIiwgIi0tZm9yY2UtY2xlYW4iLCAiLS1xdWlldCJdKQotCiAgICAgIyBBYnN0cmFjdFF1ZXVl IG1ldGhvZHMKIAogICAgIGRlZiBiZWdpbl93b3JrX3F1ZXVlKHNlbGYpOgpAQCAtNjIsMzYgKzU5 LDEzIEBAIGNsYXNzIFNoZXJpZmZCb3QoQWJzdHJhY3RRdWV1ZSwgU3RlcFNlcXVlbmNlRXJyb3JI YW5kbGVyKToKIAogICAgIGRlZiBuZXh0X3dvcmtfaXRlbShzZWxmKToKICAgICAgICAgc2VsZi5f aXJjX2JvdC5wcm9jZXNzX3BlbmRpbmdfbWVzc2FnZXMoKQotICAgICAgICBzZWxmLl91cGRhdGUo KQotCi0gICAgICAgICMgRklYTUU6IFdlIG5lZWQgdG8gZmlndXJlIG91dCBob3cgdG8gcHJvdm9r ZV9mbGFreV9idWlsZGVycy4KLQotICAgICAgICBmYWlsdXJlX21hcCA9IHNlbGYuX3Rvb2wuYnVp bGRib3QuZmFpbHVyZV9tYXAoKQotICAgICAgICBmYWlsdXJlX21hcC5maWx0ZXJfb3V0X29sZF9m YWlsdXJlcyhzZWxmLl9pc19vbGRfZmFpbHVyZSkKLSAgICAgICAgaWYgZmFpbHVyZV9tYXAuaXNf ZW1wdHkoKToKLSAgICAgICAgICAgIHJldHVybiBOb25lCi0gICAgICAgIHJldHVybiBmYWlsdXJl X21hcAorICAgICAgICByZXR1cm4KIAogICAgIGRlZiBzaG91bGRfcHJvY2VlZF93aXRoX3dvcmtf aXRlbShzZWxmLCBmYWlsdXJlX21hcCk6CiAgICAgICAgICMgQ3VycmVudGx5LCB3ZSBkb24ndCBo YXZlIGFueSByZWFzb25zIG5vdCB0byBwcm9jZWVkIHdpdGggd29yayBpdGVtcy4KICAgICAgICAg cmV0dXJuIFRydWUKIAogICAgIGRlZiBwcm9jZXNzX3dvcmtfaXRlbShzZWxmLCBmYWlsdXJlX21h cCk6Ci0gICAgICAgIGZhaWxpbmdfcmV2aXNpb25zID0gZmFpbHVyZV9tYXAuZmFpbGluZ19yZXZp c2lvbnMoKQotICAgICAgICBudW1iZXJfb2ZfZmFpbGluZ19yZXZpc2lvbnMgPSBsZW4oZmFpbGlu Z19yZXZpc2lvbnMpCi0gICAgICAgIGZvciByZXZpc2lvbiBpbiBmYWlsaW5nX3JldmlzaW9uczoK LSAgICAgICAgICAgIGJ1aWxkZXJzID0gZmFpbHVyZV9tYXAuYnVpbGRlcnNfZmFpbGluZ19mb3Io cmV2aXNpb24pCi0gICAgICAgICAgICB0cnk6Ci0gICAgICAgICAgICAgICAgY29tbWl0X2luZm8g PSBzZWxmLl90b29sLmNoZWNrb3V0KCkuY29tbWl0X2luZm9fZm9yX3JldmlzaW9uKHJldmlzaW9u KQotICAgICAgICAgICAgICAgIGlmIG5vdCBjb21taXRfaW5mbzoKLSAgICAgICAgICAgICAgICAg ICAgcHJpbnQgIkZBSUxFRCB0byBmZXRjaCBDb21taXRJbmZvIGZvciByJXMsIGxpa2VseSBtaXNz aW5nIENoYW5nZUxvZyIgJSByZXZpc2lvbgotICAgICAgICAgICAgICAgICAgICBjb250aW51ZQot ICAgICAgICAgICAgICAgIHNlbGYuX3NoZXJpZmYucG9zdF9pcmNfd2FybmluZyhjb21taXRfaW5m bywgYnVpbGRlcnMpCi0gICAgICAgICAgICAgICAgIyBXZSB1c2VkIHRvIHBvc3Qgb24gYnVncywg YnV0IGl0IHdhcyB0b28gc3BhbW15LgotICAgICAgICAgICAgZmluYWxseToKLSAgICAgICAgICAg ICAgICBmb3IgYnVpbGRlciBpbiBidWlsZGVyczoKLSAgICAgICAgICAgICAgICAgICAgc2VsZi5f dG9vbC5zdGF0dXNfc2VydmVyLnVwZGF0ZV9zdm5fcmV2aXNpb24ocmV2aXNpb24sIGJ1aWxkZXIu bmFtZSgpKQotICAgICAgICBzZWxmLl9zaGVyaWZmLnBvc3RfaXJjX3N1bW1hcnkoZmFpbHVyZV9t YXApCiAgICAgICAgIHJldHVybiBUcnVlCiAKICAgICBkZWYgaGFuZGxlX3VuZXhwZWN0ZWRfZXJy b3Ioc2VsZiwgZmFpbHVyZV9tYXAsIG1lc3NhZ2UpOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3NoZXJpZmZib3RfdW5pdHRlc3QucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc2hlcmlmZmJvdF91bml0dGVzdC5weQppbmRl eCAwYTU4YTY1MTFjMjc0MmNmODZhNDQ2ZTA1ZmE2Mzg1MWJhNThjMTA5Li43MzVjY2FiNjk1MzVj MDU0ODc2M2NiYmUwNjI3ZDFmYjk4N2M2YjI3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvY29tbWFuZHMvc2hlcmlmZmJvdF91bml0dGVzdC5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc2hlcmlmZmJvdF91bml0dGVzdC5weQpAQCAt MzQsMzIgKzM0LDQgQEAgZnJvbSB3ZWJraXRweS50b29sLm1vY2t0b29sIGltcG9ydCAqCiAKIAog Y2xhc3MgU2hlcmlmZkJvdFRlc3QoUXVldWVzVGVzdCk6Ci0gICAgYnVpbGRlcjEgPSBNb2NrQnVp bGRlcigiQnVpbGRlcjEiKQotICAgIGJ1aWxkZXIyID0gTW9ja0J1aWxkZXIoIkJ1aWxkZXIyIikK LQotICAgIGRlZiB0ZXN0X3NoZXJpZmZfYm90KHNlbGYpOgotICAgICAgICB0b29sID0gTW9ja1Rv b2woKQotICAgICAgICBtb2NrX3dvcmtfaXRlbSA9IE1vY2tGYWlsdXJlTWFwKHRvb2wuYnVpbGRi b3QpCi0gICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9IHsKLSAgICAgICAgICAgICJiZWdpbl93b3Jr X3F1ZXVlIjogc2VsZi5fZGVmYXVsdF9iZWdpbl93b3JrX3F1ZXVlX3N0ZGVycigic2hlcmlmZi1i b3QiLCB0b29sLnNjbSgpLmNoZWNrb3V0X3Jvb3QpLAotICAgICAgICAgICAgIm5leHRfd29ya19p dGVtIjogIiIsCi0gICAgICAgICAgICAicHJvY2Vzc193b3JrX2l0ZW0iOiAiIiJNT0NLOiBpcmMu cG9zdDogYWJhcnRoLCBkYXJpbiwgZXNlaWRlbDogaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFu Z2VzZXQvMjk4MzcgbWlnaHQgaGF2ZSBicm9rZW4gQnVpbGRlcjEKLU1PQ0s6IGlyYy5wb3N0OiBO ZXcgZmFpbHVyZXM6IG1vY2stdGVzdC0xCi0iIiIsCi0gICAgICAgICAgICAiaGFuZGxlX3VuZXhw ZWN0ZWRfZXJyb3IiOiAiTW9jayBlcnJvciBtZXNzYWdlXG4iLAotICAgICAgICB9Ci0gICAgICAg IHNlbGYuYXNzZXJ0X3F1ZXVlX291dHB1dHMoU2hlcmlmZkJvdCgpLCB3b3JrX2l0ZW09bW9ja193 b3JrX2l0ZW0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCi0KLSAgICBkZWYgdGVz dF9tYW55X2ZhaWxpbmdfdGVzdHMoc2VsZik6Ci0gICAgICAgIHRvb2wgPSBNb2NrVG9vbCgpCi0g ICAgICAgIG1vY2tfd29ya19pdGVtID0gTW9ja0ZhaWx1cmVNYXAodG9vbC5idWlsZGJvdCkKLSAg ICAgICAgbW9ja193b3JrX2l0ZW0uZmFpbGluZ190ZXN0cyA9IGxhbWJkYTogc2V0KFsidGVzdDEi LCAidGVzdDIiLCAidGVzdDMiLCAidGVzdDQiLCAidGVzdDUiLCAidGVzdDYiLCAidGVzdDciXSkK LSAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gewotICAgICAgICAgICAgImJlZ2luX3dvcmtfcXVl dWUiOiBzZWxmLl9kZWZhdWx0X2JlZ2luX3dvcmtfcXVldWVfc3RkZXJyKCJzaGVyaWZmLWJvdCIs IHRvb2wuc2NtKCkuY2hlY2tvdXRfcm9vdCksCi0gICAgICAgICAgICAibmV4dF93b3JrX2l0ZW0i OiAiIiwKLSAgICAgICAgICAgICJwcm9jZXNzX3dvcmtfaXRlbSI6ICIiIk1PQ0s6IGlyYy5wb3N0 OiBhYmFydGgsIGRhcmluLCBlc2VpZGVsOiBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNl dC8yOTgzNyBtaWdodCBoYXZlIGJyb2tlbiBCdWlsZGVyMQotTU9DSzogaXJjLnBvc3Q6IE5ldyBm YWlsdXJlczogdGVzdDEsIHRlc3QyLCB0ZXN0MywgdGVzdDQsIHRlc3Q1IChhbmQgMiBtb3JlLi4u KQotIiIiLAotICAgICAgICAgICAgImhhbmRsZV91bmV4cGVjdGVkX2Vycm9yIjogIk1vY2sgZXJy b3IgbWVzc2FnZVxuIiwKLSAgICAgICAgfQotICAgICAgICBzZWxmLmFzc2VydF9xdWV1ZV9vdXRw dXRzKFNoZXJpZmZCb3QoKSwgd29ya19pdGVtPW1vY2tfd29ya19pdGVtLCBleHBlY3RlZF9zdGRl cnI9ZXhwZWN0ZWRfc3RkZXJyKQorICAgIHBhc3MgICMgTm8gdW5pdHRlc3RzIGFzIHRoZSBtb21l bnQuCg==