<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>64137</bug_id>
          
          <creation_ts>2011-07-07 17:27:11 -0700</creation_ts>
          <short_desc>test-webkitpy fails on chromium win</short_desc>
          <delta_ts>2011-07-07 19:22:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dirk Pranke">dpranke</reporter>
          <assigned_to name="Dirk Pranke">dpranke</assigned_to>
          <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>433807</commentid>
    <comment_count>0</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-07-07 17:27:11 -0700</bug_when>
    <thetext>test-webkitpy fails on chromium win</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433810</commentid>
    <comment_count>1</comment_count>
      <attachid>100053</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-07-07 17:31:24 -0700</bug_when>
    <thetext>Created attachment 100053
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433813</commentid>
    <comment_count>2</comment_count>
      <attachid>100053</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-07 17:35:10 -0700</bug_when>
    <thetext>Comment on attachment 100053
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100053&amp;action=review

&gt; Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:37
&gt; +    # FIXME: We don&apos;t test some of the combinations on win32 because paths are returned using the Win32 &quot;\\&quot; conventions
&gt; +    # and the tests will fail. It&apos;s unclear if there&apos;s a good solution to this.

I&apos;m confused by this statement.

&gt; Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:40
&gt; +        if sys.platform != &apos;win32&apos;:

A constant on the class or in the file would read better than checking in each place.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433816</commentid>
    <comment_count>3</comment_count>
      <attachid>100054</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-07-07 17:41:33 -0700</bug_when>
    <thetext>Created attachment 100054
clarify comments per eseidel&apos;s review</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433818</commentid>
    <comment_count>4</comment_count>
      <attachid>100054</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-07 17:42:56 -0700</bug_when>
    <thetext>Comment on attachment 100054
clarify comments per eseidel&apos;s review

View in context: https://bugs.webkit.org/attachment.cgi?id=100054&amp;action=review

&gt; Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:40
&gt; +    # FIXME: We can&apos;t test some of the mac and linux code when running on
&gt; +    # Windows because the filename paths returned from test_files.find()
&gt; +    # have the Win32 &quot;\\&quot; filenames and # the code in the mac and linux ports&apos;
&gt; +    # implementation of &apos;relative_test_filename()&apos; expect them to have forward slashes.
&gt; +    FILES_HAVE_FORWARD_SLASHES = sys.platform != &apos;win32&apos;

This is more clear, but I&apos;m still confused why os.path.sep isn&apos;t our friend here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433819</commentid>
    <comment_count>5</comment_count>
      <attachid>100054</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-07 17:44:21 -0700</bug_when>
    <thetext>Comment on attachment 100054
clarify comments per eseidel&apos;s review

View in context: https://bugs.webkit.org/attachment.cgi?id=100054&amp;action=review

&gt;&gt; Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:40
&gt;&gt; +    FILES_HAVE_FORWARD_SLASHES = sys.platform != &apos;win32&apos;
&gt; 
&gt; This is more clear, but I&apos;m still confused why os.path.sep isn&apos;t our friend here?

Maybe it isn&apos;t worth the effort to make this platform-agnostic.  I don&apos;t know.  That&apos;s your judgment call to make.  But it&apos;s not immediately obvious to me why it&apos;s not platform-agnostic automatically if we&apos;re using os.path.sep where we&apos;re supposed to.  I don&apos;t see any &apos;/&apos; in these tests themselves.  Should we be making this check inside assertOverridesWorked instead of in each test?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433826</commentid>
    <comment_count>6</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-07 17:57:41 -0700</bug_when>
    <thetext>What does the failure look like?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433836</commentid>
    <comment_count>7</comment_count>
      <attachid>100054</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-07 18:11:20 -0700</bug_when>
    <thetext>Comment on attachment 100054
clarify comments per eseidel&apos;s review

I think the real bug here is that these tests should talk to a MockFileSystem.  Since they aren&apos;t, they arent&apos; unit tests and the file should be renamed _integrationtest.py appropriately.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433843</commentid>
    <comment_count>8</comment_count>
      <attachid>100060</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-07-07 18:30:36 -0700</bug_when>
    <thetext>Created attachment 100060
make it clearer that there are integration tests going on</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433844</commentid>
    <comment_count>9</comment_count>
      <attachid>100060</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-07 18:32:05 -0700</bug_when>
    <thetext>Comment on attachment 100060
make it clearer that there are integration tests going on

View in context: https://bugs.webkit.org/attachment.cgi?id=100060&amp;action=review

&gt; Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:50
&gt; +    def integration_test_chromium_gpu_win(self):

Do integration_test methods get run?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433847</commentid>
    <comment_count>10</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-07-07 18:35:45 -0700</bug_when>
    <thetext>The GPU failures (prior to the patch, obviously) looked like:

======================================================================
ERROR: test_get_chromium_gpu__on_linux (webkitpy.layout_tests.port.chromium_gpu_unittest.ChromiumGp
Test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File &quot;d:\src\dev\src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\port\chromium_gpu_uni
test.py&quot;, line 45, in test_get_chromium_gpu__on_linux
    self.assertOverridesWorked(&apos;chromium-gpu-linux&apos;, &apos;chromium-gpu&apos;, &apos;linux2&apos;)
  File &quot;d:\src\dev\src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\port\chromium_gpu_uni
test.py&quot;, line 91, in assertOverridesWorked
    self.assertTrue(path in files)
  File &quot;d:\src\dev\src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\port\chromium_gpu_uni
test.py&quot;, line 91, in assertOverridesWorked
    self.assertTrue(path in files)
  File &quot;d:\src\depot_tools\python_bin\lib\bdb.py&quot;, line 46, in trace_dispatch
    return self.dispatch_line(frame)
  File &quot;d:\src\depot_tools\python_bin\lib\bdb.py&quot;, line 65, in dispatch_line
    if self.quitting: raise BdbQuit
BdbQuit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433848</commentid>
    <comment_count>11</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-07-07 18:39:23 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; (From update of attachment 100060 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=100060&amp;action=review
&gt; 
&gt; &gt; Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:50
&gt; &gt; +    def integration_test_chromium_gpu_win(self):
&gt; 
&gt; Do integration_test methods get run?

Not by default. When you run the test files directly you can run them by specifying the -i flag, e.g.: pythom chromium_gpu_unittest.py -i

I would have put a lot of money on me either having added the -i flag to test-webkitpy, or at least filed a bug and posted a patch for it, but I&apos;m not finding it now, so I&apos;ll file another bug for it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433854</commentid>
    <comment_count>12</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-07-07 18:54:54 -0700</bug_when>
    <thetext>Filed bug 64137 for adding integration test support to test-wekbitpy.

Note that I did not rename the file in this patch, just so you can actually see the diff.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433859</commentid>
    <comment_count>13</comment_count>
      <attachid>100060</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-07 19:13:34 -0700</bug_when>
    <thetext>Comment on attachment 100060
make it clearer that there are integration tests going on

OK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433865</commentid>
    <comment_count>14</comment_count>
      <attachid>100060</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-07-07 19:22:53 -0700</bug_when>
    <thetext>Comment on attachment 100060
make it clearer that there are integration tests going on

Clearing flags on attachment: 100060

Committed r90607: &lt;http://trac.webkit.org/changeset/90607&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433866</commentid>
    <comment_count>15</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-07-07 19:22:58 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>100053</attachid>
            <date>2011-07-07 17:31:24 -0700</date>
            <delta_ts>2011-07-07 17:41:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-64137-20110707173122.patch</filename>
            <type>text/plain</type>
            <size>5108</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTA1ODgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5MWY1ZTEyYTFjZmUzMzQ1NWJjZWIxN2E0MThkNjA1NzRi
N2E0ZjM3Li5iNmIyMWI3OTQ2Yzk0MTFjM2ZlN2VjZjg2MTI3YjUxNDEyODFjZDhiIDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg
QEAKKzIwMTEtMDctMDcgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg
ICAgICAgdGVzdC13ZWJraXRweSBmYWlscyBvbiBjaHJvbWl1bSB3aW4KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MTM3CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdGVzdC13ZWJraXRweSBkb2Vzbid0IHBs
YXkgbmljZWx5IHdpdGggdGhlIG11bHRpcHJvY2Vzc2luZworICAgICAgICBtb2R1bGUgb24gd2lu
MzIuIEFuIGVhcmxpZXIgY2hhbmdlIGFjdHVhbGx5IHJlZW5hYmxlZCB0aGUgdGVzdHMKKyAgICAg
ICAgb24gd2luMzIgYnkgbWlzdGFrZS4KKworICAgICAgICBUaGlzIHBhdGNoIGFsc28gZml4ZXMg
YSBmZXcgY2FzZXMgd2hlcmUgcGF0aCBuYW1lcyB3aWxsIHRyaXAKKyAgICAgICAgdGhpbmdzIHVw
IG9uIHdpbjMyIChlLmcuLCBieSB0ZXN0aW5nIHVuaXggcGF0aHMgb24gd2luZG93cykuCisgICAg
ICAgIFdlIGRvIG5vdCBsb3NlIGFueSByZWFsIGNvdmVyYWdlIGhlcmUgd2l0aCB0aG9zZSBmaXhl
cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p
dW1fZ3B1LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv
Y2hyb21pdW1fZ3B1X3VuaXR0ZXN0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5
b3V0X3Rlc3RzL3BvcnQvbW9ja19kcnRfdW5pdHRlc3QucHk6CisgICAgICAgICogU2NyaXB0cy93
ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHk6
CisKIDIwMTEtMDctMDcgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAg
IE1ha2UgQ2hlY2tvdXQgdXNlIFNDTSdzIEV4ZWN1dGl2ZSBpbnN0ZWFkIG9mIGNvbmp1cmluZyB1
cCBpdHMgb3duCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0
cy9wb3J0L2Nocm9taXVtX2dwdS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl
c3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5Cm9sZCBtb2RlIDEwMDY0NApuZXcgbW9kZSAxMDA3NTUK
ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hy
b21pdW1fZ3B1X3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz
dHMvcG9ydC9jaHJvbWl1bV9ncHVfdW5pdHRlc3QucHkKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2Rl
IDEwMDc1NQppbmRleCAwZDM5OGM3M2ZkNjEwN2ZlOTFiZTBiYWYzMDRhYWFlZjQxMjM0MmJjLi41
OWQ2ODdmMDRkODViZTk3ZGUwZjQzZjJkODM3NjJkM2I3M2UwYTdlCi0tLSBhL1Rvb2xzL1Njcmlw
dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1X3VuaXR0ZXN0LnB5Cisr
KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1
X3VuaXR0ZXN0LnB5CkBAIC0yNCw2ICsyNCw3IEBACiAjIChJTkNMVURJTkcgTkVHTElHRU5DRSBP
UiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQogIyBPRiBUSElT
IFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFN
QUdFLgogCitpbXBvcnQgc3lzCiBpbXBvcnQgdW5pdHRlc3QKIAogZnJvbSB3ZWJraXRweS50b29s
IGltcG9ydCBtb2NrdG9vbApAQCAtMzIsMjEgKzMzLDI4IEBAIGltcG9ydCBjaHJvbWl1bV9ncHUK
IGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQgaW1wb3J0IGZhY3RvcnkKIAogY2xhc3Mg
Q2hyb21pdW1HcHVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAgICAjIEZJWE1FOiBXZSBkb24n
dCB0ZXN0IHNvbWUgb2YgdGhlIGNvbWJpbmF0aW9ucyBvbiB3aW4zMiBiZWNhdXNlIHBhdGhzIGFy
ZSByZXR1cm5lZCB1c2luZyB0aGUgV2luMzIgIlxcIiBjb252ZW50aW9ucworICAgICMgYW5kIHRo
ZSB0ZXN0cyB3aWxsIGZhaWwuIEl0J3MgdW5jbGVhciBpZiB0aGVyZSdzIGEgZ29vZCBzb2x1dGlv
biB0byB0aGlzLgorCiAgICAgZGVmIHRlc3RfZ2V0X2Nocm9taXVtX2dwdV9saW51eChzZWxmKToK
LSAgICAgICAgc2VsZi5hc3NlcnRPdmVycmlkZXNXb3JrZWQoJ2Nocm9taXVtLWdwdS1saW51eCcp
CisgICAgICAgIGlmIHN5cy5wbGF0Zm9ybSAhPSAnd2luMzInOgorICAgICAgICAgICAgc2VsZi5h
c3NlcnRPdmVycmlkZXNXb3JrZWQoJ2Nocm9taXVtLWdwdS1saW51eCcpCiAKICAgICBkZWYgdGVz
dF9nZXRfY2hyb21pdW1fZ3B1X21hYyhzZWxmKToKLSAgICAgICAgc2VsZi5hc3NlcnRPdmVycmlk
ZXNXb3JrZWQoJ2Nocm9taXVtLWdwdS1tYWMnKQorICAgICAgICBpZiBzeXMucGxhdGZvcm0gIT0g
J3dpbjMyJzoKKyAgICAgICAgICAgIHNlbGYuYXNzZXJ0T3ZlcnJpZGVzV29ya2VkKCdjaHJvbWl1
bS1ncHUtbWFjJykKIAogICAgIGRlZiB0ZXN0X2dldF9jaHJvbWl1bV9ncHVfd2luKHNlbGYpOgog
ICAgICAgICBzZWxmLmFzc2VydE92ZXJyaWRlc1dvcmtlZCgnY2hyb21pdW0tZ3B1LXdpbicpCiAK
ICAgICBkZWYgdGVzdF9nZXRfY2hyb21pdW1fZ3B1X19vbl9saW51eChzZWxmKToKLSAgICAgICAg
c2VsZi5hc3NlcnRPdmVycmlkZXNXb3JrZWQoJ2Nocm9taXVtLWdwdS1saW51eCcsICdjaHJvbWl1
bS1ncHUnLCAnbGludXgyJykKLSAgICAgICAgc2VsZi5hc3NlcnRPdmVycmlkZXNXb3JrZWQoJ2No
cm9taXVtLWdwdS1saW51eCcsICdjaHJvbWl1bS1ncHUnLCAnbGludXgzJykKKyAgICAgICAgaWYg
c3lzLnBsYXRmb3JtICE9ICd3aW4zMic6CisgICAgICAgICAgICBzZWxmLmFzc2VydE92ZXJyaWRl
c1dvcmtlZCgnY2hyb21pdW0tZ3B1LWxpbnV4JywgJ2Nocm9taXVtLWdwdScsICdsaW51eDInKQor
ICAgICAgICAgICAgc2VsZi5hc3NlcnRPdmVycmlkZXNXb3JrZWQoJ2Nocm9taXVtLWdwdS1saW51
eCcsICdjaHJvbWl1bS1ncHUnLCAnbGludXgzJykKIAogICAgIGRlZiB0ZXN0X2dldF9jaHJvbWl1
bV9ncHVfX29uX21hYyhzZWxmKToKLSAgICAgICAgc2VsZi5hc3NlcnRPdmVycmlkZXNXb3JrZWQo
J2Nocm9taXVtLWdwdS1tYWMnLCAnY2hyb21pdW0tZ3B1JywgJ2RhcndpbicpCisgICAgICAgIGlm
IHN5cy5wbGF0Zm9ybSAhPSAnd2luMzInOgorICAgICAgICAgICAgc2VsZi5hc3NlcnRPdmVycmlk
ZXNXb3JrZWQoJ2Nocm9taXVtLWdwdS1tYWMnLCAnY2hyb21pdW0tZ3B1JywgJ2RhcndpbicpCiAK
ICAgICBkZWYgdGVzdF9nZXRfY2hyb21pdW1fZ3B1X19vbl93aW4oc2VsZik6CiAgICAgICAgIHNl
bGYuYXNzZXJ0T3ZlcnJpZGVzV29ya2VkKCdjaHJvbWl1bS1ncHUtd2luJywgJ2Nocm9taXVtLWdw
dScsICd3aW4zMicpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90
ZXN0cy9wb3J0L21vY2tfZHJ0X3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s
YXlvdXRfdGVzdHMvcG9ydC9tb2NrX2RydF91bml0dGVzdC5weQpvbGQgbW9kZSAxMDA2NDQKbmV3
IG1vZGUgMTAwNzU1CmluZGV4IGI2MGQ5ODE2YzU3NDkzMDRjZGFmMjdjZGU3ZmNjNWFmMTE1Mzk1
ZmEuLjZlNzVhYzk1NWQ1NDU0NzkzOWEyNmIwMzllZWMwN2M3YjliNDBjMDUKLS0tIGEvVG9vbHMv
U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tb2NrX2RydF91bml0dGVzdC5weQor
KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21vY2tfZHJ0X3Vu
aXR0ZXN0LnB5CkBAIC02MCw2ICs2MCw5IEBAIGNsYXNzIE1vY2tEUlRQb3J0VGVzdChwb3J0X3Rl
c3RjYXNlLlBvcnRUZXN0Q2FzZSk6CiAgICAgZGVmIHRlc3RfY2hlY2tfc3lzX2RlcHMoc2VsZik6
CiAgICAgICAgIHBhc3MKIAorICAgIGRlZiB0ZXN0X3VzZXNfYXBhY2hlKHNlbGYpOgorICAgICAg
ICBwYXNzCisKICAgICBkZWYgaW50ZWdyYXRpb25fdGVzdF9odHRwX2xvY2soc2VsZik6CiAgICAg
ICAgIHBhc3MKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz
dHMvcnVuX3dlYmtpdF90ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dl
YmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX2ludGVncmF0aW9udGVzdC5weQpv
bGQgbW9kZSAxMDA2NDQKbmV3IG1vZGUgMTAwNzU1CmluZGV4IGFhMDMwZjJhY2M2MmFkZWJjZGQx
NzlkMmMzOWU0NTM2MDdkODlkZTAuLjhmNGI1MWY3MTllOTIzOTY5OTU5MGYyOTVhZjMyNzA5NmNk
MDAwZDcKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtp
dF90ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s
YXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHkKQEAgLTUxLDcg
KzUxLDcgQEAgZXhjZXB0IEltcG9ydEVycm9yOgogCiAjIEZJWE1FOiByZW1vdmUgdGhpcyB3aGVu
IHdlIGZpeCB0ZXN0LXdlYmtpdHB5IHRvIHdvcmsgcHJvcGVybHkgb24gY3lnd2luCiAjIChidWcg
NjM4NDYpLgotU0hPVUxEX1RFU1RfUFJPQ0VTU0VTID0gbXVsdGlwcm9jZXNzaW5nIGFuZCBzeXMu
cGxhdGZvcm0gbm90IGluICgnY3lnd2luJykKK1NIT1VMRF9URVNUX1BST0NFU1NFUyA9IG11bHRp
cHJvY2Vzc2luZyBhbmQgc3lzLnBsYXRmb3JtIG5vdCBpbiAoJ2N5Z3dpbicsICd3aW4zMicpCiAK
IGZyb20gd2Via2l0cHkuY29tbW9uIGltcG9ydCBhcnJheV9zdHJlYW0KIGZyb20gd2Via2l0cHku
Y29tbW9uLnN5c3RlbSBpbXBvcnQgb3V0cHV0Y2FwdHVyZQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>100054</attachid>
            <date>2011-07-07 17:41:33 -0700</date>
            <delta_ts>2011-07-07 18:30:33 -0700</delta_ts>
            <desc>clarify comments per eseidel&apos;s review</desc>
            <filename>bug-64137-20110707174131.patch</filename>
            <type>text/plain</type>
            <size>5152</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTA1ODgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5MWY1ZTEyYTFjZmUzMzQ1NWJjZWIxN2E0MThkNjA1NzRi
N2E0ZjM3Li5iNmIyMWI3OTQ2Yzk0MTFjM2ZlN2VjZjg2MTI3YjUxNDEyODFjZDhiIDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg
QEAKKzIwMTEtMDctMDcgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg
ICAgICAgdGVzdC13ZWJraXRweSBmYWlscyBvbiBjaHJvbWl1bSB3aW4KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MTM3CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdGVzdC13ZWJraXRweSBkb2Vzbid0IHBs
YXkgbmljZWx5IHdpdGggdGhlIG11bHRpcHJvY2Vzc2luZworICAgICAgICBtb2R1bGUgb24gd2lu
MzIuIEFuIGVhcmxpZXIgY2hhbmdlIGFjdHVhbGx5IHJlZW5hYmxlZCB0aGUgdGVzdHMKKyAgICAg
ICAgb24gd2luMzIgYnkgbWlzdGFrZS4KKworICAgICAgICBUaGlzIHBhdGNoIGFsc28gZml4ZXMg
YSBmZXcgY2FzZXMgd2hlcmUgcGF0aCBuYW1lcyB3aWxsIHRyaXAKKyAgICAgICAgdGhpbmdzIHVw
IG9uIHdpbjMyIChlLmcuLCBieSB0ZXN0aW5nIHVuaXggcGF0aHMgb24gd2luZG93cykuCisgICAg
ICAgIFdlIGRvIG5vdCBsb3NlIGFueSByZWFsIGNvdmVyYWdlIGhlcmUgd2l0aCB0aG9zZSBmaXhl
cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p
dW1fZ3B1LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv
Y2hyb21pdW1fZ3B1X3VuaXR0ZXN0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5
b3V0X3Rlc3RzL3BvcnQvbW9ja19kcnRfdW5pdHRlc3QucHk6CisgICAgICAgICogU2NyaXB0cy93
ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHk6
CisKIDIwMTEtMDctMDcgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAg
IE1ha2UgQ2hlY2tvdXQgdXNlIFNDTSdzIEV4ZWN1dGl2ZSBpbnN0ZWFkIG9mIGNvbmp1cmluZyB1
cCBpdHMgb3duCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0
cy9wb3J0L2Nocm9taXVtX2dwdV91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv
bGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1X3VuaXR0ZXN0LnB5Cm9sZCBtb2RlIDEwMDY0
NApuZXcgbW9kZSAxMDA3NTUKaW5kZXggMGQzOThjNzNmZDYxMDdmZTkxYmUwYmFmMzA0YWFhZWY0
MTIzNDJiYy4uODZkZDU1YWQ0NGM0YzRhMWI1MWFlOTYzMTRkZDQ1MWM0YWNjZGRkZgotLS0gYS9U
b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdV91bml0
dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2No
cm9taXVtX2dwdV91bml0dGVzdC5weQpAQCAtMjQsNiArMjQsNyBAQAogIyAoSU5DTFVESU5HIE5F
R0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UK
ICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBP
RiBTVUNIIERBTUFHRS4KIAoraW1wb3J0IHN5cwogaW1wb3J0IHVuaXR0ZXN0CiAKIGZyb20gd2Vi
a2l0cHkudG9vbCBpbXBvcnQgbW9ja3Rvb2wKQEAgLTMyLDIxICszMywzMSBAQCBpbXBvcnQgY2hy
b21pdW1fZ3B1CiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5wb3J0IGltcG9ydCBmYWN0b3J5
CiAKIGNsYXNzIENocm9taXVtR3B1VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CisgICAgIyBGSVhN
RTogV2UgY2FuJ3QgdGVzdCBzb21lIG9mIHRoZSBtYWMgYW5kIGxpbnV4IGNvZGUgd2hlbiBydW5u
aW5nIG9uCisgICAgIyBXaW5kb3dzIGJlY2F1c2UgdGhlIGZpbGVuYW1lIHBhdGhzIHJldHVybmVk
IGZyb20gdGVzdF9maWxlcy5maW5kKCkKKyAgICAjIGhhdmUgdGhlIFdpbjMyICJcXCIgZmlsZW5h
bWVzIGFuZCAjIHRoZSBjb2RlIGluIHRoZSBtYWMgYW5kIGxpbnV4IHBvcnRzJworICAgICMgaW1w
bGVtZW50YXRpb24gb2YgJ3JlbGF0aXZlX3Rlc3RfZmlsZW5hbWUoKScgZXhwZWN0IHRoZW0gdG8g
aGF2ZSBmb3J3YXJkIHNsYXNoZXMuCisgICAgRklMRVNfSEFWRV9GT1JXQVJEX1NMQVNIRVMgPSBz
eXMucGxhdGZvcm0gIT0gJ3dpbjMyJworCiAgICAgZGVmIHRlc3RfZ2V0X2Nocm9taXVtX2dwdV9s
aW51eChzZWxmKToKLSAgICAgICAgc2VsZi5hc3NlcnRPdmVycmlkZXNXb3JrZWQoJ2Nocm9taXVt
LWdwdS1saW51eCcpCisgICAgICAgIGlmIHNlbGYuRklMRVNfSEFWRV9GT1JXQVJEX1NMQVNIRVM6
CisgICAgICAgICAgICBzZWxmLmFzc2VydE92ZXJyaWRlc1dvcmtlZCgnY2hyb21pdW0tZ3B1LWxp
bnV4JykKIAogICAgIGRlZiB0ZXN0X2dldF9jaHJvbWl1bV9ncHVfbWFjKHNlbGYpOgotICAgICAg
ICBzZWxmLmFzc2VydE92ZXJyaWRlc1dvcmtlZCgnY2hyb21pdW0tZ3B1LW1hYycpCisgICAgICAg
IGlmIHNlbGYuRklMRVNfSEFWRV9GT1JXQVJEX1NMQVNIRVM6CisgICAgICAgICAgICBzZWxmLmFz
c2VydE92ZXJyaWRlc1dvcmtlZCgnY2hyb21pdW0tZ3B1LW1hYycpCiAKICAgICBkZWYgdGVzdF9n
ZXRfY2hyb21pdW1fZ3B1X3dpbihzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRPdmVycmlkZXNX
b3JrZWQoJ2Nocm9taXVtLWdwdS13aW4nKQogCiAgICAgZGVmIHRlc3RfZ2V0X2Nocm9taXVtX2dw
dV9fb25fbGludXgoc2VsZik6Ci0gICAgICAgIHNlbGYuYXNzZXJ0T3ZlcnJpZGVzV29ya2VkKCdj
aHJvbWl1bS1ncHUtbGludXgnLCAnY2hyb21pdW0tZ3B1JywgJ2xpbnV4MicpCi0gICAgICAgIHNl
bGYuYXNzZXJ0T3ZlcnJpZGVzV29ya2VkKCdjaHJvbWl1bS1ncHUtbGludXgnLCAnY2hyb21pdW0t
Z3B1JywgJ2xpbnV4MycpCisgICAgICAgIGlmIHNlbGYuRklMRVNfSEFWRV9GT1JXQVJEX1NMQVNI
RVM6CisgICAgICAgICAgICBzZWxmLmFzc2VydE92ZXJyaWRlc1dvcmtlZCgnY2hyb21pdW0tZ3B1
LWxpbnV4JywgJ2Nocm9taXVtLWdwdScsICdsaW51eDInKQorICAgICAgICAgICAgc2VsZi5hc3Nl
cnRPdmVycmlkZXNXb3JrZWQoJ2Nocm9taXVtLWdwdS1saW51eCcsICdjaHJvbWl1bS1ncHUnLCAn
bGludXgzJykKIAogICAgIGRlZiB0ZXN0X2dldF9jaHJvbWl1bV9ncHVfX29uX21hYyhzZWxmKToK
LSAgICAgICAgc2VsZi5hc3NlcnRPdmVycmlkZXNXb3JrZWQoJ2Nocm9taXVtLWdwdS1tYWMnLCAn
Y2hyb21pdW0tZ3B1JywgJ2RhcndpbicpCisgICAgICAgIGlmIHNlbGYuRklMRVNfSEFWRV9GT1JX
QVJEX1NMQVNIRVM6CisgICAgICAgICAgICBzZWxmLmFzc2VydE92ZXJyaWRlc1dvcmtlZCgnY2hy
b21pdW0tZ3B1LW1hYycsICdjaHJvbWl1bS1ncHUnLCAnZGFyd2luJykKIAogICAgIGRlZiB0ZXN0
X2dldF9jaHJvbWl1bV9ncHVfX29uX3dpbihzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRPdmVy
cmlkZXNXb3JrZWQoJ2Nocm9taXVtLWdwdS13aW4nLCAnY2hyb21pdW0tZ3B1JywgJ3dpbjMyJykK
ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbW9j
a19kcnRfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w
b3J0L21vY2tfZHJ0X3VuaXR0ZXN0LnB5Cm9sZCBtb2RlIDEwMDY0NApuZXcgbW9kZSAxMDA3NTUK
aW5kZXggYjYwZDk4MTZjNTc0OTMwNGNkYWYyN2NkZTdmY2M1YWYxMTUzOTVmYS4uNmU3NWFjOTU1
ZDU0NTQ3OTM5YTI2YjAzOWVlYzA3YzdiOWI0MGMwNQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp
dHB5L2xheW91dF90ZXN0cy9wb3J0L21vY2tfZHJ0X3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1Nj
cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbW9ja19kcnRfdW5pdHRlc3QucHkKQEAg
LTYwLDYgKzYwLDkgQEAgY2xhc3MgTW9ja0RSVFBvcnRUZXN0KHBvcnRfdGVzdGNhc2UuUG9ydFRl
c3RDYXNlKToKICAgICBkZWYgdGVzdF9jaGVja19zeXNfZGVwcyhzZWxmKToKICAgICAgICAgcGFz
cwogCisgICAgZGVmIHRlc3RfdXNlc19hcGFjaGUoc2VsZik6CisgICAgICAgIHBhc3MKKwogICAg
IGRlZiBpbnRlZ3JhdGlvbl90ZXN0X2h0dHBfbG9jayhzZWxmKToKICAgICAgICAgcGFzcwogCmRp
ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0
X3Rlc3RzX2ludGVncmF0aW9udGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0
X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5Cm9sZCBtb2RlIDEwMDY0
NApuZXcgbW9kZSAxMDA3NTUKaW5kZXggYWEwMzBmMmFjYzYyYWRlYmNkZDE3OWQyYzM5ZTQ1MzYw
N2Q4OWRlMC4uOGY0YjUxZjcxOWU5MjM5Njk5NTkwZjI5NWFmMzI3MDk2Y2QwMDBkNwotLS0gYS9U
b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX2ludGVn
cmF0aW9udGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9y
dW5fd2Via2l0X3Rlc3RzX2ludGVncmF0aW9udGVzdC5weQpAQCAtNTEsNyArNTEsNyBAQCBleGNl
cHQgSW1wb3J0RXJyb3I6CiAKICMgRklYTUU6IHJlbW92ZSB0aGlzIHdoZW4gd2UgZml4IHRlc3Qt
d2Via2l0cHkgdG8gd29yayBwcm9wZXJseSBvbiBjeWd3aW4KICMgKGJ1ZyA2Mzg0NikuCi1TSE9V
TERfVEVTVF9QUk9DRVNTRVMgPSBtdWx0aXByb2Nlc3NpbmcgYW5kIHN5cy5wbGF0Zm9ybSBub3Qg
aW4gKCdjeWd3aW4nKQorU0hPVUxEX1RFU1RfUFJPQ0VTU0VTID0gbXVsdGlwcm9jZXNzaW5nIGFu
ZCBzeXMucGxhdGZvcm0gbm90IGluICgnY3lnd2luJywgJ3dpbjMyJykKIAogZnJvbSB3ZWJraXRw
eS5jb21tb24gaW1wb3J0IGFycmF5X3N0cmVhbQogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVt
IGltcG9ydCBvdXRwdXRjYXB0dXJlCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>100060</attachid>
            <date>2011-07-07 18:30:36 -0700</date>
            <delta_ts>2011-07-07 19:22:53 -0700</delta_ts>
            <desc>make it clearer that there are integration tests going on</desc>
            <filename>bug-64137-20110707183035.patch</filename>
            <type>text/plain</type>
            <size>7338</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTA1ODgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5MWY1ZTEyYTFjZmUzMzQ1NWJjZWIxN2E0MThkNjA1NzRi
N2E0ZjM3Li5iNmIyMWI3OTQ2Yzk0MTFjM2ZlN2VjZjg2MTI3YjUxNDEyODFjZDhiIDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg
QEAKKzIwMTEtMDctMDcgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg
ICAgICAgdGVzdC13ZWJraXRweSBmYWlscyBvbiBjaHJvbWl1bSB3aW4KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MTM3CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdGVzdC13ZWJraXRweSBkb2Vzbid0IHBs
YXkgbmljZWx5IHdpdGggdGhlIG11bHRpcHJvY2Vzc2luZworICAgICAgICBtb2R1bGUgb24gd2lu
MzIuIEFuIGVhcmxpZXIgY2hhbmdlIGFjdHVhbGx5IHJlZW5hYmxlZCB0aGUgdGVzdHMKKyAgICAg
ICAgb24gd2luMzIgYnkgbWlzdGFrZS4KKworICAgICAgICBUaGlzIHBhdGNoIGFsc28gZml4ZXMg
YSBmZXcgY2FzZXMgd2hlcmUgcGF0aCBuYW1lcyB3aWxsIHRyaXAKKyAgICAgICAgdGhpbmdzIHVw
IG9uIHdpbjMyIChlLmcuLCBieSB0ZXN0aW5nIHVuaXggcGF0aHMgb24gd2luZG93cykuCisgICAg
ICAgIFdlIGRvIG5vdCBsb3NlIGFueSByZWFsIGNvdmVyYWdlIGhlcmUgd2l0aCB0aG9zZSBmaXhl
cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p
dW1fZ3B1LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv
Y2hyb21pdW1fZ3B1X3VuaXR0ZXN0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5
b3V0X3Rlc3RzL3BvcnQvbW9ja19kcnRfdW5pdHRlc3QucHk6CisgICAgICAgICogU2NyaXB0cy93
ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c19pbnRlZ3JhdGlvbnRlc3QucHk6
CisKIDIwMTEtMDctMDcgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAg
IE1ha2UgQ2hlY2tvdXQgdXNlIFNDTSdzIEV4ZWN1dGl2ZSBpbnN0ZWFkIG9mIGNvbmp1cmluZyB1
cCBpdHMgb3duCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0
cy9wb3J0L2Jhc2UucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0
L2Jhc2UucHkKaW5kZXggZDdkOGNmZmU1YTQwMzdkYWFkZjdmNzJiN2IxODc1M2NhZjc0ZmNiMy4u
ZGZkYmIwMzM4NzY0ZTU2ZmQ3ZmZjZTJlMTgyOGU1YTJhNjVjNTcxZiAxMDA3NTUKLS0tIGEvVG9v
bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CisrKyBiL1Rvb2xz
L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQpAQCAtNjA0LDExICs2
MDQsMTEgQEAgY2xhc3MgUG9ydChvYmplY3QpOgogICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRl
ZEVycm9yKCdQb3J0LnBhdGhfdG9fdGVzdF9leHBlY3RhdGlvbnNfZmlsZScpCiAKICAgICBkZWYg
cmVsYXRpdmVfdGVzdF9maWxlbmFtZShzZWxmLCBmaWxlbmFtZSk6Ci0gICAgICAgICIiIlJlbGF0
aXZlIHVuaXgtc3R5bGUgcGF0aCBmb3IgYSBmaWxlbmFtZSB1bmRlciB0aGUgTGF5b3V0VGVzdHMK
KyAgICAgICAgIiIiUmV0dXJucyBhIHRlc3RfbmFtZSBhIHJlYWx0aXZlIHVuaXgtc3R5bGUgcGF0
aCBmb3IgYSBmaWxlbmFtZSB1bmRlciB0aGUgTGF5b3V0VGVzdHMKICAgICAgICAgZGlyZWN0b3J5
LiBGaWxlbmFtZXMgb3V0c2lkZSB0aGUgTGF5b3V0VGVzdHMgZGlyZWN0b3J5IHNob3VsZCByYWlz
ZQogICAgICAgICBhbiBlcnJvci4iIiIKLSAgICAgICAgIyBGSVhNRTogT24gV2luZG93cywgZG9l
cyB0aGlzIHJldHVybiB0ZXN0X25hbWVzIHdpdGggZm9yd2FyZCBzbGFzaGVzLAotICAgICAgICAj
IG9yIHdpbmRvd3Mtc3R5bGUgcmVsYXRpdmUgcGF0aHM/CisgICAgICAgICMgUG9ydHMgdGhhdCBy
dW4gb24gd2luZG93cyBuZWVkIHRvIG92ZXJyaWRlIHRoaXMgbWV0aG9kIHRvIGRlYWwgd2l0aAor
ICAgICAgICAjIGZpbGVuYW1lcyB3aXRoIGJhY2tzbGFzaGVzIGluIHRoZW0uCiAgICAgICAgIGFz
c2VydCBmaWxlbmFtZS5zdGFydHN3aXRoKHNlbGYubGF5b3V0X3Rlc3RzX2RpcigpKSwgIiVzIGRp
ZCBub3Qgc3RhcnQgd2l0aCAlcyIgJSAoZmlsZW5hbWUsIHNlbGYubGF5b3V0X3Rlc3RzX2Rpcigp
KQogICAgICAgICByZXR1cm4gZmlsZW5hbWVbbGVuKHNlbGYubGF5b3V0X3Rlc3RzX2RpcigpKSAr
IDE6XQogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w
b3J0L2Nocm9taXVtX2dwdV91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5
b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1X3VuaXR0ZXN0LnB5Cm9sZCBtb2RlIDEwMDY0NApu
ZXcgbW9kZSAxMDA3NTUKaW5kZXggMGQzOThjNzNmZDYxMDdmZTkxYmUwYmFmMzA0YWFhZWY0MTIz
NDJiYy4uMDNjOGU0ZTFjYjdhN2MxNDE0ZGQ0ZWY4N2Q5MDY3NzY3ZmVkNzBkNgotLS0gYS9Ub29s
cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdV91bml0dGVz
dC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9t
aXVtX2dwdV91bml0dGVzdC5weQpAQCAtMjQsMzUgKzI0LDM3IEBACiAjIChJTkNMVURJTkcgTkVH
TElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQog
IyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9G
IFNVQ0ggREFNQUdFLgogCitpbXBvcnQgc3lzCiBpbXBvcnQgdW5pdHRlc3QKIAogZnJvbSB3ZWJr
aXRweS50b29sIGltcG9ydCBtb2NrdG9vbAogaW1wb3J0IGNocm9taXVtX2dwdQogCiBmcm9tIHdl
YmtpdHB5LmxheW91dF90ZXN0cy5wb3J0IGltcG9ydCBmYWN0b3J5Citmcm9tIHdlYmtpdHB5Lmxh
eW91dF90ZXN0cy5wb3J0IGltcG9ydCBwb3J0X3Rlc3RjYXNlCiAKIGNsYXNzIENocm9taXVtR3B1
VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6Ci0gICAgZGVmIHRlc3RfZ2V0X2Nocm9taXVtX2dwdV9s
aW51eChzZWxmKToKLSAgICAgICAgc2VsZi5hc3NlcnRPdmVycmlkZXNXb3JrZWQoJ2Nocm9taXVt
LWdwdS1saW51eCcpCi0KLSAgICBkZWYgdGVzdF9nZXRfY2hyb21pdW1fZ3B1X21hYyhzZWxmKToK
LSAgICAgICAgc2VsZi5hc3NlcnRPdmVycmlkZXNXb3JrZWQoJ2Nocm9taXVtLWdwdS1tYWMnKQot
Ci0gICAgZGVmIHRlc3RfZ2V0X2Nocm9taXVtX2dwdV93aW4oc2VsZik6Ci0gICAgICAgIHNlbGYu
YXNzZXJ0T3ZlcnJpZGVzV29ya2VkKCdjaHJvbWl1bS1ncHUtd2luJykKLQotICAgIGRlZiB0ZXN0
X2dldF9jaHJvbWl1bV9ncHVfX29uX2xpbnV4KHNlbGYpOgotICAgICAgICBzZWxmLmFzc2VydE92
ZXJyaWRlc1dvcmtlZCgnY2hyb21pdW0tZ3B1LWxpbnV4JywgJ2Nocm9taXVtLWdwdScsICdsaW51
eDInKQotICAgICAgICBzZWxmLmFzc2VydE92ZXJyaWRlc1dvcmtlZCgnY2hyb21pdW0tZ3B1LWxp
bnV4JywgJ2Nocm9taXVtLWdwdScsICdsaW51eDMnKQotCi0gICAgZGVmIHRlc3RfZ2V0X2Nocm9t
aXVtX2dwdV9fb25fbWFjKHNlbGYpOgotICAgICAgICBzZWxmLmFzc2VydE92ZXJyaWRlc1dvcmtl
ZCgnY2hyb21pdW0tZ3B1LW1hYycsICdjaHJvbWl1bS1ncHUnLCAnZGFyd2luJykKLQotICAgIGRl
ZiB0ZXN0X2dldF9jaHJvbWl1bV9ncHVfX29uX3dpbihzZWxmKToKLSAgICAgICAgc2VsZi5hc3Nl
cnRPdmVycmlkZXNXb3JrZWQoJ2Nocm9taXVtLWdwdS13aW4nLCAnY2hyb21pdW0tZ3B1JywgJ3dp
bjMyJykKLSAgICAgICAgc2VsZi5hc3NlcnRPdmVycmlkZXNXb3JrZWQoJ2Nocm9taXVtLWdwdS13
aW4nLCAnY2hyb21pdW0tZ3B1JywgJ2N5Z3dpbicpCi0KLSAgICBkZWYgYXNzZXJ0T3ZlcnJpZGVz
V29ya2VkKHNlbGYsIHBvcnRfbmFtZSwgaW5wdXRfbmFtZT1Ob25lLCBwbGF0Zm9ybT1Ob25lKToK
KyAgICBkZWYgaW50ZWdyYXRpb25fdGVzdF9jaHJvbWl1bV9ncHVfbGludXgoc2VsZik6CisgICAg
ICAgIGlmIHN5cy5wbGF0Zm9ybSBub3QgaW4gKCdsaW51eDInLCAnbGludXgzJyk6CisgICAgICAg
ICAgICByZXR1cm4KKyAgICAgICAgc2VsZi5hc3NlcnRfcG9ydF93b3JrcygnY2hyb21pdW0tZ3B1
LWxpbnV4JykKKyAgICAgICAgc2VsZi5hc3NlcnRfcG9ydF93b3JrcygnY2hyb21pdW0tZ3B1LWxp
bnV4JywgJ2Nocm9taXVtLWdwdScsICdsaW51eDInKQorICAgICAgICBzZWxmLmFzc2VydF9wb3J0
X3dvcmtzKCdjaHJvbWl1bS1ncHUtbGludXgnLCAnY2hyb21pdW0tZ3B1JywgJ2xpbnV4MycpCisK
KyAgICBkZWYgaW50ZWdyYXRpb25fdGVzdF9jaHJvbWl1bV9ncHVfbWFjKHNlbGYpOgorICAgICAg
ICBpZiBzeXMucGxhdGZvcm0gIT0gJ2Rhcndpbic6CisgICAgICAgICAgICByZXR1cm4KKyAgICAg
ICAgc2VsZi5hc3NlcnRfcG9ydF93b3JrcygnY2hyb21pdW0tZ3B1LW1hYycpCisgICAgICAgIHNl
bGYuYXNzZXJ0X3BvcnRfd29ya3MoJ2Nocm9taXVtLWdwdS1tYWMnLCAnY2hyb21pdW0tZ3B1Jywg
J2RhcndpbicpCisKKyAgICBkZWYgaW50ZWdyYXRpb25fdGVzdF9jaHJvbWl1bV9ncHVfd2luKHNl
bGYpOgorICAgICAgICBpZiBzeXMucGxhdGZvcm0gbm90IGluICgnY3lnd2luJywgJ3dpbjMyJyk6
CisgICAgICAgICAgICByZXR1cm4KKyAgICAgICAgc2VsZi5hc3NlcnRfcG9ydF93b3JrcygnY2hy
b21pdW0tZ3B1LXdpbicpCisgICAgICAgIHNlbGYuYXNzZXJ0X3BvcnRfd29ya3MoJ2Nocm9taXVt
LWdwdS13aW4nLCAnY2hyb21pdW0tZ3B1JywgJ3dpbjMyJykKKyAgICAgICAgc2VsZi5hc3NlcnRf
cG9ydF93b3JrcygnY2hyb21pdW0tZ3B1LXdpbicsICdjaHJvbWl1bS1ncHUnLCAnY3lnd2luJykK
KworICAgIGRlZiBhc3NlcnRfcG9ydF93b3JrcyhzZWxmLCBwb3J0X25hbWUsIGlucHV0X25hbWU9
Tm9uZSwgcGxhdGZvcm09Tm9uZSk6CiAgICAgICAgICMgdGVzdCB0aGF0IHdlIGdvdCB0aGUgcmln
aHQgcG9ydAogICAgICAgICBtb2NrX29wdGlvbnMgPSBtb2NrdG9vbC5Nb2NrT3B0aW9ucyhhY2Nl
bGVyYXRlZF9jb21wb3NpdGluZz1Ob25lLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBhY2NlbGVyYXRlZF8yZF9jYW52YXM9Tm9uZSwKQEAgLTgyLDYgKzg0LDgg
QEAgY2xhc3MgQ2hyb21pdW1HcHVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgIyBU
ZXN0IHRoYXQgd2UncmUgbGltaXRpbmcgdG8gdGhlIGNvcnJlY3QgZGlyZWN0b3JpZXMuCiAgICAg
ICAgICMgVGhlc2UgdHdvIHRlc3RzIGFyZSBwaWNrZWQgbW9zdGx5IGF0IHJhbmRvbSwgYnV0IHdl
IG1ha2Ugc3VyZSB0aGV5CiAgICAgICAgICMgZXhpc3Qgc2VwYXJhdGVseSBmcm9tIGJlaW5nIGZp
bHRlcmVkIG91dCBieSB0aGUgcG9ydC4KKworICAgICAgICAjIE5vdGUgdGhhdCB0aGlzIGlzIHVz
aW5nIGEgcmVhbCBmaWxlc3lzdGVtLgogICAgICAgICBmaWxlcyA9IHBvcnQudGVzdHMoTm9uZSkK
IAogICAgICAgICBwYXRoID0gJ2NvbXBvc2l0aW5nL2NoZWNrZXJib2FyZC5odG1sJwpAQCAtMTIz
LDQgKzEyNyw0IEBAIGNsYXNzIENocm9taXVtR3B1VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAK
IAogaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKLSAgICB1bml0dGVzdC5tYWluKCkKKyAgICBw
b3J0X3Rlc3RjYXNlLm1haW4oKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s
YXlvdXRfdGVzdHMvcG9ydC9tb2NrX2RydF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi
a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbW9ja19kcnRfdW5pdHRlc3QucHkKb2xkIG1vZGUgMTAw
NjQ0Cm5ldyBtb2RlIDEwMDc1NQppbmRleCBiNjBkOTgxNmM1NzQ5MzA0Y2RhZjI3Y2RlN2ZjYzVh
ZjExNTM5NWZhLi42ZTc1YWM5NTVkNTQ1NDc5MzlhMjZiMDM5ZWVjMDdjN2I5YjQwYzA1Ci0tLSBh
L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbW9ja19kcnRfdW5pdHRl
c3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tb2Nr
X2RydF91bml0dGVzdC5weQpAQCAtNjAsNiArNjAsOSBAQCBjbGFzcyBNb2NrRFJUUG9ydFRlc3Qo
cG9ydF90ZXN0Y2FzZS5Qb3J0VGVzdENhc2UpOgogICAgIGRlZiB0ZXN0X2NoZWNrX3N5c19kZXBz
KHNlbGYpOgogICAgICAgICBwYXNzCiAKKyAgICBkZWYgdGVzdF91c2VzX2FwYWNoZShzZWxmKToK
KyAgICAgICAgcGFzcworCiAgICAgZGVmIGludGVncmF0aW9uX3Rlc3RfaHR0cF9sb2NrKHNlbGYp
OgogICAgICAgICBwYXNzCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5
b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5IGIvVG9vbHMvU2Ny
aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c19pbnRlZ3JhdGlvbnRl
c3QucHkKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQppbmRleCBhYTAzMGYyYWNjNjJh
ZGViY2RkMTc5ZDJjMzllNDUzNjA3ZDg5ZGUwLi44ZjRiNTFmNzE5ZTkyMzk2OTk1OTBmMjk1YWYz
MjcwOTZjZDAwMGQ3Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1
bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi
a2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5CkBA
IC01MSw3ICs1MSw3IEBAIGV4Y2VwdCBJbXBvcnRFcnJvcjoKIAogIyBGSVhNRTogcmVtb3ZlIHRo
aXMgd2hlbiB3ZSBmaXggdGVzdC13ZWJraXRweSB0byB3b3JrIHByb3Blcmx5IG9uIGN5Z3dpbgog
IyAoYnVnIDYzODQ2KS4KLVNIT1VMRF9URVNUX1BST0NFU1NFUyA9IG11bHRpcHJvY2Vzc2luZyBh
bmQgc3lzLnBsYXRmb3JtIG5vdCBpbiAoJ2N5Z3dpbicpCitTSE9VTERfVEVTVF9QUk9DRVNTRVMg
PSBtdWx0aXByb2Nlc3NpbmcgYW5kIHN5cy5wbGF0Zm9ybSBub3QgaW4gKCdjeWd3aW4nLCAnd2lu
MzInKQogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbiBpbXBvcnQgYXJyYXlfc3RyZWFtCiBmcm9tIHdl
YmtpdHB5LmNvbW1vbi5zeXN0ZW0gaW1wb3J0IG91dHB1dGNhcHR1cmUK
</data>

          </attachment>
      

    </bug>

</bugzilla>