64135 2011-07-07 17:12:11 -0700 Some tests rely on a /tmp/LayoutTests symlink pointing to the LayoutTests directory 2011-09-07 11:53:10 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 67239 65781 1 gustavo webkit-unassigned abecsi dpranke jarred ossy oldest_to_newest 433798 0 gustavo 2011-07-07 17:12:11 -0700 Old run-webkit-tests used to create a symlink to the LayoutTests directory in /tmp. A few tests rely on that symlink existing, such as these: fast/dom/frame-loading-via-document-write.html fast/loader/local-CSS-from-local.html fast/loader/local-JavaScript-from-local.html fast/loader/local-image-from-local.html Here's where it creates the symlink: http://trac.webkit.org/browser/trunk/Tools/Scripts/old-run-webkit-tests#L501 If nobody beats me to it, I'll write a patch as soon as my tree is free from a bisect I just started. 434022 1 100112 gustavo 2011-07-08 06:02:19 -0700 Created attachment 100112 create and remove the symlink like old-run-webkit-tests used to 435201 2 100112 abarth 2011-07-11 14:11:44 -0700 Comment on attachment 100112 create and remove the symlink like old-run-webkit-tests used to Please just fix the tests. This patch is wrong on several levels. 435208 3 dpranke 2011-07-11 14:31:13 -0700 Ugh. I wonder why we haven't seen the mac NRWT port failling this test more often. Adam already R-'ed this, but at any rate, this is the wrong way to work around this. The top-level run_webkit_tests.py script is just a wrapper around controllers/manager.py which does all the real work. Assuming we did want NRWT to hack this, we should create the link (if it doesn't already exist) in manager.py:824 set_up_run(), and remove the link (if and only if we created it) in clean_up_run() in 951. However, we really shouldn't have to be doing this at all, and NRWT shouldn't need to be aware of this. Chromium, for example, is smart enough to dynamically remap this in pathToLocalResource(), and the other ports probably should be as well. Can you file a separate bug to get the DRT's fixed if we can't just fix the tests? 435274 4 100112 eric 2011-07-11 16:13:50 -0700 Comment on attachment 100112 create and remove the symlink like old-run-webkit-tests used to Yeah, definitely the wrong layer. What tests depend on this? 435601 5 gustavo 2011-07-12 05:59:23 -0700 (In reply to comment #4) > (From update of attachment 100112 [details]) > Yeah, definitely the wrong layer. What tests depend on this? There's a (probably not exhaustive) list at the first comment. Here they are: fast/dom/frame-loading-via-document-write.html fast/loader/local-CSS-from-local.html fast/loader/local-JavaScript-from-local.html fast/loader/local-image-from-local.html 459142 6 jarred 2011-08-30 13:32:11 -0700 Gonna fix this, it's bothering me as well. And no, this should not be fixed in the NRWT (especially not outside of the manager). I think the tests can be fixed instead. 459234 7 jarred 2011-08-30 14:53:42 -0700 Ok, so I don't want to lower the integrity of the fast/loader tests by making the urls relative (as opposed to fully qualified file:// scheme), which was my original intent. Similarly, those tests in http/tests/security which test loading local resources from a remote document still need the pathToLocalResource normalization. I'll open a ticket to fix the DRTs pathToLocalResource() so it normalizes file:///tmp/LayoutTests like Chromium's. 461170 8 abecsi 2011-09-02 05:16:34 -0700 (In reply to comment #4) > (From update of attachment 100112 [details]) > Yeah, definitely the wrong layer. What tests depend on this? I'm not sure whether all these tests still exist, but in BUG 33153 I found a bunch of these which also cause problems when running multiple instances of run-webkit-tests with differing repositories. LayoutTests/fast/dom/frame-loading-via-document-write.html LayoutTests/fast/loader/local-CSS-from-local.html LayoutTests/fast/loader/local-JavaScript-from-local.html LayoutTests/fast/loader/local-iFrame-source-from-local.html LayoutTests/fast/loader/local-image-from-local.html LayoutTests/fast/loader/user-style-sheet-resource-load-callbacks.html LayoutTests/http/tests/misc/image-blocked-src-change.html LayoutTests/http/tests/misc/image-blocked-src-no-change.html LayoutTests/http/tests/security/frame-loading-via-document-write.html LayoutTests/http/tests/security/local-CSS-from-remote.html LayoutTests/http/tests/security/local-JavaScript-from-remote.html LayoutTests/http/tests/security/local-iFrame-from-remote.html LayoutTests/http/tests/security/local-image-from-remote.html LayoutTests/http/tests/security/local-user-CSS-from-remote.html LayoutTests/http/tests/security/local-video-poster-from-remote.html LayoutTests/http/tests/security/local-video-source-from-remote.html LayoutTests/http/tests/security/local-video-src-from-remote.html 461195 9 jarred 2011-09-02 06:36:34 -0700 Output of a "grep -r "pathToLocalResource(" * | awk '{ print $1 }'" on LayoutTests: fast/dom/frame-loading-via-document-write.html: fast/loader/local-image-from-local-expected.txt:Currently fast/loader/local-JavaScript-from-local-expected.txt:Currently fast/loader/local-iFrame-source-from-local.html: fast/loader/local-iFrame-source-from-local.html: fast/loader/local-image-from-local.html: fast/loader/local-image-from-local.html: fast/loader/local-iFrame-source-from-local-expected.txt:Currently fast/loader/local-CSS-from-local.html: fast/loader/local-CSS-from-local.html: fast/loader/local-CSS-from-local-expected.txt:Currently fast/loader/local-JavaScript-from-local.html: fast/loader/local-JavaScript-from-local.html: http/tests/security/local-CSS-from-remote.html: http/tests/security/local-CSS-from-remote.html: http/tests/security/local-video-poster-from-remote.html: http/tests/security/local-JavaScript-from-remote-expected.txt:Currently http/tests/security/local-JavaScript-from-remote.html: http/tests/security/local-JavaScript-from-remote.html: http/tests/security/local-CSS-from-remote-expected.txt:Currently http/tests/security/local-image-from-remote-expected.txt:Currently http/tests/security/local-iFrame-from-remote.html: http/tests/security/local-iFrame-from-remote.html: http/tests/security/local-video-source-from-remote.html: http/tests/security/local-image-from-remote.html: http/tests/security/local-image-from-remote.html: http/tests/security/frame-loading-via-document-write.html: http/tests/security/local-image-from-remote-whitelisted.html:var http/tests/security/local-iFrame-from-remote-expected.txt:Currently http/tests/security/local-video-src-from-remote.html: http/tests/plugins/post-url-file.html: Output of a "grep -r "/tmp/LayoutTests/" * | awk '{ print $1 }'" on LayoutTests: fast/dom/frame-loading-via-document-write.html: fast/loader/local-iFrame-source-from-local.html: fast/loader/user-style-sheet-resource-load-callbacks.html: fast/loader/local-image-from-local.html: fast/loader/local-CSS-from-local.html: fast/loader/local-JavaScript-from-local.html: http/tests/security/local-CSS-from-remote.html: http/tests/security/local-video-poster-from-remote.html: http/tests/security/local-user-CSS-from-remote.html: http/tests/security/local-JavaScript-from-remote.html: http/tests/security/local-iFrame-from-remote.html: http/tests/security/local-video-source-from-remote.html: http/tests/security/local-image-from-remote.html: http/tests/security/frame-loading-via-document-write.html: http/tests/security/local-image-from-remote-whitelisted.html:var http/tests/security/local-video-src-from-remote.html: http/tests/misc/image-blocked-src-no-change.html: http/tests/misc/image-blocked-src-no-change.html: http/tests/misc/image-blocked-src-change.html: 100112 2011-07-08 06:02:19 -0700 2011-07-11 16:13:50 -0700 create and remove the symlink like old-run-webkit-tests used to 0001-2011-07-08-Gustavo-Noronha-Silva-gustavo.noronha-col.patch text/plain 2375 gustavo RnJvbSA2ZmRhOWRjZWI5NjA0ZDVjNzFiMWY2MThjY2MwMTgxYjIwNzU5ZTBiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IEZyaSwgOCBKdWwgMjAxMSAxMDowMDoyMyAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIDIw MTEtMDctMDggIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAKIDxndXN0YXZvLm5vcm9uaGFAY29sbGFi b3JhLmNvbT4KCiAgICAgICAgW05SV1RdIERvZXNuJ3QgY3JlYXRlIGEgbGluayBpbiAvdG1wL0xh eW91dFRlc3RzIGNhdXNpbmcgdGVzdHMgdG8gZmFpbAogICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDEzNQoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KCiAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Vi a2l0X3Rlc3RzLnB5OiBjcmVhdGUgYW5kIHJlbW92ZSB0aGUKICAgICAgICAvdG1wL0xheW91dFRl c3RzIHN5bWxpbmsgbGlrZSBvbGQtcnVuLXdlYmtpdC10ZXN0cyB1c2VkIHRvLgotLS0KIFRvb2xz L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMCArKysr KysrKysrCiAuLi4vd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkgICAg ICB8ICAgMTcgKysrKysrKysrKysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMjYgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29s cy9DaGFuZ2VMb2cKaW5kZXggYmRjMjUwNC4uY2FkZGI3NCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hh bmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTA3LTA4 ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvbT4K KworICAgICAgICBbTlJXVF0gRG9lc24ndCBjcmVhdGUgYSBsaW5rIGluIC90bXAvTGF5b3V0VGVz dHMgY2F1c2luZyB0ZXN0cyB0byBmYWlsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02NDEzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtp dF90ZXN0cy5weTogY3JlYXRlIGFuZCByZW1vdmUgdGhlCisgICAgICAgIC90bXAvTGF5b3V0VGVz dHMgc3ltbGluayBsaWtlIG9sZC1ydW4td2Via2l0LXRlc3RzIHVzZWQgdG8uCisKIDIwMTEtMDct MDcgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAgICAg W3d4XSBVbnJldmlld2VkIGJ1aWxkIGZpeCwgcmVtb3ZlIG9sZCBmaWxlcyBmcm9tIHRoZSB0cmVl IGFuZCB1cGRhdGUgcGF0aHMgdG8gbmV3IG9uZXMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCA4MmEwZDBh Li42OGMyMTA5IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTQzMCw3ICs0MzAsMjIgQEAgZGVmIHBhcnNl X2FyZ3MoYXJncz1Ob25lKToKIGRlZiBtYWluKCk6CiAgICAgb3B0aW9ucywgYXJncyA9IHBhcnNl X2FyZ3MoKQogICAgIHBvcnRfb2JqID0gcG9ydC5nZXQob3B0aW9ucy5wbGF0Zm9ybSwgb3B0aW9u cykKLSAgICByZXR1cm4gcnVuKHBvcnRfb2JqLCBvcHRpb25zLCBhcmdzKQorCisgICAgIyBDcmVh dGUgYSBzeW1saW5rIHRvIHRoZSBsYXlvdXQgdGVzdHMgZGlyZWN0b3J5LiBTb21lIHRlc3RzIHJl bHkgb24gdGhpcy4KKyAgICB0ZXN0c19kaXJlY3RvcnkgPSBwb3J0X29iai5wYXRoX2Zyb21fd2Vi a2l0X2Jhc2UoJ0xheW91dFRlc3RzJykKKyAgICB0cnk6CisgICAgICAgIG9zLnN5bWxpbmsodGVz dHNfZGlyZWN0b3J5LCAnL3RtcC9MYXlvdXRUZXN0cycpCisgICAgZXhjZXB0IE9TRXJyb3I6Cisg ICAgICAgIHBhc3MKKworICAgIHJlc3VsdCA9IHJ1bihwb3J0X29iaiwgb3B0aW9ucywgYXJncykK KworICAgIHRyeToKKyAgICAgICAgb3MudW5saW5rKCcvdG1wL0xheW91dFRlc3RzJykKKyAgICBl eGNlcHQgT1NFcnJvcjoKKyAgICAgICAgcGFzcworCisgICAgcmV0dXJuIHJlc3VsdAogCiAKIGlm ICdfX21haW5fXycgPT0gX19uYW1lX186Ci0tIAoxLjcuNS4zCgo=