64119 2011-07-07 12:32:08 -0700 [chromium] Fix crash when compositing gets disabled mid-paint 2011-07-07 13:37:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne enne jamesr oldest_to_newest 433651 0 enne 2011-07-07 12:32:08 -0700 [chromium] Fix crash when compositing gets disabled mid-paint 433652 1 100018 enne 2011-07-07 12:34:42 -0700 Created attachment 100018 Patch 433655 2 enne 2011-07-07 12:40:50 -0700 http://code.google.com/p/chromium/issues/detail?id=88682 433662 3 100018 jamesr 2011-07-07 13:07:12 -0700 Comment on attachment 100018 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100018&action=review > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:369 > + if (!m_rootLayer) > + return; do we think painting a sublayer is turning the compositor off? we already have a null-check + early-out after updateRootLayerContents() 433664 4 enne 2011-07-07 13:10:27 -0700 (In reply to comment #3) > (From update of attachment 100018 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100018&action=review > > > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:369 > > + if (!m_rootLayer) > > + return; > > do we think painting a sublayer is turning the compositor off? we already have a null-check + early-out after updateRootLayerContents() In this case, no. However, there's no reason it couldn't. I've fixed this bug at least three times now. Can you forgive some extra checks for sanity's sake? :) 433670 5 100018 jamesr 2011-07-07 13:23:29 -0700 Comment on attachment 100018 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100018&action=review >>> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:369 >>> + return; >> >> do we think painting a sublayer is turning the compositor off? we already have a null-check + early-out after updateRootLayerContents() > > In this case, no. However, there's no reason it couldn't. > > I've fixed this bug at least three times now. Can you forgive some extra checks for sanity's sake? :) Yeah I know, but it's also really valuable to know which checks are working and which aren't. We have some pretty defensive code in place to try to update compositing reqs for all layers before painting, so if that's failing then we should probably not bother since it's not free. See http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/src/WebViewImpl.cpp#L1146 Would you mind landing just the second check (in drawLayers()) without this, letting it go to canary, and seeing what that does? 433673 6 enne 2011-07-07 13:29:18 -0700 (In reply to comment #5) > (From update of attachment 100018 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100018&action=review > Would you mind landing just the second check (in drawLayers()) without this, letting it go to canary, and seeing what that does? Sure, will do. 433677 7 100026 enne 2011-07-07 13:34:19 -0700 Created attachment 100026 Patch 433678 8 100026 jamesr 2011-07-07 13:35:19 -0700 Comment on attachment 100026 Patch Lesse what happens 433679 9 enne 2011-07-07 13:37:56 -0700 Committed r90587: <http://trac.webkit.org/changeset/90587> 100018 2011-07-07 12:34:42 -0700 2011-07-07 13:34:16 -0700 Patch bug-64119-20110707123441.patch text/plain 2226 enne U3VidmVyc2lvbiBSZXZpc2lvbjogOTA1NzkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlOGMzYmUwZGM4NTQzOWIz ODE3OGYzYTUwODI5NGNlNGIxMDA3MjczLi5jNTcxMzlkMDc5ZTU4OTVjOTg3M2YzYzRkYWQ5YzE5 NjYyNTgwMTBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDctMDcgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIEZpeCBj cmFzaCB3aGVuIGNvbXBvc2l0aW5nIGdldHMgZGlzYWJsZWQgbWlkLXBhaW50CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDExOQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdCBwYWludCBjYW4gZGlz YWJsZSBjb21wb3NpdGluZyBhbmQgY2FsbCBzZXRSb290TGF5ZXIoMCkuIEFkZGluZworICAgICAg ICBhIGNoZWNrIGZvciB0aGlzIGluIGRyYXdMYXllcnMgcHJldmVudHMgYSBudWxsIHBvaW50ZXIg ZGVyZWYuIFRoZQorICAgICAgICBhZGRpdGlvbmFsIGNoZWNrIGluIHVwZGF0ZUxheWVycyBpcyBu b3QgbmVjZXNzYXJ5LCBidXQgc2VlbXMgbGlrZSBnb29kCisgICAgICAgIHByYWN0aWNlIHRvIGVh cmx5IG91dCB0byBwcmV2ZW50IG1vcmUgb2YgdGhpcyBidWcgaW4gdGhlIGZ1dHVyZS4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpMYXllclJlbmRlcmVyQ2hyb21pdW06OnVwZGF0ZUxheWVy cyk6CisgICAgICAgIChXZWJDb3JlOjpMYXllclJlbmRlcmVyQ2hyb21pdW06OmRyYXdMYXllcnMp OgorCiAyMDExLTA3LTA3ICBLeXVzdW4gS2ltICA8bWFuaWFnb29uQGNvbXBhbnkxMDAubmV0Pgog CiAgICAgICAgIFRoZSByZXR1cm4gdmFsdWUgb2YgU2hhcmVkQnVmZmVyOjpjcmVhdGVXaXRoQ29u dGVudHNPZkZpbGUgbXVzdCBoYXZlIHZhbGlkIG1fc2l6ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRl cmVyQ2hyb21pdW0uY3BwCmluZGV4IGQ5OTEyYTMwYTUxNmQ4MWE0ZDAyMTMyZDM0NWYzOGJjNjkw NDdkNDAuLmJiMDZiZGUxOTM0NzJiYWJhZTBjNjYxMTBlY2U4NGQ4NDA3ODgwYjUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVy ZXJDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcApAQCAtMzY0LDYgKzM2NCwxMCBAQCB2b2lk IExheWVyUmVuZGVyZXJDaHJvbWl1bTo6dXBkYXRlTGF5ZXJzKExheWVyTGlzdCYgcmVuZGVyU3Vy ZmFjZUxheWVyTGlzdCkKICNpZm5kZWYgTkRFQlVHCiAgICAgc19pblBhaW50TGF5ZXJDb250ZW50 cyA9IGZhbHNlOwogI2VuZGlmCisKKyAgICBpZiAoIW1fcm9vdExheWVyKQorICAgICAgICByZXR1 cm47CisKICAgICAvLyBVcGRhdGUgY29tcG9zaXRvciByZXNvdXJjZXMgZm9yIHJvb3QgbGF5ZXIu CiAgICAgewogICAgICAgICBUUkFDRV9FVkVOVCgiTGF5ZXJSZW5kZXJlckNocm9taXVtOjp1cGRh dGVMYXllcjo6dXBkYXRlUm9vdCIsIHRoaXMsIDApOwpAQCAtNDgwLDcgKzQ4NCw3IEBAIHZvaWQg TGF5ZXJSZW5kZXJlckNocm9taXVtOjpwYWludExheWVyQ29udGVudHMoY29uc3QgTGF5ZXJMaXN0 JiByZW5kZXJTdXJmYWNlTGF5CiAKIHZvaWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3TGF5 ZXJzKGNvbnN0IExheWVyTGlzdCYgcmVuZGVyU3VyZmFjZUxheWVyTGlzdCkKIHsKLSAgICBpZiAo bV92aWV3cG9ydFZpc2libGVSZWN0LmlzRW1wdHkoKSkKKyAgICBpZiAobV92aWV3cG9ydFZpc2li bGVSZWN0LmlzRW1wdHkoKSB8fCAhbV9yb290TGF5ZXIpCiAgICAgICAgIHJldHVybjsKIAogICAg IFRSQUNFX0VWRU5UKCJMYXllclJlbmRlcmVyQ2hyb21pdW06OmRyYXdMYXllcnMiLCB0aGlzLCAw KTsK 100026 2011-07-07 13:34:19 -0700 2011-07-07 13:35:19 -0700 Patch bug-64119-20110707133418.patch text/plain 1601 enne U3VidmVyc2lvbiBSZXZpc2lvbjogOTA1ODQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwZmE4NzNlZmNjN2RiZGNm ZmQ5NjgzMzIxNTUzMWUzNWI4YTUxZDc4Li5hYzU2YWQ4YzNmOWUxNzM5MjJiZjExYzkwOGNjYWFh NWQ1MWY2ZmExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMDcgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIEZpeCBj cmFzaCB3aGVuIGNvbXBvc2l0aW5nIGdldHMgZGlzYWJsZWQgbWlkLXBhaW50CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDExOQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdCBwYWludCBjYW4gZGlz YWJsZSBjb21wb3NpdGluZyBhbmQgY2FsbCBzZXRSb290TGF5ZXIoMCkuIEFkZGluZworICAgICAg ICBhIGNoZWNrIGZvciB0aGlzIGluIGRyYXdMYXllcnMgcHJldmVudHMgYSBudWxsIHBvaW50ZXIg ZGVyZWYuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRl cmVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJlckNocm9taXVt OjpkcmF3TGF5ZXJzKToKKwogMjAxMS0wNy0wNyAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFJvYiBCdWlzLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVt LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVu ZGVyZXJDaHJvbWl1bS5jcHAKaW5kZXggZDk5MTJhMzBhNTE2ZDgxYTRkMDIxMzJkMzQ1ZjM4YmM2 OTA0N2Q0MC4uOWY4Mjk4YTIyYzRmMzY2NGIxYTlmNGJmNjQ4ZTNiNmJjM2VhOTcwNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5k ZXJlckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwCkBAIC00ODAsNyArNDgwLDcgQEAgdm9p ZCBMYXllclJlbmRlcmVyQ2hyb21pdW06OnBhaW50TGF5ZXJDb250ZW50cyhjb25zdCBMYXllckxp c3QmIHJlbmRlclN1cmZhY2VMYXkKIAogdm9pZCBMYXllclJlbmRlcmVyQ2hyb21pdW06OmRyYXdM YXllcnMoY29uc3QgTGF5ZXJMaXN0JiByZW5kZXJTdXJmYWNlTGF5ZXJMaXN0KQogewotICAgIGlm IChtX3ZpZXdwb3J0VmlzaWJsZVJlY3QuaXNFbXB0eSgpKQorICAgIGlmIChtX3ZpZXdwb3J0Vmlz aWJsZVJlY3QuaXNFbXB0eSgpIHx8ICFtX3Jvb3RMYXllcikKICAgICAgICAgcmV0dXJuOwogCiAg ICAgVFJBQ0VfRVZFTlQoIkxheWVyUmVuZGVyZXJDaHJvbWl1bTo6ZHJhd0xheWVycyIsIHRoaXMs IDApOwo=