64102 2011-07-07 09:45:51 -0700 Re-enable -webkit-column-break-inside: avoid 2011-07-07 12:25:28 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz oldest_to_newest 433525 0 mitz 2011-07-07 09:45:51 -0700 Re-enable -webkit-column-break-inside: avoid 433526 1 mitz 2011-07-07 09:46:31 -0700 <rdar://problem/9737435> 433529 2 100000 mitz 2011-07-07 09:48:38 -0700 Created attachment 100000 Patch 433575 3 100000 simon.fraser 2011-07-07 10:24:56 -0700 Comment on attachment 100000 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100000&action=review > Source/WebCore/ChangeLog:6 > + <rdar://problem/9737435> Re-enable -webkit-column-break-inside: avoid > + https://bugs.webkit.org/show_bug.cgi?id=64102 > + > + Reviewed by NOBODY (OOPS!). Can you explain the "re-enable"? Was this regressed unintentionally, or intentionally? If so, when? 433577 4 mitz 2011-07-07 10:26:49 -0700 (In reply to comment #3) > Can you explain the "re-enable"? Was this regressed unintentionally, or intentionally? If so, when? Intentionally in <http://trac.webkit.org/changeset/62632>. 433578 5 mitz 2011-07-07 10:28:28 -0700 Committed r90573. <http://trac.webkit.org/r90573> 433650 6 100000 eric 2011-07-07 12:25:28 -0700 Comment on attachment 100000 Patch Patch 1000000!! 100000 2011-07-07 09:48:38 -0700 2011-07-07 12:25:28 -0700 Patch bug-64102-20110707094836.patch text/plain 3002 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwNTY0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDctMDcgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTczNzQz NT4gUmUtZW5hYmxlIC13ZWJraXQtY29sdW1uLWJyZWFrLWluc2lkZTogYXZvaWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MTAyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy QmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmFkanVzdEZvclVuc3Bs aXR0YWJsZUNoaWxkKTogVHJlYXQgdGhlIGNoaWxkIGFzIHVuc3BsaXR0YWJsZSBpZgorICAgICAg ICAnLXdlYmtpdC1jb2x1bW4tYnJlYWstaW5zaWRlOiBhdm9pZCcgd2FzIHNwZWNpZmllZC4KKwog MjAxMS0wNy0wNyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBwcmV2ZW50IGRlZmF1bHQgYWN0aW9uIGR1cmluZyBkcmFnJ24n ZHJvcCBpbiB0aGUgRWxlbWVudHMgcGFuZWwuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCbG9jay5jcHAJKHJldmlzaW9uIDkwNTYwKQorKysgU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjAzOCw3ICs2MDM4LDcg QEAgaW50IFJlbmRlckJsb2NrOjphcHBseUFmdGVyQnJlYWsoUmVuZGVyQgogCiBpbnQgUmVuZGVy QmxvY2s6OmFkanVzdEZvclVuc3BsaXR0YWJsZUNoaWxkKFJlbmRlckJveCogY2hpbGQsIGludCBs b2dpY2FsT2Zmc2V0LCBib29sIGluY2x1ZGVNYXJnaW5zKQogewotICAgIGJvb2wgaXNVbnNwbGl0 dGFibGUgPSBjaGlsZC0+aXNSZXBsYWNlZCgpIHx8IGNoaWxkLT5zY3JvbGxzT3ZlcmZsb3coKTsK KyAgICBib29sIGlzVW5zcGxpdHRhYmxlID0gY2hpbGQtPmlzUmVwbGFjZWQoKSB8fCBjaGlsZC0+ c2Nyb2xsc092ZXJmbG93KCkgfHwgY2hpbGQtPnN0eWxlKCktPmNvbHVtbkJyZWFrSW5zaWRlKCkg PT0gUEJBVk9JRDsKICAgICBpZiAoIWlzVW5zcGxpdHRhYmxlKQogICAgICAgICByZXR1cm4gbG9n aWNhbE9mZnNldDsKICAgICBpbnQgY2hpbGRMb2dpY2FsSGVpZ2h0ID0gbG9naWNhbEhlaWdodEZv ckNoaWxkKGNoaWxkKSArIChpbmNsdWRlTWFyZ2lucyA/IG1hcmdpbkJlZm9yZUZvckNoaWxkKGNo aWxkKSArIG1hcmdpbkFmdGVyRm9yQ2hpbGQoY2hpbGQpIDogMCk7CkluZGV4OiBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lv biA5MDU2NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDExLTA3LTA3ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzk3Mzc0MzU+IFJlLWVuYWJsZSAtd2Via2l0LWNvbHVt bi1icmVhay1pbnNpZGU6IGF2b2lkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NDEwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogZmFzdC9tdWx0aWNvbC9icmVhay1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4 dDoKKyAgICAgICAgKiBmYXN0L211bHRpY29sL2JyZWFrLXByb3BlcnRpZXMuaHRtbDoKKwogMjAx MS0wNy0wNyAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvYnJlYWstcHJvcGVydGllcy1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9tdWx0aWNvbC9icmVh ay1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gOTA1NjApCisrKyBMYXlvdXRUZXN0 cy9mYXN0L211bHRpY29sL2JyZWFrLXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsNCBAQAogUEFTUzogJ2JyZWFrLWJlZm9yZScgaXMgYXQgKDIxOCwgOCkK IFBBU1M6ICdhZnRlci1icmVhaycgaXMgYXQgKDQyOCwgOCkKK1BBU1M6ICduby1icmVhaycgaXMg YXQgKDUzMywgOCkKIApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9tdWx0aWNvbC9icmVhay1wcm9w ZXJ0aWVzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9tdWx0aWNvbC9icmVh ay1wcm9wZXJ0aWVzLmh0bWwJKHJldmlzaW9uIDkwNTYwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9t dWx0aWNvbC9icmVhay1wcm9wZXJ0aWVzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTMyLDQgKzMy LDUgQEAKIAogICAgIHRlc3RCb3hQb3NpdGlvbigiYnJlYWstYmVmb3JlIiwgMjE4LCA4KTsKICAg ICB0ZXN0Qm94UG9zaXRpb24oImFmdGVyLWJyZWFrIiwgNDI4LCA4KTsKKyAgICB0ZXN0Qm94UG9z aXRpb24oIm5vLWJyZWFrIiwgNTMzLCA4KTsKIDwvc2NyaXB0Pgo=