64093 2011-07-07 08:46:43 -0700 [Qt][WK2] Views should know about WebProcess crash/relaunch. 2011-07-07 10:28:37 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling benjamin oldest_to_newest 433475 0 kling 2011-07-07 08:46:43 -0700 The crash/relaunch callbacks should propagate through the ViewInterface. 433481 1 99988 kling 2011-07-07 08:56:09 -0700 Created attachment 99988 Proposed patch 433524 2 99988 benjamin 2011-07-07 09:44:45 -0700 Comment on attachment 99988 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=99988&action=review > Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:229 > + isCrashed = false; Don't you need to update here? > Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:548 > setDrawingAreaSize(m_viewInterface->drawingAreaSize()); > - > - m_isConnectedToEngine = true; > + m_viewInterface->didRelaunchProcess(); I would invert the order of those calls. :) 433579 3 kling 2011-07-07 10:28:37 -0700 Committed r90572: <http://trac.webkit.org/changeset/90572> 99988 2011-07-07 08:56:09 -0700 2011-07-07 09:44:45 -0700 Proposed patch bug-64093.diff text/plain 7508 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxMTM3NzNkLi4yODNjMWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzUg QEAKKzIwMTEtMDctMDcgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFtRdF1bV0syXSBWaWV3cyBzaG91bGQga25vdyBhYm91dCBXZWJQcm9jZXNzIGNyYXNoL3Jl bGF1bmNoLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjQwOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgcHJvY2Vzc0RpZENyYXNoKCkgYW5kIGRpZFJlbGF1bmNoUHJvY2VzcygpIHRvIFZpZXdJbnRl cmZhY2UuCisKKyAgICAgICAgUURlc2t0b3BXZWJWaWV3IG5vdyBkaXNwbGF5cyBhIHNpbXBsZSBz YWQgc21pbGV5ICI6KCIgd2hlbiB0aGUKKyAgICAgICAgd2ViIHByb2Nlc3MgY3Jhc2hlcy4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcWRlc2t0b3B3ZWJ2aWV3LmNwcDoKKyAgICAgICAg KFFEZXNrdG9wV2ViVmlld1ByaXZhdGU6OlFEZXNrdG9wV2ViVmlld1ByaXZhdGUpOgorICAgICAg ICAocGFpbnRDcmFzaGVkUGFnZSk6CisgICAgICAgIChRRGVza3RvcFdlYlZpZXc6OnBhaW50KToK KyAgICAgICAgKFFEZXNrdG9wV2ViVmlld1ByaXZhdGU6OnByb2Nlc3NEaWRDcmFzaCk6CisgICAg ICAgIChRRGVza3RvcFdlYlZpZXdQcml2YXRlOjpkaWRSZWxhdW5jaFByb2Nlc3MpOgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvcXQvcWRlc2t0b3B3ZWJ2aWV3X3AuaDoKKyAgICAgICAgKiBVSVBy b2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoUXRXZWJQYWdlUHJveHk6OlF0 V2ViUGFnZVByb3h5KToKKyAgICAgICAgKFF0V2ViUGFnZVByb3h5OjpkaWRSZWxhdW5jaFByb2Nl c3MpOgorICAgICAgICAoUXRXZWJQYWdlUHJveHk6OnByb2Nlc3NEaWRDcmFzaCk6CisgICAgICAg ICogVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5Lmg6CisgICAgICAgICogVUlQcm9jZXNzL3F0 L1RvdWNoVmlld0ludGVyZmFjZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlRvdWNoVmlld0ludGVy ZmFjZTo6c2hvd0NvbnRleHRNZW51KToKKyAgICAgICAgKFdlYktpdDo6VG91Y2hWaWV3SW50ZXJm YWNlOjpoaWRlQ29udGV4dE1lbnUpOgorICAgICAgICAoV2ViS2l0OjpUb3VjaFZpZXdJbnRlcmZh Y2U6OnByb2Nlc3NEaWRDcmFzaCk6CisgICAgICAgIChXZWJLaXQ6OlRvdWNoVmlld0ludGVyZmFj ZTo6ZGlkUmVsYXVuY2hQcm9jZXNzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvVG91Y2hWaWV3 SW50ZXJmYWNlLmg6CisgICAgICAgICogVUlQcm9jZXNzL3F0L1ZpZXdJbnRlcmZhY2UuaDoKKwog MjAxMS0wNy0wNyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgW1F0XSBbV0syXSBJbXByb3ZlIHRoZSBoYW5kbGluZyBvZiB0b3VjaCBldmVudHMgdG8g dXNlIHRoZW0gYXMgbWFpbiBpbnB1dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xZGVza3RvcHdlYnZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC9xZGVza3RvcHdlYnZpZXcuY3BwCmluZGV4IGQ0ZWExMzQuLjkxZGNkMGUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWRlc2t0b3B3ZWJ2aWV3LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FkZXNrdG9wd2Vidmlldy5j cHAKQEAgLTMwLDYgKzMwLDcgQEAKIFFEZXNrdG9wV2ViVmlld1ByaXZhdGU6OlFEZXNrdG9wV2Vi Vmlld1ByaXZhdGUoUURlc2t0b3BXZWJWaWV3KiBxLCBXS0NvbnRleHRSZWYgY29udGV4dFJlZiwg V0tQYWdlR3JvdXBSZWYgcGFnZUdyb3VwUmVmKQogICAgIDogcShxKQogICAgICwgcGFnZSh0aGlz LCBjb250ZXh0UmVmID8gbmV3IFFXS0NvbnRleHQoY29udGV4dFJlZikgOiBkZWZhdWx0V0tDb250 ZXh0KCksIHBhZ2VHcm91cFJlZikKKyAgICAsIGlzQ3Jhc2hlZChmYWxzZSkKIHsKIH0KIApAQCAt MTg5LDggKzE5MCwxOSBAQCB2b2lkIFFEZXNrdG9wV2ViVmlldzo6cmVzaXplRXZlbnQoUUdyYXBo aWNzU2NlbmVSZXNpemVFdmVudCogZXYpCiAgICAgUUdyYXBoaWNzV2lkZ2V0OjpyZXNpemVFdmVu dChldik7CiB9CiAKK3N0YXRpYyB2b2lkIHBhaW50Q3Jhc2hlZFBhZ2UoUVBhaW50ZXIqIHBhaW50 ZXIsIGNvbnN0IFFTdHlsZU9wdGlvbkdyYXBoaWNzSXRlbSogb3B0aW9uKQoreworICAgIHBhaW50 ZXItPmZpbGxSZWN0KG9wdGlvbi0+cmVjdCwgUXQ6OmdyYXkpOworICAgIHBhaW50ZXItPmRyYXdU ZXh0KG9wdGlvbi0+cmVjdCwgUXQ6OkFsaWduQ2VudGVyLCBRTGF0aW4xU3RyaW5nKCI6KCIpKTsK K30KKwogdm9pZCBRRGVza3RvcFdlYlZpZXc6OnBhaW50KFFQYWludGVyKiBwYWludGVyLCBjb25z dCBRU3R5bGVPcHRpb25HcmFwaGljc0l0ZW0qIG9wdGlvbiwgUVdpZGdldCopCiB7CisgICAgaWYg KGQtPmlzQ3Jhc2hlZCkgeworICAgICAgICBwYWludENyYXNoZWRQYWdlKHBhaW50ZXIsIG9wdGlv bik7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBkLT5wYWdlLnBhaW50KHBhaW50ZXIs IG9wdGlvbi0+ZXhwb3NlZFJlY3QudG9BbGlnbmVkUmVjdCgpKTsKIH0KIApAQCAtMjA1LDMgKzIx NywxNCBAQCBXS1BhZ2VSZWYgUURlc2t0b3BXZWJWaWV3OjpwYWdlUmVmKCkgY29uc3QKIHsKICAg ICByZXR1cm4gZC0+cGFnZS5wYWdlUmVmKCk7CiB9CisKK3ZvaWQgUURlc2t0b3BXZWJWaWV3UHJp dmF0ZTo6cHJvY2Vzc0RpZENyYXNoKCkKK3sKKyAgICBpc0NyYXNoZWQgPSB0cnVlOworICAgIHEt PnVwZGF0ZSgpOworfQorCit2b2lkIFFEZXNrdG9wV2ViVmlld1ByaXZhdGU6OmRpZFJlbGF1bmNo UHJvY2VzcygpCit7CisgICAgaXNDcmFzaGVkID0gZmFsc2U7Cit9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FkZXNrdG9wd2Vidmlld19wLmggYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FkZXNrdG9wd2Vidmlld19wLmgKaW5kZXggODgwNjFh Ni4uNzU3NWEyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x ZGVza3RvcHdlYnZpZXdfcC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQv cWRlc2t0b3B3ZWJ2aWV3X3AuaApAQCAtMzYsNiArMzYsOCBAQCBwdWJsaWM6CiAgICAgUURlc2t0 b3BXZWJWaWV3KiBxOwogICAgIFFEZXNrdG9wV2ViUGFnZVByb3h5IHBhZ2U7CiAKKyAgICBib29s IGlzQ3Jhc2hlZDsKKwogcHJpdmF0ZToKICAgICAvKiBJbXBsZW1lbnRhdGlvbiBvZiBWaWV3SW50 ZXJmYWNlICovCiAgICAgdmlydHVhbCB2b2lkIHNldFZpZXdOZWVkc0Rpc3BsYXkoY29uc3QgUVJl Y3QmKTsKQEAgLTYzLDYgKzY1LDkgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgc2hvd0Nv bnRleHRNZW51KFFTaGFyZWRQb2ludGVyPFFNZW51Pik7CiAgICAgdmlydHVhbCB2b2lkIGhpZGVD b250ZXh0TWVudSgpOwogCisgICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRDcmFzaCgpOworICAg IHZpcnR1YWwgdm9pZCBkaWRSZWxhdW5jaFByb2Nlc3MoKTsKKwogICAgIFFTaGFyZWRQb2ludGVy PFFNZW51PiBhY3RpdmVNZW51OwogfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9x dC9RdFdlYlBhZ2VQcm94eS5jcHAKaW5kZXggNzdhMjA4MS4uNmU4NDAxZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuY3BwCkBAIC0xMjQsNyArMTI0 LDYgQEAgUXRXZWJQYWdlUHJveHk6OlF0V2ViUGFnZVByb3h5KFZpZXdJbnRlcmZhY2UqIHZpZXdJ bnRlcmZhY2UsIFFXS0NvbnRleHQqIGMsIFdLUGEKICAgICAsIG1fY29udGV4dChjKQogICAgICwg bV9wcmVmZXJlbmNlcygwKQogICAgICwgbV9jcmVhdGVOZXdQYWdlRm4oMCkKLSAgICAsIG1faXND b25uZWN0ZWRUb0VuZ2luZSh0cnVlKQogI2lmbmRlZiBRVF9OT19VTkRPU1RBQ0sKICAgICAsIG1f dW5kb1N0YWNrKGFkb3B0UHRyKG5ldyBRVW5kb1N0YWNrKHRoaXMpKSkKICNlbmRpZgpAQCAtNTQ2 LDEzICs1NDUsMTIgQEAgdm9pZCBRdFdlYlBhZ2VQcm94eTo6d2ViQWN0aW9uVHJpZ2dlcmVkKGJv b2wgY2hlY2tlZCkKIHZvaWQgUXRXZWJQYWdlUHJveHk6OmRpZFJlbGF1bmNoUHJvY2VzcygpCiB7 CiAgICAgc2V0RHJhd2luZ0FyZWFTaXplKG1fdmlld0ludGVyZmFjZS0+ZHJhd2luZ0FyZWFTaXpl KCkpOwotCi0gICAgbV9pc0Nvbm5lY3RlZFRvRW5naW5lID0gdHJ1ZTsKKyAgICBtX3ZpZXdJbnRl cmZhY2UtPmRpZFJlbGF1bmNoUHJvY2VzcygpOwogfQogCiB2b2lkIFF0V2ViUGFnZVByb3h5Ojpw cm9jZXNzRGlkQ3Jhc2goKQogewotICAgIG1faXNDb25uZWN0ZWRUb0VuZ2luZSA9IGZhbHNlOwor ICAgIG1fdmlld0ludGVyZmFjZS0+cHJvY2Vzc0RpZENyYXNoKCk7CiB9CiAKIHZvaWQgUXRXZWJQ YWdlUHJveHk6OnNldEFjdHVhbFZpc2libGVDb250ZW50c1JlY3QoY29uc3QgUVJlY3QmIHJlY3Qp IGNvbnN0CkBAIC04MDMsMTEgKzgwMSw2IEBAIFdlYkNvcmU6OkludFJlY3QgUXRXZWJQYWdlUHJv eHk6OnZpZXdwb3J0VmlzaWJsZVJlY3QoKSBjb25zdAogICAgIHJldHVybiBJbnRSZWN0KCk7CiB9 CiAKLWJvb2wgUXRXZWJQYWdlUHJveHk6OmlzQ29ubmVjdGVkVG9FbmdpbmUoKSBjb25zdAotewot ICAgIHJldHVybiBtX2lzQ29ubmVjdGVkVG9FbmdpbmU7Ci19Ci0KIHZvaWQgUXRXZWJQYWdlUHJv eHk6OnNldFBhZ2VJc1Zpc2libGUoYm9vbCBpc1Zpc2libGUpCiB7CiAgICAgbV93ZWJQYWdlUHJv eHktPmRyYXdpbmdBcmVhKCktPnNldFBhZ2VJc1Zpc2libGUoaXNWaXNpYmxlKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5oIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmgKaW5kZXggYjhiZTU4OC4uODZi NmFkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVBy b3h5LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmgK QEAgLTE4OSw4ICsxODksNiBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGZpbmRab29tYWJsZUFyZWFG b3JQb2ludChjb25zdCBRUG9pbnQmKTsKIAotICAgIGJvb2wgaXNDb25uZWN0ZWRUb0VuZ2luZSgp IGNvbnN0OwotCiAgICAgdm9pZCBzZXRQYWdlSXNWaXNpYmxlKGJvb2wpOwogCiBwdWJsaWMgUV9T TE9UUzoKQEAgLTIyMyw4ICsyMjEsNiBAQCBwcml2YXRlOgogCiAgICAgQ3JlYXRlTmV3UGFnZUZu IG1fY3JlYXRlTmV3UGFnZUZuOwogCi0gICAgYm9vbCBtX2lzQ29ubmVjdGVkVG9FbmdpbmU7Ci0K ICNpZm5kZWYgUVRfTk9fVU5ET1NUQUNLCiAgICAgT3duUHRyPFFVbmRvU3RhY2s+IG1fdW5kb1N0 YWNrOwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvVG91 Y2hWaWV3SW50ZXJmYWNlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9Ub3VjaFZp ZXdJbnRlcmZhY2UuY3BwCmluZGV4IDQ2NjhjMjEuLjY2MzI3YmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9Ub3VjaFZpZXdJbnRlcmZhY2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9Ub3VjaFZpZXdJbnRlcmZhY2UuY3BwCkBAIC0xMTIsMTIg KzExMiwyMiBAQCB2b2lkIFRvdWNoVmlld0ludGVyZmFjZTo6ZGlkQ2hhbmdlTG9hZFByb2dyZXNz KGludCBwZXJjZW50YWdlTG9hZGVkKQogCiB2b2lkIFRvdWNoVmlld0ludGVyZmFjZTo6c2hvd0Nv bnRleHRNZW51KFFTaGFyZWRQb2ludGVyPFFNZW51PikKIHsKLSAgICAvLyBUT0RPCisgICAgLy8g RklYTUUKIH0KIAogdm9pZCBUb3VjaFZpZXdJbnRlcmZhY2U6OmhpZGVDb250ZXh0TWVudSgpCiB7 Ci0gICAgLy8gVE9ETworICAgIC8vIEZJWE1FCit9CisKK3ZvaWQgVG91Y2hWaWV3SW50ZXJmYWNl Ojpwcm9jZXNzRGlkQ3Jhc2goKQoreworICAgIC8vIEZJWE1FCit9CisKK3ZvaWQgVG91Y2hWaWV3 SW50ZXJmYWNlOjpkaWRSZWxhdW5jaFByb2Nlc3MoKQoreworICAgIC8vIEZJWE1FCiB9CiAKIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9Ub3VjaFZpZXdJbnRlcmZh Y2UuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9Ub3VjaFZpZXdJbnRlcmZhY2UuaApp bmRleCBkNjQ0YmMwLi44NDI2NDg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvcXQvVG91Y2hWaWV3SW50ZXJmYWNlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L3F0L1RvdWNoVmlld0ludGVyZmFjZS5oCkBAIC02MCw2ICs2MCwxMCBAQCBwcml2YXRlOgogCiAg ICAgdmlydHVhbCB2b2lkIHNob3dDb250ZXh0TWVudShRU2hhcmVkUG9pbnRlcjxRTWVudT4pOwog ICAgIHZpcnR1YWwgdm9pZCBoaWRlQ29udGV4dE1lbnUoKTsKKworICAgIHZpcnR1YWwgdm9pZCBw cm9jZXNzRGlkQ3Jhc2goKTsKKyAgICB2aXJ0dWFsIHZvaWQgZGlkUmVsYXVuY2hQcm9jZXNzKCk7 CisKIHByaXZhdGU6CiAgICAgUVRvdWNoV2ViVmlldyogY29uc3QgbV92aWV3cG9ydFZpZXc7CiAg ICAgUVRvdWNoV2ViUGFnZSogY29uc3QgbV9wYWdlVmlldzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9xdC9WaWV3SW50ZXJmYWNlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvcXQvVmlld0ludGVyZmFjZS5oCmluZGV4IGQ2MTFiZTkuLjFiMzkxN2YgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9WaWV3SW50ZXJmYWNlLmgKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1ZpZXdJbnRlcmZhY2UuaApAQCAtNjYsNiArNjYsOSBA QCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNob3dDb250ZXh0TWVudShRU2hhcmVkUG9pbnRl cjxRTWVudT4pID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgaGlkZUNvbnRleHRNZW51KCkgPSAwOwog CisgICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRDcmFzaCgpID0gMDsKKyAgICB2aXJ0dWFsIHZv aWQgZGlkUmVsYXVuY2hQcm9jZXNzKCkgPSAwOworCiBwcm90ZWN0ZWQ6CiAgICAgLyogVXRpbGl0 eSBmdW5jdGlvbnMgZm9yIHRoZSBpbXBsZW1lbnRhdGlvbnMuICovCiAgICAgc3RhdGljIFFXaWRn ZXQqIG93bmVyV2lkZ2V0KGNvbnN0IFFHcmFwaGljc1dpZGdldCopOwo=