64091 2011-07-07 08:23:08 -0700 [GTK] [NRWT] Pixel tests do not work 2011-07-11 15:29:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson eric webkit.review.bot xan.lopez oldest_to_newest 433463 0 mrobinson 2011-07-07 08:23:08 -0700 Pixel tests do not work for NRWT because _path_to_image_diff is unimplemented in the gtk.py. 433466 1 99983 mrobinson 2011-07-07 08:25:48 -0700 Created attachment 99983 Patch 433560 2 99983 eric 2011-07-07 10:15:48 -0700 Comment on attachment 99983 Patch Yay! Ideally we would test this. But there may not be much to test here. 433602 3 99983 webkit.review.bot 2011-07-07 10:57:44 -0700 Comment on attachment 99983 Patch Rejecting attachment 99983 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: 39b7cc200e948da1d67bca0f143dd0a54453d3a8 r90578 = 5352a4e441505abbb6835baf39b948e6d76c11ff Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/8991648 435233 4 99983 mrobinson 2011-07-11 15:29:29 -0700 Comment on attachment 99983 Patch Clearing flags on attachment: 99983 Committed r90786: <http://trac.webkit.org/changeset/90786> 435234 5 mrobinson 2011-07-11 15:29:33 -0700 All reviewed patches have been landed. Closing bug. 99983 2011-07-07 08:25:48 -0700 2011-07-11 15:29:28 -0700 Patch bug-64091-20110707112546.patch text/plain 1424 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogOTA1NjAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhOTQ1MjE3MmEwMmExYWE0NTE0ZjI5MzFjMWQxOTM5NTM0 YTljOGFjLi43OWFlOGNiNTZhNDBhYjkwZTFlZGY1MmVkMzJlNzIwMzJiYjIyOTJjIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDctMDcgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdIFtOUldUXSBQaXhlbCB0ZXN0cyBkbyBub3Qgd29yaworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQwOTEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggcGl4ZWwgdGVzdCBydW5z IGZvciBHVEsrIG5ldy1ydW4td2Via2l0LXRlc3RzIGJ5IGV4cG9zaW5nIHRoZQorICAgICAgICBw YXRoIHRvIHRoZSBJbWFnZURpZmYgYmluYXJ5LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHk6IEltcGxlbWVudCBfcGF0aF90b19pbWFnZV9kaWZm LgorCiAyMDExLTA3LTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1RLXSBPcGVuIGxpbmtzIGluIGEgbmV3IHdpbmRvdyB3aGVuIGNsaWNr aW5nIHdpdGggdGhlIG1pZGRsZSBidXR0b24gaW4gTWluaUJyb3dzZXIKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ3RrLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHkKaW5kZXggNTMwYWNkY2I0OWJk NTBiOTQ3NTg2NTA4OTc0ZDAyMTFiOGIzOGZjNy4uMjlkMGY5ZjU5YTVhMGI5YzI5YWRhMjEyYjRj YzI1ODMxMjFiYTYwNSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9ndGsucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9ndGsucHkKQEAgLTc3LDYgKzc3LDkgQEAgY2xhc3MgR3RrUG9ydCh3ZWJraXQuV2Vi S2l0UG9ydCk6CiAgICAgZGVmIF9wYXRoX3RvX2RyaXZlcihzZWxmKToKICAgICAgICAgcmV0dXJu IHNlbGYuX2J1aWxkX3BhdGgoJ1Byb2dyYW1zJywgc2VsZi5kcml2ZXJfbmFtZSgpKQogCisgICAg ZGVmIF9wYXRoX3RvX2ltYWdlX2RpZmYoc2VsZik6CisgICAgICAgIHJldHVybiBzZWxmLl9idWls ZF9wYXRoKCdQcm9ncmFtcycsICdJbWFnZURpZmYnKQorCiAgICAgZGVmIGNoZWNrX2J1aWxkKHNl bGYsIG5lZWRzX2h0dHApOgogICAgICAgICByZXR1cm4gc2VsZi5fY2hlY2tfZHJpdmVyKCkKIAo=