64077 2011-07-07 02:31:16 -0700 DFG JIT does not implement get_by_id prototype caching 2011-07-17 01:05:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 0 fpizlo webkit-unassigned barraclough webkit.review.bot oldest_to_newest 433364 0 fpizlo 2011-07-07 02:31:16 -0700 The JSC JIT emits stubs to cache get_by_id prototype accesses. The DFG JIT does not implement this optimization. 433367 1 99963 fpizlo 2011-07-07 02:50:35 -0700 Created attachment 99963 the patch 433770 2 99963 barraclough 2011-07-07 16:17:14 -0700 Comment on attachment 99963 the patch I think there might be an alternative given the way we're currently code generating the self accesses. We may be able to plant a couple of extra instructions inline in the JIT code to load to prototype & check its structure, immediately prior to the load. But this is just a possible idea to explore - patch as is looks fine. 433787 3 99963 webkit.review.bot 2011-07-07 16:48:52 -0700 Comment on attachment 99963 the patch Clearing flags on attachment: 99963 Committed r90601: <http://trac.webkit.org/changeset/90601> 433788 4 webkit.review.bot 2011-07-07 16:48:56 -0700 All reviewed patches have been landed. Closing bug. 434388 5 barraclough 2011-07-08 16:43:40 -0700 Reopening - these changes were rolled out in r90673 due to https://bugs.webkit.org/show_bug.cgi?id=64181 438267 6 barraclough 2011-07-17 01:05:27 -0700 Closing, I think these changes were landed as a part of another bug. Filip, please reopen if I'm mistaken & this is still a live issue. 99963 2011-07-07 02:50:35 -0700 2011-07-07 16:48:52 -0700 the patch protocache_patch_1.diff text/plain 8796 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTA1NTApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDctMDcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgSklUIGRvZXMgbm90IGltcGxlbWVudCBnZXRfYnlfaWQgcHJvdG90eXBlIGNhY2hpbmcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDA3NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR1Jl cGF0Y2guY3BwOgorICAgICAgICAoSlNDOjpERkc6OmVtaXRSZXN0b3JlU2NyYXRjaCk6CisgICAg ICAgIChKU0M6OkRGRzo6bGlua1Jlc3RvcmVTY3JhdGNoKToKKyAgICAgICAgKEpTQzo6REZHOjp0 cnlDYWNoZUdldEJ5SUQpOgorICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuaDoKKyAgICAgICAg KEpTQzo6SlNPYmplY3Q6OmFkZHJlc3NPZlByb3BlcnR5QXRPZmZzZXQpOgorCiAyMDExLTA3LTA2 ICBKdWFuIEMuIE1vbnRlbWF5b3IgIDxqbW9udEBhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJU X05PVF9SRUFDSEVEIHJ1bm5pbmcgdGVzdCAyNjIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHUmVwYXRjaC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdSZXBhdGNoLmNwcAkocmV2aXNpb24gOTA1NDEpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR1JlcGF0Y2guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Niw2ICs1Niw0NCBA QCBzdGF0aWMgdm9pZCBkZmdSZXBhdGNoQnlJZFNlbGZBY2Nlc3MoQ29kCiAgICAgICAgIHJlcGF0 Y2hCdWZmZXIucmVwYXRjaChzdHViSW5mby5jYWxsUmV0dXJuTG9jYXRpb24uZGF0YUxhYmVsMzJB dE9mZnNldChzdHViSW5mby51LnVuc2V0LmRlbHRhQ2FsbFRvTG9hZE9yU3RvcmUpLCBzaXplb2Yo SlNWYWx1ZSkgKiBvZmZzZXQpOwogfQogCitzdGF0aWMgdm9pZCBlbWl0UmVzdG9yZVNjcmF0Y2go TWFjcm9Bc3NlbWJsZXImIHN0dWJKaXQsIGJvb2wgbmVlZFRvUmVzdG9yZVNjcmF0Y2gsIEdQUlJl ZyBzY3JhdGNoR1BSLCBNYWNyb0Fzc2VtYmxlcjo6SnVtcCYgc3VjY2VzcywgTWFjcm9Bc3NlbWJs ZXI6Okp1bXAmIGZhaWwsIE1hY3JvQXNzZW1ibGVyOjpKdW1wIGZhaWx1cmVDYXNlMSwgTWFjcm9B c3NlbWJsZXI6Okp1bXAgZmFpbHVyZUNhc2UyKQoreworICAgIGlmIChuZWVkVG9SZXN0b3JlU2Ny YXRjaCkgeworICAgICAgICBzdHViSml0LnBvcChzY3JhdGNoR1BSKTsKKyAgICAgICAgCisgICAg ICAgIHN1Y2Nlc3MgPSBzdHViSml0Lmp1bXAoKTsKKyAgICAgICAgCisgICAgICAgIC8vIGxpbmsg ZmFpbHVyZSBjYXNlcyBoZXJlLCBzbyB3ZSBjYW4gcG9wIHNjcmF0Y2hHUFIsIGFuZCB0aGVuIGp1 bXAgYmFjay4KKyAgICAgICAgZmFpbHVyZUNhc2UxLmxpbmsoJnN0dWJKaXQpOworICAgICAgICBm YWlsdXJlQ2FzZTIubGluaygmc3R1YkppdCk7CisgICAgICAgIAorICAgICAgICBzdHViSml0LnBv cChzY3JhdGNoR1BSKTsKKyAgICAgICAgCisgICAgICAgIGZhaWwgPSBzdHViSml0Lmp1bXAoKTsK KyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICAKKyAgICBzdWNjZXNzID0gc3R1YkppdC5qdW1w KCk7Cit9CisKK3N0YXRpYyB2b2lkIGxpbmtSZXN0b3JlU2NyYXRjaChMaW5rQnVmZmVyJiBwYXRj aEJ1ZmZlciwgYm9vbCBuZWVkVG9SZXN0b3JlU2NyYXRjaCwgU3RydWN0dXJlU3R1YkluZm8mIHN0 dWJJbmZvLCBNYWNyb0Fzc2VtYmxlcjo6SnVtcCYgc3VjY2VzcywgTWFjcm9Bc3NlbWJsZXI6Okp1 bXAmIGZhaWwsIE1hY3JvQXNzZW1ibGVyOjpKdW1wIGZhaWx1cmVDYXNlMSwgTWFjcm9Bc3NlbWJs ZXI6Okp1bXAgZmFpbHVyZUNhc2UyKQoreworICAgIENvZGVMb2NhdGlvbkxhYmVsIHNsb3dDYXNl QmVnaW4gPSBzdHViSW5mby5jYWxsUmV0dXJuTG9jYXRpb24ubGFiZWxBdE9mZnNldChzdHViSW5m by5kZWx0YUNhbGxUb1Nsb3dDYXNlKTsKKyAgICAKKyAgICBwYXRjaEJ1ZmZlci5saW5rKHN1Y2Nl c3MsIHN0dWJJbmZvLmNhbGxSZXR1cm5Mb2NhdGlvbi5sYWJlbEF0T2Zmc2V0KHN0dWJJbmZvLmRl bHRhQ2FsbFRvRG9uZSkpOworICAgICAgICAKKyAgICBwYXRjaEJ1ZmZlci5saW5rKHN1Y2Nlc3Ms IHN0dWJJbmZvLmNhbGxSZXR1cm5Mb2NhdGlvbi5sYWJlbEF0T2Zmc2V0KHN0dWJJbmZvLmRlbHRh Q2FsbFRvRG9uZSkpOworICAgIAorICAgIGlmIChuZWVkVG9SZXN0b3JlU2NyYXRjaCkgeworICAg ICAgICBwYXRjaEJ1ZmZlci5saW5rKGZhaWwsIHNsb3dDYXNlQmVnaW4pOworICAgICAgICByZXR1 cm47CisgICAgfQorICAgIAorICAgIC8vIGxpbmsgZmFpbHVyZSBjYXNlcyBkaXJlY3RseSBiYWNr IHRvIG5vcm1hbCBwYXRoCisgICAgcGF0Y2hCdWZmZXIubGluayhmYWlsdXJlQ2FzZTEsIHNsb3dD YXNlQmVnaW4pOworICAgIHBhdGNoQnVmZmVyLmxpbmsoZmFpbHVyZUNhc2UyLCBzbG93Q2FzZUJl Z2luKTsKK30KKyAgICAgICAgICAgIAogc3RhdGljIGJvb2wgdHJ5Q2FjaGVHZXRCeUlEKEV4ZWNT dGF0ZSogZXhlYywgSlNWYWx1ZSBiYXNlVmFsdWUsIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5 TmFtZSwgY29uc3QgUHJvcGVydHlTbG90JiBzbG90LCBTdHJ1Y3R1cmVTdHViSW5mbyYgc3R1Yklu Zm8pCiB7CiAgICAgLy8gRklYTUU6IFdyaXRlIGEgdGVzdCB0aGF0IHByb3ZlcyB3ZSBuZWVkIHRv IGNoZWNrIGZvciByZWN1cnNpb24gaGVyZSBqdXN0CkBAIC04OCwzNCArMTI2LDExIEBAIHN0YXRp YyBib29sIHRyeUNhY2hlR2V0QnlJRChFeGVjU3RhdGUqIGUKIAogICAgICAgICBNYWNyb0Fzc2Vt Ymxlcjo6SnVtcCBzdWNjZXNzLCBmYWlsOwogICAgICAgICAKLSAgICAgICAgaWYgKG5lZWRUb1Jl c3RvcmVTY3JhdGNoKSB7Ci0gICAgICAgICAgICBzdHViSml0LnBvcChzY3JhdGNoR1BSKTsKLSAg ICAgICAgICAgIAotICAgICAgICAgICAgc3VjY2VzcyA9IHN0dWJKaXQuanVtcCgpOwotICAgICAg ICAgICAgCi0gICAgICAgICAgICAvLyBsaW5rIGZhaWx1cmUgY2FzZXMgaGVyZSwgc28gd2UgY2Fu IHBvcCBzY3JhdGNoR1BSLCBhbmQgdGhlbiBqdW1wIGJhY2suCi0gICAgICAgICAgICBmYWlsdXJl Q2FzZTEubGluaygmc3R1YkppdCk7Ci0gICAgICAgICAgICBmYWlsdXJlQ2FzZTIubGluaygmc3R1 YkppdCk7Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIHN0dWJKaXQucG9wKHNjcmF0Y2hHUFIp OwotICAgICAgICAgICAgCi0gICAgICAgICAgICBmYWlsID0gc3R1YkppdC5qdW1wKCk7Ci0gICAg ICAgIH0gZWxzZQotICAgICAgICAgICAgc3VjY2VzcyA9IHN0dWJKaXQuanVtcCgpOworICAgICAg ICBlbWl0UmVzdG9yZVNjcmF0Y2goc3R1YkppdCwgbmVlZFRvUmVzdG9yZVNjcmF0Y2gsIHNjcmF0 Y2hHUFIsIHN1Y2Nlc3MsIGZhaWwsIGZhaWx1cmVDYXNlMSwgZmFpbHVyZUNhc2UyKTsKICAgICAg ICAgCiAgICAgICAgIExpbmtCdWZmZXIgcGF0Y2hCdWZmZXIoKmdsb2JhbERhdGEsICZzdHViSml0 LCBjb2RlQmxvY2stPmV4ZWN1dGFibGVQb29sKCkpOwogICAgICAgICAKLSAgICAgICAgQ29kZUxv Y2F0aW9uTGFiZWwgc2xvd0Nhc2VCZWdpbiA9IHN0dWJJbmZvLmNhbGxSZXR1cm5Mb2NhdGlvbi5s YWJlbEF0T2Zmc2V0KHN0dWJJbmZvLmRlbHRhQ2FsbFRvU2xvd0Nhc2UpOwotICAgICAgICAKLSAg ICAgICAgcGF0Y2hCdWZmZXIubGluayhzdWNjZXNzLCBzdHViSW5mby5jYWxsUmV0dXJuTG9jYXRp b24ubGFiZWxBdE9mZnNldChzdHViSW5mby5kZWx0YUNhbGxUb0RvbmUpKTsKLSAgICAgICAgCi0g ICAgICAgIGlmIChuZWVkVG9SZXN0b3JlU2NyYXRjaCkKLSAgICAgICAgICAgIHBhdGNoQnVmZmVy LmxpbmsoZmFpbCwgc2xvd0Nhc2VCZWdpbik7Ci0gICAgICAgIGVsc2UgewotICAgICAgICAgICAg Ly8gbGluayBmYWlsdXJlIGNhc2VzIGRpcmVjdGx5IGJhY2sgdG8gbm9ybWFsIHBhdGgKLSAgICAg ICAgICAgIHBhdGNoQnVmZmVyLmxpbmsoZmFpbHVyZUNhc2UxLCBzbG93Q2FzZUJlZ2luKTsKLSAg ICAgICAgICAgIHBhdGNoQnVmZmVyLmxpbmsoZmFpbHVyZUNhc2UyLCBzbG93Q2FzZUJlZ2luKTsK LSAgICAgICAgfQorICAgICAgICBsaW5rUmVzdG9yZVNjcmF0Y2gocGF0Y2hCdWZmZXIsIG5lZWRU b1Jlc3RvcmVTY3JhdGNoLCBzdHViSW5mbywgc3VjY2VzcywgZmFpbCwgZmFpbHVyZUNhc2UxLCBm YWlsdXJlQ2FzZTIpOwogICAgICAgICAKICAgICAgICAgQ29kZUxvY2F0aW9uTGFiZWwgZW50cnlM YWJlbCA9IHBhdGNoQnVmZmVyLmZpbmFsaXplQ29kZUFkZGVuZHVtKCk7CiAgICAgICAgIHN0dWJJ bmZvLnN0dWJSb3V0aW5lID0gZW50cnlMYWJlbDsKQEAgLTE1MCw3ICsxNjUsNzMgQEAgc3RhdGlj IGJvb2wgdHJ5Q2FjaGVHZXRCeUlEKEV4ZWNTdGF0ZSogZQogICAgICAgICByZXR1cm4gdHJ1ZTsK ICAgICB9CiAgICAgCi0gICAgLy8gRklYTUU6IHNob3VsZCBzdXBwb3J0IHByb3RvdHlwZSAmIGNo YWluIGFjY2Vzc2VzIQorICAgIGlmIChzdHJ1Y3R1cmUtPmlzRGljdGlvbmFyeSgpKQorICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgCisgICAgLy8gT3B0aW1pemUgYWNjZXNzZXMgb24gdGhlIGRp cmVjdCBwcm90b3R5cGUKKyAgICBpZiAoc2xvdC5zbG90QmFzZSgpID09IHN0cnVjdHVyZS0+cHJv dG90eXBlRm9yTG9va3VwKGV4ZWMpKSB7CisgICAgICAgIGlmIChzbG90LmNhY2hlZFByb3BlcnR5 VHlwZSgpICE9IFByb3BlcnR5U2xvdDo6VmFsdWUpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgICAgIAorICAgICAgICBBU1NFUlQoc2xvdC5zbG90QmFzZSgpLmlzT2JqZWN0KCkpOwor ICAgICAgICAKKyAgICAgICAgSlNPYmplY3QqIHNsb3RCYXNlT2JqZWN0ID0gYXNPYmplY3Qoc2xv dC5zbG90QmFzZSgpKTsKKyAgICAgICAgc2l6ZV90IG9mZnNldCA9IHNsb3QuY2FjaGVkT2Zmc2V0 KCk7CisgICAgICAgIAorICAgICAgICBpZiAoc2xvdEJhc2VPYmplY3QtPnN0cnVjdHVyZSgpLT5p c0RpY3Rpb25hcnkoKSkgeworICAgICAgICAgICAgc2xvdEJhc2VPYmplY3QtPmZsYXR0ZW5EaWN0 aW9uYXJ5T2JqZWN0KCpnbG9iYWxEYXRhKTsKKyAgICAgICAgICAgIG9mZnNldCA9IHNsb3RCYXNl T2JqZWN0LT5zdHJ1Y3R1cmUoKS0+Z2V0KCpnbG9iYWxEYXRhLCBwcm9wZXJ0eU5hbWUpOworICAg ICAgICB9CisgICAgICAgIAorICAgICAgICBBU1NFUlQoIXN0cnVjdHVyZS0+aXNEaWN0aW9uYXJ5 KCkpOworICAgICAgICBBU1NFUlQoIXNsb3RCYXNlT2JqZWN0LT5zdHJ1Y3R1cmUoKS0+aXNEaWN0 aW9uYXJ5KCkpOworICAgICAgICAKKyAgICAgICAgQVNTRVJUKGFzT2JqZWN0KHN0cnVjdHVyZS0+ cHJvdG90eXBlRm9yTG9va3VwKGV4ZWMpKSA9PSBzbG90QmFzZU9iamVjdCk7CisgICAgICAgIAor ICAgICAgICBHUFJSZWcgYmFzZUdQUiA9IHN0YXRpY19jYXN0PEdQUlJlZz4oc3R1YkluZm8uYmFz ZUdQUik7CisgICAgICAgIEdQUlJlZyByZXN1bHRHUFIgPSBzdGF0aWNfY2FzdDxHUFJSZWc+KHN0 dWJJbmZvLnZhbHVlR1BSKTsKKyAgICAgICAgR1BSUmVnIHNjcmF0Y2hHUFIgPSBzdGF0aWNfY2Fz dDxHUFJSZWc+KHN0dWJJbmZvLnUudW5zZXQuc2NyYXRjaEdQUik7CisgICAgICAgIGJvb2wgbmVl ZFRvUmVzdG9yZVNjcmF0Y2ggPSBmYWxzZTsKKyAgICAgICAgCisgICAgICAgIE1hY3JvQXNzZW1i bGVyIHN0dWJKaXQ7CisgICAgICAgIAorICAgICAgICBpZiAoc2NyYXRjaEdQUiA9PSBJbnZhbGlk R1BSUmVnKSB7CisgICAgICAgICAgICBzY3JhdGNoR1BSID0gSklUQ29kZUdlbmVyYXRvcjo6c2Vs ZWN0U2NyYXRjaEdQUihiYXNlR1BSLCByZXN1bHRHUFIpOworICAgICAgICAgICAgc3R1YkppdC5w dXNoKHNjcmF0Y2hHUFIpOworICAgICAgICAgICAgbmVlZFRvUmVzdG9yZVNjcmF0Y2ggPSB0cnVl OworICAgICAgICB9CisgICAgICAgIAorICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6SnVtcCBmYWls dXJlQ2FzZTEgPSBzdHViSml0LmJyYW5jaFB0cihNYWNyb0Fzc2VtYmxlcjo6Tm90RXF1YWwsIE1h Y3JvQXNzZW1ibGVyOjpBZGRyZXNzKGJhc2VHUFIsIEpTQ2VsbDo6c3RydWN0dXJlT2Zmc2V0KCkp LCBNYWNyb0Fzc2VtYmxlcjo6VHJ1c3RlZEltbVB0cihzdHJ1Y3R1cmUpKTsKKyAgICAgICAgCisg ICAgICAgIHN0dWJKaXQubW92ZShNYWNyb0Fzc2VtYmxlcjo6VHJ1c3RlZEltbVB0cihzbG90QmFz ZU9iamVjdCksIHNjcmF0Y2hHUFIpOworICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6SnVtcCBmYWls dXJlQ2FzZTIgPSBzdHViSml0LmJyYW5jaFB0cihNYWNyb0Fzc2VtYmxlcjo6Tm90RXF1YWwsIE1h Y3JvQXNzZW1ibGVyOjpBZGRyZXNzKHNjcmF0Y2hHUFIsIEpTQ2VsbDo6c3RydWN0dXJlT2Zmc2V0 KCkpLCBNYWNyb0Fzc2VtYmxlcjo6VHJ1c3RlZEltbVB0cihzbG90QmFzZU9iamVjdC0+c3RydWN0 dXJlKCkpKTsKKyAgICAgICAgCisgICAgICAgIGlmIChzbG90QmFzZU9iamVjdC0+c3RydWN0dXJl KCktPmlzVXNpbmdJbmxpbmVTdG9yYWdlKCkpCisgICAgICAgICAgICBzdHViSml0LmxvYWRQdHIo TWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3Moc2NyYXRjaEdQUiwgSlNPYmplY3Q6Om9mZnNldE9mSW5s aW5lU3RvcmFnZSgpICsgb2Zmc2V0ICogc2l6ZW9mKEpTVmFsdWUpKSwgcmVzdWx0R1BSKTsKKyAg ICAgICAgZWxzZQorICAgICAgICAgICAgc3R1YkppdC5sb2FkUHRyKHNsb3RCYXNlT2JqZWN0LT5h ZGRyZXNzT2ZQcm9wZXJ0eUF0T2Zmc2V0KG9mZnNldCksIHJlc3VsdEdQUik7CisgICAgICAgIAor ICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6SnVtcCBzdWNjZXNzLCBmYWlsOworICAgICAgICAKKyAg ICAgICAgZW1pdFJlc3RvcmVTY3JhdGNoKHN0dWJKaXQsIG5lZWRUb1Jlc3RvcmVTY3JhdGNoLCBz Y3JhdGNoR1BSLCBzdWNjZXNzLCBmYWlsLCBmYWlsdXJlQ2FzZTEsIGZhaWx1cmVDYXNlMik7Cisg ICAgICAgIAorICAgICAgICBMaW5rQnVmZmVyIHBhdGNoQnVmZmVyKCpnbG9iYWxEYXRhLCAmc3R1 YkppdCwgY29kZUJsb2NrLT5leGVjdXRhYmxlUG9vbCgpKTsKKyAgICAgICAgCisgICAgICAgIGxp bmtSZXN0b3JlU2NyYXRjaChwYXRjaEJ1ZmZlciwgbmVlZFRvUmVzdG9yZVNjcmF0Y2gsIHN0dWJJ bmZvLCBzdWNjZXNzLCBmYWlsLCBmYWlsdXJlQ2FzZTEsIGZhaWx1cmVDYXNlMik7CisgICAgICAg IAorICAgICAgICBDb2RlTG9jYXRpb25MYWJlbCBlbnRyeUxhYmVsID0gcGF0Y2hCdWZmZXIuZmlu YWxpemVDb2RlQWRkZW5kdW0oKTsKKyAgICAgICAgc3R1YkluZm8uc3R1YlJvdXRpbmUgPSBlbnRy eUxhYmVsOworICAgICAgICAKKyAgICAgICAgQ29kZUxvY2F0aW9uTGFiZWwgaG90UGF0aEJlZ2lu ID0gc3R1YkluZm8uaG90UGF0aEJlZ2luOworICAgICAgICBSZXBhdGNoQnVmZmVyIHJlcGF0Y2hC dWZmZXIoY29kZUJsb2NrKTsKKyAgICAgICAgcmVwYXRjaEJ1ZmZlci5yZWxpbmsoc3R1YkluZm8u Y2FsbFJldHVybkxvY2F0aW9uLmp1bXBBdE9mZnNldChzdHViSW5mby5kZWx0YUNhbGxUb1N0cnVj dENoZWNrKSwgZW50cnlMYWJlbCk7CisgICAgICAgIHJlcGF0Y2hCdWZmZXIucmVsaW5rKHN0dWJJ bmZvLmNhbGxSZXR1cm5Mb2NhdGlvbiwgb3BlcmF0aW9uR2V0QnlJZCk7CisgICAgICAgIAorICAg ICAgICBzdHViSW5mby5pbml0R2V0QnlJZFByb3RvKCpnbG9iYWxEYXRhLCBjb2RlQmxvY2stPm93 bmVyRXhlY3V0YWJsZSgpLCBzdHJ1Y3R1cmUsIHNsb3RCYXNlT2JqZWN0LT5zdHJ1Y3R1cmUoKSk7 CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKyAgICAKKyAgICAvLyBGSVhNRTogc2hvdWxk IHN1cHBvcnQgY2hhaW4gYWNjZXNzZXMhCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgJKHJldmlzaW9uIDkwNTQxKQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAkod29ya2luZyBjb3B5 KQpAQCAtMjE5LDYgKzIxOSwxMSBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAgICB2b2lkIGFs bG9jYXRlUHJvcGVydHlTdG9yYWdlKHNpemVfdCBvbGRTaXplLCBzaXplX3QgbmV3U2l6ZSk7CiAg ICAgICAgIGJvb2wgaXNVc2luZ0lubGluZVN0b3JhZ2UoKSBjb25zdCB7IHJldHVybiBzdGF0aWNf Y2FzdDxjb25zdCB2b2lkKj4obV9wcm9wZXJ0eVN0b3JhZ2UpID09IHN0YXRpY19jYXN0PGNvbnN0 IHZvaWQqPih0aGlzICsgMSk7IH0KKyAgICAgICAgCisgICAgICAgIHZvaWQqIGFkZHJlc3NPZlBy b3BlcnR5QXRPZmZzZXQoc2l6ZV90IG9mZnNldCkKKyAgICAgICAgeworICAgICAgICAgICAgcmV0 dXJuIHN0YXRpY19jYXN0PHZvaWQqPigmbV9wcm9wZXJ0eVN0b3JhZ2Vbb2Zmc2V0XSk7CisgICAg ICAgIH0KIAogICAgICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgYmFzZUV4dGVybmFsU3RvcmFn ZUNhcGFjaXR5ID0gMTY7CiAK