64073 2011-07-07 01:33:38 -0700 DFG JIT method_check implementation does not link to optimized get_by_id slow path 2011-07-07 16:07:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 fpizlo webkit-unassigned webkit.review.bot oldest_to_newest 433347 0 fpizlo 2011-07-07 01:33:38 -0700 The JSC JIT links the method_check slow path to the optimizing get_by_id slow path, so that if method_check patching fails, get_by_id can have a go. The DFG JIT does not do this, but should. 433349 1 99957 fpizlo 2011-07-07 01:48:23 -0700 Created attachment 99957 the patch 433690 2 99957 webkit.review.bot 2011-07-07 14:10:49 -0700 Comment on attachment 99957 the patch Rejecting attachment 99957 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: 669ace4c5883549e2e26773acf636ef9b04f6685 r90589 = b4983f42a5417e5da321b861357482a455302b42 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9000249 433752 3 100042 fpizlo 2011-07-07 15:43:22 -0700 Created attachment 100042 the patch 433761 4 100042 webkit.review.bot 2011-07-07 16:07:54 -0700 Comment on attachment 100042 the patch Clearing flags on attachment: 100042 Committed r90598: <http://trac.webkit.org/changeset/90598> 433762 5 webkit.review.bot 2011-07-07 16:07:58 -0700 All reviewed patches have been landed. Closing bug. 99957 2011-07-07 01:48:23 -0700 2011-07-07 15:43:22 -0700 the patch methodcheck_regress_patch_1.diff text/plain 1349 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTA1NDkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDctMDcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgSklUIG1ldGhvZF9jaGVjayBpbXBsZW1lbnRhdGlvbiBkb2VzIG5vdCBsaW5rIHRvIG9wdGlt aXplZCBnZXRfYnlfaWQKKyAgICAgICAgc2xvdyBwYXRoLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQwNzMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdSZXBhdGNoLmNwcDoKKyAgICAgICAg KEpTQzo6REZHOjpkZmdSZXBhdGNoR2V0TWV0aG9kRmFzdCk6CisKIDIwMTEtMDctMDYgIEp1YW4g Qy4gTW9udGVtYXlvciAgPGptb250QGFwcGxlLmNvbT4KIAogICAgICAgICBBU1NFUlRfTk9UX1JF QUNIRUQgcnVubmluZyB0ZXN0IDI2MgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdSZXBhdGNoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R1JlcGF0Y2guY3BwCShyZXZpc2lvbiA5MDU0MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHUmVwYXRjaC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2OCw3ICsxNjgsNyBAQCBzdGF0 aWMgdm9pZCBkZmdSZXBhdGNoR2V0TWV0aG9kRmFzdChKU0dsCiAgICAgUmVwYXRjaEJ1ZmZlciBy ZXBhdGNoQnVmZmVyKGNvZGVCbG9jayk7CiAKICAgICAvLyBPbmx5IG9wdGltaXplIG9uY2UhCi0g ICAgcmVwYXRjaEJ1ZmZlci5yZWxpbmsobWV0aG9kSW5mby5jYWxsUmV0dXJuTG9jYXRpb24sIG9w ZXJhdGlvbkdldEJ5SWQpOworICAgIHJlcGF0Y2hCdWZmZXIucmVsaW5rKG1ldGhvZEluZm8uY2Fs bFJldHVybkxvY2F0aW9uLCBvcGVyYXRpb25HZXRCeUlkT3B0aW1pemUpOwogCiAgICAgbWV0aG9k SW5mby5jYWNoZWRTdHJ1Y3R1cmUuc2V0KCpnbG9iYWxEYXRhLCBvd25lciwgc3RydWN0dXJlKTsK ICAgICBtZXRob2RJbmZvLmNhY2hlZFByb3RvdHlwZVN0cnVjdHVyZS5zZXQoKmdsb2JhbERhdGEs IG93bmVyLCBzbG90QmFzZU9iamVjdC0+c3RydWN0dXJlKCkpOwo= 100042 2011-07-07 15:43:22 -0700 2011-07-07 16:07:54 -0700 the patch methodcheck_regress_patch_2.diff text/plain 1361 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTA1OTMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDctMDcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgSklUIG1ldGhvZF9jaGVjayBpbXBsZW1lbnRhdGlvbiBkb2VzIG5vdCBsaW5rIHRvIG9wdGlt aXplZCBnZXRfYnlfaWQKKyAgICAgICAgc2xvdyBwYXRoLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQwNzMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdSZXBhdGNoLmNwcDoKKyAgICAgICAg KEpTQzo6REZHOjpkZmdSZXBhdGNoR2V0TWV0aG9kRmFzdCk6CisKIDIwMTEtMDctMDcgIE9saXZl ciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmNvZGUganVtcCBhbmQgbGlu ayBzaXplcyBpbnRvIHRoZSBhcHByb3ByaWF0ZSBlbnVtcwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdSZXBhdGNoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR1JlcGF0Y2guY3BwCShyZXZpc2lvbiA5MDU5MykKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHUmVwYXRjaC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2OCw3ICsx NjgsNyBAQCBzdGF0aWMgdm9pZCBkZmdSZXBhdGNoR2V0TWV0aG9kRmFzdChKU0dsCiAgICAgUmVw YXRjaEJ1ZmZlciByZXBhdGNoQnVmZmVyKGNvZGVCbG9jayk7CiAKICAgICAvLyBPbmx5IG9wdGlt aXplIG9uY2UhCi0gICAgcmVwYXRjaEJ1ZmZlci5yZWxpbmsobWV0aG9kSW5mby5jYWxsUmV0dXJu TG9jYXRpb24sIG9wZXJhdGlvbkdldEJ5SWQpOworICAgIHJlcGF0Y2hCdWZmZXIucmVsaW5rKG1l dGhvZEluZm8uY2FsbFJldHVybkxvY2F0aW9uLCBvcGVyYXRpb25HZXRCeUlkT3B0aW1pemUpOwog CiAgICAgbWV0aG9kSW5mby5jYWNoZWRTdHJ1Y3R1cmUuc2V0KCpnbG9iYWxEYXRhLCBvd25lciwg c3RydWN0dXJlKTsKICAgICBtZXRob2RJbmZvLmNhY2hlZFByb3RvdHlwZVN0cnVjdHVyZS5zZXQo Kmdsb2JhbERhdGEsIG93bmVyLCBzbG90QmFzZU9iamVjdC0+c3RydWN0dXJlKCkpOwo=