64039 2011-07-06 15:41:29 -0700 DFG JIT implementation of op_call results in regressions on sunspider controlflow-recursive 2011-07-06 21:04:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 fpizlo webkit-unassigned webkit.review.bot oldest_to_newest 433082 0 fpizlo 2011-07-06 15:41:29 -0700 The op_call implementation causes more code to be compiled by DFG, and is revealing bad speculation decisions, which result in large performance regressions especially on sunspider controlflow-recursive. 433137 1 99906 fpizlo 2011-07-06 17:35:35 -0700 Created attachment 99906 the patch 433222 2 99906 webkit.review.bot 2011-07-06 21:04:42 -0700 Comment on attachment 99906 the patch Clearing flags on attachment: 99906 Committed r90533: <http://trac.webkit.org/changeset/90533> 433223 3 webkit.review.bot 2011-07-06 21:04:45 -0700 All reviewed patches have been landed. Closing bug. 99906 2011-07-06 17:35:35 -0700 2011-07-06 21:04:42 -0700 the patch fixfib_patch_1.diff text/plain 3935 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTA1MDYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDctMDYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgSklUIGltcGxlbWVudGF0aW9uIG9mIG9wX2NhbGwgcmVzdWx0cyBpbiByZWdyZXNzaW9ucyBv biBzdW5zcGlkZXIKKyAgICAgICAgY29udHJvbGZsb3ctcmVjdXJzaXZlLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQwMzkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdCeXRlQ29kZVBhcnNl ci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6OmlzU21hbGxJbnQzMkNv bnN0YW50KToKKyAgICAgICAgKEpTQzo6REZHOjpCeXRlQ29kZVBhcnNlcjo6cGFyc2VCbG9jayk6 CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklULmg6CisgICAgICAgIChKU0M6OkRGRzo6 U3BlY3VsYXRpdmVKSVQ6OmlzSW50ZWdlcik6CisKIDIwMTEtMDctMDYgIEZpbGlwIFBpemxvICA8 ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBERkcgSklUIG9wX2NhbGwgaW1wbGVtZW50YXRp b24gd2lsbCBmbHVzaCByZWdpc3RlcnMgZXZlbiB3aGVuIHRob3NlIHJlZ2lzdGVycyBhcmUgZGVh ZApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNl ci5jcHAJKHJldmlzaW9uIDkwNDgzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdC eXRlQ29kZVBhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1NCw2ICsyNTQsMTYgQEAgcHJp dmF0ZToKICAgICB7CiAgICAgICAgIHJldHVybiBpc0pTQ29uc3RhbnQobm9kZUluZGV4KSAmJiB2 YWx1ZU9mSlNDb25zdGFudChub2RlSW5kZXgpLmlzSW50MzIoKTsKICAgICB9CisgICAgYm9vbCBp c1NtYWxsSW50MzJDb25zdGFudChOb2RlSW5kZXggbm9kZUluZGV4KQorICAgIHsKKyAgICAgICAg aWYgKCFpc0pTQ29uc3RhbnQobm9kZUluZGV4KSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsK KyAgICAgICAgSlNWYWx1ZSB2YWx1ZSA9IHZhbHVlT2ZKU0NvbnN0YW50KG5vZGVJbmRleCk7Cisg ICAgICAgIGlmICghdmFsdWUuaXNJbnQzMigpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgICAgICBpbnQzMl90IGludFZhbHVlID0gdmFsdWUuYXNJbnQzMigpOworICAgICAgICByZXR1 cm4gaW50VmFsdWUgPj0gLTUgJiYgaW50VmFsdWUgPD0gNTsKKyAgICB9CiAgICAgYm9vbCBpc0Rv dWJsZUNvbnN0YW50KE5vZGVJbmRleCBub2RlSW5kZXgpCiAgICAgewogICAgICAgICByZXR1cm4g aXNKU0NvbnN0YW50KG5vZGVJbmRleCkgJiYgdmFsdWVPZkpTQ29uc3RhbnQobm9kZUluZGV4KS5p c051bWJlcigpOwpAQCAtNjc1LDkgKzY4NSwxMyBAQCBib29sIEJ5dGVDb2RlUGFyc2VyOjpwYXJz ZUJsb2NrKHVuc2lnbmVkCiAgICAgICAgICAgICBOb2RlSW5kZXggb3AyID0gZ2V0KGN1cnJlbnRJ bnN0cnVjdGlvblszXS51Lm9wZXJhbmQpOwogICAgICAgICAgICAgLy8gSWYgYm90aCBvcGVyYW5k cyBjYW4gc3RhdGljYWxseSBiZSBkZXRlcm1pbmVkIHRvIHRoZSBudW1iZXJzLCB0aGVuIHRoaXMg aXMgYW4gYXJpdGhtZXRpYyBhZGQuCiAgICAgICAgICAgICAvLyBPdGhlcndpc2UsIHdlIG11c3Qg YXNzdW1lIHRoaXMgbWF5IGJlIHBlcmZvcm1pbmcgYSBjb25jYXRlbmF0aW9uIHRvIGEgc3RyaW5n LgotICAgICAgICAgICAgaWYgKG1fZ3JhcGhbb3AxXS5oYXNOdW1lcmljUmVzdWx0KCkgJiYgbV9n cmFwaFtvcDJdLmhhc051bWVyaWNSZXN1bHQoKSkKKyAgICAgICAgICAgIGlmIChtX2dyYXBoW29w MV0uaGFzTnVtZXJpY1Jlc3VsdCgpICYmIG1fZ3JhcGhbb3AyXS5oYXNOdW1lcmljUmVzdWx0KCkp IHsKKyAgICAgICAgICAgICAgICBpZiAoaXNTbWFsbEludDMyQ29uc3RhbnQob3AxKSB8fCBpc1Nt YWxsSW50MzJDb25zdGFudChvcDIpKSB7CisgICAgICAgICAgICAgICAgICAgIHByZWRpY3RJbnQz MihvcDEpOworICAgICAgICAgICAgICAgICAgICBwcmVkaWN0SW50MzIob3AyKTsKKyAgICAgICAg ICAgICAgICB9CiAgICAgICAgICAgICAgICAgc2V0KGN1cnJlbnRJbnN0cnVjdGlvblsxXS51Lm9w ZXJhbmQsIGFkZFRvR3JhcGgoQXJpdGhBZGQsIHRvTnVtYmVyKG9wMSksIHRvTnVtYmVyKG9wMikp KTsKLSAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgICAg IHNldChjdXJyZW50SW5zdHJ1Y3Rpb25bMV0udS5vcGVyYW5kLCBhZGRUb0dyYXBoKFZhbHVlQWRk LCBvcDEsIG9wMikpOwogICAgICAgICAgICAgTkVYVF9PUENPREUob3BfYWRkKTsKICAgICAgICAg fQpAQCAtNjg2LDYgKzcwMCwxMCBAQCBib29sIEJ5dGVDb2RlUGFyc2VyOjpwYXJzZUJsb2NrKHVu c2lnbmVkCiAgICAgICAgICAgICBBUklUSE1FVElDX09QKCk7CiAgICAgICAgICAgICBOb2RlSW5k ZXggb3AxID0gZ2V0VG9OdW1iZXIoY3VycmVudEluc3RydWN0aW9uWzJdLnUub3BlcmFuZCk7CiAg ICAgICAgICAgICBOb2RlSW5kZXggb3AyID0gZ2V0VG9OdW1iZXIoY3VycmVudEluc3RydWN0aW9u WzNdLnUub3BlcmFuZCk7CisgICAgICAgICAgICBpZiAoaXNTbWFsbEludDMyQ29uc3RhbnQob3Ax KSB8fCBpc1NtYWxsSW50MzJDb25zdGFudChvcDIpKSB7CisgICAgICAgICAgICAgICAgcHJlZGlj dEludDMyKG9wMSk7CisgICAgICAgICAgICAgICAgcHJlZGljdEludDMyKG9wMik7CisgICAgICAg ICAgICB9CiAgICAgICAgICAgICBzZXQoY3VycmVudEluc3RydWN0aW9uWzFdLnUub3BlcmFuZCwg YWRkVG9HcmFwaChBcml0aFN1Yiwgb3AxLCBvcDIpKTsKICAgICAgICAgICAgIE5FWFRfT1BDT0RF KG9wX3N1Yik7CiAgICAgICAgIH0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH U3BlY3VsYXRpdmVKSVQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR1NwZWN1bGF0aXZlSklULmgJKHJldmlzaW9uIDkwNDgzKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNjYsOCAr MTY2LDkgQEAgcHJpdmF0ZToKIAogICAgICAgICBWaXJ0dWFsUmVnaXN0ZXIgdmlydHVhbFJlZ2lz dGVyID0gbm9kZS52aXJ0dWFsUmVnaXN0ZXIoKTsKICAgICAgICAgR2VuZXJhdGlvbkluZm8mIGlu Zm8gPSBtX2dlbmVyYXRpb25JbmZvW3ZpcnR1YWxSZWdpc3Rlcl07Ci0KLSAgICAgICAgcmV0dXJu IChpbmZvLnJlZ2lzdGVyRm9ybWF0KCkgfCBEYXRhRm9ybWF0SlMpID09IERhdGFGb3JtYXRKU0lu dGVnZXI7CisgICAgICAgIAorICAgICAgICByZXR1cm4gKGluZm8ucmVnaXN0ZXJGb3JtYXQoKSB8 IERhdGFGb3JtYXRKUykgPT0gRGF0YUZvcm1hdEpTSW50ZWdlcgorICAgICAgICAgICAgfHwgKGlu Zm8uc3BpbGxGb3JtYXQoKSB8IERhdGFGb3JtYXRKUykgPT0gRGF0YUZvcm1hdEpTSW50ZWdlcjsK ICAgICB9CiAKICAgICBib29sIGlzRGF0YUZvcm1hdERvdWJsZShOb2RlSW5kZXggbm9kZUluZGV4 KQo=