<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>64037</bug_id>
          
          <creation_ts>2011-07-06 15:32:15 -0700</creation_ts>
          <short_desc>Add roll-chromium-deps command to sheriff-bot</short_desc>
          <delta_ts>2022-02-27 23:43:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>dglazkov</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>433072</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-07-06 15:32:15 -0700</bug_when>
    <thetext>Add roll-chromium-deps command to sheriff-bot</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433075</commentid>
    <comment_count>1</comment_count>
      <attachid>99894</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-07-06 15:33:36 -0700</bug_when>
    <thetext>Created attachment 99894
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433079</commentid>
    <comment_count>2</comment_count>
      <attachid>99894</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-06 15:37:59 -0700</bug_when>
    <thetext>Comment on attachment 99894
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99894&amp;action=review

OK.

&gt; Tools/Scripts/webkitpy/tool/bot/irc_command.py:135
&gt; +        if revision:
&gt; +            tool.irc().post(&quot;%s: Rolling Chromium DEPS to r%s&quot; % (nick, revision))
&gt; +        else:
&gt; +            tool.irc().post(&quot;%s: Rolling Chromium DEPS last-known good revision&quot; % nick)

I would have probably used:
roll_target = &quot;r%&quot; % revision if revision else &quot;last-known good revision&quot;
tool.irc().post(&quot;%s Rolling Chromium DEPS to %s&quot; % (nick, roll_target))

&gt; Tools/Scripts/webkitpy/tool/bot/irc_command.py:142
&gt; +            match = re.search(r&quot;Current Chromium DEPS revision \d+ is newer than \d+\.&quot;, e.output)

Does this need to be multi-line?

&gt; Tools/Scripts/webkitpy/tool/bot/irc_command.py:144
&gt; +                tool.irc().post(&quot;%s: %s&quot; % (nick, match.group(0)))

You could name your groups for clarity.

&gt; Tools/Scripts/webkitpy/tool/bot/irc_command.py:145
&gt; +                return

return None will exit 0, is that what you want?  Oh, I guess this is a IRC command, so it will just not say anthing.  return None is still probably more explicit than return.  Not sure it maters.

&gt; Tools/Scripts/webkitpy/tool/bot/irc_command.py:151
&gt; +            bug_id = parse_bug_id(e.output)
&gt; +            if bug_id:
&gt; +                bug_url = tool.bugs.bug_url_for_bug_id(bug_id)
&gt; +                tool.irc().post(&quot;%s: Ugg...  Might have created %s&quot; % (nick, bug_url))

Wish we could share this somehow....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433091</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-07-06 15:49:53 -0700</bug_when>
    <thetext>Committed r90507: &lt;http://trac.webkit.org/changeset/90507&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>99894</attachid>
            <date>2011-07-06 15:33:36 -0700</date>
            <delta_ts>2022-02-27 23:43:35 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-64037-20110706153335.patch</filename>
            <type>text/plain</type>
            <size>11085</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDkwNTA0KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMjAgQEAKKzIwMTEtMDctMDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor
ICAgICAgICBBZGQgcm9sbC1jaHJvbWl1bS1kZXBzIGNvbW1hbmQgdG8gc2hlcmlmZi1ib3QKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MDM3CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTG8sIGFuZCB0aGUg
REVQUyB3ZXJlIHJvbGxlZCBvbiBjb21tYW5kLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw
eS90b29sL2JvdC9pcmNfY29tbWFuZC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rv
b2wvYm90L2lyY19jb21tYW5kX3VuaXR0ZXN0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0
cHkvdG9vbC9ib3Qvc2hlcmlmZi5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wv
Ym90L3NoZXJpZmZpcmNib3RfdW5pdHRlc3QucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRw
eS90b29sL2NvbW1hbmRzL3JvbGwucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29s
L2NvbW1hbmRzL3JvbGxfdW5pdHRlc3QucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90
b29sL3N0ZXBzL3VwZGF0ZWNocm9taXVtZGVwcy5weToKKwogMjAxMS0wNy0wNiAgQWRhbSBSb2Jl
biAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYXIgVGVzdEZhaWx1cmVzJ3MgZ2V0
TnVtYmVyT2ZGYWlsaW5nVGVzdHMgY2FjaGUKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv
dG9vbC9ib3QvaXJjX2NvbW1hbmQucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr
aXRweS90b29sL2JvdC9pcmNfY29tbWFuZC5weQkocmV2aXNpb24gOTA1MDQpCisrKyBUb29scy9T
Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2lyY19jb21tYW5kLnB5CSh3b3JraW5nIGNvcHkpCkBA
IC0xMTgsNiArMTE4LDM5IEBAIGNsYXNzIFJvbGxvdXQoSVJDQ29tbWFuZCk6CiAgICAgICAgICAg
ICAgICAgdG9vbC5pcmMoKS5wb3N0KCIlczogVWdnLi4uICBNaWdodCBoYXZlIGNyZWF0ZWQgJXMi
ICUgKG5pY2tzX3N0cmluZywgdG9vbC5idWdzLmJ1Z191cmxfZm9yX2J1Z19pZChidWdfaWQpKSkK
IAogCitjbGFzcyBSb2xsQ2hyb21pdW1ERVBTKElSQ0NvbW1hbmQpOgorICAgIGRlZiBfcGFyc2Vf
YXJncyhzZWxmLCBhcmdzKToKKyAgICAgICAgaWYgbm90IGFyZ3M6CisgICAgICAgICAgICByZXR1
cm4KKyAgICAgICAgcmV2aXNpb24gPSBhcmdzWzBdLmxzdHJpcCgiciIpCisgICAgICAgIGlmIG5v
dCByZXZpc2lvbi5pc2RpZ2l0KCk6CisgICAgICAgICAgICByZXR1cm4KKyAgICAgICAgcmV0dXJu
IHJldmlzaW9uCisKKyAgICBkZWYgZXhlY3V0ZShzZWxmLCBuaWNrLCBhcmdzLCB0b29sLCBzaGVy
aWZmKToKKyAgICAgICAgcmV2aXNpb24gPSBzZWxmLl9wYXJzZV9hcmdzKGFyZ3MpCisgICAgICAg
IGlmIHJldmlzaW9uOgorICAgICAgICAgICAgdG9vbC5pcmMoKS5wb3N0KCIlczogUm9sbGluZyBD
aHJvbWl1bSBERVBTIHRvIHIlcyIgJSAobmljaywgcmV2aXNpb24pKQorICAgICAgICBlbHNlOgor
ICAgICAgICAgICAgdG9vbC5pcmMoKS5wb3N0KCIlczogUm9sbGluZyBDaHJvbWl1bSBERVBTIGxh
c3Qta25vd24gZ29vZCByZXZpc2lvbiIgJSBuaWNrKQorCisgICAgICAgIHRyeToKKyAgICAgICAg
ICAgIGJ1Z19pZCA9IHNoZXJpZmYucG9zdF9jaHJvbWl1bV9kZXBzX3JvbGwocmV2aXNpb24pCisg
ICAgICAgICAgICBidWdfdXJsID0gdG9vbC5idWdzLmJ1Z191cmxfZm9yX2J1Z19pZChidWdfaWQp
CisgICAgICAgICAgICB0b29sLmlyYygpLnBvc3QoIiVzOiBDcmVhdGVkIERFUFMgcm9sbDogJXMi
ICUgKG5pY2ssIGJ1Z191cmwpKQorICAgICAgICBleGNlcHQgU2NyaXB0RXJyb3IsIGU6CisgICAg
ICAgICAgICBtYXRjaCA9IHJlLnNlYXJjaChyIkN1cnJlbnQgQ2hyb21pdW0gREVQUyByZXZpc2lv
biBcZCsgaXMgbmV3ZXIgdGhhbiBcZCtcLiIsIGUub3V0cHV0KQorICAgICAgICAgICAgaWYgbWF0
Y2g6CisgICAgICAgICAgICAgICAgdG9vbC5pcmMoKS5wb3N0KCIlczogJXMiICUgKG5pY2ssIG1h
dGNoLmdyb3VwKDApKSkKKyAgICAgICAgICAgICAgICByZXR1cm4KKyAgICAgICAgICAgIHRvb2wu
aXJjKCkucG9zdCgiJXM6IEZhaWxlZCB0byBjcmVhdGUgREVQUyByb2xsOiIgJSBuaWNrKQorICAg
ICAgICAgICAgdG9vbC5pcmMoKS5wb3N0KCIlcyIgJSBlKQorICAgICAgICAgICAgYnVnX2lkID0g
cGFyc2VfYnVnX2lkKGUub3V0cHV0KQorICAgICAgICAgICAgaWYgYnVnX2lkOgorICAgICAgICAg
ICAgICAgIGJ1Z191cmwgPSB0b29sLmJ1Z3MuYnVnX3VybF9mb3JfYnVnX2lkKGJ1Z19pZCkKKyAg
ICAgICAgICAgICAgICB0b29sLmlyYygpLnBvc3QoIiVzOiBVZ2cuLi4gIE1pZ2h0IGhhdmUgY3Jl
YXRlZCAlcyIgJSAobmljaywgYnVnX3VybCkpCisKKwogY2xhc3MgSGVscChJUkNDb21tYW5kKToK
ICAgICBkZWYgZXhlY3V0ZShzZWxmLCBuaWNrLCBhcmdzLCB0b29sLCBzaGVyaWZmKToKICAgICAg
ICAgcmV0dXJuICIlczogQXZhaWxhYmxlIGNvbW1hbmRzOiAlcyIgJSAobmljaywgIiwgIi5qb2lu
KGNvbW1hbmRzLmtleXMoKSkpCkBAIC0xODYsNCArMjE5LDUgQEAgY29tbWFuZHMgPSB7CiAgICAg
InJvbGxvdXQiOiBSb2xsb3V0LAogICAgICJ3aG9pcyI6IFdob2lzLAogICAgICJjcmVhdGUtYnVn
IjogQ3JlYXRlQnVnLAorICAgICJyb2xsLWNocm9taXVtLWRlcHMiOiBSb2xsQ2hyb21pdW1ERVBT
LAogfQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9pcmNfY29tbWFuZF91
bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90
L2lyY19jb21tYW5kX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA5MDUwNCkKKysrIFRvb2xzL1Njcmlw
dHMvd2Via2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmRfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29w
eSkKQEAgLTI4LDYgKzI4LDcgQEAKIAogaW1wb3J0IHVuaXR0ZXN0CiAKK2Zyb20gd2Via2l0cHku
Y29tbW9uLnN5c3RlbS5vdXRwdXRjYXB0dXJlIGltcG9ydCBPdXRwdXRDYXB0dXJlCiBmcm9tIHdl
YmtpdHB5LnRvb2wuYm90LmlyY19jb21tYW5kIGltcG9ydCAqCiBmcm9tIHdlYmtpdHB5LnRvb2wu
bW9ja3Rvb2wgaW1wb3J0IE1vY2tUb29sCiAKQEAgLTcwLDYgKzcxLDExIEBAIGNsYXNzIElSQ0Nv
bW1hbmRUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMo
InRvbTogRmFpbGVkIHRvIGNyZWF0ZSBidWc6XG5FeGNlcHRpb24gZnJvbSBidWd6aWxsYSEiLAog
ICAgICAgICAgICAgICAgICAgICAgICAgICBjcmVhdGVfYnVnLmV4ZWN1dGUoInRvbSIsIGV4YW1w
bGVfYXJncywgdG9vbCwgTm9uZSkpCiAKKyAgICBkZWYgdGVzdF9yb2xsX2Nocm9taXVtX2RlcHMo
c2VsZik6CisgICAgICAgIHJvbGwgPSBSb2xsQ2hyb21pdW1ERVBTKCkKKyAgICAgICAgc2VsZi5h
c3NlcnRFcXVhbHMoTm9uZSwgcm9sbC5fcGFyc2VfYXJncyhbXSkpCisgICAgICAgIHNlbGYuYXNz
ZXJ0RXF1YWxzKCIxMjM0Iiwgcm9sbC5fcGFyc2VfYXJncyhbIjEyMzQiXSkpCisKICAgICBkZWYg
dGVzdF9yb2xsb3V0KHNlbGYpOgogICAgICAgICByb2xsb3V0ID0gUm9sbG91dCgpCiAgICAgICAg
IHNlbGYuYXNzZXJ0RXF1YWxzKChbMTIzNF0sICJ0ZXN0aW5nIGZvbyIpLApJbmRleDogVG9vbHMv
U2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmLnB5Cj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz
L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZi5weQkocmV2aXNpb24gOTA1MDQpCisr
KyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmYucHkJKHdvcmtpbmcgY29w
eSkKQEAgLTg5LDYgKzg5LDE4IEBAIGNsYXNzIFNoZXJpZmYob2JqZWN0KToKICAgICAgICAgXSkK
ICAgICAgICAgcmV0dXJuIHBhcnNlX2J1Z19pZChvdXRwdXQpCiAKKyAgICBkZWYgcG9zdF9jaHJv
bWl1bV9kZXBzX3JvbGwoc2VsZiwgcmV2aXNpb24pOgorICAgICAgICBhcmdzID0gWworICAgICAg
ICAgICAgInBvc3QtY2hyb21pdW0tZGVwcy1yb2xsIiwKKyAgICAgICAgICAgICItLWZvcmNlLWNs
ZWFuIiwKKyAgICAgICAgICAgICItLW5vbi1pbnRlcmFjdGl2ZSIsCisgICAgICAgICAgICAiLS1w
YXJlbnQtY29tbWFuZD1zaGVyaWZmLWJvdCIsCisgICAgICAgIF0KKyAgICAgICAgaWYgcmV2aXNp
b246CisgICAgICAgICAgICBhcmdzICs9IFtyZXZpc2lvbl0KKyAgICAgICAgb3V0cHV0ID0gc2Vs
Zi5fc2hlcmlmZmJvdC5ydW5fd2Via2l0X3BhdGNoKGFyZ3MpCisgICAgICAgIHJldHVybiBwYXJz
ZV9idWdfaWQob3V0cHV0KQorCiAgICAgZGVmIHBvc3RfYmxhbWVfY29tbWVudF9vbl9idWcoc2Vs
ZiwgY29tbWl0X2luZm8sIGJ1aWxkZXJzLCB0ZXN0cyk6CiAgICAgICAgIGlmIG5vdCBjb21taXRf
aW5mby5idWdfaWQoKToKICAgICAgICAgICAgIHJldHVybgpJbmRleDogVG9vbHMvU2NyaXB0cy93
ZWJraXRweS90b29sL2JvdC9zaGVyaWZmaXJjYm90X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZmlyY2JvdF91bml0dGVzdC5w
eQkocmV2aXNpb24gOTA1MDQpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3No
ZXJpZmZpcmNib3RfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTgyLDcgKzgyLDcgQEAg
Y2xhc3MgU2hlcmlmZklSQ0JvdFRlc3QodW5pdHRlc3QuVGVzdENhcwogICAgICAgICBPdXRwdXRD
YXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgcnVuLCBhcmdzPVsiaGkiXSwgZXhwZWN0ZWRf
c3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKIAogICAgIGRlZiB0ZXN0X2hlbHAoc2VsZik6Ci0gICAg
ICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJNT0NLOiBpcmMucG9zdDogbW9ja19uaWNrOiBBdmFpbGFi
bGUgY29tbWFuZHM6IHdob2lzLCBjcmVhdGUtYnVnLCBoaSwgbGFzdC1ncmVlbi1yZXZpc2lvbiwg
cm9sbG91dCwgcmVzdGFydCwgaGVscFxuIgorICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiTU9D
SzogaXJjLnBvc3Q6IG1vY2tfbmljazogQXZhaWxhYmxlIGNvbW1hbmRzOiBoaSwgaGVscCwgbGFz
dC1ncmVlbi1yZXZpc2lvbiwgcm9sbG91dCwgcm9sbC1jaHJvbWl1bS1kZXBzLCBjcmVhdGUtYnVn
LCByZXN0YXJ0LCB3aG9pc1xuIgogICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1
dHMoc2VsZiwgcnVuLCBhcmdzPVsiaGVscCJdLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3Rk
ZXJyKQogCiAgICAgZGVmIHRlc3RfbGdyKHNlbGYpOgpAQCAtOTcsNiArOTcsMTQgQEAgY2xhc3Mg
U2hlcmlmZklSQ0JvdFRlc3QodW5pdHRlc3QuVGVzdENhcwogICAgICAgICBleHBlY3RlZF9zdGRl
cnIgPSAiTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljaywgYWJhcnRoLCBkYXJpbiwgZXNlaWRlbDog
UHJlcGFyaW5nIHJvbGxvdXQgZm9yIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzIx
NjU0Li4uXG5NT0NLOiBpcmMucG9zdDogbW9ja19uaWNrLCBhYmFydGgsIGRhcmluLCBlc2VpZGVs
OiBDcmVhdGVkIHJvbGxvdXQ6IGh0dHA6Ly9leGFtcGxlLmNvbS8zNjkzNlxuIgogICAgICAgICBP
dXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgcnVuLCBhcmdzPVsicm9sbG91dCAy
MTY1NCBUaGlzIHBhdGNoIGJyb2tlIHRoZSB3b3JsZCJdLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0
ZWRfc3RkZXJyKQogCisgICAgZGVmIHRlc3Rfcm9sbF9jaHJvbWl1bV9kZXBzKHNlbGYpOgorICAg
ICAgICBleHBlY3RlZF9zdGRlcnIgPSAiTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljazogUm9sbGlu
ZyBDaHJvbWl1bSBERVBTIHRvIHIyMTY1NFxuTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljazogQ3Jl
YXRlZCBERVBTIHJvbGw6IGh0dHA6Ly9leGFtcGxlLmNvbS8zNjkzNlxuIgorICAgICAgICBPdXRw
dXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgcnVuLCBhcmdzPVsicm9sbC1jaHJvbWl1
bS1kZXBzIDIxNjU0Il0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCisKKyAgICBk
ZWYgdGVzdF9yb2xsX2Nocm9taXVtX2RlcHNfdG9fbGtncihzZWxmKToKKyAgICAgICAgZXhwZWN0
ZWRfc3RkZXJyID0gIk1PQ0s6IGlyYy5wb3N0OiBtb2NrX25pY2s6IFJvbGxpbmcgQ2hyb21pdW0g
REVQUyBsYXN0LWtub3duIGdvb2QgcmV2aXNpb25cbk1PQ0s6IGlyYy5wb3N0OiBtb2NrX25pY2s6
IENyZWF0ZWQgREVQUyByb2xsOiBodHRwOi8vZXhhbXBsZS5jb20vMzY5MzZcbiIKKyAgICAgICAg
T3V0cHV0Q2FwdHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIHJ1biwgYXJncz1bInJvbGwtY2hy
b21pdW0tZGVwcyJdLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJyKQorCiAgICAgZGVm
IHRlc3RfbXVsdGlfcm9sbG91dChzZWxmKToKICAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIk1P
Q0s6IGlyYy5wb3N0OiBtb2NrX25pY2ssIGFiYXJ0aCwgZGFyaW4sIGVzZWlkZWw6IFByZXBhcmlu
ZyByb2xsb3V0IGZvciBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yMTY1NCwgaHR0
cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjE2NTUsIGFuZCBodHRwOi8vdHJhYy53ZWJr
aXQub3JnL2NoYW5nZXNldC8yMTY1Ni4uLlxuTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljaywgYWJh
cnRoLCBkYXJpbiwgZXNlaWRlbDogQ3JlYXRlZCByb2xsb3V0OiBodHRwOi8vZXhhbXBsZS5jb20v
MzY5MzZcbiIKICAgICAgICAgT3V0cHV0Q2FwdHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIHJ1
biwgYXJncz1bInJvbGxvdXQgMjE2NTQgMjE2NTUgMjE2NTYgVGhpcyAyMTY1NCBwYXRjaCBicm9r
ZSB0aGUgd29ybGQiXSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKSW5kZXg6IFRv
b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9yb2xsLnB5Cj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9yb2xsLnB5CShyZXZpc2lvbiA5
MDUwNCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9yb2xsLnB5CSh3
b3JraW5nIGNvcHkpCkBAIC00NiwzICs0NiwyOCBAQCBjbGFzcyBSb2xsQ2hyb21pdW1ERVBTKEFi
c3RyYWN0U2VxdWVuY2VkCiAgICAgICAgIHJldHVybiB7CiAgICAgICAgICAgICAiY2hyb21pdW1f
cmV2aXNpb24iOiAoYXJncyBhbmQgYXJnc1swXSksCiAgICAgICAgIH0KKworCitjbGFzcyBQb3N0
Q2hyb21pdW1ERVBTUm9sbChBYnN0cmFjdFNlcXVlbmNlZENvbW1hbmQpOgorICAgIG5hbWUgPSAi
cG9zdC1jaHJvbWl1bS1kZXBzLXJvbGwiCisgICAgaGVscF90ZXh0ID0gIlBvc3RzIGEgcGF0Y2gg
dG8gdXBkYXRlIENocm9taXVtIERFUFMgKGRlZmF1bHRzIHRvIHRoZSBsYXN0LWtub3duIGdvb2Qg
cmV2aXNpb24gb2YgQ2hyb21pdW0pIgorICAgIGFyZ3VtZW50X25hbWVzID0gIltDSFJPTUlVTV9S
RVZJU0lPTl0iCisgICAgc3RlcHMgPSBbCisgICAgICAgIHN0ZXBzLkNsZWFuV29ya2luZ0RpcmVj
dG9yeSwKKyAgICAgICAgc3RlcHMuVXBkYXRlLAorICAgICAgICBzdGVwcy5VcGRhdGVDaHJvbWl1
bURFUFMsCisgICAgICAgIHN0ZXBzLlByZXBhcmVDaGFuZ2VMb2dGb3JERVBTUm9sbCwKKyAgICAg
ICAgc3RlcHMuQ3JlYXRlQnVnLAorICAgICAgICBzdGVwcy5Qb3N0RGlmZiwKKyAgICBdCisKKyAg
ICBkZWYgX3ByZXBhcmVfc3RhdGUoc2VsZiwgb3B0aW9ucywgYXJncywgdG9vbCk6CisgICAgICAg
IG9wdGlvbnMucmV2aWV3ID0gRmFsc2UKKyAgICAgICAgb3B0aW9ucy5yZXF1ZXN0X2NvbW1pdCA9
IFRydWUKKworICAgICAgICBjaHJvbWl1bV9yZXZpc2lvbiA9IChhcmdzIGFuZCBhcmdzWzBdKQor
ICAgICAgICByZXR1cm4geworICAgICAgICAgICAgImNocm9taXVtX3JldmlzaW9uIjogY2hyb21p
dW1fcmV2aXNpb24sCisgICAgICAgICAgICAiYnVnX3RpdGxlIjogIlJvbGwgQ2hyb21pdW0gREVQ
UyB0byByJXMiICUgY2hyb21pdW1fcmV2aXNpb24sCisgICAgICAgICAgICAiYnVnX2Rlc2NyaXB0
aW9uIjogIkEgREVQUyByb2xsIGEgZGF5IGtlZXBzIHRoZSBidWlsZCBicmVhayBhd2F5LiIsCisg
ICAgICAgIH0KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9yb2xs
X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j
b21tYW5kcy9yb2xsX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA5MDUwNCkKKysrIFRvb2xzL1Njcmlw
dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9yb2xsX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkp
CkBAIC00Myw3ICs0Myw4IEBAIENvbW1pdHRlZCByNDk4MjQ6IDxodHRwOi8vdHJhYy53ZWJraXQu
b3IKICAgICAgICAgc2VsZi5hc3NlcnRfZXhlY3V0ZV9vdXRwdXRzKFJvbGxDaHJvbWl1bURFUFMo
KSwgWzY3NjRdLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJyKQogCiAgICAgZGVmIHRl
c3RfdXBkYXRlX2Nocm9taXVtX2RlcHNfb2xkZXJfcmV2aXNpb24oc2VsZik6CisgICAgICAgIG9w
dGlvbnMgPSBNb2NrT3B0aW9ucyhub25faW50ZXJhY3RpdmU9RmFsc2UpCiAgICAgICAgIGV4cGVj
dGVkX3N0ZGVyciA9ICIiIkN1cnJlbnQgQ2hyb21pdW0gREVQUyByZXZpc2lvbiA2NTY0IGlzIG5l
d2VyIHRoYW4gNTc2NC4KIEVSUk9SOiBVbmFibGUgdG8gdXBkYXRlIENocm9taXVtIERFUFMKICIi
IgotICAgICAgICBzZWxmLmFzc2VydF9leGVjdXRlX291dHB1dHMoUm9sbENocm9taXVtREVQUygp
LCBbNTc2NF0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIsIGV4cGVjdGVkX2V4Y2Vw
dGlvbj1TeXN0ZW1FeGl0KQorICAgICAgICBzZWxmLmFzc2VydF9leGVjdXRlX291dHB1dHMoUm9s
bENocm9taXVtREVQUygpLCBbNTc2NF0sIG9wdGlvbnM9b3B0aW9ucywgZXhwZWN0ZWRfc3RkZXJy
PWV4cGVjdGVkX3N0ZGVyciwgZXhwZWN0ZWRfZXhjZXB0aW9uPVN5c3RlbUV4aXQpCkluZGV4OiBU
b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvdXBkYXRlY2hyb21pdW1kZXBzLnB5Cj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy91cGRhdGVjaHJv
bWl1bWRlcHMucHkJKHJldmlzaW9uIDkwNTA0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90
b29sL3N0ZXBzL3VwZGF0ZWNocm9taXVtZGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtMzUsMTMg
KzM1LDIyIEBAIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5kZXByZWNhdGVkX2wKIAogCiBj
bGFzcyBVcGRhdGVDaHJvbWl1bURFUFMoQWJzdHJhY3RTdGVwKToKKyAgICBAY2xhc3NtZXRob2QK
KyAgICBkZWYgb3B0aW9ucyhjbHMpOgorICAgICAgICByZXR1cm4gQWJzdHJhY3RTdGVwLm9wdGlv
bnMoKSArIFsKKyAgICAgICAgICAgIE9wdGlvbnMubm9uX2ludGVyYWN0aXZlLAorICAgICAgICBd
CisKICAgICAjIE5vdGljZSB0aGF0IHRoaXMgbWV0aG9kIHRocm93cyBsb3RzIG9mIGV4Y2l0aW5n
IGV4Y2VwdGlvbnMhCiAgICAgZGVmIF9mZXRjaF9sYXN0X2tub3duX2dvb2RfcmV2aXNpb24oc2Vs
Zik6CiAgICAgICAgIHJldHVybiBpbnQodXJsbGliMi51cmxvcGVuKHVybHMuY2hyb21pdW1fbGtn
cl91cmwpLnJlYWQoKSkKIAogICAgIGRlZiBfdmFsaWRhdGVfcmV2aXNpb25zKHNlbGYsIGN1cnJl
bnRfY2hyb21pdW1fcmV2aXNpb24sIG5ld19jaHJvbWl1bV9yZXZpc2lvbik6CiAgICAgICAgIGlm
IG5ld19jaHJvbWl1bV9yZXZpc2lvbiA8IGN1cnJlbnRfY2hyb21pdW1fcmV2aXNpb246Ci0gICAg
ICAgICAgICBsb2coIkN1cnJlbnQgQ2hyb21pdW0gREVQUyByZXZpc2lvbiAlcyBpcyBuZXdlciB0
aGFuICVzLiIgJSAoY3VycmVudF9jaHJvbWl1bV9yZXZpc2lvbiwgbmV3X2Nocm9taXVtX3Jldmlz
aW9uKSkKKyAgICAgICAgICAgIG1lc3NhZ2UgPSAiQ3VycmVudCBDaHJvbWl1bSBERVBTIHJldmlz
aW9uICVzIGlzIG5ld2VyIHRoYW4gJXMuIiAlIChjdXJyZW50X2Nocm9taXVtX3JldmlzaW9uLCBu
ZXdfY2hyb21pdW1fcmV2aXNpb24pCisgICAgICAgICAgICBpZiBzZWxmLl9vcHRpb25zLm5vbl9p
bnRlcmFjdGl2ZToKKyAgICAgICAgICAgICAgICBlcnJvcihtZXNzYWdlKSAgIyBDYXVzZXMgdGhl
IHByb2Nlc3MgdG8gdGVybWluYXRlLgorICAgICAgICAgICAgbG9nKG1lc3NhZ2UpCiAgICAgICAg
ICAgICBuZXdfY2hyb21pdW1fcmV2aXNpb24gPSBzZWxmLl90b29sLnVzZXIucHJvbXB0KCJFbnRl
ciBuZXcgY2hyb21pdW0gcmV2aXNpb24gKGVudGVyIG5vdGhpbmcgdG8gY2FuY2VsKTpcbiIpCiAg
ICAgICAgICAgICB0cnk6CiAgICAgICAgICAgICAgICAgbmV3X2Nocm9taXVtX3JldmlzaW9uID0g
aW50KG5ld19jaHJvbWl1bV9yZXZpc2lvbikK
</data>
<flag name="review"
          id="94485"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>