64033 2011-07-06 14:54:10 -0700 InspectorInstrumentation.cpp compilation is broken 2011-07-07 00:08:16 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62982 0 romaxa webkit-unassigned caseq loislo pfeldman webkit.review.bot yurys oldest_to_newest 433053 0 romaxa 2011-07-06 14:54:10 -0700 ation.o ../../../Source/WebCore/inspector/InspectorInstrumentation.cpp ../../../Source/WebCore/inspector/InspectorInstrumentation.cpp: In static member function 'static void WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl(WebCore::InstrumentingAgents*, WebCore::Node*)': ../../../Source/WebCore/inspector/InspectorInstrumentation.cpp:165: error: 'class WebCore::InstrumentingAgents' has no member named 'inspectorDOMDebuggerAgent' ../../../Source/WebCore/inspector/InspectorInstrumentation.cpp:166: error: invalid use of incomplete type 'struct WebCore::InspectorDOMDebuggerAgent' ../../../Source/WebCore/inspector/InstrumentingAgents.h:42: error: forward declaration of 'struct WebCore::InspectorDOMDebuggerAgent' make: *** [obj/release/InspectorInstrumentation.o] Error 1 433055 1 romaxa 2011-07-06 14:55:51 -0700 Introduced in bug 62982 http://trac.webkit.org/changeset/89245 433057 2 99888 romaxa 2011-07-06 14:58:00 -0700 Created attachment 99888 Fix inspector compilation without debugger enabled 433281 3 yurys 2011-07-06 23:32:03 -0700 Oleg, thanks for taking a look at this. FYI: there is a short link webkit.org/new-inspector-bug which will create a bug with correct component, title and all potential inspector reviewers in the CC list. It is also reachable under New bug > Inspector: The Web Inspector Developer Tools link. 433307 4 99888 webkit.review.bot 2011-07-07 00:08:11 -0700 Comment on attachment 99888 Fix inspector compilation without debugger enabled Clearing flags on attachment: 99888 Committed r90544: <http://trac.webkit.org/changeset/90544> 433308 5 webkit.review.bot 2011-07-07 00:08:16 -0700 All reviewed patches have been landed. Closing bug. 99888 2011-07-06 14:58:00 -0700 2011-07-07 00:08:11 -0700 Fix inspector compilation without debugger enabled patch.diff text/plain 1501 romaxa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwNTAzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMDYgIE9sZWcgUm9t YXNoaW4gIDxyb21heGFAZ21haWwuY29tPgorCisgICAgICAgIEZpeCBJbnNwZWN0b3JJbnN0cnVt ZW50YXRpb24gY29tcGlsYXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NDAzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4ganVzdCBjb21waWxlIGZpeC4KKworICAgICAgICAq IGluc3BlY3Rvci9JbnNwZWN0b3JJbnN0cnVtZW50YXRpb24uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpkaWRJbnZhbGlkYXRlU3R5bGVBdHRySW1wbCk6 CisKIDIwMTEtMDctMDYgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgTm90IHJldmlld2VkOiBXZWIgSW5zcGVjdG9yOiBmaXhpbmcgdHlwbyBpbnRyb2R1 Y2VkIGluIHRoZSByOTAzOTcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9ySW5zdHJ1bWVudGF0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmNwcAkocmV2aXNpb24gOTA0ODMpCisrKyBT b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTYyLDggKzE2MiwxMCBAQCB2b2lkIEluc3BlY3Rvckluc3RydW1lbnRh dGlvbjo6ZGlkSW52YWxpCiB7CiAgICAgaWYgKEluc3BlY3RvckRPTUFnZW50KiBkb21BZ2VudCA9 IGluc3RydW1lbnRpbmdBZ2VudHMtPmluc3BlY3RvckRPTUFnZW50KCkpCiAgICAgICAgIGRvbUFn ZW50LT5kaWRJbnZhbGlkYXRlU3R5bGVBdHRyKG5vZGUpOworI2lmIEVOQUJMRShKQVZBU0NSSVBU X0RFQlVHR0VSKQogICAgIGlmIChJbnNwZWN0b3JET01EZWJ1Z2dlckFnZW50KiBkb21EZWJ1Z2dl ckFnZW50ID0gaW5zdHJ1bWVudGluZ0FnZW50cy0+aW5zcGVjdG9yRE9NRGVidWdnZXJBZ2VudCgp KQogICAgICAgICBkb21EZWJ1Z2dlckFnZW50LT5kaWRJbnZhbGlkYXRlU3R5bGVBdHRyKG5vZGUp OworI2VuZGlmCiB9CiAKIHZvaWQgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpmcmFtZVdpbmRv d0Rpc2NhcmRlZEltcGwoSW5zdHJ1bWVudGluZ0FnZW50cyogaW5zdHJ1bWVudGluZ0FnZW50cywg RE9NV2luZG93KiB3aW5kb3cpCg==