64032 2011-07-06 14:22:25 -0700 Work around Skia PDF's lack of inverted path support. 2011-07-07 16:16:37 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vandebo ctguil agl ctguil eric hamaji jamesr tony webkit.review.bot oldest_to_newest 433023 0 vandebo 2011-07-06 14:22:25 -0700 The trick used in http://neugierig.org/software/chromium/notes/2010/07/clipping.html to support antialiased clips doesn't work when printing to Skia's PDF backend because the backend does not support inverted paths (PDF does not support it natively meaning Skia would need a full geometry engine to support it). This manifests as rounded buttons not being drawn when printing, tracked as Chrome bug 79519. However, when the output is a vector device, like PDF, we don't need antialiased clips - it's up to the PDF rendering engine to do that. So we can simply disable the antialiased clip code if the output is a vector device. I think the fix isn't testable because it requires examining the printed output. 433049 1 99885 vandebo 2011-07-06 14:51:23 -0700 Created attachment 99885 Don't use clip antialias hack when printing. 433052 2 webkit.review.bot 2011-07-06 14:53:50 -0700 Attachment 99885 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 433056 3 99887 vandebo 2011-07-06 14:57:50 -0700 Created attachment 99887 Don't use clip antialias hack when printing. 433076 4 ctguil 2011-07-06 15:33:57 -0700 James, can you take a look at this change? 433083 5 jamesr 2011-07-06 15:42:05 -0700 Why can't we test printed output? 433085 6 vandebo 2011-07-06 15:44:31 -0700 As far as I'm aware, there's not a PDF renderer available in the testing pipeline. 433086 7 jamesr 2011-07-06 15:46:05 -0700 Who's working on fixing that? 433088 8 tony 2011-07-06 15:47:54 -0700 Have you tried layoutTestController.setPrinting()? There are a few examples of this in the tree (e.g., printing/compositing-layer-printing.html and printing/media-queries-print.html). It might only work on Mac, which probably doesn't go through this code path, in which case you can ignore me. 433089 9 tony 2011-07-06 15:48:41 -0700 Hamaji may have other ideas on how to test printing. 433092 10 vandebo 2011-07-06 15:56:11 -0700 There's a bug in Skia, assigned to me: http://code.google.com/p/skia/issues/detail?id=246 For awhile the plan was to use Chrome's PDF plugin, but licensing didn't work out on that. I investigated using ghostscript, but it has some very strange rendering quirks for the existing skia test set. Ben Wagner recently proposed some code to use lib poppler, which we may use, though it does not handle shaders or soft masks correctly. 433135 11 ctguil 2011-07-06 17:27:19 -0700 LayoutTests/platform/chromium/test_expectations.txt skips printing/compositing-layer-printing.html and printing/media-queries-print.html for the chromium port. With the comment: // These tests try to print a PDF file as the expected result. I don't think // we plan on supporting this anytime soon. I think Eric said before that automated testing of printing with DumpRenderTree is not possible. 433149 12 eric 2011-07-06 18:27:01 -0700 Yup, printing tests were a dream. But never a reality. PDFs (at least on OS X) include all sorts of per-machine information, making them a poor reference image format. 433630 13 99887 jamesr 2011-07-07 11:51:02 -0700 Comment on attachment 99887 Don't use clip antialias hack when printing. OK, but please add a descriptive comment in the changelog and inline to explain what is going on. 433717 14 100036 ctguil 2011-07-07 14:52:02 -0700 Created attachment 100036 Adding descriptive comment in changelog and inline for Steve 433757 15 100036 jamesr 2011-07-07 15:55:13 -0700 Comment on attachment 100036 Adding descriptive comment in changelog and inline for Steve Thanks for the explanation, I'm sure the next person to debug through this bit of code will appreciate it greatly. 433767 16 100036 webkit.review.bot 2011-07-07 16:16:32 -0700 Comment on attachment 100036 Adding descriptive comment in changelog and inline for Steve Clearing flags on attachment: 100036 Committed r90599: <http://trac.webkit.org/changeset/90599> 433768 17 webkit.review.bot 2011-07-07 16:16:37 -0700 All reviewed patches have been landed. Closing bug. 99885 2011-07-06 14:51:23 -0700 2011-07-06 14:57:50 -0700 Don't use clip antialias hack when printing. skia.patch text/plain 1428 vandebo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwNTAzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDctMDYgIFN0ZXZlIFZh bkRlQm9nYXJ0ICA8dmFuZGVib0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW3NraWFdIGRvbid0 IHVzZSBhbnRpYWxpYXMgY2xpcCBoYWNrIHdoZW4gcHJpbnRpbmcuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lh L1BsYXRmb3JtQ29udGV4dFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1Db250 ZXh0U2tpYTo6Y2xpcFBhdGhBbnRpQWxpYXNlZCk6CisKIDIwMTEtMDctMDYgIFBhdmVsIEZlbGRt YW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkOiBXZWIg SW5zcGVjdG9yOiBmaXhpbmcgdHlwbyBpbnRyb2R1Y2VkIGluIHRoZSByOTAzOTcuCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEv UGxhdGZvcm1Db250ZXh0U2tpYS5jcHAJKHJldmlzaW9uIDkwNDk4KQorKysgU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjk2LDYgKzI5NiwxMSBAQCB2b2lkIFBsYXRmb3JtQ29udGV4dFNraWE6OmJl Z2luTGF5ZXJDbGlwCiAKIHZvaWQgUGxhdGZvcm1Db250ZXh0U2tpYTo6Y2xpcFBhdGhBbnRpQWxp YXNlZChjb25zdCBTa1BhdGgmIGNsaXBQYXRoKQogeworICAgIGlmIChtX2NhbnZhcy0+Z2V0VG9w RGV2aWNlKCktPmdldERldmljZUNhcGFiaWxpdGllcygpICYgU2tEZXZpY2U6OmtWZWN0b3JfQ2Fw YWJpbGl0eSkgeworICAgICAgICBjYW52YXMoKS0+Y2xpcFBhdGgoY2xpcFBhdGgpOworICAgICAg ICByZXR1cm47CisgICAgfQorCiAgICAgLy8gSWYgd2UgYXJlIGN1cnJlbnRseSB0cmFja2luZyBh bnkgYW50aS1hbGlhcyBjbGlwIHBhdGhzLCB0aGVuIHdlIGFscmVhZHkKICAgICAvLyBoYXZlIGEg bGF5ZXIgaW4gcGxhY2UgYW5kIGRvbid0IG5lZWQgdG8gYWRkIGFub3RoZXIuCiAgICAgYm9vbCBo YXZlTGF5ZXJPdXRzdGFuZGluZyA9IG1fc3RhdGUtPm1fYW50aUFsaWFzQ2xpcFBhdGhzLnNpemUo KTsK 99887 2011-07-06 14:57:50 -0700 2011-07-07 14:51:48 -0700 Don't use clip antialias hack when printing. skia.patch text/plain 1483 vandebo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwNTAzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDctMDYgIFN0ZXZlIFZh bkRlQm9nYXJ0ICA8dmFuZGVib0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW3NraWFdIGRvbid0 IHVzZSBhbnRpYWxpYXMgY2xpcCBoYWNrIHdoZW4gcHJpbnRpbmcuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDAzMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Q bGF0Zm9ybUNvbnRleHRTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtQ29udGV4 dFNraWE6OmNsaXBQYXRoQW50aUFsaWFzZWQpOgorCiAyMDExLTA3LTA2ICBQYXZlbCBGZWxkbWFu ICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE5vdCByZXZpZXdlZDogV2ViIElu c3BlY3RvcjogZml4aW5nIHR5cG8gaW50cm9kdWNlZCBpbiB0aGUgcjkwMzk3LgpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1Bs YXRmb3JtQ29udGV4dFNraWEuY3BwCShyZXZpc2lvbiA5MDQ5OCkKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTI5Niw2ICsyOTYsMTEgQEAgdm9pZCBQbGF0Zm9ybUNvbnRleHRTa2lhOjpiZWdp bkxheWVyQ2xpcAogCiB2b2lkIFBsYXRmb3JtQ29udGV4dFNraWE6OmNsaXBQYXRoQW50aUFsaWFz ZWQoY29uc3QgU2tQYXRoJiBjbGlwUGF0aCkKIHsKKyAgICBpZiAobV9jYW52YXMtPmdldFRvcERl dmljZSgpLT5nZXREZXZpY2VDYXBhYmlsaXRpZXMoKSAmIFNrRGV2aWNlOjprVmVjdG9yX0NhcGFi aWxpdHkpIHsKKyAgICAgICAgY2FudmFzKCktPmNsaXBQYXRoKGNsaXBQYXRoKTsKKyAgICAgICAg cmV0dXJuOworICAgIH0KKwogICAgIC8vIElmIHdlIGFyZSBjdXJyZW50bHkgdHJhY2tpbmcgYW55 IGFudGktYWxpYXMgY2xpcCBwYXRocywgdGhlbiB3ZSBhbHJlYWR5CiAgICAgLy8gaGF2ZSBhIGxh eWVyIGluIHBsYWNlIGFuZCBkb24ndCBuZWVkIHRvIGFkZCBhbm90aGVyLgogICAgIGJvb2wgaGF2 ZUxheWVyT3V0c3RhbmRpbmcgPSBtX3N0YXRlLT5tX2FudGlBbGlhc0NsaXBQYXRocy5zaXplKCk7 Cg== 100036 2011-07-07 14:52:02 -0700 2011-07-07 16:16:32 -0700 Adding descriptive comment in changelog and inline for Steve bug-64032-20110707145201.patch text/plain 2413 ctguil SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwNTkwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDctMDcgIFN0ZXZlIFZh bkRlQm9nYXJ0ICA8dmFuZGVib0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV29yayBhcm91bmQg U2tpYSBQREYncyBsYWNrIG9mIGludmVydGVkIHBhdGggc3VwcG9ydC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MDMyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRyaWNrIHVzZWQgaW4gaHR0cDov L25ldWdpZXJpZy5vcmcvc29mdHdhcmUvY2hyb21pdW0vbm90ZXMvMjAxMC8wNy9jbGlwcGluZy5o dG1sCisgICAgICAgIHRvIHN1cHBvcnQgYW50aWFsaWFzZWQgY2xpcHMgZG9lc24ndCB3b3JrIHdo ZW4gcHJpbnRpbmcgdG8gU2tpYSdzIFBERiBiYWNrZW5kIGJlY2F1c2UKKyAgICAgICAgdGhlIGJh Y2tlbmQgZG9lcyBub3Qgc3VwcG9ydCBpbnZlcnRlZCBwYXRocy4gVGhpcyBtYW5pZmVzdHMgYXMg cm91bmRlZCBidXR0b25zIG5vdCBiZWluZworICAgICAgICBkcmF3biB3aGVuIHByaW50aW5nLCB0 cmFja2VkIGFzIENocm9tZSBidWcgNzk1MTkuCisgICAgICAgIAorICAgICAgICBIb3dldmVyLCB3 aGVuIHRoZSBvdXRwdXQgaXMgYSB2ZWN0b3IgZGV2aWNlLCBsaWtlIFBERiwgd2UgZG9uJ3QgbmVl ZCBhbnRpYWxpYXNlZCBjbGlwcy4KKyAgICAgICAgSXQncyB1cCB0byB0aGUgUERGIHJlbmRlcmlu ZyBlbmdpbmUgdG8gZG8gdGhhdC4gIFNvIHdlIGNhbiBzaW1wbHkgZGlzYWJsZSB0aGUgYW50aWFs aWFzZWQKKyAgICAgICAgY2xpcCBjb2RlIGlmIHRoZSBvdXRwdXQgaXMgYSB2ZWN0b3IgZGV2aWNl LgorICAgICAgICAKKyAgICAgICAgSSB0aGluayB0aGUgZml4IGlzbid0IHRlc3RhYmxlIGJlY2F1 c2UgaXQgcmVxdWlyZXMgZXhhbWluaW5nIHRoZSBwcmludGVkIG91dHB1dC4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpQbGF0Zm9ybUNvbnRleHRTa2lhOjpjbGlwUGF0aEFudGlBbGlhc2VkKToKKwog MjAxMS0wNy0wNyAgRW1pbCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg U3dpdGNoIGFkZEZvY3VzUmluZ1JlY3RzIHRvIHRvIG5ldyBsYXlvdXQgdHlwZXMKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Q bGF0Zm9ybUNvbnRleHRTa2lhLmNwcAkocmV2aXNpb24gOTA1MTkpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yOTYsNiArMjk2LDE0IEBAIHZvaWQgUGxhdGZvcm1Db250ZXh0U2tpYTo6YmVn aW5MYXllckNsaXAKIAogdm9pZCBQbGF0Zm9ybUNvbnRleHRTa2lhOjpjbGlwUGF0aEFudGlBbGlh c2VkKGNvbnN0IFNrUGF0aCYgY2xpcFBhdGgpCiB7CisgICAgaWYgKG1fY2FudmFzLT5nZXRUb3BE ZXZpY2UoKS0+Z2V0RGV2aWNlQ2FwYWJpbGl0aWVzKCkgJiBTa0RldmljZTo6a1ZlY3Rvcl9DYXBh YmlsaXR5KSB7CisgICAgICAgIC8vIFdoZW4gdGhlIG91dHB1dCBpcyBhIHZlY3RvciBkZXZpY2Us IGxpa2UgUERGLCB3ZSBkb24ndCBuZWVkIGFudGlhbGlhc2VkIGNsaXBzLgorICAgICAgICAvLyBJ dCdzIHVwIHRvIHRoZSBQREYgcmVuZGVyaW5nIGVuZ2luZSB0byBkbyB0aGF0LiBXZSBjYW4gc2lt cGx5IGRpc2FibGUgdGhlCisgICAgICAgIC8vIGFudGlhbGlhc2VkIGNsaXAgY29kZSBpZiB0aGUg b3V0cHV0IGlzIGEgdmVjdG9yIGRldmljZS4KKyAgICAgICAgY2FudmFzKCktPmNsaXBQYXRoKGNs aXBQYXRoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIC8vIElmIHdlIGFyZSBjdXJy ZW50bHkgdHJhY2tpbmcgYW55IGFudGktYWxpYXMgY2xpcCBwYXRocywgdGhlbiB3ZSBhbHJlYWR5 CiAgICAgLy8gaGF2ZSBhIGxheWVyIGluIHBsYWNlIGFuZCBkb24ndCBuZWVkIHRvIGFkZCBhbm90 aGVyLgogICAgIGJvb2wgaGF2ZUxheWVyT3V0c3RhbmRpbmcgPSBtX3N0YXRlLT5tX2FudGlBbGlh c0NsaXBQYXRocy5zaXplKCk7Cg==