64027 2011-07-06 13:42:29 -0700 garden-o-matic should use a favicon to indicate current state. 2011-07-06 14:10:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov abarth oldest_to_newest 432995 0 dglazkov 2011-07-06 13:42:29 -0700 garden-o-matic should use a favicon to indicate current state. 432997 1 99873 dglazkov 2011-07-06 13:44:01 -0700 Created attachment 99873 Patch 433004 2 99873 abarth 2011-07-06 13:49:39 -0700 Comment on attachment 99873 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99873&action=review > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:48 > +<link rel=icon id=favicon type=image/png href=favicon-green.png> pls use " around attribute values. > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:18 > + document.getElementById('favicon').href = 'favicon-' + (hasFailures ? 'red' : 'green') + '.png'; I was thinking we'd use jQuery to interact with the DOM: var faviconURL = 'favicon-' + (hasFailures ? 'red' : 'green') + '.png'; $('#favicon').attr('href', faviconURL); I'm not sure it really matters, but just to be consistent. 433014 3 dglazkov 2011-07-06 14:10:57 -0700 Committed r90496: <http://trac.webkit.org/changeset/90496> 99873 2011-07-06 13:44:01 -0700 2011-07-06 13:49:39 -0700 Patch bug-64027-20110706134359.patch text/plain 6204 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogOTA0NjIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2YjRkNzE3NjNiZjgyNjA1YTMzYjZkYmJiOGU2YzZjNjIy NDI2Nzc4Li5jOTJkZGY5YmQ4ZTAyY2ZmNGNjOTUxYWU5OWZmMDJlN2YxNTkwMDA2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDctMDYgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4K KworICAgICAgICBnYXJkZW4tby1tYXRpYyBzaG91bGQgdXNlIGEgZmF2aWNvbiB0byBpbmRpY2F0 ZSBjdXJyZW50IHN0YXRlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjQwMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2Vy dmVyL2Zhdmljb24tZ3JlZW4ucG5nOiBBZGRlZC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9mYXZpY29uLXJlZC5wbmc6IEFkZGVk LgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5n c2VydmVyL2luZGV4Lmh0bWw6IEFkZGVkIGJsdXJiIGFib3V0IGljb25zLgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL21haW4uanM6 IEFkZGVkIHNldHRpbmcgaWNvbiBzdGF0ZS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rv b2wvc2VydmVycy9nYXJkZW5pbmdzZXJ2ZXIucHk6IEFsbG93ZWQgdGhlIHVzZSBvZiBmYXZpY29u cy4KKwogMjAxMS0wNy0wNiAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAg ICAgTWFrZSBydW4tYXBpLXRlc3RzIG91dHB1dCBpbnRlbGxpZ2libGUgb24gdGhlIGJvdHMKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVu aW5nc2VydmVyL2Zhdmljb24tZ3JlZW4ucG5nIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvZmF2aWNvbi1ncmVlbi5wbmcKbmV3IGZpbGUg bW9kZSAxMDA3NTUKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uODljODEyOWE0OTBiMzI5ZjMxNjVmMzJmYTA3ODE3MDFhYWI0MTdlYQpHSVQgYmluYXJ5IHBh dGNoCmxpdGVyYWwgNzgxCnpjbVYrbzFNPldkUCk8aDszS3xMazAwMGUxTkpMVHEwMDBtRzAwMG1P MV5AczZBTV5pVjAwMDA0WEYqTHQwMDZKWgp6SHdCOTYwMDAwUGJWWFFuUSpVTjtjVlRqNjA2fURM VnIzdm5aREQ2K1FlfE9lZDJ6e1FKT0JVIXBHaWJQUjU7Nn0KemxqfT1VVkkwVChKOWZAP1l5JH5v TD9NRU5QPHNfNTU8OGo9I2s/I18pN2B6JkhlPVhLaSF5UnYjei1rR3YoIyNICnpQSHBQYz1HSyVs YW9KSHElKVJNQ3dQQUZ6WnxDZ0FPY0VuezswcTVBJiokQGR1NWtlM3t3SUc3NiE7RV9hO0ZkSwp6 dnBwJEgjXmUyQT40LVFpYnROKVZYUURwY3pFYHhYQWtVamglUkk+O29reGI3S0Awa3B5UTFrX1ko fE9lNyRtKF4Kek5ZWD5tSXx8c1VibW4rYzxtI0xlJmVlWHtVUzVNfnR9K15+P154fGE8NGhGfSoh WW9UOD11fUwkbm01SUd1PXQrCno5TCFDdTM2IUQyVWpvZ3s4UiohUXYjSXUtaDVod0NUJTQrYSpn fiQwdWFtLTxLO30qfHNLJkNRbHt1SUxSbyt1agp6T2N6MmlSUkh4PUE+MzwmRm5FPTR1IygpS0JT XlNIOGUpUXM1aSEjbFk9JC0xZ2JINlZsdXpVPW09RVA3OCY1dlEKei0/K2ZGUC1HMmwmbF9Relll YWxLJDsxUmw/Rmt6WFImSnY8cG49dn4jSTlyaml5IThwbmtkQkIrRTVoIXZIMlpzCnombzAzKlFI O0p8Q2o+QGZCUE5qQ3IjQVlSeUo3VUpRMHYjPyk3T3R0PT4zPHNHMXhMJjU0OV5CZGlRRGMyUms2 Qgp6YENaVU1GKm9MJCg3dGRQeD1BX0F6R182aWVVOEdMS1IwMXtkSTRxNUVORUNrT1B+KHpVTmZq RlZydlZqdyomX0gKektwTn5UY1RxaGRodVZELWI8XmNvZGJmYksqIz92ajkqNHFsMHk8fDc/NjEw IVphb2FEbEdyLUxXR2kyfGtHJmVSCnpNfXZwVjlhTjZ5S3w3b1Mpc1BISTJOdz5gIy1wViE3Pjl9 PlExakwpSDZoJmdrUEAzbkk9K0YzbkF+TT51IyhuKgp6OFQhIzhvRXcmLW1FRDQhaDRzIU5ASm8z UzdOJlE2JTZsM31ubGNkflhAPjt1ZWx2UHNTa1hJZ2d+ZSteVDF6U2YKejNTTmooNSVqS35pOEBi O0M8Q0ZWWTZ3UTQ8JUk8KlVZTT1PdStkWWNneV5yb0BuNz1gWFY5JFdkQWloTjAwMDAwCkxOa3ZY WHUwbWpme3UqS2UKCmxpdGVyYWwgMApIY21WP2QwMDAwMQoKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL2Zhdmljb24t cmVkLnBuZyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVu aW5nc2VydmVyL2Zhdmljb24tcmVkLnBuZwpuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jMzdiZDA2MmU2MGMzYjM4ZmM4 MmU0ZDFmMjM2YThhYzJmYWU5ZDhjCkdJVCBiaW5hcnkgcGF0Y2gKbGl0ZXJhbCA3MDEKemNtVjt1 MHomPFhQKTxoOzNLfExrMDAwZTFOSkxUcTAwMG1HMDAwbU8xXkBzNkFNXmlWMDAwMDRYRipMdDAw NkpaCnpId0I5NjAwMDBQYlZYUW5RKlVOO2NWVGo2MDZ9RExWcjN2blpERDYrUWV8T2VkMnp7UUpP QlUhUGYwe1VSNTs2fQp6bGdtcSNWSEN6Nnp0am5wPX5GP1I1cFFGUGwmZ3B+O2w/Z2RMPEI+TiMw JDlVZzdnPGU1RWEjOyV8TlNLYylANWYKejs3JDtYcTlVWSlMeWI8VXFuSjgmOEohZkpYNkFqKl5S fT9ROE04S1pjSkpZdy0rMiEyZEdkQGdfQEJ1Q0p0NFFSCnpHfC1yS0x3MXBAQm5ndEFOY0t9V1da JnRKPUdOIXNEcDBwQmB3ZE5DRTNlUX4qc3ZlQFp1ZlM2VjsjdnoxWGdsPQp6Z19QY2tgJWkrcTBH WFNZe0QkbUhTSlZfMkg4bnpGM3QoJmswQVA3KVYwbWs/RiU+fi1gclFecXh+bUB5Mk9VOEEKeiN6 aH49N24jWiRaKmZ4LUdPdERmMDdjZ3gwc3VDel9XKDJ+WSgwdGZARlhAUDZFUHVNX2RnbiR2ajlM dWNPKSVXCnp3JUhnTVc+PSNvTD5uWj5NJk5FZjA4PikjKWs8eyRmQ1Rfcj5yUGk9QlY9aEZoNldT XnFxemU+QzZFa31ve001JQp6YXxASkdvdzxPajBeNWRPb1FLaExDT1NXcEF3K0hHUT9wU04qayNh NFM3aVo4IS0jUGplQCNAPTtwX19QQ3F4SmMKenB8d0plMD0xbHV1ZmcpdkkjTlh1LShRWWxiTkkw e29yPWg+dTB0eyZoZ056eVNIWnh5QExUTmgpO1l6WjJ6U3BfCnpsJF5UJkRuY3xOTGImUkRfITQ+ cHRAVkhkUClaR0VSJTVabVdFZSRscnlSJnk7MnVeM2NPa088d29qa0kqS2kxbAp6I2hJQWFkVF9A Zk8/NGpnUT40IzZjJS08cnhkb35ESWl6TnpGdmhARD99TXd9aGo9KUlrRlE2IU5PcmU5ZUlNTCkK eiVBeFp8e1h6IXptVSV0cEVyO047T0pOTDxPMDQxWSM1Zlg1dm53UWZrM2FobXtHJTVEVkVwWGky OW9VKmM5Rjh2CmpPeXRtcz1RRHBkKTQjK0ltQz4oRVk2YXs2MDAwMDBOa3ZYWHUwbWpmeFMyQUkK CmxpdGVyYWwgMApIY21WP2QwMDAwMQoKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL2luZGV4Lmh0bWwgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9pbmRleC5o dG1sCmluZGV4IGI2Y2ZkNDBjMGNiMTRmY2ViOWFhMzI1NjhmOGY5ODI0NDQxMmM2MjMuLjcwODZj YWJhOWIxODg1NThmYjU5Mjk1YWQ3ZWI3ZmVjYWY3MWQ4YjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL2luZGV4Lmh0 bWwKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5p bmdzZXJ2ZXIvaW5kZXguaHRtbApAQCAtMSw0ICsxLDggQEAKIDwhRE9DVFlQRSBodG1sPgorPCEt LQorICAgIFRoZSBmYXZpY29ucyBhcmUgZnJvbSB0aGUgYXdlc29tZSBmYW1mYW1mYW0uY29tLCB3 aGljaCBpcyB0aGUgd2Vic2l0ZSBvZiBNYXJrIEphbWVzLAorICAgIGEgd2ViIGRldmVsb3BlciBm cm9tIEJpcm1pbmdoYW0sIFVLLgorLS0+CiA8aHRtbD4KIDxoZWFkPgogPHRpdGxlPkdhcmRlbi1P LU1hdGljPC90aXRsZT4KQEAgLTQxLDYgKzQ1LDcgQEAgaDEgewogICB3aWR0aDogMjAwcHg7CiB9 CiA8L3N0eWxlPgorPGxpbmsgcmVsPWljb24gaWQ9ZmF2aWNvbiB0eXBlPWltYWdlL3BuZyBocmVm PWZhdmljb24tZ3JlZW4ucG5nPgogPC9oZWFkPgogPGJvZHk+CiA8ZGl2IGNsYXNzPSJidXR0ZXJi YXIiPjxzcGFuIGNsYXNzPSJzdGF0dXMiPkxvYWRpbmcuLi48L3NwYW4+IDxhIGNsYXNzPSJoaWRl IiBocmVmPSIjIj5EaXNtaXNzPC9hPjwvZGl2PgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvbWFpbi5qcyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL21haW4u anMKaW5kZXggYTM5YjgwOWQxZWYwODUzZGNhYTVjNjFlZTE5Yzk0MTZkM2YyOTU2Ni4uZDBkY2Ux NGY4OGEzMTRkYzlkNWE2YjMxZjk3YjFiODAwYTdkNjExOSAxMDA2NDQKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvbWFpbi5qcwor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3Nl cnZlci9tYWluLmpzCkBAIC0xMywxMyArMTMsMTkgQEAgZnVuY3Rpb24gaGlkZSgpCiAgICAgJCh0 aGlzKS5wYXJlbnQoKS5mYWRlT3V0KCk7CiB9CiAKK2Z1bmN0aW9uIHNldEljb25TdGF0ZShoYXNG YWlsdXJlcykKK3sKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZmF2aWNvbicpLmhyZWYg PSAnZmF2aWNvbi0nICsgKGhhc0ZhaWx1cmVzID8gJ3JlZCcgOiAnZ3JlZW4nKSArICcucG5nJzsK K307CisKIGZ1bmN0aW9uIGZldGNoUmVzdWx0cyhvbnN1Y2Nlc3MpCiB7CiAgICAgcmVzdWx0cy5m ZXRjaFJlc3VsdHNCeUJ1aWxkZXIoY29uZmlnLmJ1aWxkZXJzLCBmdW5jdGlvbihyZXN1bHRzQnlC dWlsZGVyKSB7Ci0gICAgICAgIHVuZXhwZWN0ZWRGYWlsdXJlcyA9IHVpLnJlc3VsdHNCeVRlc3Qo cmVzdWx0cy51bmV4cGVjdGVkRmFpbHVyZXNCeVRlc3QocmVzdWx0c0J5QnVpbGRlcikpOworICAg ICAgICB2YXIgdW5leHBlY3RlZEZhaWx1cmVzID0gdWkucmVzdWx0c0J5VGVzdChyZXN1bHRzLnVu ZXhwZWN0ZWRGYWlsdXJlc0J5VGVzdChyZXN1bHRzQnlCdWlsZGVyKSk7CiAgICAgICAgICQoJy5m YWlsdXJlcycpLmFwcGVuZCh1bmV4cGVjdGVkRmFpbHVyZXMpOwogICAgICAgICBvbnN1Y2Nlc3Mo KTsKICAgICB9KTsKKyAgICBzZXRJY29uU3RhdGUoJCgnLmZhaWx1cmVzJykubGVuZ3RoKTsKIH0K IAogJCgnLmhpZGUnKS5saXZlKCdjbGljaycsIGhpZGUpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZ2FyZGVuaW5nc2VydmVyLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZ2FyZGVuaW5nc2VydmVyLnB5CmluZGV4IDlmMzUx MjUyOGZiYTdhZTE5NWMxMTA0Mjg1MjNjNTcxNGJlY2Q2ZTEuLjA3ZmZiN2ExMjU5YmU5Y2ZkMjA2 OGYxNDdmNThhOGUwMTNkNDNlMjMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9zZXJ2ZXJzL2dhcmRlbmluZ3NlcnZlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvc2VydmVycy9nYXJkZW5pbmdzZXJ2ZXIucHkKQEAgLTQyLDYgKzQyLDggQEAgY2xh c3MgR2FyZGVuaW5nSFRUUFJlcXVlc3RIYW5kbGVyKFJlZmxlY3Rpb25IYW5kbGVyKToKICAgICAg ICAgIm1haW4uanMiLAogICAgICAgICAicmVzdWx0cy5qcyIsCiAgICAgICAgICJ1aS5qcyIsCisg ICAgICAgICJmYXZpY29uLWdyZWVuLnBuZyIsCisgICAgICAgICJmYXZpY29uLXJlZC5wbmciLAog ICAgIF0pCiAKICAgICBTVEFUSUNfRklMRV9ESVJFQ1RPUlkgPSBvcy5wYXRoLmpvaW4ob3MucGF0 aC5kaXJuYW1lKF9fZmlsZV9fKSwgImRhdGEiLCAiZ2FyZGVuaW5nc2VydmVyIikK