64026 2011-07-06 13:36:32 -0700 [GTK] Only set env. variables in start when strictly needed 2011-07-06 13:51:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 xan.lopez xan.lopez webkit.review.bot xan.lopez oldest_to_newest 432988 0 xan.lopez 2011-07-06 13:36:32 -0700 Otherwise we can set then in the proper method of the GtkPort object. 432990 1 99872 xan.lopez 2011-07-06 13:38:21 -0700 Created attachment 99872 Patch 432992 2 99872 eric 2011-07-06 13:40:11 -0700 Comment on attachment 99872 Patch LGTM. 433005 3 99872 xan.lopez 2011-07-06 13:51:05 -0700 Comment on attachment 99872 Patch Clearing flags on attachment: 99872 Committed r90491: <http://trac.webkit.org/changeset/90491> 433006 4 xan.lopez 2011-07-06 13:51:14 -0700 All reviewed patches have been landed. Closing bug. 99872 2011-07-06 13:38:21 -0700 2011-07-06 13:51:05 -0700 Patch bug-64026-20110706223618.patch text/plain 2569 xan.lopez U3VidmVyc2lvbiBSZXZpc2lvbjogOTA0NzQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0NDU5Njk3YmEzZTM5ZWFjZTQzYTY3OWRjNmY4ZjI3ZDJj OWVmNGRlLi4xNzFiNTQxNmIyNWUzNmFmYzQ1MjNiNjdiOWE4ZTJiMGVjYzA0NmE3IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTEtMDctMDYgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCisgICAgICAg IFtHVEtdIE9ubHkgc2V0IGVudi4gdmFyaWFibGVzIGluIHN0YXJ0IHdoZW4gc3RyaWN0bHkgbmVl ZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDAy NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHk6IGFkZCBhCisgICAgICAgIHNl dHVwX2Vudmlyb25fZm9yX3NlcnZlciBtZXRob2QgaW4gR3RrUG9ydCBhbmQgc2V0IGFzIG1hbnkK KyAgICAgICAgZW52LiB2YXJpYWJsZXMgYXMgcG9zc2libGUgdGhlcmUuCisKKzIwMTEtMDctMDYg IFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEd1 c3Rhdm8gTm9yb25oYS4KIAogICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvZ3RrLnB5OiB1c2UgUG9wZW4gY29ycmVjdGx5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weQppbmRleCAyODAwZGIxYzdhYjI4OGY0YjMw ZWZkZDNlNWY2YmI4ZTMzOWQwYzdmLi5jZDViYTFhNDhjNmU4MGRiNjY3YTdhYzM3MzRiMzNiNGQ0 ZjgyNjA0IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L2d0ay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2d0ay5weQpAQCAtNDQsMTAgKzQ0LDggQEAgY2xhc3MgR3RrRHJpdmVyKHdlYmtpdC5XZWJLaXRE cml2ZXIpOgogICAgICAgICBydW5feHZmYiA9IFsiWHZmYiIsICI6JWQiICUgKGRpc3BsYXlfaWQp LCAiLXNjcmVlbiIsICAiMCIsICI4MDB4NjAweDI0IiwgIi1ub2xpc3RlbiIsICJ0Y3AiXQogICAg ICAgICBzZWxmLl94dmZiX3Byb2Nlc3MgPSBzdWJwcm9jZXNzLlBvcGVuKHJ1bl94dmZiKQogICAg ICAgICBlbnZpcm9ubWVudCA9IHNlbGYuX3BvcnQuc2V0dXBfZW52aXJvbl9mb3Jfc2VydmVyKCkK KyAgICAgICAgIyBXZSBtdXN0IGRvIHRoaXMgaGVyZSBiZWNhdXNlIHRoZSBESVNQTEFZIG51bWJl ciBkZXBlbmRzIG9uIF93b3JrZXJfbnVtYmVyCiAgICAgICAgIGVudmlyb25tZW50WydESVNQTEFZ J10gPSAiOiVkIiAlIChkaXNwbGF5X2lkKQotICAgICAgICBlbnZpcm9ubWVudFsnR1RLX01PRFVM RVMnXSA9ICdnYWlsJwotICAgICAgICBlbnZpcm9ubWVudFsnTElCT1ZFUkxBWV9TQ1JPTExCQVIn XSA9ICcwJwotICAgICAgICBlbnZpcm9ubWVudFsnV0VCS0lUX0lOU1BFQ1RPUl9QQVRIJ10gPSBz ZWxmLl9wb3J0Ll9idWlsZF9wYXRoKCdQcm9ncmFtcy9yZXNvdXJjZXMvaW5zcGVjdG9yJykKICAg ICAgICAgc2VsZi5fc2VydmVyX3Byb2Nlc3MgPSBzZXJ2ZXJfcHJvY2Vzcy5TZXJ2ZXJQcm9jZXNz KHNlbGYuX3BvcnQsCiAgICAgICAgICAgICBzZWxmLl9wb3J0LmRyaXZlcl9uYW1lKCksIHNlbGYu Y21kX2xpbmUoKSwgZW52aXJvbm1lbnQpCiAKQEAgLTYzLDYgKzYxLDE0IEBAIGNsYXNzIEd0a1Bv cnQod2Via2l0LldlYktpdFBvcnQpOgogICAgIGRlZiBjcmVhdGVfZHJpdmVyKHNlbGYsIHdvcmtl cl9udW1iZXIpOgogICAgICAgICByZXR1cm4gR3RrRHJpdmVyKHNlbGYsIHdvcmtlcl9udW1iZXIp CiAKKyAgICBkZWYgc2V0dXBfZW52aXJvbl9mb3Jfc2VydmVyKHNlbGYpOgorICAgICAgICBlbnZp cm9ubWVudCA9IHdlYmtpdC5XZWJLaXRQb3J0LnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcihzZWxm KQorICAgICAgICBlbnZpcm9ubWVudFsnR1RLX01PRFVMRVMnXSA9ICdnYWlsJworICAgICAgICBl bnZpcm9ubWVudFsnTElCT1ZFUkxBWV9TQ1JPTExCQVInXSA9ICcwJworICAgICAgICBlbnZpcm9u bWVudFsnV0VCS0lUX0lOU1BFQ1RPUl9QQVRIJ10gPSBzZWxmLl9idWlsZF9wYXRoKCdQcm9ncmFt cy9yZXNvdXJjZXMvaW5zcGVjdG9yJykKKworICAgICAgICByZXR1cm4gZW52aXJvbm1lbnQKKwog ICAgIGRlZiBfcGF0aF90b19hcGFjaGVfY29uZmlnX2ZpbGUoc2VsZik6CiAgICAgICAgICMgRklY TUU6IFRoaXMgbmVlZHMgdG8gZGV0ZWN0IHRoZSBkaXN0cmlidXRpb24gYW5kIGNoYW5nZSBjb25m aWcgZmlsZXMuCiAgICAgICAgIHJldHVybiBzZWxmLl9maWxlc3lzdGVtLmpvaW4oc2VsZi5sYXlv dXRfdGVzdHNfZGlyKCksICdodHRwJywgJ2NvbmYnLCAnYXBhY2hlMi1kZWJpYW4taHR0cGQuY29u ZicpCg==