64022 2011-07-06 13:07:53 -0700 DFG speculative JIT contains a FIXME for rewinding speculative code generation that has already been fixed 2011-07-14 12:31:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 fpizlo webkit-unassigned webkit.review.bot oldest_to_newest 432962 0 fpizlo 2011-07-06 13:07:53 -0700 The DFG speculative JIT may perform a speculation that turns out to be statically false. In this case, speculative code generation is rolled back. Despite the fact that this feature is already implemented, there is still a FIXME in DFGSpeculativeJIT.h that indicates that we should implement this already-implemented feature. Additionally, the same code path also generates a speculation check despite the fact that any code generated by this path will be rewound. 433003 1 99875 fpizlo 2011-07-06 13:49:34 -0700 Created attachment 99875 the patch 437254 2 99875 webkit.review.bot 2011-07-14 12:31:36 -0700 Comment on attachment 99875 the patch Clearing flags on attachment: 99875 Committed r91022: <http://trac.webkit.org/changeset/91022> 437255 3 webkit.review.bot 2011-07-14 12:31:40 -0700 All reviewed patches have been landed. Closing bug. 99875 2011-07-06 13:49:34 -0700 2011-07-14 12:31:36 -0700 the patch fixmefixed_patch_1.diff text/plain 1412 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTA0ODMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDctMDYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE Rkcgc3BlY3VsYXRpdmUgSklUIGNvbnRhaW5zIGEgRklYTUUgZm9yIHJld2luZGluZyBzcGVjdWxh dGl2ZSBjb2RlIGdlbmVyYXRpb24gdGhhdAorICAgICAgICBoYXMgYWxyZWFkeSBiZWVuIGZpeGVk LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQwMjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9E RkdTcGVjdWxhdGl2ZUpJVC5oOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjp0 ZXJtaW5hdGVTcGVjdWxhdGl2ZUV4ZWN1dGlvbik6CisKIDIwMTEtMDctMDYgIERtaXRyaXkgVnl1 a292ICA8ZHZ5dWtvdkBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExl dmluLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVK SVQuaAkocmV2aXNpb24gOTA0NzcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklULmgJKHdvcmtpbmcgY29weSkKQEAgLTIwMywxMCArMjAzLDcgQEAgcHJpdmF0 ZToKICAgICAvLyBDYWxsZWQgd2hlbiB3ZSBzdGF0aWNhbGx5IGRldGVybWluZSB0aGF0IGEgc3Bl Y3VsYXRpb24gd2lsbCBmYWlsLgogICAgIHZvaWQgdGVybWluYXRlU3BlY3VsYXRpdmVFeGVjdXRp b24oKQogICAgIHsKLSAgICAgICAgLy8gRklYTUU6IGluIGNhc2VzIHdoZXJlIHdlIGNhbiBzdGF0 aWNhbGx5IGRldGVybWluZSB3ZSdyZSBnb2luZyB0byBiYWlsIG91dCBmcm9tIHRoZSBzcGVjdWxh dGl2ZQotICAgICAgICAvLyBKSVQgd2Ugc2hvdWxkIHByb2JhYmx5IHJld2luZCBjb2RlIGdlbmVy YXRpb24gYW5kIG9ubHkgcHJvZHVjZSB0aGUgbm9uLXNwZWN1bGF0aXZlIHBhdGguCiAgICAgICAg IG1fY29tcGlsZU9rYXkgPSBmYWxzZTsKLSAgICAgICAgc3BlY3VsYXRpb25DaGVjayhtX2ppdC5q dW1wKCkpOwogICAgIH0KIAogICAgIHRlbXBsYXRlPGJvb2wgc3RyaWN0Pgo=