64015 2011-07-06 12:48:44 -0700 IconDatabase::synchronousIconForPageURL() has inconsistent API when no custom icon is available 2011-07-06 13:29:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 sullivan sullivan webkit.review.bot oldest_to_newest 432937 0 sullivan 2011-07-06 12:48:44 -0700 IconDatabase::synchronousIconForPageURL() returns 0 for some URLs that don't have custom icons (http/https ones), but instead returns the default icon (at a particular image size) for other URLs that don't have custom icons (anything other than http/https). This inconsistency makes it impossible to use the return value to know whether the page has a custom icon, or to use any client-specific default icon. In Radar as <rdar://problem/9706277>. 432941 1 99862 sullivan 2011-07-06 12:54:52 -0700 Created attachment 99862 Patch to return 0 in all cases for which there is no custom icon 432942 2 sullivan 2011-07-06 12:55:12 -0700 Oops, forgot the ChangeLog. Will resubmit. 432946 3 99864 sullivan 2011-07-06 12:58:22 -0700 Created attachment 99864 Patch to return 0 in all cases where there is no custom icon (now with ChangeLog) 432949 4 sullivan 2011-07-06 12:59:31 -0700 Oops, neglected to add bugzilla URL to ChangeLog. Third time's a charm! 432950 5 webkit.review.bot 2011-07-06 13:00:02 -0700 Attachment 99864 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 432951 6 99866 sullivan 2011-07-06 13:00:10 -0700 Created attachment 99866 Patch to always return 0 if there's no custom icon (now with correctly-styled ChangeLog!) 432980 7 sullivan 2011-07-06 13:29:17 -0700 Fixed in http://trac.webkit.org/changeset/90486 99862 2011-07-06 12:54:52 -0700 2011-07-06 13:00:10 -0700 Patch to return 0 in all cases for which there is no custom icon icon_patch.txt text/plain 902 sullivan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25EYXRhYmFzZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNwcAkocmV2 aXNpb24gOTA0MzQpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uRGF0YWJhc2Uu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjQsNyArMjI0LDcgQEAgSW1hZ2UqIEljb25EYXRhYmFz ZTo6c3luY2hyb25vdXNJY29uRm9yUAogICAgIC8vIFdlIHNob3VsZCBnbyBvdXIgb2Ygb3VyIHdh eSB0byBvbmx5IGNvcHkgaXQgaWYgd2UgaGF2ZSB0byBzdG9yZSBpdAogICAgIAogICAgIGlmICgh aXNPcGVuKCkgfHwgIXBhZ2VDYW5IYXZlSWNvbihwYWdlVVJMT3JpZ2luYWwpKQotICAgICAgICBy ZXR1cm4gZGVmYXVsdEljb24oc2l6ZSk7CisgICAgICAgIHJldHVybiAwOwogCiAgICAgTXV0ZXhM b2NrZXIgbG9ja2VyKG1fdXJsQW5kSWNvbkxvY2spOwogICAgIApJbmRleDogU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZVZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmNwcAkocmV2aXNpb24gOTA0MzQpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSw0IEBACisKIC8qCiAgKiBDb3B5 cmlnaHQgKEMpIDE5OTgsIDE5OTkgVG9yYmVuIFdlaXMgPHdlaXNAa2RlLm9yZz4KICAqICAgICAg ICAgICAgICAgICAgICAgMTk5OSBMYXJzIEtub2xsIDxrbm9sbEBrZGUub3JnPgo= 99864 2011-07-06 12:58:22 -0700 2011-07-06 13:00:10 -0700 Patch to return 0 in all cases where there is no custom icon (now with ChangeLog) icon_patch.txt text/plain 1428 sullivan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwNDgzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDctMDYgIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSWNvbkRhdGFiYXNlOjpzeW5j aHJvbm91c0ljb25Gb3JQYWdlVVJMKCkgaGFzIGluY29uc2lzdGVudCBBUEkgd2hlbiBubyBjdXN0 b20gaWNvbiBpcyBhdmFpbGFibGUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzk3MDYyNzc+CisK KyAgICAgICAgRm9yIHNvbWUgVVJMcyBpdCB3b3VsZCByZXR1cm4gYSBwYXJ0aWN1bGFyIHNpemUg b2YgZGVmYXVsdCBpY29uOyBmb3Igb3RoZXIKKyAgICAgICAgVVJMcyBpdCB3b3VsZCByZXR1cm4g MC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxv YWRlci9pY29uL0ljb25EYXRhYmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJY29uRGF0YWJh c2U6OnN5bmNocm9ub3VzSWNvbkZvclBhZ2VVUkwpOgorICAgICAgICBSZXR1cm4gMCBpbiBhbGwg Y2FzZXMgd2hlcmUgdGhlcmUgaXMgbm8gY3VzdG9tIGljb24uCisKIDIwMTEtMDctMDYgIFJ5dWFu IENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtQZXJmb3JtYW5jZV0g T25seSBjYWxsIHNlbmRDb250ZW50UmVzaXplTm90aWZpY2F0aW9uIHdoZW4gdGhlIHNjcm9sbGJh ciBhY3R1YWxseSBkaWQgY2hhbmdlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9J Y29uRGF0YWJhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29u L0ljb25EYXRhYmFzZS5jcHAJKHJldmlzaW9uIDkwNDM0KQorKysgU291cmNlL1dlYkNvcmUvbG9h ZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjI0LDcgKzIyNCw3 IEBAIEltYWdlKiBJY29uRGF0YWJhc2U6OnN5bmNocm9ub3VzSWNvbkZvclAKICAgICAvLyBXZSBz aG91bGQgZ28gb3VyIG9mIG91ciB3YXkgdG8gb25seSBjb3B5IGl0IGlmIHdlIGhhdmUgdG8gc3Rv cmUgaXQKICAgICAKICAgICBpZiAoIWlzT3BlbigpIHx8ICFwYWdlQ2FuSGF2ZUljb24ocGFnZVVS TE9yaWdpbmFsKSkKLSAgICAgICAgcmV0dXJuIGRlZmF1bHRJY29uKHNpemUpOworICAgICAgICBy ZXR1cm4gMDsKIAogICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX3VybEFuZEljb25Mb2NrKTsKICAg ICAK 99866 2011-07-06 13:00:10 -0700 2011-07-06 13:19:11 -0700 Patch to always return 0 if there's no custom icon (now with correctly-styled ChangeLog!) icon_patch.txt text/plain 1485 sullivan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwNDgzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDctMDYgIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSWNvbkRhdGFiYXNlOjpzeW5j aHJvbm91c0ljb25Gb3JQYWdlVVJMKCkgaGFzIGluY29uc2lzdGVudCBBUEkgd2hlbiBubyBjdXN0 b20gaWNvbiBpcyBhdmFpbGFibGUKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NDAxNT4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzk3MDYyNzc+CisK KyAgICAgICAgRm9yIHNvbWUgVVJMcyBpdCB3b3VsZCByZXR1cm4gYSBwYXJ0aWN1bGFyIHNpemUg b2YgZGVmYXVsdCBpY29uOyBmb3Igb3RoZXIKKyAgICAgICAgVVJMcyBpdCB3b3VsZCByZXR1cm4g MC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxv YWRlci9pY29uL0ljb25EYXRhYmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJY29uRGF0YWJh c2U6OnN5bmNocm9ub3VzSWNvbkZvclBhZ2VVUkwpOgorICAgICAgICBSZXR1cm4gMCBpbiBhbGwg Y2FzZXMgd2hlcmUgdGhlcmUgaXMgbm8gY3VzdG9tIGljb24uCisKIDIwMTEtMDctMDYgIFJ5dWFu IENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtQZXJmb3JtYW5jZV0g T25seSBjYWxsIHNlbmRDb250ZW50UmVzaXplTm90aWZpY2F0aW9uIHdoZW4gdGhlIHNjcm9sbGJh ciBhY3R1YWxseSBkaWQgY2hhbmdlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9J Y29uRGF0YWJhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29u L0ljb25EYXRhYmFzZS5jcHAJKHJldmlzaW9uIDkwNDM0KQorKysgU291cmNlL1dlYkNvcmUvbG9h ZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjI0LDcgKzIyNCw3 IEBAIEltYWdlKiBJY29uRGF0YWJhc2U6OnN5bmNocm9ub3VzSWNvbkZvclAKICAgICAvLyBXZSBz aG91bGQgZ28gb3VyIG9mIG91ciB3YXkgdG8gb25seSBjb3B5IGl0IGlmIHdlIGhhdmUgdG8gc3Rv cmUgaXQKICAgICAKICAgICBpZiAoIWlzT3BlbigpIHx8ICFwYWdlQ2FuSGF2ZUljb24ocGFnZVVS TE9yaWdpbmFsKSkKLSAgICAgICAgcmV0dXJuIGRlZmF1bHRJY29uKHNpemUpOworICAgICAgICBy ZXR1cm4gMDsKIAogICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX3VybEFuZEljb25Mb2NrKTsKICAg ICAK