64008 2011-07-06 11:27:11 -0700 Remove unused parameter from _add_test in test_expectations.py 2011-07-06 13:54:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dpranke eric webkit.review.bot oldest_to_newest 432889 0 abarth 2011-07-06 11:27:11 -0700 Remove unused parameter from _add_test in test_expectations.py 432890 1 99854 abarth 2011-07-06 11:27:34 -0700 Created attachment 99854 Patch 432896 2 99854 eric 2011-07-06 11:36:44 -0700 Comment on attachment 99854 Patch OK. 432924 3 99854 webkit.review.bot 2011-07-06 12:07:52 -0700 Comment on attachment 99854 Patch Clearing flags on attachment: 99854 Committed r90479: <http://trac.webkit.org/changeset/90479> 432925 4 webkit.review.bot 2011-07-06 12:07:56 -0700 All reviewed patches have been landed. Closing bug. 433001 5 dpranke 2011-07-06 13:48:30 -0700 It would probably be good to remove the rest of the "num_matches" logic at this point, since that code (which was already disabled) is now even more disabled :). 433009 6 abarth 2011-07-06 13:54:22 -0700 (In reply to comment #5) > It would probably be good to remove the rest of the "num_matches" logic at this point, since that code (which was already disabled) is now even more disabled :). I didn't follow that rabbit, but it's good to know that none if it is used. 99854 2011-07-06 11:27:34 -0700 2011-07-06 12:07:51 -0700 Patch bug-64008-20110706112733.patch text/plain 4236 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkwNDczKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTEtMDctMDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZW1vdmUgdW51c2VkIHBhcmFtZXRlciBmcm9tIF9hZGRfdGVzdCBpbiB0ZXN0X2V4 cGVjdGF0aW9ucy5weQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjQwMDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3Rf ZXhwZWN0YXRpb25zLnB5OgorCiAyMDExLTA3LTA2ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0 Lm9yZz4KIAogICAgICAgICB3ZWJraXQtcGF0Y2ggZmFpbHVyZS1yZWFzb24gZG9lcyBub3QgdW5k ZXJzdGFuZCBOUldUIHJlc3VsdHMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfZXhwZWN0YXRpb25zLnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3Rf ZXhwZWN0YXRpb25zLnB5CShyZXZpc2lvbiA5MDQzMykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfZXhwZWN0YXRpb25zLnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC0zMjgsNyArMzI4LDYgQEAgY2xhc3MgVGVzdEV4cGVjdGF0aW9uczoKICAg ICBkZWYgaXNfcmViYXNlbGluaW5nKHNlbGYsIHRlc3QpOgogICAgICAgICByZXR1cm4gc2VsZi5o YXNfbW9kaWZpZXIodGVzdCwgUkVCQVNFTElORSkKIAotCiAgICAgZGVmIF9oYW5kbGVfYW55X3Jl YWRfZXJyb3JzKHNlbGYpOgogICAgICAgICBpZiBsZW4oc2VsZi5fZXJyb3JzKSBvciBsZW4oc2Vs Zi5fbm9uX2ZhdGFsX2Vycm9ycyk6CiAgICAgICAgICAgICBfbG9nLmVycm9yKCJGQUlMVVJFUyBG T1IgJXMiICUgc3RyKHNlbGYuX3Rlc3RfY29uZmlnKSkKQEAgLTM0NywxMiArMzQ2LDEwIEBAIGNs YXNzIFRlc3RFeHBlY3RhdGlvbnM6CiAgICAgICAgIGV4cGVjdGF0aW9ucyA9IHNldChbUEFTU10p CiAgICAgICAgIG9wdGlvbnMgPSBbXQogICAgICAgICBtb2RpZmllcnMgPSBbXQotICAgICAgICBu dW1fbWF0Y2hlcyA9IDAKICAgICAgICAgaWYgc2VsZi5fZnVsbF90ZXN0X2xpc3Q6CiAgICAgICAg ICAgICBmb3IgdGVzdCBpbiBzZWxmLl9mdWxsX3Rlc3RfbGlzdDoKICAgICAgICAgICAgICAgICBp ZiBub3QgdGVzdCBpbiBzZWxmLl90ZXN0X2xpc3RfcGF0aHM6Ci0gICAgICAgICAgICAgICAgICAg IHNlbGYuX2FkZF90ZXN0KHRlc3QsIG1vZGlmaWVycywgbnVtX21hdGNoZXMsIGV4cGVjdGF0aW9u cywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgb3B0aW9ucywgb3ZlcnJpZGVz X2FsbG93ZWQ9RmFsc2UpCisgICAgICAgICAgICAgICAgICAgIHNlbGYuX2FkZF90ZXN0KHRlc3Qs IG1vZGlmaWVycywgZXhwZWN0YXRpb25zLCBvcHRpb25zLCBvdmVycmlkZXNfYWxsb3dlZD1GYWxz ZSkKIAogICAgIGRlZiBfZGljdF9vZl9zZXRzKHNlbGYsIHN0cmluZ3NfdG9fY29uc3RhbnRzKToK ICAgICAgICAgIiIiVGFrZXMgYSBkaWN0IG9mIHN0cmluZ3MtPmNvbnN0YW50cyBhbmQgcmV0dXJu cyBhIGRpY3QgbWFwcGluZwpAQCAtNDk1LDggKzQ5Miw3IEBAIGNsYXNzIFRlc3RFeHBlY3RhdGlv bnM6CiAgICAgICAgICAgICB0ZXN0cyA9IHNlbGYuX2V4cGFuZF90ZXN0cyh0ZXN0X2xpc3RfcGF0 aCkKIAogICAgICAgICBtb2RpZmllcnMgPSBbbyBmb3IgbyBpbiBvcHRpb25zIGlmIG8gaW4gc2Vs Zi5NT0RJRklFUlNdCi0gICAgICAgIHNlbGYuX2FkZF90ZXN0cyh0ZXN0cywgZXhwZWN0YXRpb25z LCB0ZXN0X2xpc3RfcGF0aCwgbGluZW5vLAotICAgICAgICAgICAgICAgICAgICAgICAgbW9kaWZp ZXJzLCBudW1fbWF0Y2hlcywgb3B0aW9ucywgb3ZlcnJpZGVzX2FsbG93ZWQpCisgICAgICAgIHNl bGYuX2FkZF90ZXN0cyh0ZXN0cywgZXhwZWN0YXRpb25zLCB0ZXN0X2xpc3RfcGF0aCwgbGluZW5v LCBtb2RpZmllcnMsIG51bV9tYXRjaGVzLCBvcHRpb25zLCBvdmVycmlkZXNfYWxsb3dlZCkKIAog ICAgIGRlZiBfZ2V0X29wdGlvbnNfbGlzdChzZWxmLCBsaXN0U3RyaW5nKToKICAgICAgICAgcmV0 dXJuIFtwYXJ0LnN0cmlwKCkubG93ZXIoKSBmb3IgcGFydCBpbiBsaXN0U3RyaW5nLnN0cmlwKCku c3BsaXQoJyAnKV0KQEAgLTU5NywxOCArNTkzLDE0IEBAIGNsYXNzIFRlc3RFeHBlY3RhdGlvbnM6 CiAgICAgZGVmIF9hZGRfdGVzdHMoc2VsZiwgdGVzdHMsIGV4cGVjdGF0aW9ucywgdGVzdF9saXN0 X3BhdGgsIGxpbmVubywKICAgICAgICAgICAgICAgICAgICBtb2RpZmllcnMsIG51bV9tYXRjaGVz LCBvcHRpb25zLCBvdmVycmlkZXNfYWxsb3dlZCk6CiAgICAgICAgIGZvciB0ZXN0IGluIHRlc3Rz OgotICAgICAgICAgICAgaWYgc2VsZi5fYWxyZWFkeV9zZWVuX2JldHRlcl9tYXRjaCh0ZXN0LCB0 ZXN0X2xpc3RfcGF0aCwKLSAgICAgICAgICAgICAgICBudW1fbWF0Y2hlcywgbGluZW5vLCBvdmVy cmlkZXNfYWxsb3dlZCk6CisgICAgICAgICAgICBpZiBzZWxmLl9hbHJlYWR5X3NlZW5fYmV0dGVy X21hdGNoKHRlc3QsIHRlc3RfbGlzdF9wYXRoLCBudW1fbWF0Y2hlcywgbGluZW5vLCBvdmVycmlk ZXNfYWxsb3dlZCk6CiAgICAgICAgICAgICAgICAgY29udGludWUKIAogICAgICAgICAgICAgc2Vs Zi5fY2xlYXJfZXhwZWN0YXRpb25zX2Zvcl90ZXN0KHRlc3QsIHRlc3RfbGlzdF9wYXRoKQotICAg ICAgICAgICAgc2VsZi5fdGVzdF9saXN0X3BhdGhzW3Rlc3RdID0gKHNlbGYuX2ZzLm5vcm1wYXRo KHRlc3RfbGlzdF9wYXRoKSwKLSAgICAgICAgICAgICAgICBudW1fbWF0Y2hlcywgbGluZW5vKQot ICAgICAgICAgICAgc2VsZi5fYWRkX3Rlc3QodGVzdCwgbW9kaWZpZXJzLCBudW1fbWF0Y2hlcywg ZXhwZWN0YXRpb25zLCBvcHRpb25zLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgb3ZlcnJp ZGVzX2FsbG93ZWQpCisgICAgICAgICAgICBzZWxmLl90ZXN0X2xpc3RfcGF0aHNbdGVzdF0gPSAo c2VsZi5fZnMubm9ybXBhdGgodGVzdF9saXN0X3BhdGgpLCBudW1fbWF0Y2hlcywgbGluZW5vKQor ICAgICAgICAgICAgc2VsZi5fYWRkX3Rlc3QodGVzdCwgbW9kaWZpZXJzLCBleHBlY3RhdGlvbnMs IG9wdGlvbnMsIG92ZXJyaWRlc19hbGxvd2VkKQogCi0gICAgZGVmIF9hZGRfdGVzdChzZWxmLCB0 ZXN0LCBtb2RpZmllcnMsIG51bV9tYXRjaGVzLCBleHBlY3RhdGlvbnMsIG9wdGlvbnMsCi0gICAg ICAgICAgICAgICAgICBvdmVycmlkZXNfYWxsb3dlZCk6CisgICAgZGVmIF9hZGRfdGVzdChzZWxm LCB0ZXN0LCBtb2RpZmllcnMsIGV4cGVjdGF0aW9ucywgb3B0aW9ucywgb3ZlcnJpZGVzX2FsbG93 ZWQpOgogICAgICAgICAiIiJTZXRzIHRoZSBleHBlY3RlZCBzdGF0ZSBmb3IgYSBnaXZlbiB0ZXN0 LgogCiAgICAgICAgIFRoaXMgcm91dGluZSBhc3N1bWVzIHRoZSB0ZXN0IGhhcyBub3QgYmVlbiBh ZGRlZCBiZWZvcmUuIElmIGl0IGhhcywKQEAgLTYxOCw3ICs2MTAsNiBAQCBjbGFzcyBUZXN0RXhw ZWN0YXRpb25zOgogICAgICAgICBBcmdzOgogICAgICAgICAgIHRlc3Q6IHRlc3QgdG8gYWRkCiAg ICAgICAgICAgbW9kaWZpZXJzOiBzZXF1ZW5jZSBvZiBtb2RpZmllciBrZXl3b3JkcyAoJ3dvbnRm aXgnLCAnc2xvdycsIGV0Yy4pCi0gICAgICAgICAgbnVtX21hdGNoZXM6IG51bWJlciBvZiBtb2Rp ZmllcnMgdGhhdCBtYXRjaGVkIHRoZSBjb25maWd1cmF0aW9uCiAgICAgICAgICAgZXhwZWN0YXRp b25zOiBzZXF1ZW5jZSBvZiBleHBlY3RhdGlvbnMgKFBBU1MsIElNQUdFLCBldGMuKQogICAgICAg ICAgIG9wdGlvbnM6IHNlcXVlbmNlIG9mIGtleXdvcmRzIGFuZCBidWcgaWRlbnRpZmllcnMuCiAg ICAgICAgICAgb3ZlcnJpZGVzX2FsbG93ZWQ6IHdoZXRoZXIgd2UncmUgcGFyc2luZyB0aGUgcmVn dWxhciBleHBlY3RhdGlvbnMK