64006 2011-07-06 10:12:05 -0700 webkit-patch failure-reason does not understand NRWT results 2011-07-06 11:14:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric abarth aroben webkit.review.bot oldest_to_newest 432854 0 eric 2011-07-06 10:12:05 -0700 webkit-patch failure-reason does not understand NRWT results 432855 1 99849 eric 2011-07-06 10:13:31 -0700 Created attachment 99849 Patch 432859 2 99849 abarth 2011-07-06 10:16:13 -0700 Comment on attachment 99849 Patch IMHO, we should remove this tool, but this patch is clearly an improvement. 432884 3 99849 webkit.review.bot 2011-07-06 11:14:13 -0700 Comment on attachment 99849 Patch Clearing flags on attachment: 99849 Committed r90472: <http://trac.webkit.org/changeset/90472> 432885 4 webkit.review.bot 2011-07-06 11:14:18 -0700 All reviewed patches have been landed. Closing bug. 99849 2011-07-06 10:13:31 -0700 2011-07-06 11:14:13 -0700 Patch bug-64006-20110706101330.patch text/plain 5143 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTA0NjUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2YjRkNzE3NjNiZjgyNjA1YTMzYjZkYmJiOGU2YzZjNjIy NDI2Nzc4Li41ZDAwYTY2OTFkMjJlNmJmYzBkZTAxN2U1NzRhYjNiNzY5MDQ1Mjc5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDctMDYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IHdlYmtpdC1wYXRjaCBmYWlsdXJlLXJlYXNvbiBkb2VzIG5vdCB1bmRlcnN0YW5kIE5SV1QgcmVz dWx0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQw MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGFt IEJhcnRoIHRlbGxzIG1lIGZhaWx1cmUtcmVhc29uIHNob3VsZCBiZSBkZWxldGVkIHNvb24sCisg ICAgICAgIGJ1dCBhcm9iZW4ncyBmYW5jeSBuZXcgVGVzdEZhaWx1cmVzLyBwYWdlIGRvZXNuJ3Qg d29yayBmb3IKKyAgICAgICAgTlJXVCB5ZXQsIGFuZCBJIG5lZWRlZCB0byBrbm93IHdoZW4KKyAg ICAgICAgdGhpcmQtcGFydHktY29va2llLXJlbGF4aW5nIHN0YXJ0ZWQgZmFpbGluZy4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC9idWlsZGJvdC5weToK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVlcmllcy5weToKKwog MjAxMS0wNy0wNiAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFr ZSBydW4tYXBpLXRlc3RzIG91dHB1dCBpbnRlbGxpZ2libGUgb24gdGhlIGJvdHMKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC9idWlsZGJvdC5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC9idWlsZGJvdC5w eQppbmRleCBlMjAyYzM2NTAyM2JmYjM5YTAzNTRjZjZlNGZkN2MzZTkxZWJiNTdjLi5mZTcwNGE4 ZjdhMTU3N2MyZjM1OTI2NzE4OWE4ZTFhNjg3MmU3MTFlIDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRib3QucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90L2J1aWxkYm90LnB5CkBAIC00MSwx MiArNDEsMTQgQEAgaW1wb3J0IHVybGxpYjIKIAogZnJvbSB3ZWJraXRweS5jb21tb24ubmV0LmZh aWx1cmVtYXAgaW1wb3J0IEZhaWx1cmVNYXAKIGZyb20gd2Via2l0cHkuY29tbW9uLm5ldC5sYXlv dXR0ZXN0cmVzdWx0cyBpbXBvcnQgTGF5b3V0VGVzdFJlc3VsdHMKK2Zyb20gd2Via2l0cHkuY29t bW9uLm5ldC5uZXR3b3JrdHJhbnNhY3Rpb24gaW1wb3J0IE5ldHdvcmtUcmFuc2FjdGlvbgogZnJv bSB3ZWJraXRweS5jb21tb24ubmV0LnJlZ3Jlc3Npb253aW5kb3cgaW1wb3J0IFJlZ3Jlc3Npb25X aW5kb3cKIGZyb20gd2Via2l0cHkuY29tbW9uLm5ldC50ZXN0b3V0cHV0c2V0IGltcG9ydCBUZXN0 T3V0cHV0U2V0CiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0ubG9ndXRpbHMgaW1wb3J0IGdl dF9sb2dnZXIKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS56aXBmaWxlc2V0IGltcG9ydCBa aXBGaWxlU2V0CiBmcm9tIHdlYmtpdHB5LnRoaXJkcGFydHkuQmVhdXRpZnVsU291cCBpbXBvcnQg QmVhdXRpZnVsU291cAogCisKIF9sb2cgPSBnZXRfbG9nZ2VyKF9fZmlsZV9fKQogCiAKQEAgLTIz OSwyNiArMjQxLDI2IEBAIGNsYXNzIEJ1aWxkKG9iamVjdCk6CiAgICAgZGVmIHJlc3VsdHMoc2Vs Zik6CiAgICAgICAgIHJldHVybiBUZXN0T3V0cHV0U2V0KHNlbGYuX2J1aWxkZXIubmFtZSgpLCBO b25lLCBaaXBGaWxlU2V0KHNlbGYucmVzdWx0c196aXBfdXJsKCkpLCBpbmNsdWRlX2V4cGVjdGVk PUZhbHNlKQogCi0gICAgZGVmIF9mZXRjaF9yZXN1bHRzX2h0bWwoc2VsZik6Ci0gICAgICAgIHJl c3VsdHNfaHRtbCA9ICIlcy9yZXN1bHRzLmh0bWwiICUgKHNlbGYucmVzdWx0c191cmwoKSkKLSAg ICAgICAgIyBGSVhNRTogVGhpcyBzaG91bGQgdXNlIE5ldHdvcmtUcmFuc2FjdGlvbidzIDQwNCBo YW5kbGluZyBvciBhdCBsZWFzdCBtb3ZlCi0gICAgICAgICMgdG8gbWVjaGFuaXplJ3MgdG8gYmUg bW9yZSBjb25zaXN0ZW50IHdpdGggdGhlIHJlc3Qgb2Ygb3VyIGNvZGUuCi0gICAgICAgIHRyeToK LSAgICAgICAgICAgICMgSXQgc2VlbXMgdGhpcyBjYW4gcmV0dXJuIE5vbmUgaWYgdGhlIHVybCBy ZWRpcmVjdHMgYW5kIHRoZW4gcmV0dXJucyA0MDQuCi0gICAgICAgICAgICByZXN1bHQgPSB1cmxs aWIyLnVybG9wZW4ocmVzdWx0c19odG1sKQotICAgICAgICAgICAgaWYgbm90IHJlc3VsdDoKLSAg ICAgICAgICAgICAgICByZXR1cm4gTm9uZQotICAgICAgICAgICAgIyB1cmxvcGVuIHJldHVybnMg YSBmaWxlLWxpa2Ugb2JqZWN0IHdoaWNoIHNvbWV0aW1lcyB3b3JrcyBmaW5lIHdpdGggc3RyKCkK LSAgICAgICAgICAgICMgYnV0IHNvbWV0aW1lcyBpcyBhIGFkZGluZm91cmwgb2JqZWN0LiAgSW4g ZWl0aGVyIGNhc2UgY2FsbGluZyByZWFkKCkgaXMgY29ycmVjdC4KLSAgICAgICAgICAgIHJldHVy biByZXN1bHQucmVhZCgpCi0gICAgICAgIGV4Y2VwdCB1cmxsaWIyLkhUVFBFcnJvciwgZXJyb3I6 Ci0gICAgICAgICAgICBpZiBlcnJvci5jb2RlICE9IDQwNDoKLSAgICAgICAgICAgICAgICByYWlz ZQorICAgIGRlZiBfZmV0Y2hfZmlsZV9mcm9tX3Jlc3VsdHMoc2VsZiwgZmlsZV9uYW1lKToKKyAg ICAgICAgIyBJdCBzZWVtcyB0aGlzIGNhbiByZXR1cm4gTm9uZSBpZiB0aGUgdXJsIHJlZGlyZWN0 cyBhbmQgdGhlbiByZXR1cm5zIDQwNC4KKyAgICAgICAgcmVzdWx0ID0gdXJsbGliMi51cmxvcGVu KCIlcy8lcyIgJSAoc2VsZi5yZXN1bHRzX3VybCgpLCBmaWxlX25hbWUpKQorICAgICAgICBpZiBu b3QgcmVzdWx0OgorICAgICAgICAgICAgcmV0dXJuIE5vbmUKKyAgICAgICAgIyB1cmxvcGVuIHJl dHVybnMgYSBmaWxlLWxpa2Ugb2JqZWN0IHdoaWNoIHNvbWV0aW1lcyB3b3JrcyBmaW5lIHdpdGgg c3RyKCkKKyAgICAgICAgIyBidXQgc29tZXRpbWVzIGlzIGEgYWRkaW5mb3VybCBvYmplY3QuICBJ biBlaXRoZXIgY2FzZSBjYWxsaW5nIHJlYWQoKSBpcyBjb3JyZWN0LgorICAgICAgICByZXR1cm4g cmVzdWx0LnJlYWQoKQogCiAgICAgZGVmIGxheW91dF90ZXN0X3Jlc3VsdHMoc2VsZik6Ci0gICAg ICAgIGlmIG5vdCBzZWxmLl9sYXlvdXRfdGVzdF9yZXN1bHRzOgotICAgICAgICAgICAgIyBGSVhN RTogVGhpcyBzaG91bGQgY2FjaGUgdGhhdCB0aGUgcmVzdWx0IHdhcyBhIDQwNCBhbmQgc3RvcCBo aXR0aW5nIHRoZSBuZXR3b3JrLgotICAgICAgICAgICAgc2VsZi5fbGF5b3V0X3Rlc3RfcmVzdWx0 cyA9IExheW91dFRlc3RSZXN1bHRzLnJlc3VsdHNfZnJvbV9zdHJpbmcoc2VsZi5fZmV0Y2hfcmVz dWx0c19odG1sKCkpCisgICAgICAgIGlmIHNlbGYuX2xheW91dF90ZXN0X3Jlc3VsdHM6CisgICAg ICAgICAgICByZXR1cm4gc2VsZi5fbGF5b3V0X3Rlc3RfcmVzdWx0cworCisgICAgICAgICMgRklY TUU6IFRoaXMgc2hvdWxkIGNhY2hlIHRoYXQgdGhlIHJlc3VsdCB3YXMgYSA0MDQgYW5kIHN0b3Ag aGl0dGluZyB0aGUgbmV0d29yay4KKyAgICAgICAgcmVzdWx0c19maWxlID0gTmV0d29ya1RyYW5z YWN0aW9uKGNvbnZlcnRfNDA0X3RvX05vbmU9VHJ1ZSkucnVuKGxhbWJkYTogc2VsZi5fZmV0Y2hf ZmlsZV9mcm9tX3Jlc3VsdHMoImZ1bGxfcmVzdWx0cy5qc29uIikpCisgICAgICAgIGlmIG5vdCBy ZXN1bHRzX2ZpbGU6CisgICAgICAgICAgICByZXN1bHRzX2ZpbGUgPSBOZXR3b3JrVHJhbnNhY3Rp b24oY29udmVydF80MDRfdG9fTm9uZT1UcnVlKS5ydW4obGFtYmRhOiBzZWxmLl9mZXRjaF9maWxl X2Zyb21fcmVzdWx0cygicmVzdWx0cy5odG1sIikpCisKKyAgICAgICAgIyByZXN1bHRzX2Zyb21f c3RyaW5nIGFjY2VwdHMgZWl0aGVyIE9SV1QgaHRtbCBvciBOUldUIGpzb24uCisgICAgICAgIHNl bGYuX2xheW91dF90ZXN0X3Jlc3VsdHMgPSBMYXlvdXRUZXN0UmVzdWx0cy5yZXN1bHRzX2Zyb21f c3RyaW5nKHJlc3VsdHNfZmlsZSkKICAgICAgICAgcmV0dXJuIHNlbGYuX2xheW91dF90ZXN0X3Jl c3VsdHMKIAogICAgIGRlZiBidWlsZGVyKHNlbGYpOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXJpZXMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvY29tbWFuZHMvcXVlcmllcy5weQppbmRleCAyOTNiMzc0ZTAwOWVjNTlhMTNjOTFj ZDc4YmMyZjEzOGJjMDQzYzJiLi4zNWJjNDQwODRhOGM1MGNkY2FiNTNkM2JiM2Q1MDUzNjdmZDVm ODdhIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVl cmllcy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVlcmll cy5weQpAQCAtMjI4LDcgKzIyOCw3IEBAIGNsYXNzIEZhaWx1cmVSZWFzb24oQWJzdHJhY3REZWNs YXJhdGl2ZUNvbW1hbmQpOgogICAgICAgICBsYXlvdXRfdGVzdF9yZXN1bHRzID0gYnVpbGQubGF5 b3V0X3Rlc3RfcmVzdWx0cygpCiAgICAgICAgIGlmIG5vdCBsYXlvdXRfdGVzdF9yZXN1bHRzOgog ICAgICAgICAgICAgIyBGSVhNRTogVGhpcyBjb3VsZCBiZSBtYWRlIG1vcmUgdXNlciBmcmllbmRs eS4KLSAgICAgICAgICAgIHByaW50ICJGYWlsZWQgdG8gbG9hZCBsYXlvdXQgdGVzdCByZXN1bHRz OyBjYW4ndCBjb250aW51ZS4gKHN0YXJ0IHJldmlzaW9uID0gciVzKSIgJSBzdGFydF9yZXZpc2lv bgorICAgICAgICAgICAgcHJpbnQgIkZhaWxlZCB0byBsb2FkIGxheW91dCB0ZXN0IHJlc3VsdHMg ZnJvbSAlczsgY2FuJ3QgY29udGludWUuIChzdGFydCByZXZpc2lvbiA9IHIlcykiICUgKGJ1aWxk LnJlc3VsdHNfdXJsKCksIHN0YXJ0X3JldmlzaW9uKQogICAgICAgICAgICAgcmV0dXJuIDEKIAog ICAgICAgICByZXN1bHRzX3RvX2V4cGxhaW4gPSBzZXQobGF5b3V0X3Rlc3RfcmVzdWx0cy5mYWls aW5nX3Rlc3RzKCkpCg==