63995 2011-07-06 08:26:49 -0700 [Qt] [WK2] Add touch mocking to Qt's Minibrowser 2011-07-06 12:35:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 benjamin benjamin oldest_to_newest 432795 0 benjamin 2011-07-06 08:26:49 -0700 Minibrowser is unusable with the touch view on desktop because the platform does not send any touch event. We should create fake touch events for mouse events. 432813 1 99839 benjamin 2011-07-06 08:58:06 -0700 Created attachment 99839 Patch 432823 2 99839 kling 2011-07-06 09:33:00 -0700 Comment on attachment 99839 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99839&action=review r=me with some kennethisms > Tools/ChangeLog:3 > + [Qt] [WK2] Add touch mocking to Qt's Minibrowser MiniBrowser!!!111twotwotwo > Tools/ChangeLog:8 > + The mouse event are intercepted through QCoreApplication::notify(), event -> events > Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:83 > + /* We try to be smart, if we received real touch event, we are probably on a device > + with touch screen, and we should not have touch mocking */ // comments, please! 432933 3 benjamin 2011-07-06 12:35:43 -0700 I just noticed I forgot to close this bug at work... This has landed: http://trac.webkit.org/changeset/90475 99839 2011-07-06 08:58:06 -0700 2011-07-06 09:33:00 -0700 Patch 63995.patch text/plain 5098 benjamin ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzMjgw OGE0Li5mNzA1MDFiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDctMDYgIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF0gW1dLMl0gQWRkIHRvdWNoIG1vY2tp bmcgdG8gUXQncyBNaW5pYnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjM5OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgbW91c2UgZXZlbnQgYXJlIGludGVyY2VwdGVkIHRocm91Z2ggUUNv cmVBcHBsaWNhdGlvbjo6bm90aWZ5KCksCisgICAgICAgIGFuZCBmYWtlIHRvdWNoIGV2ZW50cyBh cmUgZ2VuZXJhdGVkIGZvciBtb3VzZSBldmVudHMgd2hlbiBuZWNlc3NhcnkuCisKKyAgICAgICAg SWYgdG91Y2ggZXZlbnRzIGFyZSByZWNlaXZlZCBmcm9tIHRoZSBwbGF0Zm9ybSwgd2UgYXNzdW1l IHRoZSBjdXJyZW50CisgICAgICAgIGhhcmR3YXJlIGhhcyBhIHRvdWNoIHNjcmVlbiBhbmQgd2Ug c3RvcCBnZW5lcmF0aW5nIGZha2UgZXZlbnRzLgorCisgICAgICAgICogTWluaUJyb3dzZXIvcXQv TWluaUJyb3dzZXJBcHBsaWNhdGlvbi5jcHA6CisgICAgICAgIChpc1RvdWNoRXZlbnQpOgorICAg ICAgICAoaXNNb3VzZUV2ZW50KToKKyAgICAgICAgKE1pbmlCcm93c2VyQXBwbGljYXRpb246Ok1p bmlCcm93c2VyQXBwbGljYXRpb24pOgorICAgICAgICAoTWluaUJyb3dzZXJBcHBsaWNhdGlvbjo6 bm90aWZ5KToKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0aW9u Lmg6CisKIDIwMTEtMDctMDYgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAg ICAgICAgIFtRdF1bV0syXSBTcGxpdCBRdCBBUEkgaW50byB0d28gZGlmZmVyZW50IHdlYiB2aWV3 cyAodG91Y2ggYW5kIGRlc2t0b3ApCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9N aW5pQnJvd3NlckFwcGxpY2F0aW9uLmNwcCBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L01pbmlCcm93 c2VyQXBwbGljYXRpb24uY3BwCmluZGV4IGViMmQ5NGQuLjFmZDg5MjggMTAwNjQ0Ci0tLSBhL1Rv b2xzL01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uY3BwCisrKyBiL1Rvb2xz L01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uY3BwCkBAIC0zMCwxMCArMzAs NDIgQEAKIAogI2luY2x1ZGUgInV0aWxzLmgiCiAjaW5jbHVkZSA8UVJlZ0V4cD4KKyNpbmNsdWRl IDxRRXZlbnQ+CisjaW5jbHVkZSA8UU1vdXNlRXZlbnQ+CisjaW5jbHVkZSA8UVRvdWNoRXZlbnQ+ CisKK2V4dGVybiBRX0dVSV9FWFBPUlQgdm9pZCBxdF90cmFuc2xhdGVSYXdUb3VjaEV2ZW50KFFX aWRnZXQqLCBRVG91Y2hFdmVudDo6RGV2aWNlVHlwZSwgY29uc3QgUUxpc3Q8UVRvdWNoRXZlbnQ6 OlRvdWNoUG9pbnQ+Jik7CisKK3N0YXRpYyBpbmxpbmUgYm9vbCBpc1RvdWNoRXZlbnQoY29uc3Qg UUV2ZW50KiBldmVudCkKK3sKKyAgICBzd2l0Y2ggKGV2ZW50LT50eXBlKCkpIHsKKyAgICBjYXNl IFFFdmVudDo6VG91Y2hCZWdpbjoKKyAgICBjYXNlIFFFdmVudDo6VG91Y2hVcGRhdGU6CisgICAg Y2FzZSBRRXZlbnQ6OlRvdWNoRW5kOgorICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICBkZWZhdWx0 OgorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorfQorCitzdGF0aWMgaW5saW5lIGJvb2wg aXNNb3VzZUV2ZW50KGNvbnN0IFFFdmVudCogZXZlbnQpCit7CisgICAgc3dpdGNoIChldmVudC0+ dHlwZSgpKSB7CisgICAgY2FzZSBRRXZlbnQ6Ok1vdXNlQnV0dG9uUHJlc3M6CisgICAgY2FzZSBR RXZlbnQ6Ok1vdXNlTW92ZToKKyAgICBjYXNlIFFFdmVudDo6TW91c2VCdXR0b25SZWxlYXNlOgor ICAgIGNhc2UgUUV2ZW50OjpNb3VzZUJ1dHRvbkRibENsaWNrOgorICAgICAgICByZXR1cm4gdHJ1 ZTsKKyAgICBkZWZhdWx0OgorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorfQogCiBNaW5p QnJvd3NlckFwcGxpY2F0aW9uOjpNaW5pQnJvd3NlckFwcGxpY2F0aW9uKGludCYgYXJnYywgY2hh cioqIGFyZ3YpCiAgICAgOiBRQXBwbGljYXRpb24oYXJnYywgYXJndiwgUUFwcGxpY2F0aW9uOjpH dWlTZXJ2ZXIpCiAgICAgLCBtX3dpbmRvd09wdGlvbnMoKQorICAgICwgbV9zcG9udGFuZW91c1Rv dWNoRXZlbnRSZWNlaXZlZChmYWxzZSkKKyAgICAsIG1fc2VuZGluZ0Zha2VUb3VjaEV2ZW50KGZh bHNlKQogICAgICwgbV9pc1JvYm90aXplZChmYWxzZSkKICAgICAsIG1fcm9ib3RUaW1lb3V0U2Vj b25kcygwKQogICAgICwgbV9yb2JvdEV4dHJhVGltZVNlY29uZHMoMCkKQEAgLTQ1LDYgKzc3LDUz IEBAIE1pbmlCcm93c2VyQXBwbGljYXRpb246Ok1pbmlCcm93c2VyQXBwbGljYXRpb24oaW50JiBh cmdjLCBjaGFyKiogYXJndikKICAgICBoYW5kbGVVc2VyT3B0aW9ucygpOwogfQogCitib29sIE1p bmlCcm93c2VyQXBwbGljYXRpb246Om5vdGlmeShRT2JqZWN0KiB0YXJnZXQsIFFFdmVudCogZXZl bnQpCit7CisgICAgLyogV2UgdHJ5IHRvIGJlIHNtYXJ0LCBpZiB3ZSByZWNlaXZlZCByZWFsIHRv dWNoIGV2ZW50LCB3ZSBhcmUgcHJvYmFibHkgb24gYSBkZXZpY2UKKyAgICAgICB3aXRoIHRvdWNo IHNjcmVlbiwgYW5kIHdlIHNob3VsZCBub3QgaGF2ZSB0b3VjaCBtb2NraW5nICovCisKKyAgICBp ZiAoIWV2ZW50LT5zcG9udGFuZW91cygpIHx8IG1fc2VuZGluZ0Zha2VUb3VjaEV2ZW50IHx8IG1f c3BvbnRhbmVvdXNUb3VjaEV2ZW50UmVjZWl2ZWQpCisgICAgICAgIHJldHVybiBRQXBwbGljYXRp b246Om5vdGlmeSh0YXJnZXQsIGV2ZW50KTsKKyAgICBpZiAoaXNUb3VjaEV2ZW50KGV2ZW50KSAm JiBzdGF0aWNfY2FzdDxRVG91Y2hFdmVudCo+KGV2ZW50KS0+ZGV2aWNlVHlwZSgpID09IFFUb3Vj aEV2ZW50OjpUb3VjaFNjcmVlbikgeworICAgICAgICBtX3Nwb250YW5lb3VzVG91Y2hFdmVudFJl Y2VpdmVkID0gdHJ1ZTsKKyAgICAgICAgcmV0dXJuIFFBcHBsaWNhdGlvbjo6bm90aWZ5KHRhcmdl dCwgZXZlbnQpOworICAgIH0KKyAgICBpZiAoaXNNb3VzZUV2ZW50KGV2ZW50KSkgeworICAgICAg ICBjb25zdCBRTW91c2VFdmVudCogY29uc3QgbW91c2VFdmVudCA9IHN0YXRpY19jYXN0PFFNb3Vz ZUV2ZW50Kj4oZXZlbnQpOworICAgICAgICBpZiAobW91c2VFdmVudC0+YnV0dG9uKCkgIT0gUXQ6 OkxlZnRCdXR0b24gJiYgbW91c2VFdmVudC0+YnV0dG9ucygpICE9IFF0OjpMZWZ0QnV0dG9uKQor ICAgICAgICAgICAgcmV0dXJuIFFBcHBsaWNhdGlvbjo6bm90aWZ5KHRhcmdldCwgZXZlbnQpOwor CisgICAgICAgIFFUb3VjaEV2ZW50OjpUb3VjaFBvaW50IHRvdWNoUG9pbnQ7CisgICAgICAgIHRv dWNoUG9pbnQuc2V0U2NyZWVuUG9zKG1vdXNlRXZlbnQtPmdsb2JhbFBvcygpKTsKKyAgICAgICAg dG91Y2hQb2ludC5zZXRQb3MobW91c2VFdmVudC0+cG9zKCkpOworICAgICAgICB0b3VjaFBvaW50 LnNldElkKDApOworCisgICAgICAgIHN3aXRjaCAobW91c2VFdmVudC0+dHlwZSgpKSB7CisgICAg ICAgIGNhc2UgUUV2ZW50OjpNb3VzZUJ1dHRvblByZXNzOgorICAgICAgICBjYXNlIFFFdmVudDo6 TW91c2VCdXR0b25EYmxDbGljazoKKyAgICAgICAgICAgIHRvdWNoUG9pbnQuc2V0U3RhdGUoUXQ6 OlRvdWNoUG9pbnRQcmVzc2VkKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIFFF dmVudDo6TW91c2VNb3ZlOgorICAgICAgICAgICAgdG91Y2hQb2ludC5zZXRTdGF0ZShRdDo6VG91 Y2hQb2ludE1vdmVkKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIFFFdmVudDo6 TW91c2VCdXR0b25SZWxlYXNlOgorICAgICAgICAgICAgdG91Y2hQb2ludC5zZXRTdGF0ZShRdDo6 VG91Y2hQb2ludFJlbGVhc2VkKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBkZWZhdWx0 OgorICAgICAgICAgICAgUV9BU1NFUlQoZmFsc2UpOworICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgIH0KKworICAgICAgICBRTGlzdDxRVG91Y2hFdmVudDo6VG91Y2hQb2ludD4gdG91Y2hQb2lu dHM7CisgICAgICAgIHRvdWNoUG9pbnRzLmFwcGVuZCh0b3VjaFBvaW50KTsKKyAgICAgICAgbV9z ZW5kaW5nRmFrZVRvdWNoRXZlbnQgPSB0cnVlOworICAgICAgICBxdF90cmFuc2xhdGVSYXdUb3Vj aEV2ZW50KDAsIFFUb3VjaEV2ZW50OjpUb3VjaFNjcmVlbiwgdG91Y2hQb2ludHMpOworICAgICAg ICBtX3NlbmRpbmdGYWtlVG91Y2hFdmVudCA9IGZhbHNlOworICAgIH0KKworICAgIHJldHVybiBR QXBwbGljYXRpb246Om5vdGlmeSh0YXJnZXQsIGV2ZW50KTsKK30KKwogdm9pZCBNaW5pQnJvd3Nl ckFwcGxpY2F0aW9uOjpoYW5kbGVVc2VyT3B0aW9ucygpCiB7CiAgICAgUVN0cmluZ0xpc3QgYXJn cyA9IGFyZ3VtZW50cygpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvTWluaUJy b3dzZXJBcHBsaWNhdGlvbi5oIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXJBcHBs aWNhdGlvbi5oCmluZGV4IDRkYjQyNWUuLjQ1OTE4OWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlC cm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uaAorKysgYi9Ub29scy9NaW5pQnJvd3Nl ci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmgKQEAgLTY3LDEwICs2NywxNCBAQCBwdWJsaWM6 CiAKICAgICBXaW5kb3dPcHRpb25zIG1fd2luZG93T3B0aW9uczsKIAorICAgIHZpcnR1YWwgYm9v bCBub3RpZnkoUU9iamVjdCosIFFFdmVudCopOworCiBwcml2YXRlOgogICAgIHZvaWQgaGFuZGxl VXNlck9wdGlvbnMoKTsKIAogcHJpdmF0ZToKKyAgICBib29sIG1fc3BvbnRhbmVvdXNUb3VjaEV2 ZW50UmVjZWl2ZWQ7CisgICAgYm9vbCBtX3NlbmRpbmdGYWtlVG91Y2hFdmVudDsKICAgICBib29s IG1faXNSb2JvdGl6ZWQ7CiAgICAgaW50IG1fcm9ib3RUaW1lb3V0U2Vjb25kczsKICAgICBpbnQg bV9yb2JvdEV4dHJhVGltZVNlY29uZHM7Cg==