63988 2011-07-06 05:59:58 -0700 [GTK] Open links in a new window when clicking with the middle button in MiniBrowser 2011-07-07 03:29:37 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned oldest_to_newest 432739 0 cgarcia 2011-07-06 05:59:58 -0700 This can be easily implemented with the WKPagePolicyClient. 432742 1 99822 cgarcia 2011-07-06 06:06:25 -0700 Created attachment 99822 Patch 433370 2 cgarcia 2011-07-07 03:29:37 -0700 Committed r90551: <http://trac.webkit.org/changeset/90551> 99822 2011-07-06 06:06:25 -0700 2011-07-06 20:49:44 -0700 Patch wk2-mb-links-middle-click.diff text/plain 3043 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1MDUy NjBjLi45NWU2Y2M0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMDYgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIE9wZW4gbGlua3MgaW4gYSBu ZXcgd2luZG93IHdoZW4gY2xpY2tpbmcgd2l0aCB0aGUgbWlkZGxlIGJ1dHRvbiBpbiBNaW5pQnJv d3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM5 ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1p bmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CisgICAgICAgIChicm93c2VyV2luZG93Q29u c3RydWN0ZWQpOgorICAgICAgICAoZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbik6IEln bm9yZSB0aGUgYWN0aW9uIGlmIGEgbGluayBpcworICAgICAgICBjbGlja2VkIHdpdGggdGhlIG1p ZGRsZSBidXR0b25tIGFuZCBvcGVuIHRoZSBsaW5rIGluIGEgbmV3IHdpbmRvdy4KKyAgICAgICAg KGJyb3dzZXJXaW5kb3dQb2xpY3lDbGllbnRJbml0KToKKwogMjAxMS0wNy0wNiAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBnbG9iYWwgdmFyaWFibGUgbGVh ayBkZXRlY3RlZCBieSBub2dsb2JhbHMuCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9n dGsvQnJvd3NlcldpbmRvdy5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cu YwppbmRleCA1OTgwNmFmLi4wNDE1NjVmIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9n dGsvQnJvd3NlcldpbmRvdy5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2lu ZG93LmMKQEAgLTU2LDYgKzU2LDcgQEAgc3RydWN0IF9Ccm93c2VyV2luZG93Q2xhc3MgewogCiBz dGF0aWMgdm9pZCBicm93c2VyV2luZG93TG9hZGVyQ2xpZW50SW5pdChCcm93c2VyV2luZG93Kik7 CiBzdGF0aWMgdm9pZCBicm93c2VyV2luZG93VUlDbGllbnRJbml0KEJyb3dzZXJXaW5kb3cqKTsK K3N0YXRpYyB2b2lkIGJyb3dzZXJXaW5kb3dQb2xpY3lDbGllbnRJbml0KEJyb3dzZXJXaW5kb3cq KTsKIAogc3RhdGljIGdpbnQgd2luZG93Q291bnQgPSAwOwogCkBAIC0xODMsNiArMTg0LDcgQEAg c3RhdGljIHZvaWQgYnJvd3NlcldpbmRvd0NvbnN0cnVjdGVkKEdPYmplY3QqIGdPYmplY3QpCiAK ICAgICBicm93c2VyV2luZG93TG9hZGVyQ2xpZW50SW5pdCh3aW5kb3cpOwogICAgIGJyb3dzZXJX aW5kb3dVSUNsaWVudEluaXQod2luZG93KTsKKyAgICBicm93c2VyV2luZG93UG9saWN5Q2xpZW50 SW5pdCh3aW5kb3cpOwogfQogCiBzdGF0aWMgdm9pZCBicm93c2VyX3dpbmRvd19jbGFzc19pbml0 KEJyb3dzZXJXaW5kb3dDbGFzcyoga2xhc3MpCkBAIC02NTQsNiArNjU2LDM3IEBAIHN0YXRpYyB2 b2lkIGJyb3dzZXJXaW5kb3dVSUNsaWVudEluaXQoQnJvd3NlcldpbmRvdyAqd2luZG93KQogICAg IFdLUGFnZVNldFBhZ2VVSUNsaWVudChXS1ZpZXdHZXRQYWdlKHdpbmRvdy0+d2ViVmlldyksICZ1 aUNsaWVudCk7CiB9CiAKK3N0YXRpYyB2b2lkIGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rp b24oV0tQYWdlUmVmIHBhZ2UsIFdLRnJhbWVSZWYgZnJhbWUsIFdLRnJhbWVOYXZpZ2F0aW9uVHlw ZSBuYXZpZ2F0aW9uVHlwZSwgV0tFdmVudE1vZGlmaWVycyBtb2RpZmllcnMsIFdLRXZlbnRNb3Vz ZUJ1dHRvbiBtb3VzZUJ1dHRvbiwgV0tVUkxSZXF1ZXN0UmVmIHJlcXVlc3QsIFdLRnJhbWVQb2xp Y3lMaXN0ZW5lclJlZiBsaXN0ZW5lciwgV0tUeXBlUmVmIHVzZXJEYXRhLCBjb25zdCB2b2lkKiBj bGllbnRJbmZvKQoreworICAgIGlmIChuYXZpZ2F0aW9uVHlwZSAhPSBrV0tGcmFtZU5hdmlnYXRp b25UeXBlTGlua0NsaWNrZWQgfHwgbW91c2VCdXR0b24gIT0ga1dLRXZlbnRNb3VzZUJ1dHRvbk1p ZGRsZUJ1dHRvbikgeworICAgICAgICBXS0ZyYW1lUG9saWN5TGlzdGVuZXJVc2UobGlzdGVuZXIp OworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgV0tWaWV3UmVmIHdlYlZpZXcgPSBXS1Zp ZXdDcmVhdGUoV0tQYWdlR2V0Q29udGV4dChwYWdlKSwgMCk7CisgICAgR3RrV2lkZ2V0ICp3aW5k b3cgPSBicm93c2VyX3dpbmRvd19uZXcod2ViVmlldyk7CisgICAgV0tVUkxSZWYgdXJsID0gV0tV UkxSZXF1ZXN0Q29weVVSTChyZXF1ZXN0KTsKKyAgICBXS1BhZ2VMb2FkVVJMKFdLVmlld0dldFBh Z2Uod2ViVmlldyksIHVybCk7CisgICAgV0tSZWxlYXNlKHVybCk7CisgICAgZ3RrX3dpZGdldF9n cmFiX2ZvY3VzKEdUS19XSURHRVQod2ViVmlldykpOworICAgIGd0a193aWRnZXRfc2hvdyh3aW5k b3cpOworCisgICAgV0tGcmFtZVBvbGljeUxpc3RlbmVySWdub3JlKGxpc3RlbmVyKTsKK30KKwor c3RhdGljIHZvaWQgYnJvd3NlcldpbmRvd1BvbGljeUNsaWVudEluaXQoQnJvd3NlcldpbmRvdyog d2luZG93KQoreworICAgIFdLUGFnZVBvbGljeUNsaWVudCBwb2xpY3lDbGllbnQgPSB7CisgICAg ICAgIGtXS1BhZ2VQb2xpY3lDbGllbnRDdXJyZW50VmVyc2lvbiwKKyAgICAgICAgd2luZG93LCAv KiBjbGllbnRJbmZvICovCisgICAgICAgIGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24s CisgICAgICAgIDAsICAgICAgLyogZGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0aW9uICovCisg ICAgICAgIDAsICAgICAgLyogZGVjaWRlUG9saWN5Rm9yUmVzcG9uc2UgKi8KKyAgICAgICAgMCAg ICAgICAvKiB1bmFibGVUb0ltcGxlbWVudFBvbGljeSAqLworICAgIH07CisgICAgV0tQYWdlU2V0 UGFnZVBvbGljeUNsaWVudChXS1ZpZXdHZXRQYWdlKHdpbmRvdy0+d2ViVmlldyksICZwb2xpY3lD bGllbnQpOworfQorCiAvLyBQdWJsaWMgQVBJLgogR3RrV2lkZ2V0KiBicm93c2VyX3dpbmRvd19u ZXcoV0tWaWV3UmVmIHZpZXcpCiB7Cg==