63986 2011-07-06 05:19:31 -0700 Date.prototype.toISOString doesn't handle negative years or years > 9999 correctly. 2012-01-05 20:51:38 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 0 lrn mhahnenberg barraclough kitcambridge mhahnenberg oliver webkit.review.bot oldest_to_newest 432727 0 lrn 2011-07-06 05:19:31 -0700 The ES5.1 specification of Date.prototype.toISOString requires the result to be in the format of a Date Time String, which allows an extension of the four-digit ISO year for years outside 0000..9999. I.e., for negative years or years > 9999, the only valid formats are "+yyyyyy" or "-yyyyyy". The current version outputs dates on the form "10000-01-01T01:01:01.000Z". 440979 1 101738 mhahnenberg 2011-07-22 09:42:25 -0700 Created attachment 101738 Patch 441006 2 101738 ggaren 2011-07-22 10:48:39 -0700 Comment on attachment 101738 Patch r=me 441020 3 101738 webkit.review.bot 2011-07-22 11:01:04 -0700 Comment on attachment 101738 Patch Clearing flags on attachment: 101738 Committed r91576: <http://trac.webkit.org/changeset/91576> 441021 4 webkit.review.bot 2011-07-22 11:01:08 -0700 All reviewed patches have been landed. Closing bug. 530906 5 barraclough 2012-01-05 20:51:38 -0800 *** Bug 69231 has been marked as a duplicate of this bug. *** 101738 2011-07-22 09:42:25 -0700 2011-07-22 11:01:04 -0700 Patch bug-63986-20110722094224.patch text/plain 6285 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTE1NzApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDctMjIgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBEYXRlLnByb3RvdHlwZS50b0lTT1N0cmluZyBkb2Vzbid0IGhhbmRsZSBuZWdhdGl2 ZSB5ZWFycyBvciB5ZWFycyA+IDk5OTkgY29ycmVjdGx5LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM5ODYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2VkIHRoZSBpbXBsZW1lbnRhdGlvbiBvZiBE YXRlLnByb3RvdHlwZS50b0lTT1N0cmluZygpIHRvIHVzZSB0aGUgZXh0ZW5kZWQgeWVhcgorICAg ICAgICBmb3JtYXQgKCsvLXl5eXl5eSkgZm9yIHllYXJzIG91dHNpZGUgb2YgWzAsOTk5OV0gdG8g YmUgaW4gY29tcGxpYW5jZSB3aXRoIEVTIDE1LjkuMS4xNS4xLgorCisgICAgICAgICogcnVudGlt ZS9EYXRlUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6ZGF0ZVByb3RvRnVuY1RvSVNPU3Ry aW5nKToKKwogMjAxMS0wNy0yMSAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBs ZS5jb20+CiAKICAgICAgICAgV2luZG93cyBidWlsZCBmaXgKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwCShyZXZpc2lvbiA5MTU3MCkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC00OTgsMTAgKzQ5OCwxNCBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9D QUxMIGRhdGVQcm90b0Z1CiAgICAgY29uc3QgR3JlZ29yaWFuRGF0ZVRpbWUqIGdyZWdvcmlhbkRh dGVUaW1lID0gdGhpc0RhdGVPYmotPmdyZWdvcmlhbkRhdGVUaW1lVVRDKGV4ZWMpOwogICAgIGlm ICghZ3JlZ29yaWFuRGF0ZVRpbWUpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNO b250cml2aWFsU3RyaW5nKGV4ZWMsICJJbnZhbGlkIERhdGUiKSk7Ci0gICAgLy8gTWF4aW11bSBh bW91bnQgb2Ygc3BhY2Ugd2UgbmVlZCBpbiBidWZmZXI6IDYgKG1heC4gZGlnaXRzIGluIHllYXIp ICsgMiAqIDUgKDIgY2hhcmFjdGVycyBlYWNoIGZvciBtb250aCwgZGF5LCBob3VyLCBtaW51dGUs IHNlY29uZCkgKyA0ICguICsgMyBkaWdpdHMgZm9yIG1pbGxpc2Vjb25kcykKLSAgICAvLyA2IGZv ciBmb3JtYXR0aW5nIGFuZCBvbmUgZm9yIG51bGwgdGVybWluYXRpb24gPSAyNy4gIFdlIGFkZCBv bmUgZXh0cmEgY2hhcmFjdGVyIHRvIGFsbG93IHVzIHRvIGZvcmNlIG51bGwgdGVybWluYXRpb24u Ci0gICAgY2hhciBidWZmZXJbMjhdOwotICAgIHNucHJpbnRmKGJ1ZmZlciwgc2l6ZW9mKGJ1ZmZl cikgLSAxLCAiJTA0ZC0lMDJkLSUwMmRUJTAyZDolMDJkOiUwMmQuJTAzZFoiLCAxOTAwICsgZ3Jl Z29yaWFuRGF0ZVRpbWUtPnllYXIsIGdyZWdvcmlhbkRhdGVUaW1lLT5tb250aCArIDEsIGdyZWdv cmlhbkRhdGVUaW1lLT5tb250aERheSwgZ3JlZ29yaWFuRGF0ZVRpbWUtPmhvdXIsIGdyZWdvcmlh bkRhdGVUaW1lLT5taW51dGUsIGdyZWdvcmlhbkRhdGVUaW1lLT5zZWNvbmQsIHN0YXRpY19jYXN0 PGludD4oZm1vZCh0aGlzRGF0ZU9iai0+aW50ZXJuYWxOdW1iZXIoKSwgMTAwMCkpKTsKKyAgICAv LyBNYXhpbXVtIGFtb3VudCBvZiBzcGFjZSB3ZSBuZWVkIGluIGJ1ZmZlcjogNyAobWF4LiBkaWdp dHMgaW4geWVhcikgKyAyICogNSAoMiBjaGFyYWN0ZXJzIGVhY2ggZm9yIG1vbnRoLCBkYXksIGhv dXIsIG1pbnV0ZSwgc2Vjb25kKSArIDQgKC4gKyAzIGRpZ2l0cyBmb3IgbWlsbGlzZWNvbmRzKQor ICAgIC8vIDYgZm9yIGZvcm1hdHRpbmcgYW5kIG9uZSBmb3IgbnVsbCB0ZXJtaW5hdGlvbiA9IDI4 LiBXZSBhZGQgb25lIGV4dHJhIGNoYXJhY3RlciB0byBhbGxvdyB1cyB0byBmb3JjZSBudWxsIHRl cm1pbmF0aW9uLgorICAgIGNoYXIgYnVmZmVyWzI5XTsKKyAgICAvLyBJZiB0aGUgeWVhciBpcyBv dXRzaWRlIHRoZSBib3VuZHMgb2YgMCBhbmQgOTk5OSBpbmNsdXNpdmUgd2Ugd2FudCB0byB1c2Ug dGhlIGV4dGVuZGVkIHllYXIgZm9ybWF0IChFUyAxNS45LjEuMTUuMSkuCisgICAgaWYgKGdyZWdv cmlhbkRhdGVUaW1lLT55ZWFyID4gODA5OSB8fCBncmVnb3JpYW5EYXRlVGltZS0+eWVhciA8IC0x OTAwKQorICAgICAgICBzbnByaW50ZihidWZmZXIsIHNpemVvZihidWZmZXIpIC0gMSwgIiUrMDdk LSUwMmQtJTAyZFQlMDJkOiUwMmQ6JTAyZC4lMDNkWiIsIDE5MDAgKyBncmVnb3JpYW5EYXRlVGlt ZS0+eWVhciwgZ3JlZ29yaWFuRGF0ZVRpbWUtPm1vbnRoICsgMSwgZ3JlZ29yaWFuRGF0ZVRpbWUt Pm1vbnRoRGF5LCBncmVnb3JpYW5EYXRlVGltZS0+aG91ciwgZ3JlZ29yaWFuRGF0ZVRpbWUtPm1p bnV0ZSwgZ3JlZ29yaWFuRGF0ZVRpbWUtPnNlY29uZCwgc3RhdGljX2Nhc3Q8aW50PihmbW9kKHRo aXNEYXRlT2JqLT5pbnRlcm5hbE51bWJlcigpLCAxMDAwKSkpOworICAgIGVsc2UKKyAgICAgICAg c25wcmludGYoYnVmZmVyLCBzaXplb2YoYnVmZmVyKSAtIDEsICIlMDRkLSUwMmQtJTAyZFQlMDJk OiUwMmQ6JTAyZC4lMDNkWiIsIDE5MDAgKyBncmVnb3JpYW5EYXRlVGltZS0+eWVhciwgZ3JlZ29y aWFuRGF0ZVRpbWUtPm1vbnRoICsgMSwgZ3JlZ29yaWFuRGF0ZVRpbWUtPm1vbnRoRGF5LCBncmVn b3JpYW5EYXRlVGltZS0+aG91ciwgZ3JlZ29yaWFuRGF0ZVRpbWUtPm1pbnV0ZSwgZ3JlZ29yaWFu RGF0ZVRpbWUtPnNlY29uZCwgc3RhdGljX2Nhc3Q8aW50PihmbW9kKHRoaXNEYXRlT2JqLT5pbnRl cm5hbE51bWJlcigpLCAxMDAwKSkpOwogICAgIGJ1ZmZlcltzaXplb2YoYnVmZmVyKSAtIDFdID0g MDsKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzTm9udHJpdmlhbFN0cmluZyhleGVjLCBi dWZmZXIpKTsKIH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxNTcwKQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDctMjIgIE1hcmsg SGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KKworICAgICAgICBEYXRlLnByb3Rv dHlwZS50b0lTT1N0cmluZyBkb2Vzbid0IGhhbmRsZSBuZWdhdGl2ZSB5ZWFycyBvciB5ZWFycyA+ IDk5OTkgY29ycmVjdGx5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjM5ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDaGFuZ2VkIHRoZSBpbXBsZW1lbnRhdGlvbiBvZiBEYXRlLnByb3RvdHlwZS50b0lT T1N0cmluZygpIHRvIHVzZSB0aGUgZXh0ZW5kZWQgeWVhcgorICAgICAgICBmb3JtYXQgKCsvLXl5 eXl5eSkgZm9yIHllYXJzIG91dHNpZGUgb2YgWzAsOTk5OV0gdG8gYmUgaW4gY29tcGxpYW5jZSB3 aXRoIEVTIDE1LjkuMS4xNS4xLgorICAgICAgICBBbHRlcmVkIG9uZSB0ZXN0IHRoYXQgdGVzdGVk IGZvciBpbmNvcnJlY3QgYmVoYXZpb3Igb24geWVhcnMgPiA5OTk5LCBhbmQgYWRkZWQgYW5vdGhl ciB0ZXN0IGZvciAKKyAgICAgICAgeWVhcnMgPCAwIChpLmUuIEJDRSkuCisKKyAgICAgICAgKiBm YXN0L2pzL2RhdGUtdG9pc29zdHJpbmctZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvanMv c2NyaXB0LXRlc3RzL2RhdGUtdG9pc29zdHJpbmcuanM6CisKIDIwMTEtMDctMjIgIEFuZHJleSBL b3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBb RXh0ZW5zaW9ucyBBUEldIGFkZCB3ZWJJbnNwZWN0b3IucmVzb3VyY2VzLm9uQ29udGVudEVkaXRl ZApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9kYXRlLXRvaXNvc3RyaW5nLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL2RhdGUtdG9pc29zdHJpbmctZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiA5MTU3MCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvZGF0ZS10 b2lzb3N0cmluZy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTksNyArOSw4IEBAIFBB U1MgbmV3IERhdGUoMCkudG9JU09TdHJpbmcoKSBpcyAnMTk3MC0KIFBBU1MgbmV3IERhdGUoJzEg SmFudWFyeSAxNTAwIFVUQycpLnRvSVNPU3RyaW5nKCkgaXMgJzE1MDAtMDEtMDFUMDA6MDA6MDAu MDAwWicKIFBBU1MgbmV3IERhdGUoJzEgSmFudWFyeSAyMDAwIFVUQycpLnRvSVNPU3RyaW5nKCkg aXMgJzIwMDAtMDEtMDFUMDA6MDA6MDAuMDAwWicKIFBBU1MgbmV3IERhdGUoJzEgSmFudWFyeSA0 MDAwIFVUQycpLnRvSVNPU3RyaW5nKCkgaXMgJzQwMDAtMDEtMDFUMDA6MDA6MDAuMDAwWicKLVBB U1MgbmV3IERhdGUoJzEgSmFudWFyeSAxMDAwMDAgVVRDJykudG9JU09TdHJpbmcoKSBpcyAnMTAw MDAwLTAxLTAxVDAwOjAwOjAwLjAwMFonCitQQVNTIG5ldyBEYXRlKCcxIEphbnVhcnkgMTAwMDAw IFVUQycpLnRvSVNPU3RyaW5nKCkgaXMgJysxMDAwMDAtMDEtMDFUMDA6MDA6MDAuMDAwWicKK1BB U1MgbmV3IERhdGUoJzEgSmFudWFyeSAtMSBVVEMnKS50b0lTT1N0cmluZygpIGlzICctMDAwMDAx LTAxLTAxVDAwOjAwOjAwLjAwMFonCiBQQVNTIG5ldyBEYXRlKCcxMCBNYXJjaCAyMDAwIFVUQycp LnRvSVNPU3RyaW5nKCkgaXMgJzIwMDAtMDMtMTBUMDA6MDA6MDAuMDAwWicKIFBBU1MgbmV3IERh dGUoTmFOKS50b0lTT1N0cmluZygpIGlzICdJbnZhbGlkIERhdGUnCiBQQVNTIHN1Y2Nlc3NmdWxs eVBhcnNlZCBpcyB0cnVlCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9k YXRlLXRvaXNvc3RyaW5nLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvc2Ny aXB0LXRlc3RzL2RhdGUtdG9pc29zdHJpbmcuanMJKHJldmlzaW9uIDkxNTcwKQorKysgTGF5b3V0 VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGF0ZS10b2lzb3N0cmluZy5qcwkod29ya2luZyBj b3B5KQpAQCAtNyw3ICs3LDggQEAgc2hvdWxkQmUoIm5ldyBEYXRlKDApLnRvSVNPU3RyaW5nKCki LCAiJwogc2hvdWxkQmUoIm5ldyBEYXRlKCcxIEphbnVhcnkgMTUwMCBVVEMnKS50b0lTT1N0cmlu ZygpIiwgIicxNTAwLTAxLTAxVDAwOjAwOjAwLjAwMFonIik7CiBzaG91bGRCZSgibmV3IERhdGUo JzEgSmFudWFyeSAyMDAwIFVUQycpLnRvSVNPU3RyaW5nKCkiLCAiJzIwMDAtMDEtMDFUMDA6MDA6 MDAuMDAwWiciKTsKIHNob3VsZEJlKCJuZXcgRGF0ZSgnMSBKYW51YXJ5IDQwMDAgVVRDJykudG9J U09TdHJpbmcoKSIsICInNDAwMC0wMS0wMVQwMDowMDowMC4wMDBaJyIpOwotc2hvdWxkQmUoIm5l dyBEYXRlKCcxIEphbnVhcnkgMTAwMDAwIFVUQycpLnRvSVNPU3RyaW5nKCkiLCAiJzEwMDAwMC0w MS0wMVQwMDowMDowMC4wMDBaJyIpOworc2hvdWxkQmUoIm5ldyBEYXRlKCcxIEphbnVhcnkgMTAw MDAwIFVUQycpLnRvSVNPU3RyaW5nKCkiLCAiJysxMDAwMDAtMDEtMDFUMDA6MDA6MDAuMDAwWici KTsKK3Nob3VsZEJlKCJuZXcgRGF0ZSgnMSBKYW51YXJ5IC0xIFVUQycpLnRvSVNPU3RyaW5nKCki LCAiJy0wMDAwMDEtMDEtMDFUMDA6MDA6MDAuMDAwWiciKTsKIHNob3VsZEJlKCJuZXcgRGF0ZSgn MTAgTWFyY2ggMjAwMCBVVEMnKS50b0lTT1N0cmluZygpIiwgIicyMDAwLTAzLTEwVDAwOjAwOjAw LjAwMFonIik7CiBzaG91bGRCZSgibmV3IERhdGUoTmFOKS50b0lTT1N0cmluZygpIiwgIidJbnZh bGlkIERhdGUnIik7CiAK