63979 2011-07-06 00:28:28 -0700 garden-o-matic shouldn't show flaky tests by default 2011-07-06 00:39:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dglazkov eric ojan oldest_to_newest 432669 0 abarth 2011-07-06 00:28:28 -0700 garden-o-matic shouldn't show flaky tests by default 432670 1 99798 abarth 2011-07-06 00:30:21 -0700 Created attachment 99798 Patch 432672 2 99798 ojan 2011-07-06 00:35:39 -0700 Comment on attachment 99798 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99798&action=review > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:9 > +var kPassingResults = ['PASS']; Using an array here seems like overkill to me. I think a string would do. > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:10 > +var kPassingResults = ['PASS']; > var kFailingResults = ['TIMEOUT', 'TEXT', 'CRASH', 'IMAGE','IMAGE+TEXT']; Should have mentioned in a previous review, you might want to alias these strings, e.g. var TIMEOUT = 'TIMEOUT'; It will save you pain down the road for when you typo 'TIMEOT'. With the variables, you'll get a nice JS exception right where the problem code is. 432674 3 abarth 2011-07-06 00:38:58 -0700 var IMAGE+TEXT = 'IMAGE+TEXT'; :( 432675 4 abarth 2011-07-06 00:39:34 -0700 Committed r90442: <http://trac.webkit.org/changeset/90442> 432676 5 abarth 2011-07-06 00:39:52 -0700 IMAGE_TEXT it is! 99798 2011-07-06 00:30:21 -0700 2011-07-06 00:35:39 -0700 Patch bug-63979-20110706003020.patch text/plain 3074 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkwNDQxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTEtMDctMDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBnYXJkZW4tby1tYXRpYyBzaG91bGRuJ3Qgc2hvdyBmbGFreSB0ZXN0cyBieSBkZWZh dWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mzk3 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIGFu eSBvZiB0aGUgYWN0dWFsIHRlc3QgcmVzdWx0cyBhcmUgUEFTUywgdGhlIHRlc3QgaXMgZmxha3kg YW5kIHdlCisgICAgICAgIGNhbiBpZ25vcmUgaXQgKGF0IGxlYXN0IGZvciBub3cpLiAgSWYgd2Ug Z2V0IGF3ZXNvbWUgYXQgZGVhbGluZyB3aXRoCisgICAgICAgIGZhaWxpbmcgdGVzdHMsIHdlIG1p Z2h0IHdhbnQgdG8gdGFja2xlIGZsYWt5IHRlc3RzIGJ5IHJlZmVyaW5nIHRoZSB1c2VyCisgICAg ICAgIHRvIHRoZSBmbGFraW5lc3MgZGFzaGJvYXJkLCB3aGljaCBpcyB3YXkgbW9yZSBhd2Vzb21l IGF0IGRlYWxpbmcgd2l0aAorICAgICAgICBmbGFreSB0ZXN0cyB0aGF0IHRoaXMgdG9vbCBldmVy IHdpbGwgYmUuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRh L2dhcmRlbmluZ3NlcnZlci9yZXN1bHRzLmpzOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv dG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL3Jlc3VsdHNfdW5pdHRlc3RzLmpzOgor CiAyMDExLTA3LTA1ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAg Z2FyZGVuLW8tbWF0aWMgc2hvdWxkIGxpc3QgdGhlIGZhaWxpbmcgdGVzdHMKSW5kZXg6IFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL2RhdGEvZ2FyZGVuaW5nc2VydmVyL3Jlc3Vs dHMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMv ZGF0YS9nYXJkZW5pbmdzZXJ2ZXIvcmVzdWx0cy5qcwkocmV2aXNpb24gOTA0NDEpCisrKyBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9yZXN1 bHRzLmpzCSh3b3JraW5nIGNvcHkpCkBAIC02LDYgKzYsNyBAQCB2YXIga1Rlc3RSZXN1bHRzU2Vy dmVyID0gJ2h0dHA6Ly90ZXN0LXJlCiB2YXIga1Rlc3RUeXBlID0gJ2xheW91dC10ZXN0cyc7CiB2 YXIga1Jlc3VsdHNOYW1lID0gJ2Z1bGxfcmVzdWx0cy5qc29uJzsKIHZhciBrTWFzdGVyTmFtZSA9 ICdDaHJvbWl1bVdlYmtpdCc7Cit2YXIga1Bhc3NpbmdSZXN1bHRzID0gWydQQVNTJ107CiB2YXIg a0ZhaWxpbmdSZXN1bHRzID0gWydUSU1FT1VUJywgJ1RFWFQnLCAnQ1JBU0gnLCAnSU1BR0UnLCdJ TUFHRStURVhUJ107CiAKIGZ1bmN0aW9uIGlzRmFpbHVyZShyZXN1bHQpCkBAIC0xMywxMSArMTQs MjEgQEAgZnVuY3Rpb24gaXNGYWlsdXJlKHJlc3VsdCkKICAgICByZXR1cm4ga0ZhaWxpbmdSZXN1 bHRzLmluZGV4T2YocmVzdWx0KSAhPSAtMTsKIH0KIAorZnVuY3Rpb24gaXNTdWNjZXNzKHJlc3Vs dCkKK3sKKyAgICByZXR1cm4ga1Bhc3NpbmdSZXN1bHRzLmluZGV4T2YocmVzdWx0KSAhPSAtMTsK K30KKwogZnVuY3Rpb24gYW55SXNGYWlsdXJlKHJlc3VsdHNMaXN0KQogewogICAgIHJldHVybiAk LmdyZXAocmVzdWx0c0xpc3QsIGlzRmFpbHVyZSkubGVuZ3RoID4gMDsKIH0KIAorZnVuY3Rpb24g YW55SXNTdWNjZXNzKHJlc3VsdHNMaXN0KQoreworICAgIHJldHVybiAkLmdyZXAocmVzdWx0c0xp c3QsIGlzU3VjY2VzcykubGVuZ3RoID4gMDsKK30KKwogZnVuY3Rpb24gYWRkSW1wbGllZEV4cGVj dGF0aW9ucyhyZXN1bHRzTGlzdCkKIHsKICAgICBpZiAocmVzdWx0c0xpc3QuaW5kZXhPZignRkFJ TCcpID09IC0xKQpAQCAtMzcsNiArNDgsOCBAQCBmdW5jdGlvbiB1bmV4cGVjdGVkUmVzdWx0cyhy ZXN1bHROb2RlKQogCiBmdW5jdGlvbiBpc1VuZXhwZWN0ZWRGYWlsdXJlKHJlc3VsdE5vZGUpCiB7 CisgICAgaWYgKGFueUlzU3VjY2VzcyhyZXN1bHROb2RlLmFjdHVhbC5zcGxpdCgnICcpKSkKKyAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIHJldHVybiBhbnlJc0ZhaWx1cmUodW5leHBlY3RlZFJl c3VsdHMocmVzdWx0Tm9kZSkpOwogfQogCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9yZXN1bHRzX3VuaXR0ZXN0cy5qcwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRl bmluZ3NlcnZlci9yZXN1bHRzX3VuaXR0ZXN0cy5qcwkocmV2aXNpb24gOTA0NDEpCisrKyBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9kYXRhL2dhcmRlbmluZ3NlcnZlci9yZXN1 bHRzX3VuaXR0ZXN0cy5qcwkod29ya2luZyBjb3B5KQpAQCAtNiw2ICs2LDEwIEBAIHZhciBrRXhh bXBsZVJlc3VsdHNKU09OID0gewogICAgICAgICAgICAgImN1c3RvbS1zY3JvbGxiYXItd2l0aC1p bmNvbXBsZXRlLXN0eWxlLmh0bWwiOiB7CiAgICAgICAgICAgICAgICAgImV4cGVjdGVkIjogIklN QUdFIiwKICAgICAgICAgICAgICAgICAiYWN0dWFsIjogIklNQUdFIgorICAgICAgICAgICAgfSwK KyAgICAgICAgICAgICJmbGFreS1zY3JvbGxiYXJodG1sIjogeworICAgICAgICAgICAgICAgICJl eHBlY3RlZCI6ICJQQVNTIiwKKyAgICAgICAgICAgICAgICAiYWN0dWFsIjogIlBBU1MgVEVYVCIK ICAgICAgICAgICAgIH0KICAgICAgICAgfSwKICAgICAgICAgInVzZXJzY3JpcHRzIjogewo=