63975 2011-07-05 21:31:57 -0700 [EFL] Add Fullscreen API feature 2011-07-06 20:49:57 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 432614 0 gyuyoung.kim 2011-07-05 21:31:57 -0700 I would like to start to implement Fullscreen API for HTML5 Video. This patch is first patch for it. I add feature to OptionEfl.cmake, cmakeconfig.h.cmake as well as adding RenderFullScreen.cpp, fullscreen.css to WebCore/CMakeLists.txt. However, I don't enable the FULLSCREEN_API yet. I would like to enable it after finishing implementation. 432615 1 99789 gyuyoung.kim 2011-07-05 21:33:45 -0700 Created attachment 99789 Patch 432740 2 rakuco 2011-07-06 06:05:35 -0700 From what I understood, if one sets ENABLE_FULLSCREEN_API to ON, the build will fail or things will not work later, right? If so, I prefer to hold this commit until the missing implementation enters the tree. > ChangeLog:6 > + Reviewed by NOBODY (OOPS!). More details are welcome here: if you still need to work on the code as you mentioned in the bug report, explain here that this commit only adds the flags and files to the build system. > Source/WebCore/CMakeLists.txt:1410 > + ${WEBCORE_DIR}/css/fullscreen.css Not sorted alphabetically. > Source/cmake/OptionsEfl.cmake:76 > +WEBKIT_FEATURE(ENABLE_FULLSCREEN_API "Enable the Fullscreen API support" DEFAULT OFF) "the" not needed 432766 3 99829 gyuyoung.kim 2011-07-06 07:32:46 -0700 Created attachment 99829 Modified Patch I fix this patch according to your comments. >> if one sets ENABLE_FULLSCREEN_API to ON, the build will fail or things will not work later, right? If so, I prefer to hold this commit until the missing implementation enters the tree. If RenderFullScreen.cpp is missed when this feature is enabled on current version, build error happens. So, though ENABLE_FULLSCREEN_API is turned on, there is no build break on this patch . I'd like to implement remained missing things step by step after landing this patch. 432772 4 rakuco 2011-07-06 07:42:34 -0700 As long as enabling fullscreen support after this patch enters the tree does not break the build, r+ from my side. 433209 5 99829 webkit.review.bot 2011-07-06 20:49:51 -0700 Comment on attachment 99829 Modified Patch Clearing flags on attachment: 99829 Committed r90531: <http://trac.webkit.org/changeset/90531> 433210 6 webkit.review.bot 2011-07-06 20:49:57 -0700 All reviewed patches have been landed. Closing bug. 99789 2011-07-05 21:33:45 -0700 2011-07-06 07:32:46 -0700 Patch patch-add-fullscreen-api.patch text/plain 3121 gyuyoung.kim ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwNTE4ODhjLi5lZDU0MDY1 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDctMDQgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXSBBZGQgRnVsbHNjcmVlbiBBUEkgZmVhdHVyZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM5NzUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlOiBBZGQgRU5BQkxFX0ZVTExTQ1JFRU5fQVBJIGZlYXR1cmUuCisgICAgICAgICogU291 cmNlL2NtYWtlY29uZmlnLmguY21ha2U6IGRpdHRvLgorCiAyMDExLTA3LTA0ICBTaGVyaWZmIEJv dCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy b2xsaW5nIG91dCByOTAzNzMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3Rz LnR4dCBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IDEwNzgzNWQuLjIzNjRm YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0xMjEyLDYgKzEyMTIsNyBAQCBTRVQoV2ViQ29y ZV9TT1VSQ0VTCiAgICAgcmVuZGVyaW5nL1JlbmRlckZyYW1lLmNwcAogICAgIHJlbmRlcmluZy9S ZW5kZXJGcmFtZUJhc2UuY3BwCiAgICAgcmVuZGVyaW5nL1JlbmRlckZyYW1lU2V0LmNwcAorICAg IHJlbmRlcmluZy9SZW5kZXJGdWxsU2NyZWVuLmNwcAogICAgIHJlbmRlcmluZy9SZW5kZXJIVE1M Q2FudmFzLmNwcAogICAgIHJlbmRlcmluZy9SZW5kZXJJRnJhbWUuY3BwCiAgICAgcmVuZGVyaW5n L1JlbmRlckltYWdlLmNwcApAQCAtMTQwNiw2ICsxNDA3LDcgQEAgU0VUKFdlYkNvcmVfVVNFUl9B R0VOVF9TVFlMRV9TSEVFVFMKICAgICAke1dFQkNPUkVfRElSfS9jc3MvcXVpcmtzLmNzcwogICAg ICR7V0VCQ09SRV9ESVJ9L2Nzcy9zdmcuY3NzCiAgICAgJHtXRUJDT1JFX0RJUn0vY3NzL3ZpZXct c291cmNlLmNzcworICAgICR7V0VCQ09SRV9ESVJ9L2Nzcy9mdWxsc2NyZWVuLmNzcwogKQogCiBJ RiAoRU5BQkxFX0JMT0IpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWM5MzAyYy4uOWVlNzZmNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSw1ICsxLDE2IEBACiAyMDExLTA3LTA0ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5r aW1Ac2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW0VGTF0gQWRkIEZ1bGxzY3JlZW4gQVBJIGZlYXR1 cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzOTc1 CisKKyAgICAgICAgQWRkIG5lZWRlZCBmaWxlcyBmb3IgZW5hYmxpbmcgRU5BQkxFX0ZVTExTQ1JF RU5fQVBJIGZlYXR1cmUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogQWRkIFJlbmRlckZ1bGxTY3JlZW4uY3BwLCBmdWxs c2NyZWVuLmNzcworCisyMDExLTA3LTA0ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ft c3VuZy5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCiAKICAgICAgICAg W0VGTF0gQWRkIGhhc093bkRpc2FibGVkU3RhdGVIYW5kbGluZ0ZvcigpIHRvIFJlbmRlclRoZW1l RWZsCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9j bWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDRlMmJiMjAuLjk2MzY0ZjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25z RWZsLmNtYWtlCkBAIC03Myw2ICs3Myw3IEBAIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9GQVNUX01B TExPQyAiRW5hYmxlIFRDbWFsbG9jIGluc3RlYWQgb2Ygc3lzdGVtJ3MgYWxsb2NhdG9yCiBXRUJL SVRfRkVBVFVSRShFTkFCTEVfRkFTVF9NT0JJTEVfU0NST0xMSU5HICJFbmFibGUgZmFzdCBtb2Jp bGUgc2Nyb2xsaW5nIiBERUZBVUxUIE9OKQogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX0ZJTFRFUlMg IkVuYWJsZSBTVkcgZmlsdGVycyIgREVGQVVMVCBPTiBTVkcpCiBXRUJLSVRfRkVBVFVSRShFTkFC TEVfRlRQRElSICJFbmFibGUgRlRQIGRpcmVjdG9yeSBzdXBwb3J0IiBERUZBVUxUIE9OKQorV0VC S0lUX0ZFQVRVUkUoRU5BQkxFX0ZVTExTQ1JFRU5fQVBJICJFbmFibGUgdGhlIEZ1bGxzY3JlZW4g QVBJIHN1cHBvcnQiIERFRkFVTFQgT0ZGKQogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX0dFT0xPQ0FU SU9OICJFbmFibGUgZ2VvbG9jYXRpb24iIERFRkFVTFQgT0ZGKQogV0VCS0lUX0ZFQVRVUkUoRU5B QkxFX0dMSUJfU1VQUE9SVCAiRW5hYmxlIEdsaWIgc3VwcG9ydCIgREVGQVVMVCBPTikKIFdFQktJ VF9GRUFUVVJFKEVOQUJMRV9JQ09OREFUQUJBU0UgIkVuYWJsZSBpY29uIGRhdGFiYXNlIiBERUZB VUxUIE9OKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UgYi9Tb3VyY2Uv Y21ha2Vjb25maWcuaC5jbWFrZQppbmRleCAyYzdjMDcwLi5hMTRkOTI4IDEwMDY0NAotLS0gYS9T b3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFr ZQpAQCAtMTgsNiArMTgsNyBAQAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0ZBU1RfTU9CSUxFX1ND Uk9MTElORwogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0ZJTFRFUlMKICNjbWFrZWRlZmluZTAxIEVO QUJMRV9GVFBESVIKKyNjbWFrZWRlZmluZTAxIEVOQUJMRV9GVUxMU0NSRUVOX0FQSQogI2NtYWtl ZGVmaW5lMDEgRU5BQkxFX0dFT0xPQ0FUSU9OCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfR0xJQl9T VVBQT1JUCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfSUNPTkRBVEFCQVNFCg== 99829 2011-07-06 07:32:46 -0700 2011-07-06 20:49:51 -0700 Modified Patch patch-fullscreen.patch text/plain 3332 gyuyoung.kim ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBmMzcxOTFkLi42NmIwNzVk IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDctMDYgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXSBBZGQgRnVsbHNjcmVlbiBBUEkgZmVhdHVyZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM5NzUKKworICAgICAgICBUaGlzIGlz IGp1c3QgdG8gYWRkIGRpc2FibGVkIEVOQUJMRV9GVUxMU0NSRUVOX0FQSSB0byBPcHRpb25FRmwu Y21ha2UuCisgICAgICAgIEVOQUJMRV9GVUxMU0NSRUVOX0FQSSB3aWxsIGJlIGVuYWJsZWQgYWZ0 ZXIgZmluaXNoaW5nIG1pc3NpbmcgaW1wbGVtZW50YXRpb25zLgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNFZmwu Y21ha2U6IEFkZCBkaXNhYmxlZCBFTkFCTEVfRlVMTFNDUkVFTl9BUEkgZmVhdHVyZS4KKyAgICAg ICAgKiBTb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZTogZGl0dG8uCisKIDIwMTEtMDctMDUgIFZz ZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogU2hvdyBjb250ZW50IGZvciBwbHVnaW4gcmVxdWVzdHMgaW4gbmV0d29yayBwYW5lbC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNv cmUvQ01ha2VMaXN0cy50eHQKaW5kZXggMTA3ODM1ZC4uZjZmNzNmMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKQEAgLTEyMTIsNiArMTIxMiw3IEBAIFNFVChXZWJDb3JlX1NPVVJDRVMKICAgICByZW5k ZXJpbmcvUmVuZGVyRnJhbWUuY3BwCiAgICAgcmVuZGVyaW5nL1JlbmRlckZyYW1lQmFzZS5jcHAK ICAgICByZW5kZXJpbmcvUmVuZGVyRnJhbWVTZXQuY3BwCisgICAgcmVuZGVyaW5nL1JlbmRlckZ1 bGxTY3JlZW4uY3BwCiAgICAgcmVuZGVyaW5nL1JlbmRlckhUTUxDYW52YXMuY3BwCiAgICAgcmVu ZGVyaW5nL1JlbmRlcklGcmFtZS5jcHAKICAgICByZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCkBA IC0xNDAxLDYgKzE0MDIsNyBAQCBTRVQoV2ViQ29yZV9DU1NfVkFMVUVfS0VZV09SRFMKIAogU0VU KFdlYkNvcmVfVVNFUl9BR0VOVF9TVFlMRV9TSEVFVFMKICAgICAke1dFQkNPUkVfRElSfS9jc3Mv aHRtbC5jc3MKKyAgICAke1dFQkNPUkVfRElSfS9jc3MvZnVsbHNjcmVlbi5jc3MKICAgICAke1dF QkNPUkVfRElSfS9jc3MvbWF0aG1sLmNzcwogICAgICR7V0VCQ09SRV9ESVJ9L2Nzcy9tZWRpYUNv bnRyb2xzLmNzcwogICAgICR7V0VCQ09SRV9ESVJ9L2Nzcy9xdWlya3MuY3NzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggNTk2ZTA0NS4uN2IzOWY1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTA3 LTA2ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAg W0VGTF0gQWRkIEZ1bGxzY3JlZW4gQVBJIGZlYXR1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzOTc1CisKKyAgICAgICAgQWRkIG5lZWRlZCBmaWxl cyBmb3IgZW5hYmxpbmcgRU5BQkxFX0ZVTExTQ1JFRU5fQVBJIGZlYXR1cmUuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDog QWRkIFJlbmRlckZ1bGxTY3JlZW4uY3BwLCBmdWxsc2NyZWVuLmNzcworCiAyMDExLTA3LTA2ICBB bmRyYXMgQmVjc2kgIDxhYmVjc2lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIFJldm9tZSB1 bnVzZWQgYnV0IHNldCBzaGFkb3dCbHVyIHZhcmlhYmxlIGFmdGVyIHI5MDQwNi4KZGlmZiAtLWdp dCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNF ZmwuY21ha2UKaW5kZXggNGUyYmIyMC4uNzczOWFmYiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtl L09wdGlvbnNFZmwuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKQEAg LTczLDYgKzczLDcgQEAgV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX0ZBU1RfTUFMTE9DICJFbmFibGUg VENtYWxsb2MgaW5zdGVhZCBvZiBzeXN0ZW0ncyBhbGxvY2F0b3IKIFdFQktJVF9GRUFUVVJFKEVO QUJMRV9GQVNUX01PQklMRV9TQ1JPTExJTkcgIkVuYWJsZSBmYXN0IG1vYmlsZSBzY3JvbGxpbmci IERFRkFVTFQgT04pCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfRklMVEVSUyAiRW5hYmxlIFNWRyBm aWx0ZXJzIiBERUZBVUxUIE9OIFNWRykKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9GVFBESVIgIkVu YWJsZSBGVFAgZGlyZWN0b3J5IHN1cHBvcnQiIERFRkFVTFQgT04pCitXRUJLSVRfRkVBVFVSRShF TkFCTEVfRlVMTFNDUkVFTl9BUEkgIkVuYWJsZSBGdWxsc2NyZWVuIEFQSSBzdXBwb3J0IiBERUZB VUxUIE9GRikKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9HRU9MT0NBVElPTiAiRW5hYmxlIGdlb2xv Y2F0aW9uIiBERUZBVUxUIE9GRikKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9HTElCX1NVUFBPUlQg IkVuYWJsZSBHbGliIHN1cHBvcnQiIERFRkFVTFQgT04pCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVf SUNPTkRBVEFCQVNFICJFbmFibGUgaWNvbiBkYXRhYmFzZSIgREVGQVVMVCBPTikKZGlmZiAtLWdp dCBhL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlIGIvU291cmNlL2NtYWtlY29uZmlnLmguY21h a2UKaW5kZXggMmM3YzA3MC4uYTE0ZDkyOCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlY29uZmln LmguY21ha2UKKysrIGIvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKQEAgLTE4LDYgKzE4LDcg QEAKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9GQVNUX01PQklMRV9TQ1JPTExJTkcKICNjbWFrZWRl ZmluZTAxIEVOQUJMRV9GSUxURVJTCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfRlRQRElSCisjY21h a2VkZWZpbmUwMSBFTkFCTEVfRlVMTFNDUkVFTl9BUEkKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9H RU9MT0NBVElPTgogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0dMSUJfU1VQUE9SVAogI2NtYWtlZGVm aW5lMDEgRU5BQkxFX0lDT05EQVRBQkFTRQo=